New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1095, on October 11th, 2011, 01:14 PM »
Revision: 1095
Author: arantor
Date: 12:08:05, 11 October 2011
Message:
! Performance optimisation that actually didn't work properly (ManagePlugins.php)

! Improved layout when there's an error in plugins. (ManagePlugins.template.php, admin.css)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/skins/admin.css
Re: New revs
« Reply #1096, on October 11th, 2011, 02:00 PM »
Revision: 1096
Author: arantor
Date: 12:59:57, 11 October 2011
Message:
! Cleaned up some language strings, less of this composite stuff and more unified strings that can be translated meaningfully. (Load.php, SSI.php, InfoCenter.template.php, index.english.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/languages/index.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: New revs
« Reply #1097, on October 11th, 2011, 03:40 PM »
rev 1097
(6 files, forgot to check size)

* The PM area in the info center should use $txt['personal_messages'] rather than $txt['personal_message'] as its title. Also removed the odd duplicate, added whitespace and increased the font size for the previously smalltext details. (InfoCenter.template.php)

- Removed $txt['msg_alert_you_have'], $txt['msg_alert_messages'] and $txt['your_pms'], unused in Wedge. Or even SMF probably. (index.french.php)

- Removed support for Imeem from Aeva. That's three entries in the sitelist. Apparently they were bought out by MySpace two years ago and nobody bothered to tell me, eh eh. I suspect there are dozens more such dead websites in the list... Anyone willing to test them? (Subs-Aeva-Sites.php)

- Removed an unused parameter in setFocus(). (editor.js)

* French translation. (index.french.php, ManagePlugins.french.php)

! Undefined global in is_already_taken(). (Subs-PrettyUrls.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1098, on October 11th, 2011, 05:08 PM »
(44KB, 49 files)

Revision: 1098
Author: arantor
Date: 16:08:17, 11 October 2011
Message:
! More language clean-ups, mostly to purge variables from language files. It's not finished but I have things to do out here in RL, NB this has not been tested either :( (Sources: Feed, ManageAttachments, ManageMemberOptions, ManageNews, ManagePaid, ManageSettings, media/Aeva-Foxy, Profile-Actions, Reminder, ScheduledTasks, Subs-Post, Subs-Template, Who, Templates: Boards, Display, index, ManageNews, MessageIndex, ModerationCenter, PersonalMessage, Profile, Language files: Admin, Errors, index, ManageMembers, ManagePaid, ManageSettings, Media, ModerationCenter, Modlog, PersonalMessage, Post, Profile, Stats, Who)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/ManageMembers.french.php
Modified : /trunk/Themes/default/languages/ManagePaid.english.php
Modified : /trunk/Themes/default/languages/ManagePaid.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Media.english.php
Modified : /trunk/Themes/default/languages/Media.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/Stats.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Re: New revs
« Reply #1099, on October 12th, 2011, 01:40 AM »
Revision: 1099
Author: arantor
Date: 00:38:27, 12 October 2011
Message:
! Added probably-working support into the add-column code for ENUM/SET types. Not tested. Also cleaned up old parameters for the add/change/remove column functions because they're not needed for MySQL. (Class-DBPackages.php)
! Whoa, boy. Various bits of deduplication of code since we don't expressly have to call for children() when we only want one type of child node, plus factoring duplicate tests and code (some of which were actually ignored) into their own functions, and making sure that the DB cleanup stuff actually had access to the manifest file, meaning that DB changes are actually undone when the appropriate call is made. Oh, and hopefully added support for adding individual columns from the install (and appropriate cleanup), not yet tested having since found a bug elsewhere. (ManagePlugins.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManagePlugins.php


@ The bug in question is that my snazzy code for pruning folders on uninstall chokes on nested subdirectories. Which for all the ones I'd tested thus far, it wasn't a problem because they only had their own files in their own little world. All the ones I have in Plugins/ now have an .svn tree attached, which chokes it. (As does WedgeDesk but I'd never tested that since I added the remove folders code)
Re: New revs
« Reply #1100, on October 12th, 2011, 01:53 AM »
Revision: 1100
Author: arantor
Date: 00:52:57, 12 October 2011
Message:
! Another minor optimisation in plugins, and using the right function name. (ManagePlugins.php)
! Don't bother carrying on the package log from the DB changing functions. (Class-DBPackages.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManagePlugins.php
Re: New revs
« Reply #1101, on October 12th, 2011, 02:09 AM »
Revision: 1101
Author: arantor
Date: 01:09:28, 12 October 2011
Message:
! More of the variable removals from the language files. Still not tested. (CoppaForm.php, Profile-Modify.php, Who.php, and language files: Login, Media, Profile, Who)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/Media.english.php
Modified : /trunk/Themes/default/languages/Media.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php


@ The outstanding items are EmailTemplates, Help and index. These have special needs compared to normal items, which doesn't help much.

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: New revs
« Reply #1102, on October 12th, 2011, 09:27 PM »
rev 1102
(11 files, 11kb)

! Long-standing SMF bug: finally got rid of these 'Last post by ... in ... on Today'. It's not proper English, it should use on_timeformat(). (MessageIndex.php, Subs-BoardIndex.php, index.language.php)

* More {string} optimizations. (Subs-Template.php, Subs.php, index.language.php, Help.language.php)

! Quick and temporary hack for fixing the default English time format when removing the year. (Subs.php)

- $_GET['in'] is already tested as valid, no need to re-test it. Also optimized the string modification. It's only used on two strings, is that really worth a_preg_replace...? (Help.php)

- Removed $txt['your_pms'] from the English version as well. (index.english.php)

! French version had an incorrect default time format. (index.french.php)

* Indenazi. (Boards.template.php, MessageIndex.template.php)
Re: New revs
« Reply #1103, on October 12th, 2011, 10:34 PM »
rev 1103
(8 files, 12kb)

* Replaced individual {scripturl} replacements with a page-wide buffer replacement. It only takes a few microseconds. (Load.php, ManageAttachments.php, Subs-Cache.php, Subs-Template.php, Who.php, index.template.php, ManageNews.template.php, ModerationCenter.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1104, on October 13th, 2011, 02:13 AM »
Revision: 1104
Author: arantor
Date: 01:13:01, 13 October 2011
Message:
! Removed globalisation of $helptxt variable in the Help language files, and just extended the two places it would actually make a difference in terms of making sure the variable was available. (Help language file, Subs.php, Subs-Template.php)
! Removed birthdays from the core code. Everything of use can either be retrieved from diffs, or I've already copied it over to the plugin. (install.sql, ssi_examples.php, SSI.php, skins/index.css; Sources: Boards, Calendar, Feed, ManageCalendar, ManageMail, ScheduledTasks, Subs-Calendar, Subs-Members, Subs-Template, Welcome; Templates: Calendar, InfoCenter; Languages: EmailTemplates, Help, index, ManageCalendar, ManageMail, ManagePermissions, ManageScheduledTasks)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageCalendar.english.php
Modified : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/Themes/default/languages/ManageMail.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.english.php
Modified : /trunk/Themes/default/languages/ManageScheduledTasks.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/other/install.sql
Modified : /trunk/other/ssi_examples.php
Re: New revs
« Reply #1105, on October 13th, 2011, 04:51 PM »
Revision: 1105
Author: arantor
Date: 15:51:21, 13 October 2011
Message:
! Allow hooks to indicate a priority value. Hooked functions of equal priority will be assumed to be able to run in any given order without any issue. It defaults to 50, and runs on a scale of 1 to 100, with 100 being the highest priority. While there's nothing to stop authors just forcing everything to 100, the default should be perfectly adequate in the vast majority of cases, except if you know in advance that you have to run something before or after something else. In my case, I need to run birthdays after the calendar, so that birthdays know to hook into the calendar properly in the board index. Is complicated. (Load.php, ManagePlugins.php, plugin-info.rng)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/other/plugin-info.rng

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: New revs
« Reply #1106, on October 13th, 2011, 08:30 PM »
rev 1106
(15 files, 21kb)

* Moved URL replacements to the very end, to avoid URLs not being transformed in some situations. (Subs-Template.php)

* Renamed {scripturl} to <we:scripturl> to avoid literal uses of {scripturl} in user posts to be converted on the fly. Also converted the quote tag entry and removed a few str_replace calls that were now useless. (other/install.sql, Subs-BBC.php, Subs-Template.php, SSI.php, index.template.php, Warm/skin.xml, LANGUAGES: Admin, index, ModerationCenter, Who)

! $context needed to be globalized. (Who.php)
Re: New revs
« Reply #1107, on October 13th, 2011, 09:21 PM »
rev 1107
(8 files, 9kb)

- Removed a non-existent birthday function call. (other/ssi_examples.shtml)

! French translation fixes. (EmailTemplates.french.php, Help.french.php, index.french.php, ManagePermissions.french.php, Profile.french.php)

* Minor tidbits and unused strings. (index.english.php, Profile.english.php, Profile.french.php)
Re: New revs
« Reply #1108, on October 13th, 2011, 11:17 PM »
rev 1108
(13 files, 18kb)

! Fixed a very odd skeleton bug where the skeleton would be emptied after reindexing it for the Nth time. I think my... solution to the problem is even weirder than the bug itself. (Subs-Template.php)

* Renamed <we:scripturl> to <URL>, because we can. And to fix a conflict with macros. (other/install.sql, Subs-Template.php, index.template.php, Warm/skin.xml, LANGUAGES: Admin, index, ModerationCenter, Who)

- Useless $scripturl. (Subs-BBC.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1109, on October 14th, 2011, 12:42 PM »
Revision: 1109
Author: arantor
Date: 11:41:34, 14 October 2011
Message:
! No need to update the calendar_updated variable if a user changes their DOB; this is done by the birthday plugin all on its own through the change_member_data hook. (Profile.php)
! Add a hook for deleting topics en masse. (Note that merely moving to the recycle bin, as it stands, will not trigger the hook - but then it's not supposed to. This hook is for clearing out any topic-related data on topic deletion.) (ManagePlugins.php, RemoveTopic.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/RemoveTopic.php