Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Anthony`
31
Bug reports / Maintenance Task Hangs
« on November 7th, 2012, 12:41 AM »
When I try to run the "Check all files against current versions" task, the page is blank and nothing happens. No errors anywhere.

I went through the source code and I believe it is the exec() function call in the media_handler::testImageMagick() method which is hanging PHP. I don't have ImageMagick installed on my system, so I'm assuming that's why it hangs.

This is the code in Subs-Admin.php which allows this to happen due to some logic error,
Code: [Select]
// ImageMagick?
if (in_array('imagick', $checkFor))
{
$data = array();
if (media_handler::testIMagick())
{
$data['imagick'] = true;
$imagick = new Imagick;
$data['imagick_ver'] = $imagick->getVersion();
$imv = $data['imagick_ver']['versionString'];
}
if (media_handler::testMW())
{
$data['mw'] = true;
$data['mw_ver'] = MagickGetVersion();
$imv = $data['mw_ver'][0];
}
if ($im_ver = media_handler::testImageMagick())
$imv = $im_ver;
if (isset($imv))
$versions['imagick'] = array(
'title' => $txt['support_imagemagick'],
'version' => $tick . ' (' . $imv . ')</em><br>
  ' . $txt['support_imagick'] . ': <em>' . (isset($data['imagick']) ? $tick . ' ' . $txt['support_available'] : $untick . ' ' . $txt['support_not_available']) . '</em><br>
  ' . $txt['support_MW'] . ': <em>' . (isset($data['mw']) ? $tick . ' ' . $txt['support_available'] : $untick . ' ' . $txt['support_not_available']), // don't end the /em tag! The template already does that...
);
else
$versions['imagick'] = array('title' => $txt['support_imagemagick'], 'version' => $untick . ' ' . $txt['support_not_available']);
}

If the check for ImageMagick fails in the first if block, why would it later "test" ImageMagick regardless?


After adjusting the code, the page loads fine.
32
The Pub / Re: About SMF and this project
« on November 6th, 2012, 10:54 PM »
Quote from Kindred on November 6th, 2012, 03:05 PM
Oh, you won't get any disagreement from me about what wedge has done. I am impressed and in favor of most of the stuff done here. I just thing that you are wrong about all those bells and whistles.  Content is what matters, in the end. I go to a site or a page to read what is there...

Back in the 80s and 90s, some people decided, like you, that bells and whistles and animation and moving bits, etc were good.  Those pages were trash... Absolute trash.

In the end, while a pretty site may get visitors, only a site with good content will keep them..., regardless of the "flashiness" of the site.
(and btw, I despise all the crap that Facebook forces on us)
I won't argue that content is king because it is. And I've seen some of the stuff produced in the 90s that don't look very good, that isn't what I'm aiming at.

Let me reiterate my argument: "Bells and whistles" aren't what makes a forum successful, but when a user is viewing a forum, they don't want to see a boring site that looks like it is nowhere near as modernized as it should be. It's like a nice looking theme, it isn't necessary at all, but it makes a difference in terms of the overall perspective of the forum.
33
Archived fixes / Re: Thoughts and Viewing All
« on November 6th, 2012, 10:37 PM »
Marked as solved. Whoo!
34
Archived fixes / Re: Thoughts and Viewing All
« on November 6th, 2012, 04:16 AM »
Quote from Arantor on November 6th, 2012, 04:10 AM
As mentioned on the thoughts recently, there seems to have been some kind of regression bug. I've been saying for a while that the code in SVN was not the same as on the front page but I don't have FTP access to verify it. Seems that the front page is now harmonised with SVN... and is broken.
Heh, lovely. :P Looks like some code needs to be reviewed in the master codebase then.
35
Archived fixes / Re: Thoughts and Viewing All
« on November 6th, 2012, 04:00 AM »
Quote from Arantor on November 6th, 2012, 03:57 AM
I edited your post to remove the full path in the error - we prefer not to include those on here for security reasons as I'm sure you can probably understand.

Interesting bug though.
Haha whoops, sorry about that.
Yep, I'm pretty sure this is a new one considering (unless my memory is failing me) this was working atleast a day or two ago?
36
Archived fixes / Thoughts and Viewing All
« on November 6th, 2012, 03:56 AM »
On the main page of this forum, when I go to the Thoughts section and press the "All" link to view all the thoughts, I return to the main index again except with the following error embedded where the same block was:
Quote
Notice: Undefined index: page_index in .../wedge/Themes/default/Home.template.php on line 126
37
The Pub / Re: Hardening admin security
« on November 6th, 2012, 02:18 AM »
In my opinion, I don't think implementing Google Authenticator as a core feature is really appropriate. If anything, a plugin would probably be more suitable.
38
The Pub / Re: Hardening admin security
« on November 5th, 2012, 10:52 PM »
This is a great idea. It's not very often hackers have access both to an admin password and the person's e-mail account (atleast in my experience).
39
The Pub / Re: About SMF and this project
« on November 5th, 2012, 10:46 PM »
Quote from Kindred on November 5th, 2012, 05:26 PM
Anthony,
you give the general public too much credit.
Quote
Let's face it, the web is obviously alot more dynamic nowadays, and if people didn't want these things, they wouldn't be used so much.
As someone who is involved in the web for business, I disagree with this statement 110%. People have no idea what they "want" except what they are TOLD they should want...   dealing with marketing and sales folks, I am continually telling them "NO! I don't care what you think you heard on Jimmy Kimmel...(or whatever show they thought told them that something was 'popular'.) "

People want them because they are used... and then others follow the "trend" no matter how stupid it is.
They are not (in general) used because people want them.
So people don't want more engaging, dynamic effects on a webpage? I personally find that hard to believe because it seriously is alot more interactive than a boring static page. :P Facebook and Twitter for example is highly dynamic, just imagine them without all their "Javascript-spiced" features. You would have to keep refreshing your Twitter page to see new tweets. I don't work for the web, heck I'm a kid in highschool, but I can already see people want more of these things - and this also includes the "instant" effect because refreshing a page to see if there is new content is too much.

I'm not saying make a forum one big AJAX application (not just AJAX but effects-wise as well), but it would probably help, atleast in my opinion, if a forum was a little more dynamic than what some forum software is like now.

As a matter of fact, Wedge is doing this already. It is pretty modern interactively, but it's also built more like that way (code-wise such as utilizing more modern CSS and Javascript). It's even on the front page! :)
Quote
Wedge allows you to create and maintain message boards with a modern twist. Blogs, HTML 5, CSS 3, jQuery
40
Archived fixes / Re: Modify board: \
« on November 5th, 2012, 04:23 AM »
Quote from spoogs on November 5th, 2012, 04:15 AM
Quote from Arantor on November 5th, 2012, 12:38 AM
Or should it? If it's a board you can see but can't enter, should you be able to see the last post?
I would say you should not be able to see the last post if you cannot enter the board.
I agree with this. If member's can't see the contents of the board, it would probably be a bad idea if they were to see a detail such as the last post's title when they got the chance assuming the board is supposed to be private.
Posted: November 5th, 2012, 04:22 AM

PS: Arantor, when someone else posts before submitting a reply is there supposed to be a notice in place like how SMF does it?
41
Test board / Re: "hello world!"
« on November 5th, 2012, 02:23 AM »
Interesting, I didn't realize this was the situation regarding the encoding of subjects. I don't know about any XSS bugs but I will play around with that idea for a bit the next time I get a chance to.
42
Archived fixes / Re: open_basedir and Cache Errors
« on November 4th, 2012, 11:22 PM »
Quote from live627 on November 4th, 2012, 10:38 PM
So THAT's why glob() would sometimes give errors...
Yep, a pain to realize but atleast the workaround is quite simple.
43
Archived fixes / Minor Quick Edit Bug
« on November 4th, 2012, 09:16 PM »
It seems when I try to quick edit a post with double quotes (") in it, the Javascript has an issue with the quote(s) and instead replaces the entire title textbox with a slash (\). Possible escape issue? Every other special character on my keyboard works fine.

I made a test topic for this here,
http://wedge.org/pub/test/7658/hello-world/msg282990/#msg282990
Just click on the quick edit icon and look at the title's textbox.

44
Test board / "hello world!"
« on November 4th, 2012, 08:40 PM »
Blah blah don't mind me.
45
Archived fixes / open_basedir and Cache Errors
« on November 4th, 2012, 07:15 PM »
Looks like there is another open_basedir issue here (this setting is quite a pain in the arse)...

I noticed I had 4 errors in the error log after installing Wedge:
Quote
2: Invalid argument supplied for foreach()
File: /home/projecte/public_html/dexterslab/wedge/Sources/Subs-Cache.php
Line: 766

2: Invalid argument supplied for foreach()
File: /home/projecte/public_html/dexterslab/wedge/Sources/Subs-Cache.php
Line: 553
Line 766,
Code: [Select]
foreach (glob($jsdir . '/' . $id. '*' . $ext) as $del)
Line 553,
Code: [Select]
foreach (glob($final_folder . '/' . ($id ? $id . '-*' : '[0-9]*') . $ext) as $del)

The open_basedir setting on my host does have a value according to phpinfo(). Resetting the file cache reproduced these errors, so it seems iterating through the cached CSS and JS files are a problem.

After looking at this,
https://bugs.php.net/bug.php?id=47358

It seems glob() is returning boolean false rather than an empty array. Obvious fix: check beforehand whether it's false and if so make it an empty array.