« [Plugin] Awards
[Plugin] User Mentions v1.0 (9th March 2013)

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #30, on April 4th, 2013, 11:11 AM »
Heh, for my curiosity, what changes do you have in my mentions plug in apart from the Ui? Also,
Quote
Oh and is markReadForNotifier disabled for this site? It isn't marking my notifications as read when I view this topic.
The way it's meant to be

Nao

  • Dadman with a boy
  • Posts: 15,968
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #31, on April 4th, 2013, 12:14 PM »
Err... I don't remember exactly... Not that many, though..?
I mostly tore the JS apart and added the avatar stuff.

And mark read is disabled, yes. On wedge.org only though. For tests.
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #32, on April 4th, 2013, 07:26 PM »
Notifications popup updated... It's a bit better now.
It's using the same template as on the notifications page, with a few minor modifications.
Also, everything is now pulled through Ajax (HTML included), so it makes for a shorter HTML container and JS file as well. (About 80 bytes saved in JS, dunno for HTML but it's all right too.)

I'm very close to being able to commit... Hopefully tomorrow. Then I'll just have to merge Dragooon's changes ;)

Which reminds me: id_member_notified sounds a bit strange... Instead of "ID of member who notified you", it implies to me "ID of member to be notified"... Wouldn't it be better to use something like 'id_issuer' or 'id_member_from'...?
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #33, on April 4th, 2013, 10:47 PM »
Uploaded another version, which will excite @Dragooon because now the popup will only show unread items ;)
I also added a limit of 10 items in the popup, it's totally arbitrary though, maybe it should be higher..? Or unlimited?

There are also a few bugs in this version, but I don't have time to work on them tonight, so it'll have to wait, sorry. :)
Design is also still a WIP...

PS: everybody please like this post, so I can get some 'easy to remove' notifications... Thanks ;)

MultiformeIngegno

  • Posts: 1,337

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #35, on April 5th, 2013, 06:45 AM »
Couple of things, I got mention notification in french. Although I should probably use email template but I'm not sure if that'll fix this problem. Secondly, the email is bloody useless as it is :P, I need to seriously improve it.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,666
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #36, on April 5th, 2013, 06:59 AM »
Quote
Although I should probably use email template but I'm not sure if that'll fix this problem.
No, won't  fix. Check the mailer for PMs. Gotta juggle languages manually.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #37, on April 5th, 2013, 04:39 PM »
The mailer for PMs is separate to loadEmailTemplate, and you can pass a language to it specifically for it to load if you so wish.

However if you have big batches to run, you would be strongly advised to batch them by language wherever possible.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #38, on April 5th, 2013, 04:45 PM »
Okay, I'll look into improving this. I'm not entirely sure how to handle Email templates here especially given the amount of notificaiton plugins.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841

Nao

  • Dadman with a boy
  • Posts: 15,968
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #41, on April 6th, 2013, 01:46 PM »
Quote from MultiformeIngegno on April 5th, 2013, 12:51 AM
What about read notifications greyed?
They used to be shown and greyed out, yes. What exactly are you trying to say..?

The only reason I kept showing them in the popup was because I wanted to always have notifications in there for me to style the damn thing... :P Other than that, it probably makes more sense to have a separate page for all notifications, and a popup for unread ones.

Or did you prefer the 'all' solution...?

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #42, on April 6th, 2013, 01:56 PM »
Well I obviously prefer the current solution, but don't mind either way. As long as the unread ones are on the top.

MultiformeIngegno

  • Posts: 1,337
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #43, on April 6th, 2013, 03:27 PM »
Uhm I think I'd be fine with both solutions.. maybe the "all" solution with read notifs grayed/smaller is more common..

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: User Mentions v1.0 (9th March 2013)
« Reply #44, on June 3rd, 2013, 10:04 AM »
@Nao: Okay I can see you uploaded the mentions plugin but since it's not completely BSD anymore I can't merge the changes back to my GitHub repository, and I can't distribute it either. So...what happens now?