importer MySQL bug

Harz-FEAR

  • Posts: 12
importer MySQL bug
« on February 4th, 2014, 01:18 AM »Last edited on February 4th, 2014, 01:24 AM
The importer throws an error:
Code: [Select]
This query:
SELECT @@SQL_BIG_SELECTS, @@SQL_MAX_JOIN_SIZE;
Caused the error:
Unknown system variable 'SQL_MAX_JOIN_SIZE'

I changed line 366 in importer.php to
Code: [Select]
$results = $db->query("SELECT @@SQL_BIG_SELECTS, @@MAX_JOIN_SIZE");
and now it works fine.

MySQL version is 5.6.12

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,666
Re: importer MySQL bug
« Reply #1, on February 4th, 2014, 06:52 AM »
Moved. Even though this was in bug reports, I think it is better suited here and might grab @TE's attention faster.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 15,969
Re: importer MySQL bug
« Reply #2, on February 4th, 2014, 10:19 AM »
It caught mine anyway ;)

SQL_ seems to have been removed somewhere before the release of v5.0 (since it can be seen in the 5.0 constant list in both spellings), and deprecated on 5.6... I guess.

So I should safely be able to commit the proposed fix. Once I'm done with breakfast, car duty, Himym, Brooklyn 99 and Uncle. In that order. :P
Posted: February 4th, 2014, 07:35 AM

Fixed in the repo. Thanks for the report! I can confirm that it's a MySQL 5.6 change, and that MySQL 5.0 should be fine with this change -- I tracked down the rename to MySQL 4.0!!