« Fatal error: Call to undefined function Display()
[Fixed] Bug with color & font selectboxes
Thoughts edits now shown in the sidebar »

MultiformeIngegno

  • Posts: 1,337
[Fixed] Bug with color & font selectboxes
« on March 23rd, 2012, 01:28 PM »Last edited on March 27th, 2012, 10:54 PM by Nao
Reply/start a new topic, in the post box write for example "This is a dummy text". Now select "This" and choose the red color. Then select "dummy" and choose red again. Nothing happens.. It works if you choose a different color (same for size).

Seems like the select box doesn't get "reset" when you choose a value.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Bug with color & font selectboxes
« Reply #2, on March 23rd, 2012, 01:40 PM »
Ain't got time to check (dozens of bugs at the same time :P), but how is it correct behavior exactly...?
Also, I suspect this would only happen in Wysiwyg?

MultiformeIngegno

  • Posts: 1,337
Re: Bug with color & font selectboxes
« Reply #3, on March 23rd, 2012, 01:45 PM »
Not WYSIWYG mode. BBC mode. Well IMO it's not a correct behavior.. If I want something red I want something red. If I push the red option and nothing happens, it just doesn't work. :P
Posted: March 23rd, 2012, 01:42 PM
Quote from Nao on March 23rd, 2012, 01:40 PM
Ain't got time to check (dozens of bugs at the same time :P), but how is it correct behavior exactly...?
I think it should be that when you select a text and then choose a color/font size, the select box should be reset to "Change color/Font Size", so it will work again if I choose the same color/font size for anoher portion of text.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Bug with color & font selectboxes
« Reply #4, on March 23rd, 2012, 01:48 PM »
Quote
but how is it correct behavior exactly...?
In WYSIWYG mode it should change and stay there to indicate the current style. In non WYSIWYG mode it should do as MultiformeIngegno suggests.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Bug with color & font selectboxes
« Reply #5, on March 23rd, 2012, 02:17 PM »
Quote from Arantor on March 23rd, 2012, 01:48 PM
Quote
but how is it correct behavior exactly...?
In WYSIWYG mode it should change and stay there to indicate the current style. In non WYSIWYG mode it should do as MultiformeIngegno suggests.
I think that in non-Wys, I should reset the select box to default all the time, since it never updates when moving through the post.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082

MultiformeIngegno

  • Posts: 1,337

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Bug with color & font selectboxes
« Reply #11, on March 27th, 2012, 10:13 PM »
It is in my to do list ;)
I'm too ill tonight to do any serious work though. And first I have to finish my 'show groups under user names' rewrite.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Bug with color & font selectboxes
« Reply #13, on March 27th, 2012, 10:53 PM »
Quote from Arantor on March 27th, 2012, 10:25 PM
You really should take a break for a day or so.
I don't know... I'm sure I'll feel better in the morning. I'll just go to bed now.

@Lorenzo> Fixed locally and here! Will commit tomorrow. I only had to add two lines of code :)

Code: [Select]
if (!this.bRichTextEnabled)
sel.attr('selectedIndex', 0).sb();
[Fixed] Re: Bug with color & font selectboxes
« Reply #14, on March 27th, 2012, 10:57 PM »
Oh, bugger... Looks like the Fixed selectbox system is broken. From what I saw in the quick moderation sbox at least...
I don't get it. I did the fixing specifically for my membergroup select box earlier today. I tested it. It still works. It just seems to fail in that particular situation... And, I suspect, in others as well.
« Fatal error: Call to undefined function Display()
Thoughts edits now shown in the sidebar »