« [Fixed] Bug with color & font selectboxes
IE8: menu broken (with fix)
Undefined index: start_from »

TE

  • We-Gen
  • Posts: 246
IE8: menu broken (with fix)
« on March 22nd, 2012, 12:27 PM »
the menu icons are slightly overlapping in IE8 (see attachment):
proposed fix:
 .menu > li
 display: inline-block
should be changed to  display: inline

 ie8_menu.png (3.14 kB, 318x58 - viewed 202 times.)
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru<br />----------------------------------------------------------<br />SMF is dead, long live Wedge ;)

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,892
Re: IE8: menu broken (with fix)
« Reply #1 on March 22nd, 2012, 12:31 PM »
I can assure you that IE9 in IE8 mode (in Windows 7) doesn't have this problem...
The only odd/amusing thing is the extra gradient on the menu bar itself. It shouldn't be there... Probably due to a quick hack to provide the gradient in the first place (since IE6-9 all require some filter:gradient crap...)

 ie8shot.png (6.87 kB, 372x119 - viewed 373 times.)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

TE

  • We-Gen
  • Posts: 246
Re: IE8: menu broken (with fix)
« Reply #2 on March 22nd, 2012, 12:36 PM »
My screenshot is native IE8 on a W2k3 Server.. (IE 8 in IE7 mode is fine)
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru<br />----------------------------------------------------------<br />SMF is dead, long live Wedge ;)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,593
Re: IE8: menu broken (with fix)
« Reply #3 on March 22nd, 2012, 12:46 PM »
Native IE8 on WinXP (in a VM) does the same as TE's screenshot. Yay for IE9 supporting 'IE8 rendering'.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

billy2

  • We-Gen
  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 348
Re: IE8: menu broken (with fix)
« Reply #4 on March 22nd, 2012, 12:49 PM »
Now I dont feel so stupid :yahoo:
<br /><br />cough, cough.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,892
Re: IE8: menu broken (with fix)
« Reply #5 on March 22nd, 2012, 12:56 PM »
Holy crap... Thank you, Microsoft........ -_-

What do I do now.
And yes, playing with display styles usually fixes this kind of stuff.
However, there's often a reason for deciding to use this or that style. Too many times, I've fixed something to break it somewhere else. (This is why I was so adamant to implement @remove from: because instead of replacing a rule with another, we can now simply ignore it... Simple example: try cancelling hasLayout on older IEs after it was triggered... Good luck!)
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE... Oh, well: it works when you first open it... But if you switch to another menu entry, it'll display a transparent background instead. Fun... Maybe it's only in IE9 in compatibility mode... But I won't tempt the devil.

So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,593
Re: IE8: menu broken (with fix)
« Reply #6 on March 22nd, 2012, 12:57 PM »
There's not really much reason to feel stupid... if it's not working, it's not working for a reason. Half the battle here is understanding what that reason is.

If it's because you have a totally alien configuration that's a monstrosity under the hood, we might not be able to do too much about it, but if it's reproducible and causing problems, the bigger the problem (or at least, the bigger the impact it has and the more reproduced it is) the more we can figure out WTF is the problem and fix it.
Quote
Holy crap... Thank you, Microsoft........ -_-
My sentiments exactly. This is why I've always been wary of IETester and ilk.
Quote
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE...
Speaking of which, in my Weglas theme, it's actually broken in IE9 where the gradient just doesn't work. The CSS generated is correct (so it's not a WeCSS bug) but IE9 chooses to ignore it. I have no idea why, and I can't be arsed debugging IE9's stupid behaviour.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

billy2

  • We-Gen
  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 348
Re: IE8: menu broken (with fix)
« Reply #7 on March 22nd, 2012, 01:36 PM » Last edited on March 22nd, 2012, 02:13 PM
Quote from Arantor on March 22nd, 2012, 12:57 PM
There's not really much reason to feel stupid... if it's not working, it's not working for a reason. Half the battle here is understanding what that reason is.
As far as I was aware - no-one else could see the icon overlap. See my thoughts - no responses.
 :angel:

:edit: Sorry TE, just re-read your 'confirm' response and interpreted correctly this time.
<br /><br />cough, cough.

TE

  • We-Gen
  • Posts: 246
Re: IE8: menu broken (with fix)
« Reply #8 on March 22nd, 2012, 04:20 PM »
Quote from Nao on March 22nd, 2012, 12:56 PM
So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?
Yep, didn't found anything suspicious after changing the code.

Using IE8 developer tools, I can see only one difference between native IE8 and IE8 in IE7 compabilty mode, that's  the "inline-block" style,
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru<br />----------------------------------------------------------<br />SMF is dead, long live Wedge ;)

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,892
Re: IE8: menu broken (with fix)
« Reply #9 on March 23rd, 2012, 11:03 AM »
So, err... Does it work now, here?
I applied the menu>li change to index.ie8.css.
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,593
Re: IE8: menu broken (with fix)
« Reply #10 on March 23rd, 2012, 11:06 AM »
Yup, all good in real IE8.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

billy2

  • We-Gen
  • Trying to earn brownie points for a lads trip to the Red Sea. Minus 1 already - just for asking!!
  • Posts: 348
Re: IE8: menu broken (with fix)
« Reply #11 on March 23rd, 2012, 11:15 AM »
:cool:
<br /><br />cough, cough.

Farjo

  • "genuinely interested"
  • We-Gen
  • Posts: 244
Re: IE8: menu broken (with fix)
« Reply #12 on March 23rd, 2012, 06:38 PM »
This PC has IE8 and all the dropdown options drop down below "Home". Does that make sense?
We've moved on - will you come with us?

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,892
Re: IE8: menu broken (with fix)
« Reply #13 on March 23rd, 2012, 06:41 PM »
Quote from Farjo on March 23rd, 2012, 06:38 PM
This PC has IE8 and all the dropdown options drop down below "Home". Does that make sense?
I can't test.
Are you implying that before today (i.e. before the fix), it worked better than now..?
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Farjo

  • "genuinely interested"
  • We-Gen
  • Posts: 244
Re: IE8: menu broken (with fix)
« Reply #14 on March 23rd, 2012, 06:47 PM »
Yes, but I would wait for someone else's confirmation as this PC seems a bit odd - this is the one that occasionally hangs when going into Forum Profile with no pattern. So in hindsight ignore me unless someone else has the same problem.
We've moved on - will you come with us?
« [Fixed] Bug with color & font selectboxes
Undefined index: start_from »