The commas instead of dots confuse me. I'd argue that ie7,replace,ie6 is a combination that isn't really necessary... what purpose would it (practically) solve?
|
Arantor
-
- With a Box
-
- As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
- Posts: 13,600
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
Well, that's the reason I asked. (I could use 'index.replace.ie6,ie7.css' but I'm not sure people would follow.)
I'm already getting the list of suffixes for a file -- I could just as well remove 'replace' from the array, and then do a search on all parent folders, get all files with the same radix, explode the suffix list and compare the arrays. (Perhaps doing a sort() before maybe? I don't think array(1, 2) == array(2, 1)...)
There also is the point of replacing non-suffixed files in the same skin. Like, 'custom.replace,ie6.css' could be a request to entire remove 'custom.css' when IE6 is used, and replace it with 'custom.replace,ie6.css'...
I'm already getting the list of suffixes for a file -- I could just as well remove 'replace' from the array, and then do a search on all parent folders, get all files with the same radix, explode the suffix list and compare the arrays. (Perhaps doing a sort() before maybe? I don't think array(1, 2) == array(2, 1)...)
There also is the point of replacing non-suffixed files in the same skin. Like, 'custom.replace,ie6.css' could be a request to entire remove 'custom.css' when IE6 is used, and replace it with 'custom.replace,ie6.css'...
 | ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
Arantor
-
- With a Box
-
- As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
- Posts: 13,600
You're right, array(1, 2) != array(2, 1) but that's sort of the point.
I'd keep it simple: if you indicate replace, and there's a suffix after that, that's all that's replaced. Bear in mind that we'll have to explain this to other people!
I'd keep it simple: if you indicate replace, and there's a suffix after that, that's all that's replaced. Bear in mind that we'll have to explain this to other people!
|
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
Lulz yeah...
But there's hardly any reason to account for the replace keyword's position when already I'm getting the suffixes as an array...
Could simply test for implode(',', array_diff($suffix_list_from_this_file_that_has_a_replace_suffix, (array) 'replace'))...
But there's hardly any reason to account for the replace keyword's position when already I'm getting the suffixes as an array...
Could simply test for implode(',', array_diff($suffix_list_from_this_file_that_has_a_replace_suffix, (array) 'replace'))...
| ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
Arantor
-
- With a Box
-
- As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
- Posts: 13,600
Putting aside the position of the replace keyword, just consider the remainder of the terms - index.replace.some,thing.css should replace index.some,thing.css but not index.thing,some.css.
While I can see the logic of arguing either way, I'd strongly be in favour of keeping it simple.
While I can see the logic of arguing either way, I'd strongly be in favour of keeping it simple.
|
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
Nao, I think your rewrite is broken somewhat. My custom board icons don't show (full path instead of URI). Also, my custom menu is completely broken. Does the reset keyword still work?
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
I don't think anything's broken in here...?
Even the reset keyword seems to work.
Can you look into it further, please? You know I'm as careful as possible when touching my skin code, but maybe I missed something, given the number of possibilities wetem and wecss offer...
Even the reset keyword seems to work.
Can you look into it further, please? You know I'm as careful as possible when touching my skin code, but maybe I missed something, given the number of possibilities wetem and wecss offer...
| ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
It was a misplaced parenthesis!
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
Offending line:
.menu:not(#main_menu2, #context_menus)
The comma confuses the parser, it seems.
.menu:not(#main_menu2, #context_menus)
The comma confuses the parser, it seems.
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
Not surprised. WeCSS has trouble with any complex css2/3 that uses commas or quotes. I think one of my comments warns against that.
What shall we do? Protect all code at parse time? In what order? etc.... Headaches ahead.
What shall we do? Protect all code at parse time? In what order? etc.... Headaches ahead.
| ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
Thing is, my entire skin worked just as expected before the rewrite.
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
Can you help determine what revision broke it?
| ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
Nao
-
- With a Box
-
- If you say so.....
- Posts: 12,896
Can you revert to an even older copy then? Just check the log for Class-CSS.php to see the relevant revs... Thanks!
| ...« I say wedge wedge (in the butt) » « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson) |
live627
-
- Talking Head
-
- Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
- Posts: 1,412
OMG so many changes... so fucking lost.
it works in r1584
also in 1590
and not in 1593
Quote I'd assume that has something to do with it.
Posted: June 10th, 2012, 06:14 AM
it works in r1584
Posted: June 10th, 2012, 06:20 AM
also in 1590
Posted: June 10th, 2012, 06:24 AM
and not in 1593
Posted: June 10th, 2012, 06:26 AM
* Sort selector lists before generating the CSS files. This helps a bit with overall gzip compression rates. (Class-CSS.php)
