rev 1926 -- we::$is_ajax harmonization, and fixing a Wysiwyg bug. (My fault for this one.)
(37 files, 14kb)
* Renamed $context['is_ajax'] to we::$is_ajax, as it's more of a system variable than context one. It doesn't seem to be tested against before the system class is loaded, but I may be wrong. Also harmonized all $_REQUEST['xml'] requests to replace them with we::$is_ajax and remove 'xml' from Ajax URLs. Just plain and simple... Mass-upload was a special case, because it uses YUI, so I'll be forcing we::$is_ajax on this one. (unittest.js, Class-Editor.php, Class-Skeleton.php, Class-System.php, JSModify.php, Like.php, Load.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Aeva-Subs-Vital.php, Subs-Media.php, Packages.php (when do we remove that one?), PersonalMessage.php, Post.php, Post2.php, Profile-View.php, QueryString.php, Search.php, Search2.php, Security.php, Split.php, Stats.php, Subs-Menu.php, Subs-Post.php, Subs-Template.php, GenericPopup.template.php, ManageMedia.template.php, Packages.template.php, editor.js, script.js)
* Rewrote some Ajax calls in the editor code to save about, hmm... 30 bytes? Even years after I started my quest to reduce the size of all our JS files to a couple of bytes, I'm still amazed at how much I can save just by being a bit smart about something. (editor.js)
! Which hopefully compensates the silly bug I introduced a month ago, that actually broke switching from Wysiwyg to non-Wysiwyg. Interestingly, a jQuery bug is also associated with it, but because my 'fix' actually compresses better than what I'd written, I'm not even going to bother submitting a report for that one. (editor.js)
* Simplified draft ajax response. Just enough to be able to optimize the matching editor-func JS file... Surprised uh? No? Okay, no. It saves 10 bytes, so sue me. (Subs-Post.php, editor-func.js)
* Moved .xml->feed action compatibility code to the QueryString file, which seems more appropriate for that to me. Also ensured that the corresponding $_GET/$_REQUEST action is updated as well. (index.php, QueryString.php)
! Fixed Pretty URLs in media feeds. (Aeva-Foxy.php)
* Now using XML template codepath for Atom feeds... This seems to work. Needs some double checking. Also fixed some Aeva Media files that still requested the older feed format (.xml in the URL) -- boo. (Load.php, Aeva-Embed.php, Aeva-Subs-Vital.php, Subs-Media.php)
- Replaced a few remaining ISO header declarations to UTF. (upgrade.php, Aeva-ModCP.php)
* Forgot a newline at the end of a file. (ManagePlugins.french.php)
@ I'm (very) worried about start_output() now always returning a XML header for all Ajax responses. Because not all of them are XML-formatted... Do you think this will be okay? (Subs-Template.php)