Wedge

I say no for user preference, its just one more setting most people will not use, and it doesn't really add anything.

In that case, let's flip it back the other way. Do we need the ability for users to set a preference on posts, as they can currently do?

Does it add value to have that option? Do users take it?

I don't personally think it matters, as Admin on some sites I set it to have it for everyone and on some I set it for none.

So you don't ever leave it on by default but turn it off yourself? (This is what I'm wondering, because it would simplify the code to remove it for that too.)

Correct, sorry for not being more clear.

Anyone else who feels strongly about this one?

Yea I do.
Because of our recent pm discussion about editing pms after they're sent. Could be a user setting, either way is fine. Obviously if you want to edit or delete a sent pm, you need to ensure it wasn't sent by email already. Otherwise you can only fix typos...

That suggests then that we might want to remove the body text in every case from PM notifications and just be done with it? Not even making it optional, allows for editing after sending - until it has been read, of course.

Plus that then gains the benefit by default of not having messages sent by return email to the admin...

I suppose the benefits outweight the inconvenience. :-/

Well, they do, but if there's enough people that would prefer to have the option, we can leave the option in - but having the option does constrict what editing you can do of PMs that are as yet unread.

I have a feeling that either no one reads the 'SMF bug' topics, or no one cares about the option :P

They probably don't :/

If a quick read of what's above will suffice; make it a user opt-in to have the body in the notification, off per default (least information leakage that way...)

As for edit/delete, I personally see no conflict whether the body is included in the notification or not. If I send you a PM, then retract it (whether before or after you are notified), a message at the time of retraction (be it by editing or deleting) to say that the recipient has already been notified of the original should serve as sufficient warning to the sender. Stupid people will always be stupid, and no amount of helper code will stop that :)