(Sorry about the topic title, I found it irresistible to use it :lol: I'm also not posting this in private boards because I'm not sure who's in our Friends group or not. If you want it to be private, please ask for a Friend badge if you don't already have one, and request for the move to be done.)
So... First time I'm looking at Elkarte's github... There's a lot of activity so I'm not going to do that often... But I find it amusing (also a bit upsetting I'll admit) that in the first page of commits, I found this:
https://github.com/elkarte/Elkarte/commit/babfac398abdb9b49ffb3e1d3d1631585e917ede
This looks a LOT like a fix I made to Wedge in rev 1847, just four days ago...
Code: [Select]
As you'll notice, the main change in here is that I fixed the || into &&, just like in the Elkarte commit.
This sounds too coincidental to be true to me. Shouldn't I be the one who gets the thanks, not emanuele?
So...
ema, I have no problems with giving you our alpha versions or whatever, I have absolutely no qualms with you or Elkarte and wish you all the best. I'd just rather be told if you already somehow have access to our SVN without telling. It would make things more comfortable for everyone I think. It's not that I don't think it can be a coincidence -- it's that now this has happened, just a few days after my own fix, this is how I'll remember it, and the harm is already done in my mind, whatever the truth might be. And I don't like this. I don't like being in a situation where I feel uncomfortable about sharing things with other like-minded developers.
If anyone at Elkarte wants to reuse an idea or code block that we wrote, please ask us. We're not ogres. We don't cling to every bit of code that we write like it's our virgin child that we won't give away. Our license is for a general code of conduct and how we want to deal with things generally, but we're flexible on the whole.
Just please don't do this kind of thing behind our back.
Oh, the joys of doing several things at the same time...
I just noticed that the Elkarte commit was made on the exact same day. I haven't checked the times but I suspect it means that I mentioned the exact bug somewhere in this forum, which would explain everything, i.e. that it's neither a coincidence nor a problem.
But did I...? I don't remember. Can someone find my post?
So... First time I'm looking at Elkarte's github... There's a lot of activity so I'm not going to do that often... But I find it amusing (also a bit upsetting I'll admit) that in the first page of commits, I found this:
https://github.com/elkarte/Elkarte/commit/babfac398abdb9b49ffb3e1d3d1631585e917ede
This looks a LOT like a fix I made to Wedge in rev 1847, just four days ago...
Index: ManageErrors.php
===================================================================
--- ManageErrors.php (revision 1846)
+++ ManageErrors.php (revision 1847)
@@ -659,14 +659,11 @@
// Decode the file and get the line
$file = realpath(base64_decode($_REQUEST['file']));
- $real_board = realpath($boarddir);
- $real_source = realpath($sourcedir);
+ $line = isset($_REQUEST['line']) ? (int) $_REQUEST['line'] : 0;
$basename = strtolower(basename($file));
- $ext = strrchr($basename, '.');
- $line = isset($_REQUEST['line']) ? (int) $_REQUEST['line'] : 0;
// Make sure the file we are looking for is one they are allowed to look at
- if ($ext != '.php' || (strpos($file, $real_board) === false || strpos($file, $real_source) === false) || ($basename == 'settings.php' || $basename == 'settings_bak.php') || strpos($file, $cachedir) !== false || !is_readable($file))
+ if (strrchr($basename, '.') != '.php' || $basename == 'settings.php' || $basename == 'settings_bak.php' || (strpos($file, realpath($boarddir)) === false && strpos($file, realpath($sourcedir)) === false) || strpos($file, realpath($cachedir)) !== false || !is_readable($file))
fatal_lang_error('error_bad_file', true, array(htmlspecialchars($file)));
// Get the min and max linesAs you'll notice, the main change in here is that I fixed the || into &&, just like in the Elkarte commit.
This sounds too coincidental to be true to me. Shouldn't I be the one who gets the thanks, not emanuele?
So...
ema, I have no problems with giving you our alpha versions or whatever, I have absolutely no qualms with you or Elkarte and wish you all the best. I'd just rather be told if you already somehow have access to our SVN without telling. It would make things more comfortable for everyone I think. It's not that I don't think it can be a coincidence -- it's that now this has happened, just a few days after my own fix, this is how I'll remember it, and the harm is already done in my mind, whatever the truth might be. And I don't like this. I don't like being in a situation where I feel uncomfortable about sharing things with other like-minded developers.
If anyone at Elkarte wants to reuse an idea or code block that we wrote, please ask us. We're not ogres. We don't cling to every bit of code that we write like it's our virgin child that we won't give away. Our license is for a general code of conduct and how we want to deal with things generally, but we're flexible on the whole.
Just please don't do this kind of thing behind our back.
Posted: January 19th, 2013, 01:58 PM
Oh, the joys of doing several things at the same time...
I just noticed that the Elkarte commit was made on the exact same day. I haven't checked the times but I suspect it means that I mentioned the exact bug somewhere in this forum, which would explain everything, i.e. that it's neither a coincidence nor a problem.
But did I...? I don't remember. Can someone find my post?
