[Plugin] Notifications system (1.0)

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
The way it's meant to be

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #17, on March 11th, 2013, 09:07 PM »
I like the overall idea of the popup but the (1) bit needs to be bigger and more prominent and preferably with a label to indicate what it is.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #18, on March 11th, 2013, 09:20 PM »
Yeah, will work on it more tomorrow. I've finished most of other things with the plugin and further extensions, perhaps Nao can install them here in a couple of days (atleast the core and mentions plugin)?

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,667
[Plugin] Re: Notifications system (1.0)
« Reply #19, on March 12th, 2013, 12:30 AM »
Meh. Move the number, so the title is "Notifications ❶ (show all)".
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #20, on March 12th, 2013, 12:31 AM »
But if the number is part of the popup, what do users interact with to get the popup?

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841

MultiformeIngegno

  • Posts: 1,337
[Plugin] Re: Notifications system (1.0)
« Reply #22, on March 12th, 2013, 12:53 PM »
This can be useful also to notify the likes on posts (actually there's no notification of likes). :)

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #23, on March 12th, 2013, 12:55 PM »
Quote from MultiformeIngegno on March 12th, 2013, 12:53 PM
This can be useful also to notify the likes on posts (actually there's no notification of likes). :)
Of course, that's one of the notification extensions I've planned.
Posted: March 12th, 2013, 12:54 PM

The idea is to replace the entire notification and subscription system Wedge currently has with this.

Nao

  • Dadman with a boy
  • Posts: 16,063
[Plugin] Re: Notifications system (1.0)
« Reply #25, on March 17th, 2013, 04:52 PM »
I'd suggest using <h6> for the Notifications title. I'm trying to move all 'small titles' to use this ;) (see search popup.)

Also, a few remarks on the database structure... More specifically the members table.
- I'd rather we leave 'data' at the very end. It needn't be lost in that extremely crowded list of columns...
- Does the mod really, really need so many new columns..? Technically, all new member data should go to the data column. If you need an explanation of how it works (really, it's just an array that's serialized and unserialized as needed), you can ask me.
- What should be in data: anything that's not updated for all members at once, or at least not on a regular basis, and that isn't used as a search parameter. Considering no new keys are added, I'm inclined to think that it's all right.

What do you think...?
I'd like to make sure we all agree on the same thing before I actually go and manually add all of these entries to the Wedge.org database... ;) (Already done on my local install. I had to, if I wanted to ensure my 'close mini-menu on click' trick worked... :lol:)

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #26, on March 17th, 2013, 05:01 PM »
Quote from Nao on March 17th, 2013, 04:52 PM
- Does the mod really, really need so many new columns..? Technically, all new member data should go to the data column. If you need an explanation of how it works (really, it's just an array that's serialized and unserialized as needed), you can ask me.
notfy_email_last_sent and notify_email_period definitely need to be columns since they are searched for scheduled tasks, unread_notifications are also used (I forgot to define Keys, I'm not sure how that'll work for these). I guess disabled_notifiers, notifiers_prefs and email_notifiers can be consolidated into data since the latter two are json_encoded arrays anyway.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
[Plugin] Re: Notifications system (1.0)
« Reply #27, on March 17th, 2013, 05:33 PM »
The thing for keys is that the value as they stand didn't seem to me to be very key-like in structure. Text keys are next to useless in this case, as are keys on things like flags for the simple reason that unless they're decently selective, they're just bloat.

The email_last_sent and email_period might be indexable, but I don't know. Some stuff I can usually get a feel for indexes while writing it, other stuff I want to see in action to judge how useful an index would be - and this certainly is the case.

Nao

  • Dadman with a boy
  • Posts: 16,063
[Plugin] Re: Notifications system (1.0)
« Reply #28, on March 18th, 2013, 05:59 PM »
I'd really appreciate if Dragooon could rework these columns into data variables. If it's not too much to ask for.

Also, I'm looking at the CSS, and: (1) anything that's member-only should be within '@if member' blocks. This saves the extra load for guests... (2) What exactly is that ":parent" pseudo-class..? If you actually mean "select this selector's parent", this isn't defined anywhere in CSS, even in CSS4. (I should know, I read through their entire pseudo-class list for CSS4 no later than yesterday for some other reason.) At worst, you can use JavaScript for that, but...

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
[Plugin] Re: Notifications system (1.0)
« Reply #29, on March 18th, 2013, 06:05 PM »
Quote from Nao on March 18th, 2013, 05:59 PM
I'd really appreciate if Dragooon could rework these columns into data variables. If it's not too much to ask for.
Yeah sure, but you'll have to wait till weekend until my exams are through.
Quote from Nao on March 18th, 2013, 05:59 PM
Also, I'm looking at the CSS, and: (1) anything that's member-only should be within '@if member' blocks. This saves the extra load for guests... (2) What exactly is that ":parent" pseudo-class..? If you actually mean "select this selector's parent", this isn't defined anywhere in CSS, even in CSS4. (I should know, I read through their entire pseudo-class list for CSS4 no later than yesterday for some other reason.) At worst, you can use JavaScript for that, but...
1) Ah okay
2) Ugh...I always thought CSS has a :parent selector, I'll fix that as well.