« Repository logs
Reply Error with Chrome
Typo in Class-DBPackages.php »

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Reply Error with Chrome
« on January 14th, 2013, 10:22 AM »
Try to reply to an post but no letters are shown in Reply-Box. This only occurs with Chrome. IE works, but looks a bit odd (Screenshot).

 wedgescreen.png - 93.47 kB, 987x987, viewed 211 times.

# dpkg-reconfigure brain
error: brain is not installed or configured

Auk

  • Can I get a Box?
  • Posts: 64
Re: Reply Error with Chrome
« Reply #1, on January 14th, 2013, 11:24 AM »
Which version of the I.E browser (I'm using I.E 10 and don't see the problem)? o_O
Posted: January 14th, 2013, 11:22 AM

And what version of chrome (Still see no problem)? Mines is Version 23.0.1271.97.

Post recently edited.

Nothing is more despicable than respect based on fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Reply Error with Chrome
« Reply #2, on January 14th, 2013, 11:27 AM »
Bloody WYSIWYG editor, it's broken again. The activated arrow icon is a big giveaway.

Methinks it might be time to consider adopting SCEditor like SMF 2.1 has.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Pandos

  • Living on the edge of Wedge
  • Posts: 635

Auk

  • Can I get a Box?
  • Posts: 64
Re: Reply Error with Chrome
« Reply #4, on January 14th, 2013, 11:36 AM »
My I.E 10 seems a bit updated compared to yours. 10.0.9200.16384.   Now I see the problems after enabling this feature in my profile for Look & Layout (Show WYSIWYG editor on post page by default.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Reply Error with Chrome
« Reply #5, on January 14th, 2013, 11:37 AM »
(You can also press the little arrow button to switch to WYSIWYG without changing your preferences.)

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Reply Error with Chrome
« Reply #6, on January 17th, 2013, 10:20 PM »
Quote from Arantor on January 14th, 2013, 11:27 AM
Bloody WYSIWYG editor, it's broken again. The activated arrow icon is a big giveaway.

Methinks it might be time to consider adopting SCEditor like SMF 2.1 has.
It was broken by a few of my recent changes, I'm afraid.

1/ the editor's iframe body needs a proper reset. There are too many items that are changed in either html or body tags in the container page... for now, I'll simply stick to fixing the skins one by one. :(

2/ the issue reported here was about the lack of a cursor, right...? This was due to Chrome being detected as both is_chrome and is_ff. I rewrote the is_ff detection code, it's now 6 gzipped bytes shorter (lulz!), and should work properly. Tested before and after the change -- it was indeed that.

Phew :) I'm not ready to retire this wysiwyg crap yet! :p

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Reply Error with Chrome
« Reply #7, on January 17th, 2013, 10:31 PM »
I'm not saying that it should be retired overnight, I'm just saying that we might want to consider it. It would also potentially allow us to ditch a lot of the complexity of Class-Editor's PHP code, but at the cost of a little more client weight (which, to be fair, should be cached most of the time)

SCEditor, in case it wasn't known, actually exports bbcode rather than natural HTML.
Quote
/ the issue reported here was about the lack of a cursor, right...? This was due to Chrome being detected as both is_chrome and is_ff. I rewrote the is_ff detection code, it's now 6 gzipped bytes shorter (lulz!), and should work properly. Tested before and after the change -- it was indeed that.
Nope... it wasn't actually displaying anything I'd typed either. And that's a different bug again to what was in the OP.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Reply Error with Chrome
« Reply #8, on January 18th, 2013, 08:18 AM »
Quote from Arantor on January 17th, 2013, 10:31 PM
I'm not saying that it should be retired overnight, I'm just saying that we might want to consider it. It would also potentially allow us to ditch a lot of the complexity of Class-Editor's PHP code, but at the cost of a little more client weight (which, to be fair, should be cached most of the time)
As well as being forced to keep up with their updates (if any), and possibly fix bugs ourselves and have to re-apply them on each update, etc...
Quote
SCEditor, in case it wasn't known, actually exports bbcode rather than natural HTML.
Which is the same as Wedge's..? No?
Quote
Nope... it wasn't actually displaying anything I'd typed either. And that's a different bug again to what was in the OP.
It didn't display anything of what I typed, either. It was a focus problem, so it's all related. And it's the same as what the OP says... (?)

All in all, I'd probably say SCEditor is sexier than other editors BECAUSE it's smaller than them, but then again, ours is twice smaller... So to me, it's 10 times sexier because I did the optimizations :P

Just give me three reasons to switch to SCEditor, really!
All of the bugs mentioned in this topic were due to my rewrites, and were things that would have easily broken otherwise, and things that only beta testers could find because we don't use Wysiwyg ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Reply Error with Chrome
« Reply #9, on January 18th, 2013, 05:42 PM »
No, ours receives HTML from the browser and converts it manually to bbc at post save time. SCEditor sends it as bbc to the server.

Need to dig in to actually find you reasons though :/

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Reply Error with Chrome
« Reply #10, on January 18th, 2013, 05:51 PM »
Hmm... So it means SCE has a built-in JavaScript convert tool for HTML to BBCode..? (Meaning it doesn't need to rely on Ajax for Wysiwyg switching... Although it also means it's less flexible!)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Reply Error with Chrome
« Reply #11, on January 18th, 2013, 05:52 PM »
I don't know all the mechanics but I can see all sorts of issues with doing it like that.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Reply Error with Chrome
« Reply #12, on January 18th, 2013, 06:14 PM »
Which is both a good reason to switch to SCE and an excellent reason not to :P
« Repository logs
Typo in Class-DBPackages.php »