This topic was marked solved by Arantor, on August 1st, 2013, 06:13 AM
« Board search
Theme selector broken + more...
SMorg »

Nightwish

  • Posts: 41
Theme selector broken + more...
« on July 30th, 2012, 11:24 AM »
First, is the Wuthering sub-skin supposed to look like in the screenshot? The dark grey does look a bit off :)

But, I would simply change to another theme *if* the theme selector in the side bar would let me... Tried to switch to another theme and ended up with an empty page under the url http://wedge.org/?http://wedge.org/theme=1 or something more weird like http://wedge.org/?http://wedge.org/theme=1_c2tpbnM=

The empty page is probably a result of some error not displayed - maybe it's just in the log.

Side note: switching themes in the profile does seem to work.

Every program has at least one bug and can be shortened by at least one instruction -- from which, by induction, one can deduce that every program can be reduced to a single instruction that doesn't work.
My SMF-based forum fork

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Theme selector broken + more...
« Reply #1, on July 31st, 2012, 02:00 AM »
Sounds like it still uses the old weUrl format.
Posted: July 31st, 2012, 01:56 AM

Maybe you caught Nao updating this site? It's definitely not supposed to look like that.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Theme selector broken + more...
« Reply #2, on July 31st, 2012, 02:13 AM »
Wuthering is very old now and is very likely broken compared to what it was originally.

It does sound like it's using the old weUrl code, more accurately not properly handling the changes related to ? being in the URL that Nao recently added, which would not surprise me.

* Arantor gave up worrying about keeping plugins compatible with Wedge's development because things change in backwards incompatible ways so often...
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Theme selector broken + more...
« Reply #3, on July 31st, 2012, 02:50 AM »
ok. I just tried it and it changed the skin to Wuthering just fine. I wonder if it differs by browser. Also,  I looked at changeTheme and I didn't see weUrl anywhere.
Posted: July 31st, 2012, 02:46 AM

Also, it does nothing in the stats page

The menu for Wine is red, isn't it supposed to match the color of the top bar?

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Theme selector broken + more...
« Reply #4, on July 31st, 2012, 08:35 AM »
So...

@Nightwish: the theme selector bug was added this week. It's because I changed the weUrl() format. I made sure that nothing in Wedge relied on the old format, but I forgot to double-check the existing plugins. Turned out that both MultiAttach and SkinSelector were indeed relying upon it, so MultiAttach was easily fixed but SkinSelector took a bit more time. I think it's not entirely fixed yet.

The Wuthering (and Wine, and Warm) bug is something I was aware of. I 'added' this bug last week when doing gradient work on the main background for Weaving, trying to get rid of the gradient PNG, but it didn't work as I expected, so I did a revert but forgot to revert the main gradient line. In the meantime I got a PC crash, lost my work-in-progress tracking, and forgot to work on that one... So, I just removed the gradient yesterday and now the header for Wine doesn't look great, but I was planning to rework it anyway, as I don't like the idea of it relying on a 'trick' just to show the 'right' color...

@Pete, I worry about plugins ;) I just don't worry TOO much about them... I know they're not 'out' yet, as Wedge isn't, but at least it gives me a pretty accurate idea of how I'll have to deal with existing plugins once Wedge is out and I decide to change this or that... It definitely means that Wedge needs to be as close as possible to completion before we release it. That way, we'll avoid this kind of awkward situation... (OTOH, I wouldn't have modified weUrl() that easily if we were out.)
Re: Theme selector broken + more...
« Reply #5, on September 17th, 2012, 06:46 PM »
Okay... I just realized that the theme selector is broken for guests.
This is most certainly due to the recent change where I'm passing it through action=skin and redirecting to the old page to save the need for additional JavaScript to store the URL.

I don't have much time to look into it, and since you wrote the original skin selector Pete, do you think you can look into it (or anyone else), and tell me where to fix that? I suppose it's very doable by using ?theme= instead of ?th= for guests (or vice versa), but I'd rather store that one in a cookie if possible, etc, rather than just have it in a fixed session...

(Oh, and for some reason I don't know about, I had Weaving when I started replying another post, and then I had Warm when I got the 'other people answered this in the meantime' warning!)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Theme selector broken + more...
« Reply #6, on September 17th, 2012, 06:56 PM »
I don't think I even tested it for guests... I can't remember anything about how it works really.

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Theme selector broken + more...
« Reply #7, on September 17th, 2012, 07:40 PM »
IIRC it worked for guests, which is why I installed it here because, more than a shortcut to the skin selector page, it was the only way for guests to change a skin because the skin selector is in the Profile area, which they don't have...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Theme selector broken + more...
« Reply #8, on September 17th, 2012, 07:56 PM »
Just because it worked for guests is no reflection of the fact that I didn't test it for them :P

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: Theme selector broken + more...
« Reply #9, on September 18th, 2012, 04:06 PM »
Fixed in the latest rev by, as I mentioned, simply reverting to the all method for guests ;)
It's no big deal really.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
« Board search
SMorg »