More sidebar complications...

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: More sidebar complications...
« Reply #75, on July 10th, 2013, 11:47 PM »
So... Anything left hanging?? Or is it commit-time for me, at last...?
Posted: July 10th, 2013, 11:46 PM

(I'll take it that the complete lack of comments following my iPad fix is the current equivalent of thinking "oh yes it works now" and clicking the "Like" button...? :^^;:)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: More sidebar complications...
« Reply #76, on July 11th, 2013, 12:06 AM »
Yes it all appears to be working properly. I'm sorry that we didn't manage to reply within a reasonable feedback timeframe[1] but yes it is working properly on both desktop and iPad as far as I can tell with the few minutes of testing I've given it.

Also, side bug discovered with infinite scroll on a not-so-huge window, see attached.
 1. We should add this as a rule, that all suggestions must have feedback within an hour and if no feedback is received, just proceed. Same with bug fixes, if no-one says it's got issues inside an hour, assume it's fixed.

 Screen Shot 2013-07-10 at 23.02.55.png - 324.01 kB, 1104x1089, viewed 162 times.

When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Re: More sidebar complications...
« Reply #77, on July 11th, 2013, 12:21 AM »
Working on iOS 6.whatever I said last time :P Good work. I am okay with the icon used on most responsive designs for menus. I like Weaving on iPad more than ever :) I almost wish there was a persistent bar with notifications, search, and the sidebar. Scrolling to the top for all those neat features is a pity. I am liking the direction thats for sure :)
Thank you,
Boko

MultiformeIngegno

  • Posts: 1,337
Re: More sidebar complications...
« Reply #78, on July 11th, 2013, 02:40 AM »
On iOS 6 if I'm at the bottom of a long page and press the button to open the sidebar, it's blank. I need to go to the top of the page to view the sidebar content. It should be set as position fixed I think.

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: More sidebar complications...
« Reply #79, on July 11th, 2013, 10:34 AM »
Quote from Arantor on July 11th, 2013, 12:06 AM
We should add this as a rule, that all suggestions must have feedback within an hour and if no feedback is received, just proceed. Same with bug fixes, if no-one says it's got issues inside an hour, assume it's fixed.
I'm assuming that you read all of the forum posts, because you're strong. I don't. Especially if the topic already has a lot of comments. I'll usually keep it for later... I guess @ mentions only solve part of the problem, but... I don't always check out my notifs either, at least until it's working 100%. Yeah, I'm not helping I know... :^^;:
Quote
Also, side bug discovered with infinite scroll on a not-so-huge window, see attached.
Ah, yes, this is because topic.js is using a relatively old version of the code, and I wasn't correctly removing the extra #forumposts layer. I've rewritten the code to work; I'm not using the newer version, because I know for a fact that *this one* is working, while I'm not 100% sure about the latest one, and I don't want to finish my work on topic.js before I'm done on script.js...
Re: More sidebar complications...
« Reply #80, on July 11th, 2013, 10:42 AM »
Quote from Godboko on July 11th, 2013, 12:21 AM
I almost wish there was a persistent bar with notifications, search, and the sidebar. Scrolling to the top for all those neat features is a pity. I am liking the direction thats for sure :)
There was, at one point, such a bar... Actually, I committed a (partial) change to skeleton.xml the other day, to submit a new extra layer, top_bar, which as its name indicates, holds all of the elements that could/would/should be in a persistent top bar. However, after some tests, I gave up on it, for two reasons:

- it's mostly useful on mobile devices, *and* mobile devices are the ones where saving space is a most important matter, so I couldn't make it too big, but if it was too small, it started losing its 'practicality'...

- this one is more technical, but having a persistent bar at the top, takes about 30 to 50px height, and there's no way to tell the browser that this space shouldn't be used, so it actually still keeps showing stuff behind this... For instance, doing "html { margin-top: 50px }" will only add 50px at the top, so... Whatever... And I don't think doing a position fixed would help either, ah ah... Anyway, because the browser still uses that extra space behind the top bar, when you click on a topic link for instance, you're taken to a specific post, right..? Well, this post anchor is shown right behind the top bar... In order to be able to see who wrote the post, you'd have to scroll up. So, I started implementing various ideas, such as using JS to fix that (it sucked), and then using pure CSS to do it -- there was a solution that worked very well, but... Only if the anchor was linked to an empty div or a tag. Or a simple one, but linking it to a <div style="display: table"> would break the table layout, which absolutely SUCKS, even more than the JS solution....

I spent about half a day on this one, and the persistent top-right menu button is the only leftover of this. This *is* the top bar... Yes, the only solution I found to 'fix' the anchor, was to simply not care about it, and show a button that doesn't hide anything. (As it is, in fact, it hides the "expand" button in the header, but I'm assuming it's not a big issue...)

So, if you can find a solution for this, you're welcome to suggest one...!
Re: More sidebar complications...
« Reply #81, on July 11th, 2013, 10:54 AM »
Quote from MultiformeIngegno on July 11th, 2013, 02:40 AM
On iOS 6 if I'm at the bottom of a long page and press the button to open the sidebar, it's blank. I need to go to the top of the page to view the sidebar content. It should be set as position fixed I think.
Nope, nope, nope...

position: fixed is all I did in the beginning, and for several days, until I gave up on it.
It was (position-) absolute hell.

- Earlier versions of iOS don't support it correctly at all. Not that I care, but...
- Mobile devices only implement it half-heartedly, meaning that if you scroll the main screen, you can clearly see the sidebar struggling to keep up, probably because mobile devices implement position: fixed with some kind of JavaScript hack, or at least they refresh the position with a low priority, lower than the main screen's scroll thread, if you know what I mean...
- Scrolling within a fixed-position sidebar with overflow-hidden, while possible (and very much necessary, given that it also holds the main menu), is excruciatingly slow and unresponsive on my Galaxy S3... I can't even begin to imagine how slow it might be on older devices.
- When you reach the end of the sidebar, the browser will then bubble up the scrolling request to the main screen, meaning you find yourself with a static fixed sidebar and a scrolling screen, even though you're attempting to scroll the sidebar itself... It's really unintuitive, and I wrote some code to prevent that, which worked perfectly in desktop browsers, but failed on my S3. I couldn't get it to work, and I tried hard. I actually committed that piece of code to the attic, at the end of the "Unused-swipe.js" file, if anyone wants to look into it, but I'd hold my horses, if I were you...

So, yeah, for all these reasons, I started looking into using position: absolute, and it simply worked better for me... Yes, of course, you end up with empty space if you're at the end of a topic, but I can't help it. I could do something more convoluted, believe me I've thought about it[1], all I could think of is to reset the top position of the sidebar to whatever is your current scrollTop position, it's a cop-out, but it might work. It also means that if you accidentally close the sidebar and re-open it, its scroll position will be reset, but... Whatever. Is this something that most people would be interested in, or not..?

Or am I just trying too hard..? I mean, I guess everyone but me was happy with having the sidebar at the bottom, uh..? I just couldn't take the pressure of properly positioning the elements horizontally, sometimes it just looked so fucking ugly, I wanted an alternative, but I didn't expect it'd take me so long, and for that, I'm not grateful to my own quest for perfection... :-/
 1. When opening the sidebar, calculate the current screen scrollTop position, determine whether the sidebar is shorter than that; if yes, absolutely position the sidebar to the bottom of the screen instead. It's counter-intuitive, and only works 'as intended' if the screen is not more than twice higher than the total sidebar height, otherwise you still end up with empty space when you're opening the sidebar while scrolling in the middle of the page...
Re: More sidebar complications...
« Reply #82, on July 12th, 2013, 12:06 AM »
Quote from Nao on July 11th, 2013, 10:54 AM
all I could think of is to reset the top position of the sidebar to whatever is your current scrollTop position, it's a cop-out, but it might work. It also means that if you accidentally close the sidebar and re-open it, its scroll position will be reset, but... Whatever. Is this something that most people would be interested in, or not..?
Started working on this..... And as expected, it's harder than I hoped.
It's working, though... And it seems 'usable' enough, but I'm having issues with the sidebar when the container page is shorter than it.
Then again, the exact same problem already exists in the current version (just click my user name in mobile mode, and open the sidebar... It'll systematically be shown on top of the footer...), so really, it's not that big a deal.


I'll probably end up reverting a couple of things in the implementation, e.g. the table-to-block override for the sidebar div, hopefully this will help keep the sidebar visible at all times, although people might start wondering why there's empty space in profile pages... (Said empty space being there to prevent the sidebar from overflowing when opened, of course.)
What's best, then..?

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Re: More sidebar complications...
« Reply #83, on July 12th, 2013, 01:12 AM »
I read no solutions at the moment, still thinking net being off all day killed productivity.

markham

  • Finally finished the Slideshow... phew!
  • Posts: 138
Re: More sidebar complications...
« Reply #84, on July 14th, 2013, 01:04 PM »Last edited on July 14th, 2013, 01:16 PM
On my Samsung Note 10.1 (Android 4.1.2) I get different results depending on which browser I use. With the 'standard' browser, the skin changes to Wireless and there's no button to control the sidebar's appearance. However, if I use Firefox (v22), the default skin is Weaving and I do have that button.

Rather oddly, when viewing this site (and only this site has this affect), the 'standard' browser is forced into landscape mode and will not switch to portrait. The Firefox browser works in either screen orientation as one would expect.

spoogs

  • Posts: 417
Re: More sidebar complications...
« Reply #85, on July 14th, 2013, 06:24 PM »
I'm currently seeing 4 menu buttons for the sidebar.
1 each before and after the the language flags
1 each before and after search field and button
Windows Phone8 IE10
Stick a fork in it SMF

icari

  • Posts: 88
Re: More sidebar complications...
« Reply #86, on July 14th, 2013, 07:33 PM »
am i correct that the sidebar is an option for anyone with a page width of less then 985px? give or take?

there are some users that have a widescreen desktop and dont have the browser full screen, on my current setup my opera window is about 973px wide... i get the option for the sidebar but when i click on it nothing shows up but a blank space on the left side

i am not resizing the window either. also without having a middle click i find this menu will be used very little as it would require scrolling all the way back up to the top of the page each and every time i would want to see the menu.

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: More sidebar complications...
« Reply #87, on July 15th, 2013, 12:47 AM »
@spoogs, I'm not sure how I missed that, eh eh... It was a precedence problem, fixed in the latest commit.

@icari> the trigger is 1000px width, not including the scrollbar. Generally, a maximized window in 1024x768 won't trigger it, but if it does, it's not really a problem, considering a ~700px window (sidebar not included) is too narrow to really enjoy a forum, I think.

Anyway, any bugs in Wedge.org should be accompanied with: OS used, browser used (+ version if relevant), and skin used.
Ideally, if you could debug visual issues by yourself, and indicate what went wrong for you, it'd be obviously even better, because I can't access some of the platform combinations...

spoogs

  • Posts: 417
Re: More sidebar complications...
« Reply #88, on July 15th, 2013, 01:48 AM »
@Nao yep only seeing one now and seems to be working. I see only the one before the search field, is that accurate?

icari

  • Posts: 88
Re: More sidebar complications...
« Reply #89, on July 15th, 2013, 02:16 AM »
windows 7 opera 12.16

with dragonfly up

but there is no scroll bar on the bottom of the window to show the menu, also anytime i right or left click when the menu is up it closes the menu, so if i want to right click and copy for example it causes issues. [or even use dragonfly]