Miscellaneous/WIP screenshots

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Miscellaneous/WIP screenshots
« Reply #75, on May 10th, 2013, 12:24 AM »
Quote from Arantor on May 9th, 2013, 09:36 PM
It all works but I just feel odd about its code :/

Anyway, @Nao or anyone else, any thoughts about presentation?
I like it. I like the idea, and I like that it's windowbg stuff, even though it's not in line with the rest of the visuals.
I'd recommend using text links instead of buttons, though -- this would make the box a bit less intrusive, mesays.

Will probably have a play with the source code...
May I ask why you took to add your functions through prototypes, rather than including them Inside the main object, like the rest...? A leftover from the SMF way of doing things? ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #76, on May 10th, 2013, 12:29 AM »
Because I had to do something with it. The original suggest objects were contained inside the wePersonalMessageSend function as properties and thus not accessible outside of that object.

I dunno, it just felt slightly more natural to do it the same way as other stuff does it. *shrug*
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Miscellaneous/WIP screenshots
« Reply #77, on May 10th, 2013, 12:42 AM »
In SMF, all objects had prototypes, even if not used outside of the object. I turned most of them into self-contained this.function déclarations, for these reasons:
- it looks a bit better...
- it compresses better, sometimes much better
- these functions can access their parent's local variables, so no need for this.opt for instance... (dunno why it's still in this one.)

The only drawback is that it's supposed to consume more memory, but there's no point in worrying about that when you only create a couple of these objects per page... ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #78, on May 10th, 2013, 12:45 AM »
I spent an hour futzing with it and farting with variable scope. JS is a tool I can use but it doesn't mean I like it...

Nao

  • Dadman with a boy
  • Posts: 16,079

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #80, on May 10th, 2013, 12:53 AM »
Quote from Arantor on May 9th, 2013, 11:13 PM
+ Contact list is now shown in the PM area, allowing you to send a PM to/bcc your contacts. As I intimated I'm not overly happy with the JS I've done here, it feels fragile and ugly and yet more organised than before. Feel free to rewrite/refactor/ignite. (PersonalMessage.template.php, PersonalMessage.template.php, pm.js, index.member.css, PersonalMessage language file)
Go nuts ;)

Nao

  • Dadman with a boy
  • Posts: 16,079

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Thank you,
Boko

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #83, on May 10th, 2013, 03:39 AM »
I've always wanted more options for the editor. I like users not having to write mods for something I can reasonably trivially support in the core. This has made the editor code slightly bigger, haven't benchmarked it in terms of size.

I'm planning to offer up the whole editor thing itself being organisable, but just this for now.

 post_editor_settings.png - 28.35 kB, 948x494, viewed 168 times.

Re: Miscellaneous/WIP screenshots
« Reply #84, on May 10th, 2013, 03:51 AM »
@Nao, it's likely you'll want to tweak the code. I'm not very happy with what I have but it was the only way I could see of getting it from the bbcbox initialisation up through to the bbcbox object and then to the editor object. (This will become clear when I commit it, but if no-one's that bothered I might just skip that bit)

spoogs

  • Posts: 417
Stick a fork in it SMF

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #86, on May 16th, 2013, 06:28 AM »
It's been a few days since I posted in here with something I'm 'definitely' doing rather than asking input on. (Though this is also a WIP)

So, the plan is to offer a list of who can see and edit a given field rather than the current options. I have a few things to work out in the design but it's getting there ;)

 profile_fields_privacy.png - 45.06 kB, 931x1013, viewed 148 times.

Re: Miscellaneous/WIP screenshots
« Reply #87, on May 21st, 2013, 08:36 PM »
So, finally getting round to a few things.

In particular, I'm getting shot of the language 'settings' page (since it only has two settings, one of which was already duplicated)

So, the main language page as shown now lets you select the default, as well as whether users get to play with choosing their own language and on top of that it also sorts out what language choices users can have.

Installing a language pack then becomes the job of dropping files into the languages folder then visiting this page to enable it, and this page to deselect a language pack. (In theory we could just bundle all the translations in a release and just let users enable the ones they want)

 language_selector.png - 27.69 kB, 937x408, viewed 118 times.


Farjo

  • "a valuable asset to the community"
  • Posts: 492
Re: Miscellaneous/WIP screenshots
« Reply #88, on May 22nd, 2013, 03:42 AM »
Looks good and very simple to use :cool:

Is the "Enable user-selectable language support" option and the "Available" column mutually exclusive?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Miscellaneous/WIP screenshots
« Reply #89, on May 22nd, 2013, 03:45 AM »
In a real sense, yes, they would be but right now the UI doesn't prevent it - though, if the 'user selectable support' option is unticked, the available list is enforced to be the default language (so that one is enforced to be set)