This is more of a FYI and note in case it spawns bugs (it might introduce issues from the converter, I guess, as well as any place I didn't already catch)
I originally planned to overhaul is_activated in a different way, a long time ago, but I realised that it's sort of unnecessary (and not as performant as I'd hoped), so here's the plan for what is_activated means going forward. (There are so many fringe cases in SMF/Wedge around this >_<)
0 - user has registered, waiting for email activation
1 - user has registered and is active
2 - user has previously registered and is active but has changed their email address
3 - awaiting admin approval
4 - user is pending deletion
5 - awaiting COPPA approval
10 -> 19 - as 0 - 9 but with 'discourage' (i.e. Annoy User)
20 -> 29 - as 0 - 9 but banned on top
In other words, all I've done is move what was previously 10+ being banned to being 20+, with 10-19 being the new annoy facility. I also believe this is the only complete list of what all the states in SMF do for is_activated, I don't believe anyone previously actually figured it out (not even me, my original topic mentioning the changes I had originally planned didn't note states 2, 3 or 5, and until today I wasn't actually sure what state 2 did)
It is also possible additional statuses will be added, I'm likely going to add status 6 to mean 'user has to re-agree to the user agreement' but not just yet ;)
I originally planned to overhaul is_activated in a different way, a long time ago, but I realised that it's sort of unnecessary (and not as performant as I'd hoped), so here's the plan for what is_activated means going forward. (There are so many fringe cases in SMF/Wedge around this >_<)
0 - user has registered, waiting for email activation
1 - user has registered and is active
2 - user has previously registered and is active but has changed their email address
3 - awaiting admin approval
4 - user is pending deletion
5 - awaiting COPPA approval
10 -> 19 - as 0 - 9 but with 'discourage' (i.e. Annoy User)
20 -> 29 - as 0 - 9 but banned on top
In other words, all I've done is move what was previously 10+ being banned to being 20+, with 10-19 being the new annoy facility. I also believe this is the only complete list of what all the states in SMF do for is_activated, I don't believe anyone previously actually figured it out (not even me, my original topic mentioning the changes I had originally planned didn't note states 2, 3 or 5, and until today I wasn't actually sure what state 2 did)
It is also possible additional statuses will be added, I'm likely going to add status 6 to mean 'user has to re-agree to the user agreement' but not just yet ;)