Converting media to use the same internals as other admin pages

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Converting media to use the same internals as other admin pages
« on November 28th, 2012, 02:07 AM »
This is more a braindump than anything else.

I can fully understand keeping the admin settings entirely separate when it was still an SMF mod - because it's a big and complex mod with dozens and dozens of settings - but now it's in Wedge, not only should it adhere to the same UI as everywhere else (or everywhere get adjusted to how Aeva did it, I'm amenable either way as long as it's consistent), it should reuse as much of the same logic as possible.

Unfortunately, given this, we're almost closer to being a rewrite of the admin logic rather than being a simple set of changes - since the original logic is set up to serve the three different pages from a single function. (I'm only talking about Admin > Media > Settings and its subitems at this point, nothing else yet)

What I'm also thinking of doing is pulling the EXIF data out of being its own page and making it a single item with collapsible selector, much like Admin > Members > Registration and Login > Settings > Notify administrators when a new member joins is - we get to save a page and admins only touch it if they need to. And we then only have a single settings entry that contains everything rather than a separate entry per item - and we can do away with the 'display meta data' item, because if the list of metadata items is empty, they didn't want to show anything.

The other thing about converting it to use the standardised methods is that it can be adapted easily to be searchable as well.

I guess the only real question starts turning into how much work it is to remove wedge_media_settings and fold it into the core settings without breaking anything, whether that's feasible/practical/desirable or not. From an admin point of view, I'd say it would tend to be better if it were done that way.

I haven't ruled out any other changes yet, e.g. breaking up the current Configuration page into several smaller pages, e.g. General Configuration, Files and Folders (for the paths, file types and stuff), Previews.

I'm also not entirely sure about the list of file types. It just seems to me that we could possibly do it better than that, perhaps providing a list of default file types we know about and letting users select/deselect. See attachment.

 ipb_attach_types.png - 56.13 kB, 767x896, viewed 92 times.

When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,063
Re: Converting media to use the same internals as other admin pages
« Reply #1, on November 28th, 2012, 11:40 AM »
Quote from Arantor on November 28th, 2012, 02:07 AM
This is more a braindump than anything else.

I can fully understand keeping the admin settings entirely separate when it was still an SMF mod - because it's a big and complex mod with dozens and dozens of settings - but now it's in Wedge, not only should it adhere to the same UI as everywhere else (or everywhere get adjusted to how Aeva did it, I'm amenable either way as long as it's consistent), it should reuse as much of the same logic as possible.
I agree...
Originally I wanted to rewrite the admin panel to be more like Aeva, but it was too much work, and... Let's just said I called it quits and got used to the regular SMF style.
We did some stuff in the beginning to help AeMe feel at home, like splitting the Aeva embedding section into its own sub-section and place it outside of the media menu... But then we skipped to other things.
Quote
What I'm also thinking of doing is pulling the EXIF data out of being its own page and making it a single item with collapsible selector, much like Admin > Members > Registration and Login > Settings > Notify administrators when a new member joins is - we get to save a page and admins only touch it if they need to. And we then only have a single settings entry that contains everything rather than a separate entry per item - and we can do away with the 'display meta data' item, because if the list of metadata items is empty, they didn't want to show anything.
99% of the time it's not going to be empty, as a picture generally has a 'shot date' and a 'file date' in it, and they generally differ. Music files always have a duration. Video files too. I think these are in the meta data stuff but I'm not 100% sure of it.

But I get your point. ;)
Quote
I guess the only real question starts turning into how much work it is to remove wedge_media_settings and fold it into the core settings without breaking anything, whether that's feasible/practical/desirable or not. From an admin point of view, I'd say it would tend to be better if it were done that way.
It's feasable, it's just as easy as converting these in $settings['media_xxx'] items. It's one of the (very old) items in my to-do-list, but because it implied adding stuff to the convert script (and thus adding more work for TE to do, and I don't like asking others to do stuff for me :P), I figured at one point that I'd just leave it that way...
Quote
I haven't ruled out any other changes yet, e.g. breaking up the current Configuration page into several smaller pages, e.g. General Configuration, Files and Folders (for the paths, file types and stuff), Previews.
It's such a mess...
Heck, even me, who co-wrote it... I'm confused by things here and there. Why isn't there a 'Delete' button anywhere but in the admin panel for media albums, for instance...?
Quote
I'm also not entirely sure about the list of file types. It just seems to me that we could possibly do it better than that, perhaps providing a list of default file types we know about and letting users select/deselect. See attachment.
Dunno about that... :-/