Decided to create all mini-menus at page load rather than on the fly. Saved over 30 gzipped bytes. Yay. Until I realized it added a whole second of load time to IE6... On my super-modern PC running XP in a box. Must be pretty close to regular numbers, especially since even Opera in my Win7 takes 0.15s to run it.
Back to square one...
Anyway, I've saved about 10 gzipped bytes by keeping to the on-the-fly creation thingy, which is better than nothing...
OTOH, I've added an extra 10 bytes to script.js just to filter correctly the click event on main menus.
Remember how someone complained that clicking the top-level item in the profile menu would close the menu and clicking it again would do nothing...? Well, the goal wasn't to close the menu, but to close any menu after a click was made, to give a feeling of responsiveness, i.e. "I've registered your call, I'm processing it." However, in the profile menu, there's no link in the top-level item, so it just closes it and does nothing... I had two solution: either I added a filter (for an extra ~10b) or removed the entire click event (to save a whopping ~20 bytes). In the end, I decided to use the filter (
.filter(':has(>a,>h4>a)')), because I really like the responsiveness thing... But it also wastes 30 bytes in total, eh.
So, my solution to this...
Well, it's pretty elegant if you will... Although it's totally unrelated
:lol:I 'simply' moved we_avatarResize() to a new file. This function is ~150 bytes gzipped, and it's not used by default (one has to enable a feature in the admin area, "resize with JavaScript" or something.)
That's it... New script file is now 120 bytes smaller, ahah, I love my cache system.
Totally OT now...
A quick poll... I'm thinking of doing a small rewrite to $context['javascript_files']. Instead of adding strings to the array ( [] = 'script.js' ), you would add an indexed array ( ['script.js'] = true ), where 'true' means 'add the filename to the final filename' while false would ignore it.
While it isn't useful right now, I can imagine that some modders would like to be able to add their files to the main script, *and* not have them pollute the final filename. Right now, it's not possible to do it because the list of ignored filenames (custom, sbox, theme, and now avasize) is hardcoded into our source files...
Since it makes the javascript_files array a bit harder to understand than just using a simple list of files, I'd rather ask because there's always a fine line between customizability (English??) and complexity.
Posted: May 18th, 2012, 11:38 AM
A quick poll... I'm thinking of doing a small rewrite to $context['javascript_files']. Instead of adding strings to the array ( [] = 'script.js' ), you would add an indexed array ( ['script.js'] = true ), where 'true' means 'add the filename to the final filename' while false would ignore it.
Implemented. I can always revert, but I'm pretty happy with it.
:)Except for the fact that the $ignore_files flag now acts differently in both add_js_file and add_css_file... Meh!
Where do you like your action buttons best?
