(Still working a lot on Wedge, it's just that I'm so overwhelmed by the amount of changes to commit, that I'm postponing my next commit every time...)
I'm not sure, there is such a thing as having too much stuff.
Alright...
I'm still not 100% sure about whether or not I'll keep the note classes with likes number etc... But at least it's a solution that would be perfect on mobile. (Perhaps I should just show the 'You like this' text next to it, and then hide it entirely on a media query test.)
Try it :)
I'm not sold on either solution, actually...
:-/I uploaded it, saw it was corrupt, removed it, reuploaded it and still corrupt (the same way). Very weird. But I didn't find any of the normal PNG block indicators, I couldn't find the IHDR sector end when downloading the file again...
Did you look into this bug in the meantime...?
Back on topic -- I rewrote the minimenu CSS/JS code to fix a detail that bothered me at low-res (iPhone etc) -- if a minimenu overlaps another minimenu's parent entry (like the Actions button overlapping the following post's author name), the parent entry has priority z-index so it shows up on top of the menu. This is because of a complex implementation to ensure the parent entry wouldn't be 'hidden' by the menu showing up behind it.
I tried to fix it by doing a reverse walkthrough of all umme/acme tags, like this:
(function () {
var zindex = 1;
$.fn.reverse = [].reverse;
$('.acme, .umme').reverse().each(function () { $(this).css('z-index', zindex++); });
})();(Isn't this some cool JavaScript?
:P)
I would then create the minimenus dynamically to use the parent item's z-index minus 1. Worked perfectly, but I noticed it didn't look great on my iPod -- most notably the menus tended to disappear and then reappear as they were animated. Possibly due to the great amount of processing power this requires... (Yay for mobile devices.)
So I threw away that solution, and instead decided to .clone() the parent into the minimenu and position it on top of the parent. Fixing all z-index issues immediately, meaning I didn't have to specify them any longer (which makes it easier to style stuff, too.)
And again -- it works nicely. Well, it didn't at first, but then I got rid of the padding animation implied by .show() (by replacing it with a longer .animate() call, but thanks to gzipping it's actually much shorter than the original code). Except for my iPod, again.....!!!
Now, the animations work correctly, but I can't seem to get the font sizes right. I can fix it by setting paddings and sizes manually in the index.iphone.css file, but it also means that some other devices are bound to show issues with this...
So, two possible fixes:
- Finding a 'correct' way to clone the parent entry perfectly. (This would *probably* imply setting the minimenu to be a child of the parent, rather than a child of the body. I'll try this next but it's like that it's going to create other issues.)
- Getting rid of the current minimenu style. Instead, implement them to look just like the 'normal' menus, i.e. an arrow below the item, and nothing surrounding it. Basically, doing what John did in the first place when he suggested re-using our menu style but I wanted to look into more animation styles.
I need opinions.