Wedge

Nao · « Reply #**165**, on October 3rd, 2011, 02:52 PM »

Quote from Arantor on October 3rd, 2011, 10:52 AM

Jogging is harsh :/

I can breathe and everything, even though I'm a smoker, but the first things to fail me in my body are always the collateral ligaments in my left knee (followed by the right knee a few minutes later.)
I've always had weak knees but my girlfriend won't listen to me... She insisted we run for an hour, even when it was the first time we'd been jogging in years. Yeah sure...

Anyway-- that's life. I'm pretty messed up today. My health has been worsening ever since I started work on Wedge. Wondering how I'm going to cope after we go live...

Quote

Anything in particular you'd like me to look over in r1049 since you flagged it as wanting feedback?

It was mainly about the new icons in the moderation strip. I took classic SMF icons and made them smaller, but I hesitate between keeping them this way, or making them grayscale. Also, would possibly be better to use another icon set... Maybe the very small ones. Diagona or another.

Arantor · « Reply #**166**, on October 3rd, 2011, 03:01 PM »

Take care of yourself! I doubt I could manage an hour's jog. Even after two months on Wii Fit... which I've let lapse because even after 2 months I hadn't shifted much in the way of weight. :(

Quote

Anyway-- that's life. I'm pretty messed up today. My health has been worsening ever since I started work on Wedge. Wondering how I'm going to cope after we go live...

Going live isn't going to be a problem, given my typical 100+ posts per day support schedule... especially given that towards the end of my regular time at sm.org I was consistently doing 5k posts a month.

I'm hoping, though, to limit the number of support posts that we get by setting intelligent defaults (like making quick reply on by default) and the admin UI just being easier to cope with.

Meanwhile, I'm just reinstalling it cleanly to be able to judge what it looks like - but I'm getting the impression that using Diagona icons might be an idea.

Posted: October 3rd, 2011, 02:59 PM

Having now actually seen it, I'm inclined to agree with using smaller icons. They just seem a shade too big for the relative size of buttons. Going greyscale won't really help, IMO.

Nao · « Reply #**167**, on October 3rd, 2011, 07:20 PM »

Btw I've fixed the skeleton stuff. Took me a day because of a STUPID mistake (I'd removed a & where I shouldn't have.)
RemoveLayer was broken too btw.

PantsManUK · « Reply #**168**, on October 4th, 2011, 10:25 AM »

Quote from Nao on October 3rd, 2011, 02:52 PM

can breathe and everything, even though I'm a smoker, but the first things to fail me in my body are always the collateral ligaments in my left knee (followed by the right knee a few minutes later.)
I've always had weak knees but my girlfriend won't listen to me... She insisted we run for an hour, even when it was the first time we'd been jogging in years. Yeah sure...

Wildly OT, but have you considered having an ibuprofen or aspirin tablet (with food or milk) an hour *before* you go out jogging? It'll help with pain during and recovery after... Former Olympian told me that one. Oh, and make her make you run less until you're comfortable running for half an hour (you fool).

(That is all, further correspondence on the subject can be conducted via PM)

Nao · « Reply #**169**, on October 4th, 2011, 10:28 AM »

Have no idea what I'll do next about this... I guess I'll just refuse to jog at all until I find a solution for my knees. As I said, I could only run for 5 minutes before I was pretty much unable to *walk* at all. Then I simply looked ridiculous for the remaining 55 minutes :P

Arantor · « Reply #**170**, on October 4th, 2011, 10:32 AM »

Get bionic knees!!

Cassiel · « Reply #**171**, on October 4th, 2011, 05:25 PM »

Maybe you'll find it easier to bike instead of jog?

Nao · « Reply #**172**, on October 4th, 2011, 07:01 PM »

A few bugs to take care of in the recycle bin... (I'm still of the opinion that this thing should go anyway :P)

- If you're trying to restore posts, you get the "empty skeleton" error message.

- Even worse -- if you're trying to restore posts *when there are no other boards available* (or possibly even if there are other boards, just not the original post board), the messages just disappear!
Well, they're not deleted, but they're given their original board ID back, and since there's no board at that address, the posts just become invisible. Nasty bug!

(This happened after I clicked 'Delete board' to see if there was some kind of confirmation request... Well, there isn't. Something else to fix!)

Arantor · « Reply #**173**, on October 4th, 2011, 07:03 PM »

Yeah, it should go - subject to a good (better) replacement being added.

Nao · « Reply #**174**, on October 4th, 2011, 07:29 PM »

In the meantime, could you look into these bugs? IRL time... >_<
I'm curious about the skeleton error... It shouldn't be happening. I'm sure it can be spotted just by looking at the source code.

Another error: go to the admin area, Maintenance, click on Repair. You're redirected to the main page without a confirmation or whatever... (The task still runs though, AFAIK. Although it didn't reassociate my restored posts with my newly re-created board #1... I guess it's the kind of error that doesn't happen to EVERYONE, meh...)

Arantor · « Reply #**175**, on October 4th, 2011, 07:39 PM »

I'm away from keyboard for a few hours (on iPad) but I will when I get back upstairs.

Nao · « Reply #**176**, on October 4th, 2011, 10:30 PM »

RepairBoards error is due to something you implemented in Admin.php, I'm not exactly sure what it does but it seems to be security-related. Please find a solution...?

Code: [Select]

	// The admin front page is not part of the above. But if you can see any of the items in the admin panel, you can see the front page too.
	elseif (empty($_GET['area']) || $_GET['area'] != $menu_context['current_area'])

The problem is that area=repairboards but current_area=maintain, as per the 'select' => 'maintain' entry in the menu array. You already added a workaround for AdminSearch (which had 'select' => 'index'), but not for RepairBoards...

Arantor · « Reply #**177**, on October 4th, 2011, 10:33 PM »

Not security related, but logic related; the point is that the front page should exist and be a valid fallback for requested pages (i.e. ones that don't exist/aren't accessible), while the index shouldn't exist as far as the menu is concerned.

Seems to suggest the repair boards logic is broken in some other interesting way. I'll take a look later on.

Nao · « Reply #**178**, on October 4th, 2011, 11:11 PM »

I don't think the logic is broken... It just needs special treatment at the top level, just like you gave to AdminSearch. Although at this point I think it'd make more sense to do generic handling of all 'select'-type entries.

Also, I *think* there's supposed to be a confirmation request for deleting boards.... I only get one for deleting categories. Can you...confirm? Anyone?

Re: restore posts, I couldn't find the origin of the skeleton error. Argh. If you could look into it as well... I have no time to actually go and try to restore posts for now.

Re: board ID bug, I don't really know how Wedge should react to this... Or do we just drop this and use unapproved posts instead?

Loosely related: when deleting a post, Wedge should update its 'children' posts to use the deleted post's parent ID. Should be easy enough, but we then have to update their own children, too... I'm not sure how to do this with minimal impact on the DB performance.
And-- I guess 'parent' shouldn't be touched when removing through the recycle bin... Or maybe yes. What's certain is that it shouldn't be deleted when a post is 'unapproved'.

Sorry, lots of questions and not many answers from me today... Girlfriend is calling. Don't want to get into trouble :P

Arantor · « Reply #**179**, on October 4th, 2011, 11:27 PM »

Quote

I don't think the logic is broken... It just needs special treatment at the top level, just like you gave to AdminSearch. Although at this point I think it'd make more sense to do generic handling of all 'select'-type entries.

Why does it need special treatment? Doesn't it call a function and issue a normal template?

Quote

Also, I *think* there's supposed to be a confirmation request for deleting boards.... I only get one for deleting categories. Can you...confirm? Anyone?

Fairly sure there's supposed to be... there's a JS error in suggest.js (which is called for the board moderator selector) which causes the rest of the page JS to get upset, which prevents the confirm() being called.

Quote

Re: restore posts, I couldn't find the origin of the skeleton error. Argh. If you could look into it as well... I have no time to actually go and try to restore posts for now

I'll look into it right now I'm back on the PC.

Quote

Loosely related: when deleting a post, Wedge should update its 'children' posts to use the deleted post's parent ID. Should be easy enough, but we then have to update their own children, too... I'm not sure how to do this with minimal impact on the DB performance.

It's tricky - and that's before you get into the realms of split/merging. However, if you have any given tree of x->y->z, and it's y you're deleting, you only have to update all the cases for z where the parent is y. It's a single-direction graph, we're only recording the parent, not the children, nor the latter descendants, so if post y is deleted, UPDATE wedge_messages SET id_parent = x WHERE id_parent = y, and that'll match all the z cases because we're only recording the immediate parent...

Quote

And-- I guess 'parent' shouldn't be touched when removing through the recycle bin... Or maybe yes. What's certain is that it shouldn't be deleted when a post is 'unapproved'.

This is *really* where it gets fun. What might be better is if the actual hierarchy remains untouched in a physical sense but a simple "This post has been removed" placeholder is shown to the user. That would not only solve the whole issue of how to handle it (because you don't move it, you leave it totally in place) and prevent logical disjoint where the post is removed and the flow of conversation seems broken: it's still going to be broken if part of the conversation is missing, but at least you have context for it.

Wedge

Home

Login

Register

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments

Nao

Re: New revs - Public comments

PantsManUK

Re: New revs - Public comments

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments

Cassiel

Re: New revs - Public comments

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments

Nao

Re: New revs - Public comments

Arantor

Re: New revs - Public comments