New revs

Nao

  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #2415, on January 27th, 2014, 10:41 PM »
[Commit revision 2d894d6]
Author: Nao
Date: Mon, 27 Jan 2014 22:41:07 +0100
Stats: 2 files changed; +229 (insertions), -3 (deletions)

  • Forgot to add the OriginalFiles.php file... A classic. (OriginalFiles.php)
  • Forgot to update the README with the simpler install instructions. (README.md)
  • Forgot my head somewhere. (MyBody.xml)
Re: New revs
« Reply #2416, on January 27th, 2014, 11:16 PM »
[Commit revision d1adbac]
Author: Nao
Date: Mon, 27 Jan 2014 22:48:39 +0100
Stats: 1 files changed; +5 (insertions), -1 (deletion)

  • Importer information was outdated. (README.md)
Re: New revs
« Reply #2417, on January 27th, 2014, 11:52 PM »
[Commit revision 7eccc60]
Author: Nao
Date: Mon, 27 Jan 2014 23:50:24 +0100
Stats: 1 files changed; +3 (insertions), -2 (deletions)

  • Attempting to make life easier for new installers having problems, at least for the duration of my sleep time. Nao needs his sleep, otherwise he gets grumpy and inefficient. (README.md)
Re: New revs
« Reply #2418, on January 28th, 2014, 05:31 PM »
[Commit revision 176edca]
Author: Nao
Date: Tue, 28 Jan 2014 13:14:11 +0100
Stats: 2 files changed; +3 (insertions), -5 (deletions)

  • Incorrect smiley upload path. (ManageSmileys.php)
  • Unneeded globals. (ManageSmileys.php, OriginalFiles.php)

[Commit revision 915a2c4]
Author: Nao
Date: Tue, 28 Jan 2014 13:15:09 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

  • One of the captchas was still using the older font. (captcha-recomposeanim_shadow.php)
Re: New revs
« Reply #2419, on January 29th, 2014, 10:52 AM »
[Commit revision 7afbc8d]
Author: Nao
Date: Tue, 28 Jan 2014 19:38:30 +0100
Stats: 1 files changed; +1 (insertion), -2 (deletions)

  • Improved accessibility for stand-alone search page. Yes, I know, inline styles... But it's better than wasting bytes in the generic CSS files. (Search.template.php)

[Commit revision 2577996]
Author: Nao
Date: Tue, 28 Jan 2014 19:41:51 +0100
Stats: 2 files changed; +34 (insertions), -8 (deletions)

  • Implemented wedge_ranged_implode/explode functions, which do implode/explode but transform number ranges into actual, err... Ranges. Making the resulting string shorter. Which is good for limiting the query string size when you have hundreds of boards. I like it so much, I might move it to Subs.php at some point. (Search.php, Search2.php)
  • Fixed a remaining 'e' modifier in a preg_replace call. Wondering if there are any more left... (Search2.php)

[Commit revision a832463]
Author: Nao
Date: Tue, 28 Jan 2014 22:44:13 +0100
Stats: 1 files changed; +2 (insertions), -1 (deletion)

  • Disabling follow_me on Opera Presto; hadn't tried it in a long time, and it totally doesn't like my fallback. (topic.js)
  • Also fixed a wrong test in the same line, which sort of made it possible for IE6 to once again show it sucks at everything. Ahem. (topic.js)

[Commit revision 88783ce]
Author: Nao
Date: Tue, 28 Jan 2014 22:48:53 +0100
Stats: 3 files changed; +14 (insertions), -8 (deletions)

  • That Google CDN blunder reminded me that without jQuery, Wedge will have trouble performing properly, especially in the admin area where you get to choose the jQuery script origin. So, to my great dismay, I'm now adding a fallback loader on all pages. (Subs-Cache.php)
  • I'm keeping the fallback code clean (and thus, whitespace), but I shortened the usual window.jQuery test, as well as the final filename for the fallback script. This adds a bit less than 40 bytes per page after compression, and yes, I guess I'm okay with that. Please don't remind it to me for some time, though.
  • Compensating byte by byte, saving about 4 gzipped bytes in HTML headers by refraining from outputting a title for Atom feeds. The website name is enough, and chances are your feed reader doesn't even care. Plus, if you use the feed links in the sidebar, you don't get titles anyway. (index.template.php)
  • Saving 7 bytes and 2 lines of code. In a PHP file. And I'm okay thank youuuuuglllbzblzglz. (Search.php)

[Commit revision e168928]
Author: Nao
Date: Tue, 28 Jan 2014 23:04:24 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

  • Turned the 'me' bbcode into a div. This takes less space than a span (obviously), and I'd rather not have to style it in the CSS files. Really, it's tailored for block styling, not inline styling. (install.sql)

[Commit revision 4aab401]
Author: Nao
Date: Tue, 28 Jan 2014 23:05:28 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

  • Minor documentation fix for the install process. (Install.english.php)
Re: New revs
« Reply #2420, on January 29th, 2014, 12:57 PM »
[Commit revision e974a13]
Author: Nao
Date: Wed, 29 Jan 2014 12:41:06 +0100
Stats: 1 files changed; +1 (insertion), -1 (deletion)

  • Mini-menus were broken on pages with guest posts on them. Well, first time I'm seeing that... But it's true we don't have a lot of guests on wedge.org..? (script.js)
Re: New revs
« Reply #2421, on January 29th, 2014, 07:55 PM »
[Commit revision 5d04d52]
Author: Nao
Date: Wed, 29 Jan 2014 19:54:58 +0100
Stats: 1 file changed; +5 (insertions), -5 (deletions)

  • Fixed installer always trying to create generic folders, even when existing. (OriginalFiles.php)
Re: New revs
« Reply #2422, on January 29th, 2014, 10:06 PM »
[Commit revision 62e7344]
Author: Nao
Date: Wed, 29 Jan 2014 21:32:03 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Fixed follow_me() not working properly if (1) using a browser without experimental features enabled, (2) loading a long topic in a new tab and then switching to the tab after it finished loading. Tested on the New Revs topic, could reproduce the bug and its fix every single time. (topic.js)

[Commit revision b9eeca8]
Author: Nao
Date: Wed, 29 Jan 2014 21:35:41 +0100
Stats: 1 file changed; +6 (insertions), -10 (deletions)

  • Forgot to commit part of the jQuery mini-filename patch. Living on the edge... Exciting, innit? (Load.php)

[Commit revision 9f60293]
Author: Nao
Date: Wed, 29 Jan 2014 21:36:45 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • $settings['minify_html'] (a not-so-hidden feature without a proper UI) has changed a lot since its original badass (but very slow) incarnation. Meaning it no longer modifies comments. And as such, an old 'fix' for the old version would now actually break JavaScript on pages. Not so badass now. (Subs-Template.php)
Re: New revs
« Reply #2423, on January 30th, 2014, 06:43 PM »
[Commit revision 770f36d]
Author: Nao
Date: Thu, 30 Jan 2014 18:39:42 +0100
Stats: 3 files changed; +76 (insertions), -75 (deletions)

  • The notification JavaScript code is a bit of a mess. Thanks to a certain person's final commit :P, it was made to look even more complicated. I rewrote the code to unify generic notification popups and PM popups, making it (hopefully) a bit easier to understand. Plugin authors still can't reuse the code easily (mostly because var names are compressed), but should there be some interest, I'll spend some time on that. (Notifications.template.php, PersonalMessage.template.php, script.js)

[Commit revision 87bbcd4]
Author: Nao
Date: Thu, 30 Jan 2014 18:43:03 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)

  • Helping with the installer: ensuring that PHP <5.3 doesn't crash before Wedge gets a chance to tell the user why; preventing source cache at install time (I could also empty that cache after the install process is done, but...); and just a cosmetic change in the SQL. (index.php, install.sql)
Re: New revs
« Reply #2424, on January 30th, 2014, 07:11 PM »
[Commit revision 9add95e]
Author: Nao
Date: Thu, 30 Jan 2014 19:10:54 +0100
Stats: 1 file changed; +4 (insertions), -1 (deletion)

  • Fixing undefined jquery_version (again!) in Ajax contexts. (Load.php)
  • If the notification popup had a user in it that got removed earlier, loadMemberAvatar would cause problems. (Load.php)
Re: New revs
« Reply #2425, on January 31st, 2014, 04:10 PM »
[Commit revision 9262e3f]
Author: Nao
Date: Fri, 31 Jan 2014 16:07:57 +0100
Stats: 2 files changed; +10 (insertions), -14 (deletions)

  • Fixing a minor error in the Reverse Proxy admin page. If you've previously supplied a list of IPs, make sure to visit the page and hit Submit again, so that your IPs can be stored in the new format. (ManageServer.php, QueryString.php)
  • Now hard-coding template dir and URL into core/html. I'm not sure there'd be a reason to want to get them out of the core folder, really. I'll probably just eventually allow you to move the core folder somewhere outside, but even then, security-wise, does it matter? (QueryString.php)
Re: New revs
« Reply #2426, on January 31st, 2014, 04:54 PM »
[Commit revision 09c96d3]
Author: Nao
Date: Fri, 31 Jan 2014 16:49:40 +0100
Stats: 1 file changed; +3 (insertions), -13 (deletions)

  • Fixed this huge installer bug that caused all paths to be wrong; it was simply due to a function being called too late in the process. Apologies to those affected. I guess a lot of support topics can be closed now, yay. (install.php)
  • Removed some very, very old leftover code. If it makes you feel better (or me?), it's also still in SMF and Elk. Nobody seemed to bother that infile_css is just not used anywhere else in their codebase, so it happily lives on here, unaware that it's wasting your time on each install. (install.php)
Re: New revs
« Reply #2427, on February 1st, 2014, 03:22 PM »
[Commit revision 0d8dfe9]
Author: Nao
Date: Fri, 31 Jan 2014 23:10:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Typo. (Security.english.php)

[Commit revision 342172d]
Author: Nao
Date: Sat, 01 Feb 2014 15:10:16 +0100
Stats: 3 files changed; +3 (insertions), -5 (deletions)

  • Removed all unneeded globals in anonymous functions... Is it what you think it is? Does it mean what you think it means? Yes, I think it is what you think it might mean to be! Globye is now properly working in PHP 5.3+ lambdas, after weeks of rethinking the wheel. Am I happy with it? I think! Does it mean I'll now have more time to devote to Wedge? You'd think! (ManageMembers.php, ManagePaid.php, Profile-Modify.php)

[Commit revision 9c69e45]
Author: Nao
Date: Sat, 01 Feb 2014 15:11:26 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • On the stats page, the filter select box wasn't correctly positioned on the current value. For instance, if you accessed it from a new session, it'd say 'Everything' but only show you Posts (the default). (Stats.template.php)

[Commit revision 13e45e8]
Author: Nao
Date: Sat, 01 Feb 2014 15:22:15 +0100
Stats: 1 file changed; +4 (insertions), -5 (deletions)

  • Fixed a non-breaking warning on the last step of the install process. Hopefully this shouldn't, uh... Break anything, really. (install.php)
  • At the end of the install process, Wedge would also attempt to download remote files. If it failed, it made it impossible to access the forum without editing a file. I decided that this particular step was less important than actually making the forum available, so I swapped code around. (install.php)
Re: New revs
« Reply #2428, on February 3rd, 2014, 04:07 PM »
[Commit revision 7ed1e12]
Author: Nao
Date: Sat, 01 Feb 2014 15:54:00 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • In Wess, channels() was considering unspecified RGBA channels to be forced to 0, instead of unchanged. channels(gray, 30%) is supposed to mean 'Gray, with 30% more red' (as it's the first channel in the list), not 'gray, with 30% more red, no green, no blue and no opacity'. (Class-CSS.php)

[Commit revision 4733f8f]
Author: Nao
Date: Sat, 01 Feb 2014 18:57:16 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • The Purge Cache admin menu entry should always be enabled for admins, regardless of their cache settings, because language cache is always enabled anyway. (Subs.php)

[Commit revision 8c9a955]
Author: Nao
Date: Sat, 01 Feb 2014 22:53:01 +0100
Stats: 6 files changed; +19 (insertions), -11 (deletions)

  • First set of patches from SMF 2.0.7. As this one is quite large, I'm slower to update. Some stuff is outdated and doesn't need to be applied. Some is for Postgresql compatibility, but it doesn't hurt MySQL so whatever, I'm applying it. Finally, many things are fixes taken by Mr. A from Wedge, applied to SMF, and that are trying to make their way back into Wedge. It gets kinda confusing. (index.php, SSI.php, Profile-Modify.php, Register.php, ScheduledTasks.php, Search2.php)
  • A security fix from SMF 2.0.3 wasn't applied by said Mr. A back when he was in charge of back-porting SMF patches, so... Did I tell you it was getting confused? Because I'm confused. (SSI.php)

[Commit revision 679a511]
Author: Nao
Date: Sun, 02 Feb 2014 19:04:44 +0100
Stats: 1 file changed; +5 (insertions), -6 (deletions)

  • Updated readme_install.html with some of the latest developments for the installer. Should I show this file in an iframe from the installer..? Possibly. (install/readme_install.html)

[Commit revision 4b0255a]
Author: Nao
Date: Mon, 03 Feb 2014 14:50:47 +0100
Stats: 5 files changed; +36 (insertions), -86 (deletions)

  • Just saved over a KB of code in the pretty URL conversion function. Some of the characters were tested against several times in various ways (!), some searches were to fail from the start, it's all very interesting. I'm not sure whether it comes down to the fact that this is a very old mod, or maybe I screwed it up when I converted my code to Wedge... I don't know. It's all very complicated anyway, I'm just making it simpler to get. Hopefully not breaking any special cases. (Subs-PrettyUrls.php)
  • Improved westr::entity_to_utf8 to include some edge cases. (Class-String.php)
  • Continuing the patch road, but since there's nothing to apply in Wedge (it was already done for the most part), I'm just simplifying hardcoded functions into entity_to_utf8. (Dlattach.php, Subs-Members.php, Subs-Post.php)
  • Note: testers wanted for pretty URLs. Just create new topics on your test forums, with silly characters in the title, even entities. They should be converted to a simple alpha-numeric string. Thanks!

[Commit revision b85bdff]
Author: Nao
Date: Mon, 03 Feb 2014 16:06:52 +0100
Stats: 8 files changed; +94 (insertions), -798 (deletions)

  • Removed Maintain Database area, moved table optimization to Routine Maintenance area. (Admin.php, ManageMaintenance.php...)
  • Removed UTF converters. We have an importer for that... No need to maintain 22KB of code, even in the admin area. TE, the rest is up to you! ;) (ManageMaintenance.php, Subs-Charset.php, ManageMaintenance.template.php, Admin.english.php, ManageMaintenance.english.php)
  • Cleaned up Routine Maintenance area. It looks better to me, but your mileage may vary. (ManageMaintenance.template.php)
  • Moved getLegacyAttachmentFilename to ManageAttachments. This function is only used once in Subs and once in M.A., I don't see the point in always loading 3KB of code in our main function library when you can afford to loadSource M.A. and be done with it. (Subs.php, ManageAttachments.php)
Re: New revs
« Reply #2429, on February 3rd, 2014, 07:28 PM »
[Commit revision 35b0756]
Author: Nao
Date: Mon, 03 Feb 2014 19:23:14 +0100
Stats: 1 file changed; +40 (insertions), -46 (deletions)

  • A quick fix for PHP 5.2 (and less) users trying to install Wedge on their server. It will still refuse to install, but at least with this, they shouldn't be kicked out of the script with a syntax error. Lesson learned: never used the nowdoc format, even if it sounds cooler than heredoc and avoids having to escape single quotes. (OriginalFiles.php)