New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2280, on October 24th, 2013, 01:00 PM »
rev 2280 [master 1dd8825]
3 files changed, 35 insertions(+), 40 deletions(-)

+ Initial privacy rewrite. Some stuff is dependent upon my WIP contact list system, so it probably won't work perfectly until I'm done with it all. Still... I love looking at how simpler the privacy queries now are. (index.php, Class-System.php, install.sql)
Re: New revs
« Reply #2281, on October 24th, 2013, 09:15 PM »
rev 2281 [master 33a803d]
 14 files changed, 550 insertions(+), 62 deletions(-)

+ Initial contact list code. There are still tons of things to do, so for now you can only create generic lists (including one type I'll probably end up dropping), and add/remove users from their profile pages. (install.sql, Class-System.php, Profile-Modify.php, Profile.php, Subs.php, Profile.template.php, index.language.php, Help.language.php, Profile.language.php, sections.css)
Re: New revs
« Reply #2282, on October 24th, 2013, 09:27 PM »
rev 2282 [master 05be743]
 8 files changed, 48 insertions(+), 32 deletions(-)

+ Second batch of privacy rewrites. Thoughts should now support contact lists, and everything (or most everything) should use integer values now. Phew. (Ajax.php, Post.php, Subs-Post.php, Thoughts.php, Thoughts.template.php, script.js)

- Removed unused variables. (Like.php)

@ Todo comment. (Load.php)
Re: New revs
« Reply #2283, on October 24th, 2013, 09:31 PM »
rev 2283 [master 955283b]
 5 files changed, 37 insertions(+), 15 deletions(-)

! Fixed 'file not found' errors not actually showing the filename. (ManageErrors.php)

! Ajax requests didn't return any parseable HTML when errors occurred. (Errors.php, Errors.template.php)

* Try to minimize gaps between membergroup IDs if deleting groups right after creating them. (Subs-Membergroups.php)

- Don't show your avatar in the sidebar if you're a guest. Duh. (index.css)

! Fixed (hopefully without introducing new issues on other browsers..?) a scrollbar problem on pages that were shorter than the window height. (index.css)
Re: New revs
« Reply #2284, on October 25th, 2013, 01:29 AM »
rev 2284 [master 8477fec]
 2 files changed, 101 insertions(+), 37 deletions(-)

+ Implemented a converter for buddy lists to contact lists. Will only execute after you've made use of Thorsten's importer and thus gotten buddy lists from an earlier SMF install, for instance. (Load.php)

! Thoughts needed more work to work with the new privacy & contact list systems. It's not perfect yet, but it's getting there! (Thoughts.template.php)
Re: New revs
« Reply #2285, on October 25th, 2013, 02:45 PM »
rev 2285
 5 files changed, 19 insertions(+), 14 deletions(-)

! Some Ajax requests still did skin-related testing, so let's just forget about being rigid about it, and initialize dummy versions of the most common skin variables, even in Ajax mode. (Load.php, Subs-Cache.php)

! Event detector in sidebar opener was actually broken, oops. (script.js)

- Old unused variable. (Class-CSS.php, install.php)
Re: New revs
« Reply #2286, on October 25th, 2013, 03:15 PM »
rev 2286
 3 files changed, 8 insertions(+), 6 deletions(-)

! Wedge didn't even show the thought form if no thoughts were found in the database. Didn't make sense. Thanks Pandos for pointing it out. (Thoughts.template.php, index.language.php)
Re: New revs
« Reply #2287, on October 25th, 2013, 03:53 PM »
rev 2287
 5 files changed, 12 insertions(+), 8 deletions(-)

! Privacy constants weren't defined in SSI mode. They're probably better off in the user class file, then... (index.php, Class-System.php)

! Fixed redefined constants, and simplified (a bit) the skin option parser. (Ajax.php, Load.php, Subs-Cache.php)
Re: New revs
« Reply #2288, on October 26th, 2013, 06:24 PM »
rev 2288
 7 files changed, 34 insertions(+), 27 deletions(-)

+ Saved about 0.15s (25%-30% of total time) on index CSS cache regeneration by adding a simple lookbehind assertion in the very last regex. I can't believe that one single, ultra-simple regex to remove a few empty elements used to take as long as the entire process of nesting, which has dozen of complex regular expressions. And yes, I did tons of tests. Something is wrong here. Well, at least it's fixed now. (Subs-Cache.php)

+ Wess tests in the shape of @is() calls are now even more useful. Up till now, @is (test, if_true, if_false) would be a straightforward use, then @is (test, if_true) showed nothing if test was false; I've now added the simplest possible form, @is (test), which, instead of returning the desired string, returns true or false strings, making it possible to use @is tests inside variable declarations. (Class-CSS.php)

* And obviously, as a result, I've removed the simili-hack for can_flex/can_animate and replaced them with similarly named variables, $can_flex and $can_animate. Technically, I could already have done it long ago (and considered doing it), by just storing the list of browsers in the variables, but I didn't think it was worth cluttering the common CSS file. Since @is tests with no nested variables are executed before variables are parsed, it means Wess will only do the @is test once, instead of each time a can_flex/can_animate request was made before. This-- much better. Not much faster, but at least now I can safely use these as many times as I want. (Class-CSS.php, common.css, index.css, media.css, sections.css)

+ Also added aliases to 'true' and 'false', so that you can use them all alone in an @if/@is test, for debugging purposes (previously, you could only have them inside tests that has a variable in them, such as @if ($var && true)). Seriously, I should have done that one long ago. (Class-System.php)
Re: New revs
« Reply #2289, on October 27th, 2013, 01:08 AM »
rev 2289 -- so, seriously, I've been the only poster today..?! :^^;:
 5 files changed, 19 insertions(+), 49 deletions(-)

+ Topic lists now show the number of unread posts per topic, just like unread posts/unread replies have been doing. (MessageIndex.php, MessageIndex.template.php)

* Added a parameter in the unread post number retrieval code, to allow passing a straight array of topic IDs to look up. I probably should set that param to true by default, but... Whatever. (Subs.php)

- Removed duplicate code. (Unread.php, UnreadReplies.php)
Re: New revs
« Reply #2290, on October 27th, 2013, 09:53 AM »
rev 2290 -- still very quiet in here, hmm...
 5 files changed, 41 insertions(+), 22 deletions(-)

+ Restricted lists should now work. Needs testing, though. I can't believe I spent days wondering how to implement these efficiently, and it took less than 5 lines of code to actually do it. (Class-System.php)

+ Preliminary code for new ignore lists. Very very early, really. (Class-System.php)

* Renamed PRIVACY_JUSTME to PRIVACY_AUTHOR, for harmonization. (Class-System.php, Security.php)

* Moved get_privacy_type to Security; I should be using that file more, I'd say... (Security.php, Thoughts.template.php)

* More work on the topic privacy rewrite. It still won't work, mind you... (Post.php, Post.template.php)
Re: New revs
« Reply #2291, on October 28th, 2013, 12:11 PM »
rev 2291 -- ♫ Blame Pete! ♫
 7 files changed, 53 insertions(+), 61 deletions(-)

- Removed more unused globals, and unused variables, such as $this_plugindir or $last_0. Blame Pete. (index.php, Load.php, ManagePlugins.php, QueryString.php, Security.php, SSI.php, Subs.php)

* Moved test_ip_host to Security file, as it's only used there. And still not working, BTW... Blame Pete. (Subs.php, Security.php)

! $SERVER was used instead of $_SERVER. Blame Pete. (QueryString.php)

! loadPluginLanguage didn't allow for $fatal to be set to false. Blame Pete. (Load.php)

! on_date(), which I have yet to use anywhere in Wedge, was using the wrong parameter. Blame me. (Subs.php)
Re: New revs
« Reply #2292, on October 28th, 2013, 11:57 PM »
rev 2292
 3 files changed, 8 insertions(+), 5 deletions(-)

! Wess didn't correctly handle the webkit prefixes on flex-* properties for Safari 7. It only handled 'display: flex', which was pretty useless. (Class-CSS.php)

! While 'true' tests in Wess worked, I'm afraid 'false' didn't, at least not always. It's complicated. (Class-CSS.php)

! Fixed CSS file URLs showing an unneeded keyword. (Subs-Cache.php)

- Another unneeded global. (ssi_examples.php)
Re: New revs
« Reply #2293, on October 29th, 2013, 05:31 PM »
rev 2293
3 files changed, 3 insertions(+), 3 deletions(-)

! The install files need a reminder that mysqli is now required. (readme_install.html, Install.language.php)
Re: New revs
« Reply #2294, on October 29th, 2013, 06:29 PM »
rev 2294
 13 files changed, 16 insertions(+), 16 deletions(-), 1.71 KiB (yes, I missed using patch sizes... :P)

* More spacinazi. Fascinating... I'm leaving some of the libraries aside (SFTP, Exif etc), because they're not from my codebase anyway. (Load.php, ModerationCenter.php, Notifications.php, Profile-Actions.php, Profile-View.php, SearchAPI-Custom.php, Subs-BoardIndex.php, Subs-Post.php, ManageInfractions.template.php, ManageModeration.template.php, ManageSearch.template.php, profile.js, index.css)