New revs

Nao

  • Dadman with a boy
  • Posts: 16,061
Re: New revs
« Reply #2310, on November 8th, 2013, 04:31 PM »
rev 2310
 5 files changed, 30 insertions(+), 25 deletions(-), 1.66 KiB

! Page header was incorrectly sized in responsive mode (with 1.5 pixel density or higher, which I rarely test on desktop.) (sections.css)

! Post avatars were incorrectly aligned in responsive mode. (sections.css)

! ins tag styling fixes. (extra.rtl.css, sections.css)

* Pixel-perfect news in the admin sidebar. The jury's still out on whether I'll use that area at all, though... (mana.css)

* Intermediate work on font types. Seriously, more to come. I just need to see it in action on a live site. (common.css, index.css, sections.css)

:edit: Forgot to document (why is TortoiseGit missing the ability to edit the latest changelog, when even TortoiseSVN allows it..?!): disabled flexbox on iOS 6, because it's obviously not working between us.
Re: New revs
« Reply #2311, on November 8th, 2013, 10:10 PM »
rev 2311
 7 files changed, 49 insertions(+), 40 deletions(-), 2.24 KiB

* As Wess doesn't do anything interesting with array variables, let's at least return the size of them, allowing you to test for empty (or non-existent) arrays. Should account for 90% of all use cases. Using that for language flags. (Subs-Cache.php, index.css)

* Like buttons in posts should have the same opacity effect as other action elements. (sections.css)

! Wrong font variable name. (index.css, sections.css, Wireless/extra.css)

! Overflow problem. Again. (Wireless/extra.css)

! Was this an unfinished language string? It certainly didn't mean anyth (Admin.language.php)

! When a post had an attachment, clicking its icon would result in a broken icon list. (topic.js)

! Hadn't committed my local changes to quick edit, regarding the new tags for last modified date. (topic.js)

! follow_me() fixes. (topic.js)

* Very minor rewrites. (topic.js)
Re: New revs
« Reply #2312, on November 9th, 2013, 12:47 AM »
rev 2312
 2 files changed, 2 insertions(+), 2 deletions(-), 903 bytes

! Spoiler tags didn't accept spaces in their descriptions, and as an indirect cause, made quick edit fail through some complicated crap in strip_tags(). Definitely NOT a fun thing to debug, really. (install.sql)

! JavaScript doesn't like receiving malformed XML CDATA strings. In some rare situations (pasting some code, maybe?), it would simply freeze at parse time. (Subs.php)

@ Note for those who already have Wedge installed somewhere: either repopulate your bbcode table with the updated version, or ignore the fix, or edit it. You just need to add two double quotes, no biggie.
Re: New revs
« Reply #2313, on November 10th, 2013, 07:30 PM »
rev 2313
 2 files changed, 6 insertions(+), 3 deletions(-), 762 bytes

! Fixed runtime CSS errors related to bad clean-ups after an unextends keyword. (Subs-Cache.php)

! Fixed an innocent bug that turned into a nasty JavaScript-show-stopper for guests on mobile devices. (Display.template.php)
Re: New revs
« Reply #2314, on November 10th, 2013, 08:50 PM »
rev 2314
 8 files changed, 7 insertions(+), 39 deletions(-), 1.80 KiB

* Admin area is now much more mobile-friendly. Can you believe it..? Oh, and yes, I try to avoid using the !important keyword whenever possible, but sometimes, it's just not worth the hassle. (ManageBoards.template.php, sections.css)

- Wuthering (and thus, Wilde) still had leftovers from the pre-mobile sidebar system, and it conflicted with the sidebar toggle button, making it impossible to change the theme if you'd chosen any of these by default on a mobile device. Ouch! (Wilde/skin.xml, Wuthering/skin.xml)

- Removing oldIE leftover CSS. (extra.ie6.css, extra.ie7.css, extra.ie8.css, extra.rtl.css)

- Removing a topic list hack for mobile, which doesn't seem to be very efficient to me. Hopefully, the original bug fixed itself by magic. Needs more testing. (sections.css)

! Attachments and custom fields shouldn't be removable by soft-merging. (skeleton.xml)

(And that commit deserves a few Likes, I say :niark:)
Re: New revs
« Reply #2315, on November 11th, 2013, 04:29 PM »
rev 2315
 4 files changed, 45 insertions(+), 5 deletions(-), 2.04 KiB

! Fixed a bug with no consequences, but nasty to figure out, because it implied the homepage was loaded on mobile in Ajax mode, which wasn't supposed to happen. (Yeah, whatever.) As a rule of thumb, really, please developers, avoid using redirectexit() in an Ajax page! It didn't strike me as 'obvious' that the page would be loaded this way, which is why it took me days to figure it out. It's tempting to add a failsafe in that function itself, but I don't think it's likely to happen often, and I'll probably remember it next time, eheh. (Notifications.php)

! Forgot to add the skeleton.xml file in the last commit. (skeleton.xml)

+ A tentative DCO file, for contributors to agree to when they sign-off their code. (DCO.txt)

- Unused class. (PersonalMessage.template.php)
Re: New revs
« Reply #2316, on November 11th, 2013, 08:36 PM »
rev 2316
 4 files changed, 61 insertions(+), 55 deletions(-), 2.31 KiB

* Tweaked Wilde -- headers, and added flexboxing on the linktree, for mobile use mostly. (Wilde/extra.css)

* Updated Home template to be more... generic, really. It was tailored for wedge.org, and didn't have a reason to be that way in the repo. While the 'default' is still Welcome, I'd appreciate to get feedback from users -- which one should be the default? (If Home is, then Welcome will be completely removed.) (Home.template.php, Home.language.php)
Re: New revs
« Reply #2317, on November 12th, 2013, 01:35 AM »
rev 2317 -- yeah, ultra-short one, but I couldn't stand having it unpushed.
 1 file changed, 1 insertions(+), 1 deletions(-), 503 bytes

! Repeat a 1000 times: do not commit any last-minute optimizations without testing them... This one made we::is('mobile') return true on desktop browsers, which was... Not so good. (Class-System.php)
Re: New revs
« Reply #2318, on November 12th, 2013, 01:08 PM »
rev 2318
 6 files changed, 103 insertions(+), 36 deletions(-), 2.97 KiB

+ Added support for relative dates in topic pages. (topic.js, index.language.php)

@ Need to know: this isn't going to stay 'as is'. I'm only trying to clean up my uncommitted stuff, and this is an important part of it. Also, an issue: done always at runtime, so you might see the absolute date at load time, a second before it becomes relative. As I said-- won't stay like this.

* Forcing relative dates to be absolute after 2 years. (Msg.template.php)

+ Added a helper function, time_tag(), which will be helpful to add these tags outside of topic pages later. Also removed a couple of lines that didn't make sense in forum_time(). (Subs.php, Msg.template.php)

* Moved runtime code like code+flexbox fixing, follow_me() adjuster and relative dates, to a new function that will get re-called whenever necessary. (topic.js)
Re: New revs
« Reply #2319, on November 14th, 2013, 12:42 PM »
rev 2319
 5 files changed, 10 insertions(+), 11 deletions(-), 1.37 KiB

! Fixed username positioning in topic pages on iOS browsers. Please -- don't ask. If you really must know, it was an old hack for iOS 4 (from rev 1584), that was fixed by Apple in iOS 5, without my knowledge. To hell with iOS 4, I'm removing the hack entirely. (extra.ios.css)

* Tweaked layout in userbox for mobile; should be properly aligned, now. (Wireless/extra.css)

- Duplicate code. (Wine/extra.css)

! Forgot some <ins> styling. (extra.rtl.css)

+ Some line needed clearing up. (contributors.txt)
Re: New revs
« Reply #2320, on November 14th, 2013, 01:09 PM »
rev 2320 -- hopefully, my last commit before I start pushing theme changes.
 3 files changed, 6 insertions(+), 7 deletions(-), 1002 bytes

* Minor fixes on quote/code headers. Most notably, style was broken on quoted spoiler tags. (index.css)

- Don't remove overflow on an open sidebar. I know it will slightly break the skin selector or board selector on short pages, but it's better than mobile complications. (script.js)

* Trying an !important-free responsive admin area. Don't laugh, it's hard to get right. (sections.css)
Re: New revs
« Reply #2321, on November 14th, 2013, 02:30 PM »
rev 2321 -- changed my mind. I'll get rid of as much as possible, before I start moving folders around.
 11 files changed, 13 insertions(+), 49 deletions(-), 4.32 KiB

* Moved Forum Width setting from themes to general settings. (ManageSettings.php, Settings.template.php, index.template.php, ManageSettings.language.php, Themes.language.php)

* Moved Random News setting from themes to News Settings. Renamed language string to 'enable_news'. (ManageNews.php, Settings.template.php, ManageSettings.language.php, Themes.language.php, install.sql)

- Removed Show Profile Buttons theme option. Seriously, I could understand that one wouldn't want to know their friends' online status, but... Nope, couldn't understand. (Msg.template.php, Settings.template.php, Themes.language.php, upgrade.php, install.sql)

- Removed Last Modification theme toggle. Again: no crazy reason for disabling that will work on me. If you really want to hide them, set 'ins' styling to display: none. (Msg.template.php, Settings.template.php, Themes.language.php, upgrade.php, install.sql)

- Removed deprecated language strings: enable_single_post, enable_multiple_posts (I have no idea what these are, but they're not used anywhere), inline_desc (this one was probably outdated 8 years ago) and member_list_bar. (Themes.language.php)

@ Yes, I know, I have no reason to keep updating upgrade.php. Don't mind me.
Re: New revs
« Reply #2322, on November 16th, 2013, 11:37 AM »
rev 2322 -- first batch of small fixes to Wedge. Attention SMF developers: some minor bugs are mentioned in there that are also in SMF 2.1 as far as I could see. If you can't find the bugs I'm referring to, please open a topic somewhere in the SMF board here, and I'll try to help. At worst, I'll do a pull request, but right now I'm focusing on Wedge issues, so it'll have to wait until I have more time.
 24 files changed, 74 insertions(+), 91 deletions(-), 4.72 KiB

! weSkeleton->remove() was expected to return a success value. (Class-Skeleton.php)

! The new ban management code returned $row at one point, instead of $rowData. Blame Pete. (ManageBans.php)

! The 'do_empty_field' feature could never be disabled, due to a typo in the disabler code. Blame Pete. Still, nice feature, not sure why anyone would want to disable it. (Subs-Editor.php)

- pretty_synchronize_topic_urls doesn't provide a return value, no need to output it then... (ManageSettings.php)

! SMF 'bug': While session-related functions are not expected to return a value (it's undocumented, but the official examples provide values), I realized that the SMF implementation was flawed, such as providing a return value from an insert query, which is also undefined. Ahum. Cleaned it all up. (Load.php)

! SMF bug: $_COOKIE&#91;'guest_poll_vote'] has three bugs in one line: a 'count' ternary test that can perfectly be eliminated; an explode() used instead of implode() (!!), and the explode itself only has one parameter, since the comma was replaced with a period. (!!!) (Poll.php)

- SMF bug? Error lists in saveProfileFields and groupMembership2 parameters are never used. Also a typo in the documentation for these, hmm. (Profile.php, Profile-Modify.php)

- SMF bug: a beautiful unneeded line indeed... validateSession() never returns any value, and what do you think that test does anyway? (we::$is_member || validateSession()) -- if it's a member, it's true. If it's a guest, it calls the function, which then calls is_not_guest(), which generates an error. Thus skipping the line executed by that test, which... Generated an error. Well, yeah, sure, man, whatever you want. (Profile.php)

- SMF 'bug'? The first parameter in mergePosts() was optional, while the others weren't. (RemoveTopic.php)

! SMF bug: $entryname is used before it's declared. Wrong copy & paste, I guess. (Subs-Package.php)

! ...Which Pete then proceeded to reproduce in his plugin system. Along with an undeclared $path variable, a $dir variable missing its dollar sign (and thus considered as a constant), a $pluginsdir global renamed to '$plugins_dir', and another variable used before it's declared, $full_path, although in this case I think he meant to say $dir. Yeah, that one again... (Subs-Plugins.php)

! Nice one... A file_get_contents call using FILE_BINARY as a flag. Not only is it not necessary (file is considered binary by default), but it's a PHP 6-only flag. In code written at least 4 years ago. Real fun. (Class-Media.php)

* media_handler->resizeJpgImage() returned nothing, and that null return value was used and inverted to turn it into a true value. That's oh-so-badass. But it's also confusing, and fixed by simply forcibly return true. (Class-Media.php)

! show_prevnext() should have returned its output, rather than echoed it. Same for aeva_listFiles(), but as this one's more complicated, I'll just settle on echoing stuff, and then doing an explicit return ''. (Media.template.php)

- Unused function, getZippedfile(). Was buggy anyway. Debug code I'm sure. (Class-Zip.php)

! Undeclared global in aeva_moveAlbum(). It was only used if an error occurred, which I guess, never did happen. (Aeva-Gallery2.php)

- Unused globals. (install.php, Profile-Modify.php, Reports.php, Subs-Members.php)

- Duplicate globals. (ManageBoards.php, MoveTopic.php, Profile-Modify.php, Subs-Menu.php, Media.template.php)

! Missing global. Technically, it's a non-existing global, but it's also for a non-existing function, so who cares. (ManageMaintenance.php)

- Spacinazi, commenazi, etc. (PrettyUrls-Filters.php, Security.php)
Re: New revs
« Reply #2323, on November 16th, 2013, 12:12 PM »
rev 2323 -- what's with the number 23 again?! I love this commit. It has so many fixes for details *important* to me.
 8 files changed, 44 insertions(+), 46 deletions(-), 3.12 KiB

! This is my tentative fix for the infamous "quick edit just marked my post as unread, you silly!" bug... I'm pretty sure it's due to a settings caching problem (as I believe it only happens when the post you're editing is the latest in the forum *and* you've finished editing it within a minute of posting it in the first place), but I tried to follow the 'workflow' and it seemed flawless to me, so I'll instead use the message ID as the log date if the maxMsgID value is outdated at that point. (Subs-Post.php)

+ Added support for outputting Secure HTTP links in Aeva embedding. Rendered videos will still be unsecure, but the point is only to prevent https protocols from breaking the whole process. (ManageMedia3.php)

! Select boxes will now take the page height into account if it's shorter than the window height. Meaning, they'll try to avoid showing their dropdowns below them if there's more room above them, than between their bottom and the actual bottom of the body tag (not the window height). I know, it's complicated, but it magically fixes the skin selector in short pages with a responsive sidebar. That one ate at me over a long time, you can't imagine. Uh, no, actually not that much. (sbox.js)

* Instead of having stat bars span from 4px to 104px in size, I'll have them span from 5px to 100px, that's more than enough thank you. (Stats.php, Stats.template.php)

! Macros weren't being parsed if the skin.xml file was missing, even though they're located in the macros.xml file. (Subs-Cache.php)

* Removed flexbox and display: table code paths for Wilde linktrees. Seriously, it was too complicated for its own good. It works better as an inline-block, especially in iPhones. As a fix for broken gradients on multi-line linktrees, I've simply decided to drop all linktree gradients in responsive mode. Looks 80% as good, and doesn't 'break' when over 2 lines or more. (Wilde/extra.css)

* Improved translation. (PersonalMessage.french.php)

@ Re: quick edit bug. Considering that Wedge is using pretty much the same workflow as SMF here, I'd like to invite SMF developers to look into doing the same. Same comment as before: if you're unsure, ask me to do a pull request. I'll wait until I can confirm this is definitely fixed, though.
Re: New revs
« Reply #2324, on November 16th, 2013, 10:51 PM »
rev 2324 -- more quick edit bug squashing! Hopefully all working now, eh.
 3 files changed, 8 insertions(+), 17 deletions(-), 1.04 KiB

! Quick edit save was somehow broken by an earlier commit of Pete's, due to a wrongly placed parenthesis. I don't know if it had any influence over the contents of posts. Sorry if it did. (JSModify.php)

! And, Quick edit retrieval was also broken, this time by a recent commit of mine, where some [ signs were turned into their entity equivalent. I was under the impression that un_htmlspecialchars was enough, when I should have gone all the way through westr::entity_to_utf8. Let's not talk about that anymore. (QuoteFast.php)

@ Well, at least the Quick edit 'last post' bug fix from the last commit was proven to work. Yay. How strange that quick edit had so many bugs, and I didn't realize it until recently.

- Removed some remaining unused index params from wesql::insert calls. (ManageSmileys.php)