New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2220, on August 22nd, 2013, 09:33 PM »
5 modified, 5KB

Revision: 2220
Author: arantor
Date: 22 August 2013 20:33:13
Message:
! Simplified like tooltips as we talked about. Saves a query too. (Display.php, Like.php, Msg.template.php, Thoughts.template.php, index language file)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/Thoughts.template.php
Modified : /trunk/Themes/default/languages/index.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2221, on August 22nd, 2013, 10:02 PM »
rev 2221 -- lulz, it's really becoming a running joke: long time without a commit, and then we both do one within the same hour ;)
(5 files, 3kb)

* Overhauled Msg template, to make it rely less on the skin's mobile status, and leave it up to the skeleton to decide what to do -- effectively making it much more readable, hopefully. Post header spans are now a <time> tag, something I've wanted to do for so long. A new macro was added, msg_author_avatar, which allows changing the tag type for the avatar container (li or div). The jury is still out on whether the new extra div inside .poster should be called 'column', it's an SMF convention, but that's a lot of bytes for something that could be handled with just '.poster>div'... Don't you think so..? Actually, most column definitions would fit that description, so... (Msg.template.php, sections.css, macros.xml, skeleton.xml)

* French translation. (index.french.php)
Re: New revs
« Reply #2222, on August 22nd, 2013, 10:14 PM »
rev 2222 -- hopefully, Wireless is stable enough for prime time!
(5 files, 2kb -- but it feels more like 10KB... :P)

* Rewrote Wireless to take advantage of the new Msg skeleton. I thought it deserved its own commit, yeah... So, basically, the user box is now correctly shown in the post header, and I'm giving you back the info that was removed earlier, such as the post name (and last edit time). I reckoned that it was still very much useful in mobile mode, because often the topic title won't show up there, so it can be helpful to have it in the post. Also, it's a proper link, so you can copy and paste a post's permalink from there. (Wireless/extra.css)

* Finally found the reason why all of these Android browsers gave me different font sizes... Turns out, some of them force a scale of 1 on page load, even if it's set to 0.7, like it was. I decided that it was best to just do "like the rest" and set it to 1 (I'm even thinking of disabling zooming entirely), and then work on font sizes later. For now, it's very satisfying. (index.template.php, Wireless/extra.css)

! Fixed an undefined constant. I still really, really need to figure out why it can be undefined, but for now... It's cleaner to just test for defined(), and let it go. I can't win every time. (Subs-Template.php)

- Removed an inline style from select boxes. (Themes.php, index.css)
Re: New revs
« Reply #2223, on August 22nd, 2013, 10:23 PM »
rev 2223 -- follow me!
(1 file, 5kb)

+ You wanted it, you have it! Here's the JS code to make user boxes follow you in topic pages. I've commented it thoroughly, in case you don't understand it on first sight. As with many other recent features in Wedge, it's something that could be plugin material, it's easy enough to insert a hook there and let the plugin do the job, so I'm committing this separately, to make it easier to spot the code and remove it, if needed. (topic.js)
Re: New revs
« Reply #2224, on August 23rd, 2013, 12:03 AM »
rev 2224 -- GFY, IE8!
(16 files, 4kb)

- Got rid of postbg classes, replaced with :nth-of-type zebra striping. This isn't supported in IE 6-8, and I couldn't care less. We're talking about alternating colors or something, not dinner with the Queen. This should make everything a bit faster. Also, renamed the .root class (which was JS-oriented) with a more generic .msg class, which should also compress a bit better, FWIW. (attic/scripts/Unused-softMerge.js, Subs-Template.php, Msg.template.php, PersonalMessage.template.php, Post.template.php, post.js, script.js, topic.js, common.css, extra.ie6.css, extra.ie7.css, index.css, sections.css, Wine/extra.css, Warm/extra.css)

- Removed 'alternate' entry in the message array, since we're no longer using it... Feel free to restore it, if you can find another reason to use it, I guess! (Display.php)

@ Note to self: need to remove all references to .keyinfo, too.
Re: New revs
« Reply #2225, on August 23rd, 2013, 01:50 PM »
rev 2225 -- didn't have much to commit, but I have a feeling it's still helpful to split these into chunks.
(4 files, 2kb)

! Correct me if I'm wrong, but Wedge disables template evals by default, not the other way around. So, these language strings needed to be updated... (Help language files)

* Gave labels to profile page checkboxes. Accessibility FTW. (Profile.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2226, on August 23rd, 2013, 06:02 PM »
9 files, 26KB[1]

Revision: 2226
Author: arantor
Date: 23 August 2013 17:01:57
Message:
! PM menu now elevated out of the main menu and put up with Notifications. There's quite a bit to this commit so let me cover it off.
 * When doing the regular poll for notifications, also supply the number of unread PMs too. We already have this number calculated, just have to send it. (Notifications.php)
 * Don't have the PM item in the main menu. I removed the m_pm declaration but the mail icons (including the one I don't think I've ever seen) are still in the sprite. (Subs.php, index.template.php, index.css)
 * Add the PM popup area next to the notifications area. (skeleton.xml, index.css, index.template.php)
 * The PM area itself handles the popup, both for the main popup as well as the preview. Previewing immediately marks something read and this must only touch is_read; is_new is used for a separate purpose in the bowels of the PM code. (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage language file)
 * Lastly, the JS has to make it all play nicely. Sorry that it's basically a duplicate of the notifications code but there are a few subtle differences; firstly the PM count and notifications count are kept separate. The PM count is never used to update the page title, it doesn't have to do separate callbacks to mark any read, and there's no delete function directly from the popup (intentionally). This just felt right to me but I'd suggest we try it for real to see how people feel about it. There's also differences of URLs and the need for each popup to close the other. (script.js)
----
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/skeleton.xml

@ I *really* didn't know how to make the JS any leaner than it is :(
 1. Eek.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2227, on August 24th, 2013, 12:47 AM »
rev 2227
(8 files, 19kb)

! Tweaked PM notifications to use different text strings, allowing for the French version (and any other complicated language) to fit into the smaller width, because we're worth it... Also restored the Settings icon. Dunno if it not being there was as desired, uh..? (PersonalMessage.template.php, Notifications.language.php, PersonalMessage.english.php)

! PM notification update code was incorrectly using the 'count' variable, instead of items[1]. Also reworked code flow to save a few bytes, e.g. pmload() is never used outside of script.js, and thus can be declared as a local function. (script.js)

- Removed the PM icons from the menu sprite. Saves 220+ bytes of CSS, yay. (index.css, images/sprite-menu-32bit.png, images/icons/sprite.png)
Re: New revs
« Reply #2228, on August 24th, 2013, 04:22 PM »
rev 2228
(2 files, 1kb)

! The recent Wireless tweaks apparently broke the notification popup width. Hopefully this should fix it. (script.js, Wireless/extra.css)
Re: New revs
« Reply #2229, on August 26th, 2013, 06:24 PM »
rev 2229 -- back to work after this, err... Interesting detour..?
(12 files, 4kb)

+ Added a new note class, notevoid, which is meant to be neutral, so it has a grey background. Used in notifications. (index.template.php, script.js, index.css)

* Moved notification block creation to the skeleton file itself. Effectively, this means that skins can choose to hide it, and while I don't see *why* they would want to, it's still okay to do it in my opinion. People aren't forced to use your skins. (Notifications.php, index.template.php, skeleton.xml, Warm/skeleton.xml)

* Just like CSS files, people shouldn't be able to view skin XML files from within their browser. (skins/.htaccess * 5)

! most_online param was inverted when it came to Ajax loading of monthly stats. (Stats.template.php)
Re: New revs
« Reply #2230, on August 28th, 2013, 09:53 AM »
rev 2230
(8 files, 3kb)

* Using HTML5 instead of a div tag soup on spoiler tags.

(click to show/hide)
The main advantage is that it allows them to act like quote tags when it comes to keeping footnotes inside them[1].
 1. Ring any bell, Pete? ;)
(install.sql, index.css)

! border-box divs are nice, but adding a margin to these increases their width above 100% and kinda misses the original purpose... Doesn't it? (sections.css)

! Signatures need some extra horizontal padding in Wireless. (Wireless/extra.css)

- Removed two language strings that were no longer in use, and moved another to a more specific file. (index.language.php, PersonalMessage.language.php)

- Removing tags column from topics for now. These aren't used, and I might as well try and put them to a different table, it'd probably be better for performance. (install.sql)

* Added UptimeRobot to the bot list; it's probably a wedge.org thing only, but it's not like it's going to change anything if I add it or not, so might as well add it. (install.sql)

@ Note: forgot to add 'mixes .hide' to .spoiler blockquote, will do on next commit, do it yourself if needed ;) Did it here.
Re: New revs
« Reply #2231, on August 29th, 2013, 12:23 AM »
rev 2231
(5 files, 2kb)

! PM blocking system wasn't working. Hopefully should work now... (Subs-Post.php)

! Stop forcing user boxes to 'position-fix' themselves if they're as tall as their parent message in the first place. Hmm, my math is a bit strange here... I think it works, though. (topic.js)

! Ouch, my eyes! An actual 'or' instead of '||', the folly! (MessageIndex.template.php)

! SPOILERS! Forgot to hide them. Which is the basic idea behind a spoiler box, right..? (index.css)

! PM preferences should load the PM language files, even if in the profile area. Cleaner. (Profile-Modify.php)
Re: New revs
« Reply #2232, on August 29th, 2013, 12:24 AM »
rev 2232
(8 files, 3kb)

* Three more strings that weren't used in the index language files. (index.language.php, Post.language.php)

- Removed some duplicate PM strings. (PersonalMessage.language.php, Profile.language.php)
Re: New revs
« Reply #2233, on August 31st, 2013, 01:24 PM »
rev 2233
(6 files, 2kb)

! Switching to between Wysiwyg modes generated an undefined index. (Class-Editor.php)

! Smileys were missing some left padding to compensate for the (very appropriate) internal fix I made recently. (editor.css)

! Search icon position was incorrect. (index.css)

- Spoiler input tag was over-styled. Yes, this happens once every blue moon, but I actually removed unneeded CSS. (index.css)

* Made Poll results more responsive, notably by using percentage widths. (Display.php, Wireless/extra.css)

* Spacinazi. (Display.template.php)
Re: New revs
« Reply #2234, on August 31st, 2013, 04:28 PM »
rev 2234
(3 files, 1kb)

+ Added a skin_parser hook, which allows you to add custom parameter types to skins, and parse them. (ManagePlugins.php, Subs-Cache.php)

! Fixed a wrong CSS rule on unrecognized user agents. (Class-CSS.php)

! <css for="browser" include="file"> might have included the file in all browsers... (Subs-Cache.php)
Plugin revs »