New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2205, on August 4th, 2013, 10:12 PM »
rev 2205 -- signatures, mostly.
(5 files, 3kb)

! Fixed signatures not showing up in soft-merged posts. (Subs-Template.php)

! And, err... Fixed signatures not showing up, like, anywhere. Silly typo. (macros.xml)

* A few CSS tweaks: .bbc_img should have some margin around them, and left/right-aligned images should modify them accordingly. Needs testing, especially with img.center possibly conflicting with .bbc_img, but I don't think it will... Fixed letter-spacing in Chrome (latest versions seem to finally be using DirectWrite, so...), and improved background color of code blocks. (index.css)

- Since Firefox 2 hasn't been supported for a long time in Wedge, there's no need for hacks targeted to it, really. (common.css)

- Saving a few bytes of CSS in Chrome. (sections.css)
Re: New revs
« Reply #2206, on August 6th, 2013, 11:16 PM »
rev 2206 -- moving slogan to main settings, and related changes.
(17 files, 4kb)

* Moved site slogan setting from theme area to main settings. This just makes more sense. (Load.php, ManageSettings.php, Settings.template.php, ManageSettings.language.php, Themes.language.php)

* Renamed #siteslogan to #slogan, and #wedgelogo to #logo. If these are in conflict with a parent site, well... Use creative CSS. Oh, and yes, Warm is still broken in SVN, please forgive me for not keeping it up to date there, but it is locally at least. (Load.php, index.template.php, extra.rtl.css, index.css, sections.css, skin.xml, Wine/extra.css, Warm/skin.xml, Wuthering/skin.xml)

* Minor tweak to the banner macro. (index.template.php, macros.xml)

* Minor CSS tweaks. (index.css)

! MySQLi no longer returns false when a query returns no rows. Instead, it returns null. Which is fun, because SMF/Wedge does a false test on this, not a null test. I found one in SSI.php, but there are probably dozens elsewhere. I'm going to rely on Pete to decide whether or not it's best rewriting fetch_assoc, or checking all requests individually, yay... (SSI.php)
Re: New revs
« Reply #2207, on August 8th, 2013, 04:15 PM »
rev 2207 -- no biggies.
(6 files, 2kb)

+ Wess now allows nesting math() calls together. While it doesn't make sense to include a math() inside another (the contents can be directly parsed anyway), I realize that themers might want to assign a math() function to a variable, which itself might be used inside a math() function, causing endless troubles until now. Also, it's a nearly free fix, so, whatever. (Class-CSS.php)

* New optional variable $responsive_search_min_width should help you quickly redefine the minimum popup width for the search box. To be more specific, in Warm it's moved to the sidebar, and is thus too big to be used. This should fix it, once I'm done with the Warm update. (sections.css)

! Small fixes to Wine, Warm and Wuthering. (Wine/skin.xml, Warm/macros.xml, Wuthering/extra.css)

* Bytenazi. (index.template.php)
Re: New revs
« Reply #2208, on August 8th, 2013, 05:32 PM »
rev 2208 -- even less of a biggie, at this point.
(1 file, 4kb)

* Warm really needed to be committed at this point, so I'm doing a half-commit, with all changes except for the new color set, which I'm not even sure I'll adopt anyway, so... There you go. This mainly fixes the sidebar button not showing up in responsive mode, and other problems related to the top bar being moved to the sidebar, overall. (Warm/extra.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2209, on August 8th, 2013, 11:59 PM »
2 modified, 2KB

Revision: 2209
Author: arantor
Date: 08 August 2013 22:58:55
Message:
! Merge in some fixes from SMF 2.0.5 patch (other issues already fixed, or require larger changes than this one commit):
 ! (XSS) $_REQUEST['sa'] could be used unsanitised. Clean up if not valid, and remove some other code we don't need any more. (PersonalMessage.php)
 ! (XSS) Email addresses were not validated when accepted for newsletters. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/PersonalMessage.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2210, on August 9th, 2013, 04:17 PM »
rev 2210 -- I'm starting to hate preg_replace_callback......
(6 files, 7kb)

* Converted more of the eval preg_replaces into callbacks, and believe me, some of these were very, very ugly to do... I feel bad about them. Class-CSS has some global scope/private complications in the def replacer, and Subs-Cache has an even more awful interaction with a $context variable within the callback, ahh, don't say any more! Wess-related stuff was tested thoroughly (yeah sure..), the rest has yet to be tested, but I double-checked it. The only file left to convert is Class-Editor.php, and I'm not doing it right now because, guess what? It has too many of them for my stomach right now. (Class-CSS.php, Subs-Media.php, Modlog.php, Post.php, Subs-Cache.php)

* Spacinazi. (PersonalMessage.php)
Re: New revs
« Reply #2211, on August 9th, 2013, 11:55 PM »
rev 2211 -- although, I also dislike evals, so... I guess it nearly balances out, doesn't it?
(1 file, 6kb)

* Converted the last 10 remaining preg_replace evals to preg_replace_callback. Phew. As earlier, I've ensured it doesn't crash or anything, but needs more testing, if anything. (Class-Editor.php)

! Fixed an odd little bug (another one of those that always escape my attention), where switching from Wysiwyg to normal editor would sometimes add an extra space after smileys, hmm. (Class-Editor.php)
Re: New revs
« Reply #2212, on August 13th, 2013, 12:54 PM »
rev 2212
(5 files[1])

+ Added support for IE 11. Mostly, fixed IE path for a few DOM elements that were removed, and forced Wedge to detect IE 11 it as 'ie11' instead of 'gecko0', as well as setting is_ie to true in JavaScript. See, 'gecko' browsers don't get lot of rights, only Firefox gets the gradients and all. Should I change this to give all CSS to unrecognizable browsers by default..? I don't know, honestly. (Class-Editor.php, Class-System.php, script.js, Theme.template.php)

! Used the opportunity to ensure a browser that can't be detected doesn't generate a version number of '0' in the CSS filenames... Just the browser name will be okay, at that point. (Subs-Cache.php)
 1. AND FRIGGIN' TORTOISESVN 1.8 NO LONGER INDICATES SIZES! CAN I EVEN DOWNGRADE?!
Re: New revs
« Reply #2213, on August 13th, 2013, 01:53 PM »
rev 2213
(7 files, 3kb[1])

* Moved header_logo_url setting from Theme to Basic, as originally planned. I have yet to figure out how to rewrite this all... Maybe offer a 'header' select box with 3 possible pairs, forum name + logo / forum name + slogan / logo + slogan..? (Load.php, ManageSettings.php, Settings.template.php, LANGUAGES: ManageSettings, Themes)
 1. Aaahhhh... This is one of those rare cases, where it feels so much better to downgrade!
Re: New revs
« Reply #2214, on August 13th, 2013, 08:52 PM »
rev 2214 -- removing some outdated HTML...
(24 files, 11kb)

- Got rid of all first_th/last_th classes, as they're forgotten remains of a time when :first-child was a web designer's dream. Seriously, since these are only used to do rounded borders, and IE 6 supports neither border-radius nor :first-child, the only reason we should care is that some layouts might not cause issues, so I tried to ensure rounded corners only show up in catbg and titlebg heads, but in any case, it's no big deal. Who cares about round borders in 2013, anyway? (Memberlist.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Paid / Permissions / Plugins, Merge, MessageIndex, Notifications, PersonalMessage, Profile, Recent, Who, index.css)

- Similarly, removed all scope="col" occurrences. I don't know where it originated from, but basically, in a table, all th tags automatically apply that scope if they're in the first row, so there's no need for these. (TEMPLATES: Admin, GenericList, ManageInfractions / Members / Moderation / Plugins, Memberlist, Merge, MessageIndex, Notifications, Profile, Recent, Reports, Themes, Who)

* Anti-spam question tables were a bit too rigid, breaking easily in narrow widths. (Admin.template.php)

* Forced a vertical scrollbar on all pages, to avoid strange sidebar behavior on short pages. (index.css)

* Layout tweaks on ViewQuery MySQL queries. (ViewQuery.php)
Re: New revs
« Reply #2215, on August 15th, 2013, 01:50 PM »
rev 2215 -- manage attachment area, reworked. This is frontend only, even though it's backend... It's complicated ;)
(5 files, 4kb)

! The (relatively old) alert/confirm rewrite broke the attachment manager, so after successfully rewriting the reqWin code to account for that, I realized that a single admin area wasn't worth the script's 100+ extra bytes, and removed the preview entirely. Instead, I'm showing a small thumbnail for all images, and it's much, much more usable now. Also removed the extra classes that made the attachment manager less sexy, in my opinion. (ManageAttachments.php)

* Added a 'nh' (no hit) parameter to attachment downloads, allowing to force the hit counter to keep quiet. This was needed for the thumbnails above, of course. (Dlattach.php, ManageAttachments.php)

! We need to determine whether windowbg or windowbg2 are the 'default' backgrounds when not alternating, really. (ManageAttachments.template.php)

! Typos and so on. (Admin.french.php)

! Forgot to commit a file in the last revision, oops. last_th stuff, if you'll remember. (Themes.template.php)
Re: New revs
« Reply #2216, on August 15th, 2013, 01:55 PM »
rev 2216 -- crumbs.
(6 files, 3kb)

+ Added a .tinytext class that's even smaller than .smalltext (I used it in the last commit, but forgot to include it), and fixed some rules here and there. (PrintPage.template.php, extra.ios.css, index.css, report.css)

* Spacinazi. (Profile.template.php)

! Oh, and another file I forgot... Still last_th-related. (extra.rtl.css)
Re: New revs
« Reply #2217, on August 15th, 2013, 02:31 PM »
rev 2217 -- most online, buh-bye.
(4 files, 3kb)

* Now hiding 'most online' statistics for non-moderators, as per our discussion at wedge.org, where it was established that this kind of data is only of interest to forum owners, and might be discouraging if a forum's peak activity is long gone, yet still has loyal activity. Anyone ever been slashdotted..? (Stats.php, InfoCenter.template.php, Stats.template.php)

+ Added support for border-top-left-radius and other directions, more specifically, adding prefixes to them if the user is on a very, very old browser that's not IE. Silly, eh..? Well, might as well account for everything, I say. (Class-CSS.php)

@ I think I addressed all areas, but I didn't test thoroughly, so please make sure to apply the same treatment to anything else you can find, really..!
Re: New revs
« Reply #2218, on August 17th, 2013, 11:17 PM »
rev 2218 -- various mobile/layout related fixes or improvements, yay. This one deserves a Like, right..?
(4 files, 4kb)

* Found a better technique to fix the code tag's flex bug. Instead of setting overflow-y to scroll, I'm simply setting flex to none, which technically doesn't make it sense at all, because it's the default at this point, but it looks like Chrome insists on silently applying some non-default flex value on all flex children, which is a very bad idea, if you ask me. (topic.js)

+ Added support for the Android 'simulator' in Chrome, i.e. recognize their custom user agent as an Android device, even though it doesn't have any Android-specific element in it, e.g. 'mobile'. (Class-System.php)

* Mobile skins shouldn't show the entire topic title, in some situations. It often breaks layout, so... Shortened the message titles to 20 characters, and did the same to previous/next topic titles, which works better, for me at least. (Display.php)

- Do not soft-merge posts in mobile skins. It's not that it's not doable... It's mainly down to the fact that it's pointless, because there's nothing to remove, apart from the avatar and user name, which are optimized not to take any further space, so... No need to waste CPU cycles on this, I'd say. (Subs-Template.php)

@ Regarding topic titles, I actually pondered whether to use we::is('mobile') or SKIN_MOBILE. The first applies to mobile devices only but in all skins, while the second applies to all devices, but in mobile skins only (e.g. Wireless). In the end, I decided that since non-mobile skins usually render badly on mobile devices, it's not worth doing on these skins anyway. I'm very, very open to changing my mind, though.
Re: New revs
« Reply #2219, on August 19th, 2013, 08:38 PM »
rev 2219
(2 files, 1kb)

+ Here's a rare thing: an attempt of mine at increasing security, which is usually Pete's thing. This is probably overkill (an isset test on all pages, to test for something that's admin-only, and probably never an actual risk anyway), but at the very least, I think it's worth discussing keeping it in or not. (index.template.php)

! A typo in a callback name generated errors when editing a post. (Class-Editor.php)
Plugin revs »