New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2100, on May 9th, 2013, 01:09 PM »
rev 2100
(6 files, 7kb)

* Merged two isAllowedTo calls into one. (ManageErrors.php)

! Fixed issues related to http-equiv refresh calls. One was a typo dating back to old SMG days I think; the other was conceptual: if you have a semicolon in your URL (which is likely given you're using Wedge, right..?), you don't *need* to turn it into an ampersand, you just need to surround the URL with single quotes... Yup, that was all... (Aeva-Gallery2.php, ManageMedia.php)

* More French translations. Also fixed an issue with 'pre-set' vs 'ad-hoc' in French. (Admin, ManageInfractions, Profile)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2101, on May 9th, 2013, 05:54 PM »
(13 files, 4KB)

Revision: ALL YOUR REVISIONS BELONG TO US because in AD 2101...
Author: arantor
Date: 09 May 2013 16:52:53
Message:
! Calling functions statically that are not declared statically is bad. (Subs-Admin.php)

! The credits function is never called outside of being an action. (Credits.php)

! The old support and credits page has been gone for a while but for some reason the template was hanging around, uncallable. (Admin.template.php, Admin and Help language files)

! Spacinazi (ModerationCenter.php)

! Display the user's multiple badges in the profile. The profile template needs an overhaul sometime though. (Load.php, Profile.template.php)

! Minor tweaks to moderation centre/reported posts, providing information pulled from the DB but never displayed before, also improving i18n slightly. I did set up the French strings but I may not have done it properly :/ (ModerationCenter.template.php, ModerationCentre language file)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2102, on May 9th, 2013, 06:31 PM »
Was waiting for Pete to use that rev number... :P

rev 2102
(8 files, 8kb)

! Popup height fix didn't work properly on Android devices with a HD screen, due to screen.height being a wrong value for compatibility purposes, or something. Gave up and replaced with window.innerHeight, and I don't care if it's off by a few pixels... It shouldn't be. (script.js)

! Fixed error log's file viewer sometimes giving you a login confirm box. Because the popup wasn't designed to hold these, I've rewritten the admin check code to determine whether it's called from Ajax (as in the file viewer), and if yes, silently redirect the user to a full page. Better than a broken form, really..! (Subs-Auth.php)

- Removed forced windowbg on help popups; this would cause some bad styling when the popup is shown as a full page. This breaks styling on IE7, which I don't care about, because it just goes to show how IE7 is buggy... I'll fix that later, yay. (GenericPopup.template.php)

* More French translations. Fixed mc_warned_users_points string, which wasn't in the original commits (good thing I checked the English version for once...) (Errors, ManageInfractions, ManageTopics, ModerationCenter, Profile)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2103, on May 9th, 2013, 11:13 PM »
(6 modified, 1 new folder, 10KB)

Revision: 2103
Author: arantor
Date: 09 May 2013 22:12:33
Message:
! Likes were broken if for any reason you tried to immediately follow up on an (un)like with a reverse of it because the return value was not passed through the buffers, so return_raw() is out, but because return_text flushes buffers first, we have to start a new buffer, capture the content, then pass it to return_text(). Either that or rewrite the template to return values and then output from wherever it's called from. I'm satisfied with what I've done for now though. (Like.php)
+ Contact list is now shown in the PM area, allowing you to send a PM to/bcc your contacts. As I intimated I'm not overly happy with the JS I've done here, it feels fragile and ugly and yet more organised than before. Feel free to rewrite/refactor/ignite. (PersonalMessage.template.php, PersonalMessage.template.php, pm.js, index.member.css, PersonalMessage language file)
! As discussed, a new folder for notifiers to be put into for organisation. The folder needs to exist before SVN will accept the move. (notifiers)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/PersonalMessage.php
Added : /trunk/Sources/notifiers
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/skins/index.member.css
Re: New revs
« Reply #2104, on May 9th, 2013, 11:15 PM »
(1 modified, 1 moved, 1KB)

Revision: 2104
Author: arantor
Date: 09 May 2013 22:14:54
Message:
! Move likes notifier to notifiers folder - we'll have more in future. (Notifications.php, Class-NotifierLikes.php)
----
Deleted : /trunk/Sources/Class-NotifierLikes.php
Modified : /trunk/Sources/Notifications.php
Added : /trunk/Sources/notifiers/Class-NotifierLikes.php (Copy from path: /trunk/Sources/Class-NotifierLikes.php, Revision, 2100)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2105, on May 9th, 2013, 11:41 PM »
(What? Likes are broken?! I need to look into that code... Will have to do that tomorrow, though.)

rev 2105
(10 files, 6kb)

! Some fixes for popup dimming in oldIE, and removing support for responsive design in IE6/7, because it's just too messed up. Keeping it in IE8 because it's more sensible. Also fixed main menu position in IE8 (it still has a glitch, but I don't care at this point), and table-layout not being needed in IE 6/7. (Load.php, index.css, sections.css, Wine/extra.css)

! Had a hardcover responsive media query value left in... (extra.rtl.css)

! Some nbsp-related fixes. Basically, what happened is that I noticed in my Win XP virtual box that IE doesn't support Unicode 3.0 entities in there; the same in Windows 7 work fine. And any other browser in Win XP seems to work fine. So that's just that combination... I threw in mobile devices in the process, because I can't be sure whether they support it, as it's probably not too memory efficient, so whatever, it's just the pedantic French translator talking and making everyone else waste a CPU cycle with a str_replace that will wield no results. I'm odd. Pete, you have my authorization to add a language test before it, if you want, because it's unlikely any other translator will use my obscure entity... ;) (Subs-Template.php, Admin.english.php (sic), ManagePlugins.french.php, ManageSettings.french.php)

* More translations. And I'm far from finished, since I have ManageInfractions left to complete... Hmmmmmmmm. (ModerationCenter.french.php)
Re: New revs
« Reply #2106, on May 10th, 2013, 12:49 AM »
rev 2106 -- just all my remaining fixes before going to bed.
(5 files, 2kb)

! In the end, IE7 *did* need that table layout rule... (index.css)

! And IE8 still had issues with its main menu. I finally figured that I needed to disable the filter for it to work. Uh... (extra.ie8.css)

* Translation. (PersonalMessage.french.php)

* Commenazi. (Security.php)

* Optimization of JS code. Saves 0 bytes. Happens even to me. (pm.js)
Re: New revs
« Reply #2107, on May 11th, 2013, 06:35 PM »
rev 2107 -- with another one coming up in a few minutes.
(4 files, 2kb)

! Fixed a bug where URLs like /profile/?u=123 would ignore the u parameter (member ID), and instead redirect to your profile. (QueryString.php)

* No need to define that variable..? (ManageBans.php)

* Pedant optimizations. Really, I'm not even sure it saves time... But don't complain too much; I could have used a single-line call_user_func on that variable function, saving three lines but doubling execution time by, err... Half a micro-second per pretty URL filter. I told you, it's a pedant optimization. (Subs-Template.php)

* Commenazi. (PrettyUrls-Filters.php)
Re: New revs
« Reply #2108, on May 11th, 2013, 06:36 PM »
rev 2108 -- okay, maybe not 'a few minutes' after all... More like a few seconds.
(5 files, 6kb)

+ Added a new return_* helper function, return_callback, which accepts a string representing a function name (usually a template), followed with an array of arguments (or nothing). This allows you to use the return_* system with a function that will echo its output, instead of returning it in a string. Replaced Like handling with this. (Like.php, Subs.php)

* Rewrote pm.js "my way", with Pete's blessing. This saves about 500 bytes, and 150 when gzipped. Not bad for something that does exactly the same... (pm.js)

! Minor auto-suggest bug. Item count shouldn't be increased if the hook called right after it decides to prevent adding an item... This wasn't found until now, because no hooks were called so far anyway... (suggest.js)

! And they wouldn't have worked anyway. Fixed a sorry bug where I was calling the hook with .call(function), instead of .call(this, function). And that was an old one..! (suggest.js)

! overflow-y: scroll always shows a scrollbar, even if you don't have many contacts. Fixed to overflow-y: auto. (index.member.css)
Re: New revs
« Reply #2109, on May 12th, 2013, 12:13 AM »
rev 2109 -- before jumping to bed...
(5 files, 2kb)

* More pedantic optimizations. Despite everything you'll hear, strpos($str, $substr) === 0 is slower than $str[0] === $substr. Deal with it. (Class-Package.php, ManageErrors.php, QueryString.php, Security.php)

* Commenazi. This one's for Pete... ;) (Subs.php)
Re: New revs
« Reply #2110, on May 12th, 2013, 07:33 PM »
rev 2110
(3 files, 3kb)

! Fixed JavaScript errors in Thought threads, when at least one of the thoughts in the thread was deleted. Wedge was showing an action menu for these... (Thoughts.template.php)

* Finished translation... Phew! I hope I didn't forget anything. Also fixed a typo in the English version. (ManageInfractions.english.php, ManageInfractions.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2111, on May 13th, 2013, 01:02 AM »
(51 files, 34KB)

Revision: 2111
Author: arantor
Date: 13 May 2013 00:02:22
Message:
! New user sanction: scrambling the letters of each word except the first/last letter. (ManageInfractions.php, Subs-BBC.php, ManageInfractions.english.php)
! New admin page for configuring the bbc editor. The plan is to have a drag 'n' drop thing to move the buttons around too but I haven't gotten to that yet. Apologies, Nao, code is a shade ugly :( (Admin.php, Class-Editor.php, ManagePosts.php, editor-func.js, editor.js, Admin and ManagePosts language file)
! Refactored parse_bbc semantics, as documented in Subs-BBC.php. This new setup allows us to expand upon things like not parsing embeds for signatures into things like not parsing embeds for feeds too. Just a thought. I don't think I broke anything, I checked for syntax errors everywhere (automatically) and checked the list of parse_types, should be all good. (all the other files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-ModCP.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/Thoughts.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.french.php
Modified : /trunk/Themes/default/scripts/editor-func.js
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/root/install.sql
Re: New revs
« Reply #2112, on May 13th, 2013, 02:49 AM »
(2 modified, 6KB)

Revision: 2112[1]
Author: arantor
Date: 13 May 2013 01:48:08
Message:
! Actually get the board index using the last report and last group request. I am aware the count is still wrong for requestable groups but that's mostly down to the current fundamental flaws in requestable groups. (ModerationCenter.php, Subs-BoardIndex.php)
! Don't show the group requests option in moderation centre if there aren't any requestable groups at present. (ModerationCenter.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-BoardIndex.php
 1. I want my life back, Jeff Minter! Llamatron stole too many hours from me as well as Revenge of the Mutant Camels!

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2113, on May 13th, 2013, 12:31 PM »
rev 2113 -- a helpful commit with an unlucky rev name, ahh, shit happens :P
(7 files, 5kb)

! Disabled that annoying font boosting in Chrome for Android, which has been killing most, if not all, forum systems by making short posts tiny and long posts huge (wouldn't the *other way around* make more sense, really...?) I believe Wedge is the first to 'fix' it, but I wouldn't bet on it. The fix is actually documented if you search for long enough. I've adopted the shortest possible fix that worked on my S3, but will keep doing more tests. Need to test on my iPod as well... Haven't turned on that one in a loooong time... (index.css)

! Fixed notifications generating JS errors in oldIE when polling for new results. Also saves 2 bytes from the final file... (script.js)

* Given that personal_text is no longer directly linked to thoughts, I figured it should revert to its original title... Or not? (Profile.english.php, Profile.french.php)

* Translation. (Admin.french.php, ManageInfractions.french.php)

* Spacinazi. (Display.php)

@ I wrote the scramble code from rev 2111... It was a quick idea and only took a few minutes to implement a basic version, but I still want the credit, eheh :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2114, on May 14th, 2013, 06:24 PM »
(83 files, 7KB)

Revision: 2114
Author: arantor
Date: 14 May 2013 17:23:27
Message:
! Removing the << toggle from the areas with generic menus. (Admin.php, Subs-Menu.php, GenericMenu.template.php)
! Getting rid of an old friend from the moderation centre, related to the old warning system. (ModerationCenter.php)
! Getting rid of what look like some unused global variables. I haven't been able to get errors out of anything with this. (all files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/Class-Media.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/Sphinx/SearchAPI-Sphinx.php
Modified : /trunk/other/Sphinx/sphinx_config.php

(I have a feeling the Sphinx stuff will become a core feature at some point, just needs some updating and tweaking)
Plugin revs »