New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2085, on May 2nd, 2013, 03:31 PM »
(3 files, 2KB)

Revision: 2085
Author: arantor
Date: 02 May 2013 14:26:16
Message:
! Daft as it sounds, you couldn't actually delete an individual ban from the ban's edit page, which is a shame if you're coming from the profile area which links to the specific bans currently applying to a user's account. (ManageBans.php, ManageBans.template.php, ManageBans.english.php
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Re: New revs
« Reply #2086, on May 2nd, 2013, 03:37 PM »
(4 files, 2KB)

Revision: 2086
Author: arantor
Date: 02 May 2013 14:36:56
Message:
Yay for thematic commits![1]

! The changes to the manage boards area for the moderation category as well as the new ignorable boards option. Of course, the support for the rest of this is not yet finished but every little bit I can commit helps, right? (Class-System.php, ManageBoards.php, ManageBoards language file)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.french.php
 1. I should have put that here rather than in the actual changelog >_<
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2087, on May 4th, 2013, 10:19 AM »
rev 2087 -- a few things before the oncoming storm...
(4 files, 3kb)

! Fixed JS not correctly updating the number of notifications in the header, when marking an item as read or receiving new notifications. (script.js)

! Fixed thought reply process hiding the parent thought, instead of showing the form next to it. (script.js)

! Fixed this annoying bug I used to get in the error log, with popups not showing up despite the screen being dimmed. This was apparently due to $(window).height() returning a huge value, probably the equivalent of the body height, and thus showing the popup below the visible viewport. I fixed this by using window.innerHeight instead, but it's less precise because it includes horizontal scrollbars (if there are any, which is unlikely, but meh.) Used screen.height as a limiter instead, so it should at least make the popup accessible, at worst by maximizing your window if it's not already maximized. Feedback welcome... (script.js)

* Only show Mark Read buttons on unread notifications, duh... (Notifications.template.php)

* French translation. (ManageBans, ManageBoards)

Note to Pete: perhaps you never noticed (it took me a while to see it, as it was a new TortoiseSVN feature in 1.7 or something), but you *can* edit your SVN changelogs now, even the old ones... :)
Re: New revs
« Reply #2088, on May 5th, 2013, 02:56 PM »
rev 2088 -- and here we are... The Big Fix for CSS keywords.
(11 files, 22kb) (88, 11, 22... A pattern?!)

* And another huge overhaul of Wess and the system class... Basically, we::$browser['is_*'] is now we::$browser['*'], and all of the we::$user['is_*'] variables are moved to we::$is['*'], to make them clearer to differentiate from non-boolean $user variables, basically. Finally, we::$browser OS variables are moved to we::$os, including the we::$os['mobile'] boolean, which is an alias to we::$is['mobile'] anyway. Got it..? (Class-CSS.php, Class-System.php, Display.php, Load.php, Notifications.php, Post.php, Post2.php, Profile-View.php, RemoveTopic.php, Subs-Cache.php, Subs-Template.php)

* CSS suffix overhaul. I'm no longer initializing a css_suffixes array, and instead using the system class's properties directly. This saves nearly 2KB in Load.php, really... Also added support for all kind of tests within filename suffixes, so basically index.!(opera && windows).css is now a possibility... If you're crazy enough, of course. (Load.php, Subs-Cache.php)

* CSS file caching should now be working properly for board and category IDs tested against within the CSS file itself. I spent an awful lot of time on it, and I'm pretty sure not many people are going to find this of use anyway, but I wanted to harmonize the list of keywords available between filename suffixes and @if tests. Also saves about 700 bytes of code. (Class-System.php, Subs-Cache.php)

+ Added support for the | (logical OR) delimiter in CSS tests (not in filename suffixes though, as | is not a valid filename char). You can use a comma, or |, or ||, whatever you prefer, I'm not going to judge. (Class-System.php)

! The system class could never hold board information, because loadBoard is called after it... And not only that, but I was globaling $board instead of $board_info. Anyway, fixed and moved to loadBoard instead... (Class-System.php, Load.php)

@ Note... Support for the replace keyword was rewritten, and is untested. Might go away at some point. Same for fallback folders -- it wasn't rewritten though, just left to rot. Also, the local keyword still won't work inside CSS files. And finally, plugin CSS wasn't rewritten either, and instead I chose to remove support for filename suffixes for them; I have yet to see them used by someone else than me, and I'm fine with it.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2089, on May 5th, 2013, 05:25 PM »
3 modified, 2 added, 60KB[1]

Revision: 2089
Author: arantor
Date: 05 May 2013 16:24:19
Message:
! I think I'm happy enough to commit this now. It still can't be called, but it's one less set of things to forget. (ManageInfractions.php, ManageInfractions.template.php, install.sql)
! Revised wording, seems to flow better. (ManageInfractions.english.php)
! Moved this scary function. (Subs-Scheduled.php)
----
Added : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/Subs-Scheduled.php
Added : /trunk/Themes/default/ManageInfractions.template.php
Modified : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/root/install.sql
 1. You remember I said the warning system was big and scary and driving me crazy? This is why. And, frankly, this is still only a fraction of it. As per my other posts, this is why my temper is much shorter than usual.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2090, on May 5th, 2013, 06:12 PM »
rev 2090 -- woot, need to check out your rev, Pete!
(3 files, 1kb)

! Undefined index error. (Class-CSS.php)

! Undefined variable error. (Subs-Cache.php)

! array_flip warning. Oops, definitely not my day... (Subs-Cache.php)

* More breathing space for the header in Wireless. (Wireless/extra.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2091, on May 6th, 2013, 06:33 AM »
43 modified, 1 added, 135KB[1]

Revision: 2091
Author: arantor
Date: 06 May 2013 05:32:14
Message:
! It's late, I'm tired and I think I finally finished this stuff into something I can at least commit, even if it is a modest distance from perfect, even it's not entirely finished or battle tested. I just want to be able to commit it and have a proper good night's sleep for the first time in a month. Yes, there are bugs, there are unfinished bits, but committing it will at least allow me to figure out what's next. There is, as far as I know, nothing actually outright broken here. Just things that don't work properly or at all (as opposed to error vomiting). And now I can go to bed and try and find some of my sanity again.

Amongst the warning system, there's various other oddments relating to the moderation centre, the plugin loader and some other stuff.

IMPORTANT: When this is deployed, you should disable all plugins PRIOR to uploading this, and then re-enable them AFTER uploading this. There are some important changes in the way plugin hooks are handled, to do with storing their paths properly. There's also overhauls to the hooks a little in here too which all seems to work properly for me and means language hooks reuse code nicely. Feel free to ask me when I wake up if there's anything you're not clear about. (Yes, I'm well aware that some stuff really is non functional, especially some of the stuff related to the mod centre overhaul. The full infraction log, for example, doesn't even exist yet. But right now I do not actually care. This has taken me a month to get done, along with the periodic commits along the way. I'm human; I have been weighed, I have been measured, and at times I found myself wanting.

If you want to play with it on a test installation before updating wedge.org that would probably be best.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Msg.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Profile.english-uk.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/pm.js
Added : /trunk/Themes/default/scripts/profile.js
Modified : /trunk/root/install.sql
 1. I wasn't kidding when I said that was only a fraction of it.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2092, on May 6th, 2013, 04:30 PM »
rev 2092 -- small fixes, and minor notification popup improvements. Anythin' to keep me from the work of going through rev 2091... :whistle:
(3 files, 7kb)

* Added a subtle hover highlight on the notification link. Main issue is that since I'm relying on CSS3 animations to show the popup, I can't do a proper parent hover because of this technicality when you start mov... err... Is anyone reading? Didn't think so. (script.js, index.css)

* Added another amusing little 3D effect on the notification popup. Just done with a box-shadow. Too much of a good thing probably, so it'll probably go away at some point, but in the meantime, have some fun with it, will you..? (index.css)

! Fixed skin.xml files not properly removing skin directives embedded within an <if> test. Sorry for not seeing this earlier -- this means that in the last few weeks, everyone visiting wedge.org was actually loading Open Sans from Google's font repo without it ever being used... Ah ah, silly me... (Subs-Cache.php)

! Fixed link breaker adding a '...' break effect on links that don't need to be broken, if user tries formatting their link from within the url tag, rather than outside of it. (script.js, index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2093, on May 6th, 2013, 04:32 PM »
2 files, 2KB

Revision: 2093
Author: arantor
Date: 06 May 2013 15:30:51
Message:
! Don't notify the user themselves that they have been softbanned. Also, tidy up the punishments warning when injected so that it really does reflect the true state of play. (Profile-Actions.php)
! Moderation category could cause errors, and be shown inappropriately, under some conditions. (Subs-BoardIndex.php)

@ And so it begins, first bugfixes to the warnings commit.
----
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subs-BoardIndex.php


@Nao: You can certainly understand now why it's been messing with my head :^^;: Hopefully I should be a bit nicer in future :)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2094, on May 7th, 2013, 11:43 PM »
Oh yes I do understand, Pete... ;)

rev 2094
(12 files +1, 32kb)

* French translation for infractions. ManageInfractions is only partial, I'll finish it eventually... Also, I have yet to test punishments, so I don't know if I should translate 'warnings' to 'sanctions' or just literally, 'warnings'... (Admin, Errors, Help, index, ManageInfractions, ManageSettings, ModerationCenter, Profile)

* Typonazi..? The Help one is for sure, but as for the other one, you tell me. I probably added some typos of my own to my French translation anyway, but shhh..! (Help.english.php, ManageInfractions.english.php)

! Notifications page wasn't taking into account your modifications. I'm talking about the page for the newest Notifs feature, not the old one, which we'll remove at some point... (Profile.template.php)

- JS function declarations don't need a closing semicolon, only anonymous functions require one. Also replaced all double quotes with single quotes. To be quick, any JS included within a HTML page should use double quotes for better compression, while single quotes compress better in stand-alone files. Only saves a few bytes, but that's a free change, so... (pm.js, profile.js)
Re: New revs
« Reply #2095, on May 8th, 2013, 12:29 PM »
rev Yours Truly 2095 -- She has an IQ of 1001, she has a jumpsuit on, and she's also a telephone. ♫
(4 files, 2kb)

* Helping mobile devices a bit; removing the body padding by default (I'm sure they'll appreciate the gesture), and removing the extra box-shadow animation on the notifications popup, as it seems to slow it down even on my S3 to the point that the animation no longer shows at all, meaning it's probably going to be jerky for all mobile devices. Without the extra animation, it's still barely visible, but at least it's there. (index.css)

* Said notif popup came a bit out of nowhere; changed it to drop from the notif title instead, as expected (and in line with all other dropdown animations.) (index.css)

* Changed z-index for mini-menu animations, to ensure they always come on top of main menu animations. While usually not an issue, this would give odd behaviors on search and notif popup animations when hovering the main menu while the animations were being performed. (index.css)

! Oops, fixed the *wrong* bug yesterday with regards to saving notification settings... (Notifications.php, Profile.template.php)

! Fixed button icon position in buttons for IE8. This was due to a hack that was no longer needed since the recent button code rewrite. It just goes to show how much I test under IE8... (extra.ie8.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2096, on May 8th, 2013, 02:21 PM »
(3 files, 1KB)

Revision: 2096
Author: arantor
Date: 08 May 2013 13:18:58
Message:
! Don't show Profile > Posts > Attachments if Attachments are disabled. (Profile.php)
! Remove is-writable test from setting language default. (This page may still be changed yet.) (ManageLanguages.php)
! If only variables should be passed by reference, let's give it a variable. (Aeva-Gallery2.php)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Re: New revs
« Reply #2097, on May 8th, 2013, 10:49 PM »
(5 files, 12KB)

Revision: 2097
Author: arantor
Date: 08 May 2013 21:48:46
Message:
! Remove-infraction widget was not set up properly meaning that it would never complete successfully. (Profile-Actions.php)

! A little housecleaning. (MoveTopic.php)

! New feature: ability to specify a new board when splitting a topic. It applies if you could conceivably have moved it after the event (and honours the same restriction about moving *to* boards). There is one edge case whereby if you have permission to move your own topics but not any topics, it will ignore that and just refuse you the option, but that's intentional. There is no shiny 'cool story, bro, but I moved ur topic' dialogue yet. (Split.php, Split.template.php, ManageTopics.english.php)
----
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Themes/default/Split.template.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Re: New revs
« Reply #2098, on May 9th, 2013, 04:38 AM »
(11 files, 14KB)

Revision: 2098
Author: arantor
Date: 09 May 2013 03:37:39
Message:
! Some housekeeping is needed before this is called, depending on where it's called from. (ManageInfractions.php)

! Per row styling is now available for generic lists. Just declare in the master definition which column from results should be used for additional classes, or inline styling, and if that column is present in a given row return, use it. (Subs-List.php, GenericList.template.php)

! Better wording for users who are looking at their own infractions list. (Profile.english.php, Profile.template.php)

! Renaming area=userwatch to area=warnings in the moderation centre (ModerationCenter.php, ModerationCenter.template.php)

! Bug fix for moderation filters; seems that providing .val(0) to a select doesn't work if 0 isn't actually an option in the selectbox, though it used to work, but passing .val("") works fine. (ManageModeration.template.php)

! General infractions log now in the moderation centre. Other places that are relevant (e.g. revoking from the log brings you back ot the log) also updated. (ModerationCenter.php, ModerationCenter.english.php, Subs-BoardIndex.php, Profile-Actions.php, Profile.template.php)
----
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php


@ I will probably update the infractions area in the profile itself to use a generic list now that per-row styling is available, it's the only reason I didn't previously.
Re: New revs
« Reply #2099, on May 9th, 2013, 05:37 AM »
(6 modified, 4KB)

Revision: 2099
Author: arantor
Date: 09 May 2013 04:37:06
Message:
! Wrong error string. (Profile-Actions.php)

! Improved handling of redirection notices. Specifically: when a redirection notice is now issued, an option is given to the user to automatically redirect. If that option is used, well, it'll do the redirect. Additionally, if the message has been moved to a board the user can't see, instead of the 'no access' message, there's now a specific error: "This topic has been moved to a board that you cannot access." (this is why the board number is stored, it's also used to figure out that hey, we did a redirect, it's just a bonus in that respect) Some minor reorganisation of display workflow was necessary to defer skeleton initialisation to after this was processed, but this shouldn't cause problems. (Display.php, MoveTopic.php, MoveTopic.template.php, Errors and ManageTopics language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageTopics.english.php
Plugin revs »