New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2070, on April 25th, 2013, 05:07 PM »
(15 files, 7KB)

Revision: 2070
Author: arantor
Date: 25 April 2013 16:05:22
Message:
@ Things I can commit without breaking anything else. And for the first time since I started on this hellish journey into the infractions/warnings/post moderation/post ban overhaul, conflicts. Two of them!

! English-UK fixes. (Help.english-uk.php, ManageMedia.english-uk.php, ManageMembers.english-uk.php, Themes.english-uk.php)

! Some otherwise unrelated changes for the benefit of the admin search. Note that the magic underlying logic is elsewhere and cannot be committed at this time due to other changes in the same file. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageRegistration.php, ManageSearch.php, ManageSearchEngines.php, ManageSmileys.php, Admin.template.php)

! Use the we_ wrapper function for json_encode. (Admin.template.php)

! Language files with *just* new strings, for translation purposes. (ManageBoards.english.php, ManageMembers.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english-uk.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2071, on April 25th, 2013, 06:58 PM »
rev 2071
(18 files, 4kb)

* Reordered smiley file cache. Not a big deal of a code addition, for a less than thrilling result (a dozen bytes saved), but as it's a free saving, and it took only minutes to implement, and it doesn't take more time to run, I'd say it's a good use of a few minutes... (Subs-Cache.php)

* Remembered that grepWin has a replace function, so I did the rest of the we::$is_member conversions... And checked them all manually, of course. (Login.php, Logout.php, MoveTopic.php, Poll.php, Post2.php, Profile.php, Register.php, RemoveTopic.php, Search2.php, Subs-Auth.php, Subs-Menu.php, Subs-Template.php, ViewQuery.php, SSI.php, Home.template.php)

* Minor CSS fixes. One looks complicated, and its only point is to save a couple of bytes and a console warning in Opera, hmm... (sections.css)

! Fixed thought template in mobile mode. (Thoughts.template.php)
Re: New revs
« Reply #2072, on April 25th, 2013, 08:09 PM »
rev 2072 -- POP! POP! (© Magnitude)
(6 files, 10kb)

* Finalized (hopefully?) the notification popup, where you can now choose on-the-fly between 'All latest' and 'latest unread' notifications. There are style a few hardcoded styles here and there, but no biggie, and these are Ajax-loaded anyway. (Notifications.php, Notifications.template.php, script.js)

! Fixed notification popup animation to what it was supposed to do... You're going to like that. Or not. Well, I do, so tough luck. Wait until I'm bored. (index.css)

! Sometimes, user has several tabs opened, then logs out of one, and other tabs still attempt to load notifications, but have no proper session to provide, and are thus kicked out. These do NOT need to be logged in the error log, obviously..! (Notifications.php)

! Fixed warn class commas, and turned some extends to mixes (I do that when it saves bytes). (index.css)

* Translation. (ManageBoards.french.php, ManageMembers.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2073, on April 25th, 2013, 08:48 PM »
(7 files, 7KB)

Revision: 2073
Author: arantor
Date: 25 April 2013 19:47:35
Message:
! Backend for saving and editing plugin language data. The caching part is in Load.php and as such I can't commit it just yet. (ManageLanguages.php)

! Who's Online should be a bit more consistent with the online list in terms of formatting. is-contact is still not rectified but that's a much larger battle anyway. (Who.template.php)

! Like action shouldn't actually be in the online log. (index.php)

! Clean up the current user's sanction state, simplifies checks later on. (Class-System.php)

! A few ban changes... namely moving a few things around for the admin search, but also to flush certain caches that will be updated in future. (ManageBans.php)

! Style changes. These are mostly likely to be final from my perspective, but could change. Not really worth optimising these *just* yet. Also reverts about 1/3 of r2072, namely all the changes that were conflicted in that file. (index.css, index.member.css)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2074, on April 25th, 2013, 10:57 PM »
rev 2074 -- easy peasy!
(4 files, 2kb)

+ Ajaxified the Like button for thoughts. It's a bit hackish, with back-and-forth between Ajax.php and Like.php, but if you can do better in less than 30 lines and 20 minutes of work, you call me. (Ajax.php, Like.php, Thoughts.php, script.js)

! Fixed wrong language string index. (script.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2075, on April 26th, 2013, 02:58 AM »
(2 modified, 3 added, 9KB)

Revision: 2075
Author: arantor
Date: 26 April 2013 01:57:34
Message:
! After some fiddling around, I realised that I could save 5KB of admin language stuff from being loaded every admin page by breaking it off into its own file, I actually prefer this to all-in-one dumping grounds if it's feasible, so I did it for Forum > Posts and Topics. I have NOT removed it from the admin language file in this commit, because I don't want to commit and leave other stuff broken. But locally I have removed that so only what should be in the admin file is in there. There *is* a new feature indicated here and it is currently being implemented, this is just the UI for it, 1 translation required in ManagePosts.french.php (ManagePosts.php, ManagePosts language files)

! Tweaked layout in admin search results. (Admin.template.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/languages/ManagePosts.english-uk.php
Added : /trunk/Themes/default/languages/ManagePosts.english.php
Added : /trunk/Themes/default/languages/ManagePosts.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2076, on April 26th, 2013, 11:08 AM »
rev 2076 -- had these optimizations around for some time, figured it'd be okay to commit them...
(4 files +32 image manipulations, 58kb)

! New thoughts could be empty, which is wrong. This is due to the latest rewrites, in which I added the ability to delete one's existing thoughts by editing them to nothingness, rather than using the Delete button. (Ajax.php)

* Optimized some image file sizes. Some of them were integrated into the CSS files, saving close to 200 bytes. Others aren't integrated, but that shouldn't excuse some of the (sometimes already optimized) files from being 100 to 300 bytes larger than they could be. Also of note, warning_mute doesn't seem to be used anywhere, but I'm not removing it because it might be hidden in some variable like $context['warning_status'].gif or something. I'll leave it up to Pete. (16 files in the attic, 16 in /images, including board status icons, warning icons, and Wedge footer logos.)

* I'm not convinced that warning icons should be integrated into the CSS. The only 'visible' difference between integrated and non-integrated is the extra HTTP hit, and I'm not sure warnings are a feature that is supposed to seen on every page... Is it? So I'm adding the no-base64 keyword to them, but it can always be reverted. (index.member.css)

* Admin intro could use some extra margin, I think. (mana.css)

* Translation. Eh... Sounds like a cool new feature for Wedge... ;) (ManagePosts.french.php)
Re: New revs
« Reply #2077, on April 26th, 2013, 03:31 PM »
rev 2077 -- another large commit with tons of changes made over the weeks... When is TortoiseSVN going to add cherry-picking, please..?
(6 file, 8kb) (very meager compared to the time I spent on these... :P)

@ By order of appearance in the index CSS file... (index.css)

! Fixed search popup width in IE6.

- Removed the Chrome hover/focus hack I added a few months ago, as the bug no longer seems to trigger in the latest versions. At least if it shows up again, this time I know where to look for a quick fix, eh...

* Moved .ie_button class to the IE6 file. We don't need to define it for other browsers, do we..? (Also, extra.ie6.css)

* Minor tweak to button styling in hover mode. Slightly better, I think...

* A NEARLY complete rewrite of the CSS and JS for main menus. The basic principle is the same, but I wanted to use a CSS-only image for menu arrows, instead of a GIF picture. This forced me to use alternate techniques, and add more bytes for IE compatibility, although I'm later planning to see if I can't just write a 'cleaner' version with more proper CSS, and have an oldIE-compatible version on the side, as an afterthought. Also, among the advantages of the rewrite: you'll no longer get 'stuck' menu arrows in menu animations, you can easily change the arrow color to match the menu's, the JS-free version actually behaves better (sub-menus are correctly located next to their parent entries, rather than at a fixed position next to them, which I always disliked), and the rewrite saves about 60 gzipped bytes of CSS and 90 gzipped bytes of JS, which is always nice... And more than compensates for the fixes and additions I made to the thought system in my last couple of commits. (Also, script.js)

@ And the other files...

! Fixed .pagesection showing scrollbars in IE6. (extra.ie6.css)

- Removed various IE6 and IE7 fixes for mini-menus and button backgrounds, as they were no longer needed due to the rewrite... Eh eh. (extra.ie6.css, extra.ie7.css)

* A few tweaks to Wine and Wuthering, to accomodate for the menu rewrite mostly, but also keep up with some other changes I made recently, and remove tweaks that were no longer in use. I don't always test these, maybe I should... (Wine/extra.css, Wuthering/extra.css)
Re: New revs
« Reply #2078, on April 26th, 2013, 06:55 PM »
rev 2078
(2 files, 5kb)

+ Another one of my hobbies... I've had this running literally for weeks on my local install, with no discernable issues, so I'm assuming my regex and general code is flawless. Implemented :matches pseudo-selector in Wess, in a way that you don't have to do it yourself, instead it will group your elements as efficiently as it can (it's far from perfect, but really, it's better than nothing), and only on browsers that support it, meaning mostly Firefox and Chrome, as usual. This doesn't save a lot, I'm afraid... But still, it's something like 100 or 200 bytes on the main CSS file, gzipped, and it's basically free, except for the processing at cache time, so there you go. (Subs-Cache.php)

! Oops, committed some debug styles, it seems... (index.css)

@ And there we are, most of my code is now committed. There are still a few things here and there, but I've got only 12 outstanding files left to commit (mostly changes that will never make it because I'm not sure about them), which is very, very little by my standards. Yay, now I can have a look at my to-do list again, ah ah... It's never going to end, I think... ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2079, on April 26th, 2013, 08:00 PM »
(4 files, 7KB)

This is a collection of bits I wanted to get committed and out the way so I could stop procrastinating by adding new features finish the infraction system.

Revision: 2079[1]
Author: arantor
Date: 26 April 2013 18:57:05
Message:
! Admin search now includes the likes page, such as it is, and now includes the page title of where your results come from, assuming the settings pages have been set up to do so - most have not, but I will fix that in future commits. (Admin.php)

! $helptxt value could be ditched on conventional language-cache loading under some circumstances. (Load.php)
! Plugin language files should also be loading from cache. This patch does NOT include the changes to language hooks. (Load.php)

! Permissions settings were doing a weird thing to get their title across to the settings page. There is a proper variable for falling back, let's use it. Also makes it searchable. (ManagePermissions.php)

! Make sure the admin pages pull up the help text from plugins a bit more properly. (ManageServer.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
 1. The year Judge Dredd graduated from law school.
Re: New revs
« Reply #2080, on April 27th, 2013, 06:29 PM »
(13 modified, 21KB)

More bits and pieces I have that can be committed without serious issues elsewhere.

Revision: 2080
Author: arantor
Date: 27 April 2013 17:20:45
Message:
! Sync security tests with those in BB 2.1.14 (only the relevant parts) (Security.php, Security.english.php)

! Hopefully all the error messages related to infractions. (Errors.english.php)

! Language strings for the moderation area on board index. (index.english.php)

! Dropping MSN/Live and adding Skype to the custom profiles templating stuff. (ManageMemberOptions.php, ManageSettings.english.php)

! Messages need a data column. (install.sql)

! Formatting options for membergroups. The text items were already added before. (install.sql, ManageMembergroups.php, ManageMembergroups.template.php, Subs-Cache.php, Subs-Membergroups.php, Subs-Template.php)

! Bolster the normal functions for adding to, editing and cleaning up the shiny new message data column. (Subs-Post.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/root/install.sql
Re: New revs
« Reply #2081, on April 29th, 2013, 01:40 AM »
(6 modified, 2 added, 19KB. I only dread to see the final commit for the rest of infractions system because of the many minute changes it makes.)

Revision: 2081
Author: arantor
Date: 29 April 2013 00:38:51
Message:
! Signature area needs the manage-posts language file. (ManageMemberOptions.php)

! Settings in Settings.php could sometimes disappear. (ManageServer.php)

! The original code assumed no clean-up would be applied on loading, but it is now. (Related code not yet committed. It's just one less than the mountain) (Subs-BBC.php)

! Imperative tasks' handler is slightly more useful. Also included an imperative task for later. This cannot be called in current trunk, nor would it work if it were, but the task might as well be committed now. (Subs-Scheduled.php)

! Moving of code out of the template and into the JS file that we already had. (Register.template.php, register.js)

! Mostly complete, if not fully complete, version of the infractions management language file. There will still be a ton for the profile area, but this is for the admin area and hopefully won't generate many/any more for the time being. Fingers crossed! (ManageInfractions.english.php, ManageInfractions.english-uk.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/Register.template.php
Added : /trunk/Themes/default/languages/ManageInfractions.english-uk.php
Added : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/Themes/default/scripts/register.js

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2082, on April 29th, 2013, 02:18 PM »Last edited on May 5th, 2013, 02:57 PM
rev 2082 -- just for the French audience. Okay... Just for me, then.
(34 files, 30kb)

* French translation. (Errors, index, Security)

* Updated all French language files to replace   (non-breaking spaces) with narrow versions ( ), which I just realized even works in oldIE... So, why bother using nbsp? Except for the extra byte it takes, which I can live with... After all, we just added another kilobyte to the index language file... (Hopefully not forever, eheh.) For those wondering, thin spaces are supposed to be shown right before any punctuation sign with at least two strokes, which basically means [?!;:]. (34 files)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2083, on April 30th, 2013, 01:39 AM »
(2 files, 1KB)

Revision: 2083
Author: arantor
Date: 30 April 2013 00:38:43
Message:
! Board selection from generic settings template needed a little tweaking. (Admin.template.php)
! Better handling of empty values for generic settings and fix an edge case where an empty value could be ignored. (ManageServer.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2084, on April 30th, 2013, 12:16 PM »
rev 2084
(3 files, 2kb)

! Fixed two woopsies in thought threads: likes not showing up (thanks to me not calling the template block for them), and mini-menus not working entirely, despite showing up (due to the Thought object not being initialized in that code path.) (Thoughts.php, Thoughts.template.php)

* Wedge doesn't need to go through obExit() to run ob_sessrewrite, as it's already added in the clean_output() process. So, no need to waste time running this, I'm sure the mail queue and track stats won't mind that Ajax calls don't trigger them... (Subs.php)

! Fixed return_raw() crashing, and thus failing to return thoughts and likes, due to an issue with ob_end_clean() and gzipping. Pete and I couldn't find the reason why it doesn't work there but works in other situations, such as file downloading, but it's all right, I can live with small Ajax returns being gzipped, I'm sure it has no influence over anything. (Subs.php)
Plugin revs »