New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1995, on March 14th, 2013, 12:29 PM »Last edited on March 15th, 2013, 12:18 AM
rev 1995 - Mesecina, mesecina, joj, joj! Joj, joj! Sunce sija ponoc bije, joj, joj! Joj, joj! Sa nebesa, zaproklija... Niko ne zna! Niko ne zna![1]
(8 files, 4kb)

! Yes, I know redirectexit() doesn't require <URL>, but if it's *forced* upon it, it would actually fail. So, fixed the function to accept <URL>, and dropped the test for 'about:', because I couldn't find any Wedge file that makes use of that, and can't think of any reason for a plugin to redirect to an internal browser page either. (Subs.php)

- Removed ;xml from a few remaining URLs. This is no longer needed, as all of our tests are done on the AJAX constant now. Or other variables (usernamecheck for instance). (post.js, register.js, suggest.js, topic.js)

* Saved over 50 bytes in topic.js by not giving a damn about oldIE. So, it no longer gets a hover effect in IconList..? Who cares? Have you ever seen a moderator/admin ever using IE6? Do you *want* them to be your own admin? Anyway... The location.hash trick is probably a leftover from dinosaurIE because it works in IE7 for me. Same for the width-forcing hack... IE7 doesn't need it. IE6, I probably won't bother to test anything anymore. (topic.js)

* Moved .iconbox and #iconlist selectors to the member file, as these elements are never available to guests. (sections.css, index.member.css)

* Minor cleanup. (Subs-Media.php)

:edit: Fixed a copy'n'paste disaster.
 1. It's a beautiful song from one of my favorite movies. I had, for a long time, a subdomain at cyna.net that was called 'mese'... For some reason ;)
Re: New revs
« Reply #1996, on March 15th, 2013, 12:17 AM »
rev 1996 - Dakishimete itai, subete wo wasurete, kiken na kurai Ray, kimi wo...[1]
(1 file, 1kb -- had more to commit, but wasn't confident enough in their stability.)

* Slightly optimized Pretty URLs handling, using rtrim() everywhere it can be used, instead of just in a couple of lines. (Subs-Template.php)

! PM viewing mode was broken... And apparently had been for a while... Because the quick URLs ended with a '=', and PURLs would 'optimize' and remove them. So, I rewrote the lines to prevent removing these if they're at the end of a URL. I couldn't think of a single case where this would be a problem... Then again, nobody ever noticed this was broken in the first place, right..? (Subs-Template.php)
 1. Okay, apparently I got it :P It's Ray, by Luna Sea. Another fantastic rock song. I'd love to quote more instrumental albums, there are so many, but that's gonna be hard... Stay tuned for rev 1997, which will probably have my last 'cult' J-Rock album. Oh, and I skipped X Japan's 1993 Art of Life. Shouldn't have. Okay, time for bed. Or the psychiatric ward.
Re: New revs
« Reply #1997, on March 15th, 2013, 03:18 PM »
rev 1997 - Around the world, around the world (bis repetita) / La vie est belle, le destin s’en écarte, personne ne joue avec les mêmes cartes / Rain down, rain down... Come on rain down on me, from a great height.. / Estuans interius, ira vehementi, estuans interius, ira vehementi, Sephiroth! Sephiroth! / Whatever I've done, I've been staring down the barrel of a gun... / Endless, timeless, faceless terror! To the isle of deadly shores! Sightless, countless, ageless torture! To behold the sight of Medusa's eyes / Baby I'll be good. Pray for me, Praying for the light...[1]
(8 files, 23kb)

! Fixed strict errors in post editor (add_button is a per-instance method, not a static one), and in captcha (both animated and sound). Rewrote create_led and paint_led to use the same parameters in both versions, but I'll let Pete decide whether to do a 'proper' rewrite of these -- maybe simply different function names..? (Class-Editor.php, Subs-Sound.php, captcha/captcha-ledicons.php, captcha/captcha-ledicons_anim.php)

! SFTP code had nearly 2 kilobytes of unneeded whitespace, and was missing newlines, or things like that. I think I fixed most of them, at least the ones that hurt the most... I'm going to have nightmares about this one for months. (Class-SFTP.php)

* Harmonized whitespace around $context['menu_separator'] and page index. (Display.template.php, index.template.php, PersonalMessage.template.php)
 1. And again, an excellent musical year... With plenty of great instrumental albums (Philip Glass's Kundun, Jean Michel Jarre's Oxygen 7-13...) and tons of others I loved. I should say that I listened exclusively to Japanese music between 1989 and early 1996, so in 1997 I really spent a lot of time 'catching up' with recent music. Okay, I'll be nice and tell you what I mentioned, since I decided to be more thorough (don't worry, 16 commits to go and I'll be back to my one-liner commit comments!)

Daft Punk's 1st album -- not the best but still;
IAM's best album (and also the best rap album I've ever listened to) "L'école du micro d'argent";
Paranoid Android, from Radiohead's best album and arguably one of the best and most influential pop albums ever released;
Final Fantasy VII's final boss song, need I say more??;
My favorite album from Depeche Mode;
Symphony X's The Divine Wings of Tragedy: one of my top 3 metal albums, the other 2 being released soon after... Maybe I'll mention them :P;
Craig Armstrong's first solo album was also fantastic, heck, even Yôko Kanno totally ripped him off over the years...
I wanted to quote Berserk's opening, but I'm not a big fan of it, I really prefer the instrumentals, which are gorgeous. Can't quote instrumentals, eh?
Re: New revs
« Reply #1998, on March 15th, 2013, 07:59 PM »Last edited on March 16th, 2013, 06:40 PM
rev 1998 - I'm coming to an end, I've realized what I could have been. I can't sleep so I take a breath and hide behind my bravest mask, I admit I've lost control. Lost control...[1] / Just you and I can find the answer. And then, we can run to the end of the world, we can run to the end of the world.[2] / Gin no shizuku wo nonda kara...[3] / Umaretara shinu nante, umaretara kieru nante, kurikaesu nante totemo fujouri...[4] / We will destroy all that you create, cause we are the trolls of invention.[5] / Aka kiiro himawaru. Daidai gunjou ajisai.[6]
(4 files, 2kb)

+ At a cost of only 16 bytes (thanks to some clever reordering, which should hopefully not break anything), Wedge's select boxes will no longer overflow out of your browser window if the box is too close to the right. Well, it does look like my to-do list for select boxes is finally completed... :) (sbox.js)

! Fixed admin menu icons, which no longer inherited .inline-block because, well, it's now a @mixin, so until I finally get to turns mixins into actual virtual classes, this will do. Well, it saves over 100 bytes doing it this way anyway... Can't believe I spent so little time testing mixin performance for widely used classes. (Subs-Cache.php)

! My <URL> fix for redirectexit() wasn't exactly too smart... And untested. Fixed that. (Subs.php)

* Tweaked media profile list layout. No biggie. (ManageMedia.template.php)
 1. Alternative 4 by Anathema... My second favorite symphonic metal album. I love it as much as 'Natural Disaster' from 2003.
 2. Xenogears. Best. Videogame. Ever.
 3. While this wasn't released in 1998, I have fond memories of listening to that song in loops while working on Kyodai Mahjongg. http://youtu.be/U8f3OBLUT1Q
 4. Missing Link, Utena final episode. Breath-taking song. Look it up!
 5. Next Time, by Yôko Kanno. So, I'm probably going to quote her songs a lot in future commits, I'm a devoted fan, and also one of the first to denounce her tendencies to plagiarize anything she can find, from Pink Floyd to obscure (in Japan) French artists. Still... Big fan, as I said. She's talented, she just doesn't have the faintest idea what copyright is, like Goran Bregovic. Another genius who upsets me from time to time. But I still quoted his Mesecina and went to see him live three times -- go figure.
 6. :edit: Added Gessekai by Buck-Tick. One of the best J-Rock songs. Also great: Sexy Stream Liner album (1997). And the subsequent live album.
Re: New revs
« Reply #1999, on March 15th, 2013, 10:45 PM »
rev 1999 - Jeune homme doucement, commence à comprendre, qu'on est seul dans cette vie, qu'on est seul dans cette vie.[1] / Jag hörde, en nostalgisk sång, någonstans långt borta.[2] / So what would Brian Boitano do, If he were here today? I'm sure he'd kick an ass or two. / Taan les tai la la la, la la loo. Morie taan mi fai es volta...[3]
(4 files, 3kb)

* Various CSS tweaks. Rewrote <hr> tags separating topic posts to have a class of 'separator' instead of 'post_separator'. Menu separators share the same class, but in a <li> tag, so this should help with gzip compression. Moved to styling the .root class instead of .postbg, this is more readable. Prevented said class to have a 'display: table' in case the flexbox model is being used. Moved .postbg2 margin to hr tags instead, this is way cleaner, although requires a few tricks thanks to stupid oldIE. Removed .flow_hidden margin again: what?! Removed #author styling, quite obviously a leftover from a very old version. (index.css, extra.rtl.css, sections.css)

! Post separators are there to separate posts. Yes. So there shouldn't be a separator AFTER the last post in a page... (Msg.template.php)

* Tweaked oldIE (and to a lesser extent, other browsers) positioning of status icons next to author names. (sections.css)
 1. Raphaël's first album, a gem of French pop-rock, which nobody heard. This song in particular is a classic. After his second album, he became a star in France and started releasing commercial crap. <Sad face.>
 2. Legend of Mana, by Yôko Shimomura. My favorite video game composer... And one of her best soundtracks.
 3. Moon, from Turn-A Gundam, by Yôko Kanno. Who else..?
Re: New revs
« Reply #2000, on March 16th, 2013, 04:59 PM »Last edited on March 16th, 2013, 05:57 PM
rev 2000 - Ranym-rano, da po nad chistym nebom, Podnimalosya oj da krasno solntse... / Rise my minions, from within the deep abyss my disciples, thunder this necropolis[1]
(10 files, 8kb)

* Tweaked media template. Added an extra layer to ease later styling. Removed the last remaining <input type="text"> and window.location entries. Harmonized the action bar with other action bars in Wedge (including the HTML stuff). Moved it below the picture, next to the contextual sidebar. This is only a WIP, as I'm planning to use a flexbox for this as well very soon. I'm still unsure about the direction I should take for 'Report' etc. pop-ups. Will probably rewrite the code entirely. Plus, I need to fix the 'close' button... (Aeva-Gallery.php, Media.template.php, media.css)

- Unneeded echo call. (index.template.php)

* Moved the search popup width hack up a level, to also prevent non-advanced_search elements from overflowing. Incidentally, this also saves 8 bytes... Go figure. (script.js)

! Fixed topic title alignment. (sections.css)

! Fixed search button styling inside search popup in Wine and Wuthering. Same is ready for Warm, but it's being worked on. (Wine/extra.css, Wuthering/extra.css)

* A small tweak in merge icon alignment. I'm not even sure it's needed... (Wine/index.member.css)

* Commenazi. (Warm/skeleton.xml)

:edit: Forgot to mention the files / size :^^;:
 1. And that's it... Princess Arete, and my favorite metal album. The decade was off to a great start ;) Hopefully it'll be the same for Wedge! Oh, and I promise I'll keep my quotes to a minimum now. I had plenty other albums to quote, but I don't think anyone cares but me anyway :lol:
Re: New revs
« Reply #2001, on March 17th, 2013, 12:57 AM »
rev 2001 - Ce parfum de nos années mortes, ceux qui peuvent frapper à ta porte, infinité de destins : on en pose un, qu'est-ce qu'on en retient ? Le vent l'emportera...[1] / The variations we will find in space are almost infinite...[2] / Maybe I'm wrong, dreaming of you, dreaming the lonely night through... If it's a crime, then I'm guilty, guilty of dreaming of you.[3] / Why should I suffer for things that I never saw ? And if you know which way to follow, my soul's emotions I'll give you...[4] / Que voy a hacer je ne sais pas, que voy a hacer je ne sais plus, que voy a hacer je suis perdu, que horas son mi corazón...[5]
(15 files, 5kb)

* From now on, Wess will always imply that common.css (and its children) are included by default in each and every CSS file compiled by it. Which in turn allows you to use all of the virtuals defined in commons without having to wonder whether to include an extra file or not. An example is given in media.css... (install.php, Admin.php, Class-Editor.php, Load.php, ModerationCenter.php, Subs-Cache.php, media.css)

+ Added new Wess color function: stronger(). It acts as an alias to darker() or lighter(), depending on the current color's brightness. This will help you craft a custom color that stands out compared to other elements, whatever the current skin's palette is (dark or light). (Class-CSS.php)

* Renamed Wess some color functions, many for logical and spelling reasons: darken to darker, lighten to lighter, saturize to saturated, desaturize to desaturated. Also finally found a use for desaturated, ah ah. (Class-CSS.php, common.css, index.css, sections.css, Wine/common.css, Wine/extra.css, Warm/extra.css, Wuthering/extra.css)

! Fixed sidebar's search box in Warm. (Warm/extra.css)
 1. Noir Désir
 2. Children of Space, Jean Michel Jarre + vocals by Arthur C. Clarke (yes, that was in 2001.)
 3. 'Guilty', Al Bowlly, in 'Amélie Poulain'
 4. On Thorns I lay, 'Angeldust'. Not their best album, but 1999/2000 were crowded in the metal area and I can't forgive myself for forgetting them ;)
 5. Me gustas tu, Manu Chao. The same guy who guest-played guitars on 'Le vent l'emportera', first song in this list...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2002, on March 17th, 2013, 04:02 AM »
(6 added, 6 modified, 79KB)

Revision: 2002 - "All of my songs can only be composed of the greatest of pains / Every single verse can only be born of the greatest of wishes / I wish I had one more night to live"[1]
Author: arantor
Date: 17 March 2013 02:49:21
Message:
+ Notification system courtesy of Dragooon's BSD code, thank you :) (all files)
----
Added : /trunk/Sources/Class-Notification.php
Added : /trunk/Sources/Class-Notifier.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManagePlugins.php
Added : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/Profile.php
Added : /trunk/Themes/default/Notifications.template.php
Added : /trunk/Themes/default/languages/Notifications.english.php
Added : /trunk/Themes/default/scripts/notifications.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/root/install.sql
 1. Century Child was an epic album. Marco Hietala's first, and bringing up The Phantom of the Opera...? DAYUM. But this is from Beauty of the Beast, rather than Phantom. It seems to encapsulate a few things.
Re: New revs
« Reply #2003, on March 17th, 2013, 05:10 AM »
(5 files, 2KB)

Revision: 2003 - "And I know you feel the same / I've wondered all my life, if this moment comes / Would I know what to say? / Then you say nothing at all"[1]
Author: arantor
Date: 17 March 2013 04:06:03
Message:
! SQL doesn't like text columns having a default value. (install.sql)
! Notifications was using the wrong variable. (Notifications.php)
! Language page now has caching, just for Nao. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/root/install.sql
 1. And you said nothing at all, well I couldn't have said it better myself. Tonight the conversation takes the fall, just love me like you love nobody else. DAMN, Meat Loaf, just... Couldn't Have Said It Better. First ML show I went to see was this tour. Good times.
Re: New revs
« Reply #2004, on March 17th, 2013, 06:15 AM »
(38 files, 9KB)

Revision: 2004 - "A siren from the deep came to me / Sang my name, my longing / Still I write my songs about that dream of mine / Worth everything I may ever be"[1]
Author: arantor
Date: 17 March 2013 05:11:44
Message:
! Syntax error in the installer table, oops. (install.sql)

! There really is no reason to load $language as a global. There is absolutely no need that I can see for it being a global because even the error handling will fail to do anything differently whether it's available or not prior to $settings being loaded, so might as well. This does also make other things possible, like changing the default language without having to hack up Settings.php at all. I don't think anything broke - and there's a fallback in Load.php just in case of not-defined. I also tested the installer, which still fails to load JavaScript because of some error, but too tired to debug it properly now. But it does the tweaked language stuff right. (all files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/root/Settings.php
Modified : /trunk/root/Settings_bak.php
Modified : /trunk/root/install.php
Modified : /trunk/root/install.sql
 1. Holy hell. This song is the first Nightwish song I ever heard, and it still moves me, possibly more than anything else they've ever done. 2004's "Once" album has a long to answer for, hahahahaha. Though if pushed, I would probably argue Imaginaerum (the instrumental title track from their 2011 album) moves me almost as deeply.
Re: New revs
« Reply #2005, on March 17th, 2013, 06:38 AM »
(3 files, 2KB) Quick bug fixes before bed.

Revision: 2005 - "Do you know like we were sayin'? About the Earth revolving? It's like when you're a kid. The first time they tell you that the world's turning and you just can't quite believe it 'cause everything looks like it's standin' still. I can feel it. The turn of the Earth. The ground beneath our feet is spinnin' at 1,000 miles an hour and the entire planet is hurtling around the sun at 67,000 miles an hour, and I can feel it. We're fallin' through space, you and me, clinging to the skin of this tiny little world, and if we let go... That's who I am."[1]
Author: arantor
Date: 17 March 2013 05:32:19
Message:
! Another thing broken by my crazy language edit: default language can be set in two places. Haven't decided which I want to keep yet. (ManageLanguages.php)
! Comment was a touch out of date, heh. (Class-DB.php)
! Flags weren't shown; inline-block is a mixin not a direct extensible thing. (Subs-Cache.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Subs-Cache.php
 1. I couldn't find a good music reference but... IT'S DOCTOR WHO.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2006, on March 18th, 2013, 05:34 PM »
rev 2006 - It hurts to feel, it hurts to hear, it hurts to face it, it hurts to hide... / Television rules the nation... (bis repetita.) / It was me on that road. But you couldn't see me, too many lights out, but nowhere near here. / In the whole of the soul of Count Olaf, there's no love. When you see Count Olaf count to zero, then screeeeam and run away. / Je nous vois tous assis devant. Mais le front baissé, les épaules en dedans. Avec dans les yeux toutes les larmes d'avant.[1]
(33 files, 36kb)

* Clean-up job. Removed extra spaces, unneeded string concatenations, turned 4-space tabs into proper tabs, fixed a couple of British strings in the language files, etc. Note to Dragooon: please ensure your text editor uses tabs, not spaces ;) (index.php, Class-JSON.php, Class-Notification.php, Class-Notifier.php, Load.php, Mailer.php, ManageMaintenance.php, Notifications.php, Notify.php, Split.php, Subs-Membergroups.php, SSI.php, Display.template.php, index.template.php, Media.template.php, Notifications.template.php, Thoughts.template.php)

* Optimized notifications JavaScript and HTML for size and elegance, the usual Nao way. (Notifications.php, Notifications.template.php, notifications.js)

* Renamed WeNotif to weNotif. Wedge classes are named 'wexxx', so I'll just allow for the second ucfirst, but not the first. Also fixed 'initialise' method to read 'initialize'. I love British English, but our codebase just is American English-based. (index.php, Class-Notification.php, Class-Notifier.php, Load.php, Notifications.php, Profile.php)

@ A message for anyone providing JS code to Wedge (in this case, Dragooon). Please follow our conventions :) Okay, my conventions! It'll save me time later ;)
  - Also, one convention I inaugurated in Wedge is to only use '$var' variable names for jQuery objects, not regular strings/ints/bools.
  - return false instead of e.preventDefault and e.stopPropagation,
  - use <URL> instead of $scripturl, where possible,
  - use weUrl() instead of we_script,
  - use $.now() instead of +new Date() or whatever variation.
  - 'document.location' is also an error, it's a property of the window object. Which implies one can just strip it down to 'location'.
  - Also, custom event data: that's a very neat feature, but my tests show that it doesn't help with compression, and more importantly, you don't need to save variables that are in the parent scope. They're still available in the event! So there's no need to store them, AFAIK.
  - I have to admit I haven't tested the results, but the resulting JS file is nearly half the size of its original commit's. Less than 700 bytes...
 1. Okay, in order: Archive, Daft Punk, Royksopp, Daniel Handler (aka Lemony Snicket), Yann Tiersen.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2007, on March 19th, 2013, 05:22 AM »
(3 files, 1KB)

Revision: 2007[1]
Author: arantor
Date: 19 March 2013 04:18:59
Message:
+ Language editing works. Doesn't work for plugins, but otherwise it works. (ManageLanguages.php, ManageLanguages.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


@ It's not pretty but it works as far as I can tell. I have to admit I'm not very happy, nor very proud of this, it's kind of ugly. And it can't even sanitise content - because raw HTML does get used in some strings and there's not a lot we can do that about.
 1. Did you ever hear what I told you?
Did you ever read what I wrote you?
Did you ever listen to what we played?
Did you ever let in what the world said?
Did we get this far just to feel your hate?
Did we play to become only pawns in the game?
How blind can you be, don't you see?
You chose the long road, but we'll be waiting

Bye Bye Beautiful, from Dark Passion Play, 2007

📎 langedit_2.png - 56.99 kB, 1000x1012, viewed 248 times.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2008, on March 19th, 2013, 09:19 AM »
Woohoo above ^

rev 2008 - Yeahhhh, shall I cut you down... Yes 'twould be a last physical communion, I'll be gentle! I'll be gentle! I'll be gentle! I'll be gentle![1] / Komonangayo Bandeko Makila Mabe Oyo...[2] / Sublime... Pour moi, c'était sublime.[3] / Tududum, tududum.[4]
(33 files, 7kb)

* I don't know why I was putting up with regex replacements in Wess's comma protection, when I could have just gone for a str_replace... (Class-CSS.php)

* Changed all files to americanize British endings (optimise, sanitise, colour, etc.) I'm not touching WedgeDesk though, as it's 100% Pete's thing, and maybe he wants to wave the British flag with pride on it. Or something ;) An important change is that I renamed wedit::legalise_bbc to legalize_bbc, and I couldn't be certain that the word 'legalise' isn't commonly used in the US. (30 files -- do they need listing..?)

! Missing $settings global in $language rewrite. (Are there other..? I only fixed the one I found in my error log.) (Subs.php)

* Commenazi. (index.php)
 1. Comus, 'Drip Drip', 1972. I missed that year but they performed it live in 2008 and it was recorded on an album so I'm using the opportunity, eh eh. As for the lyrics, they're a parody, don't be scared, I just happen to love the way the guy sings it! :lol: http://fox.noisen.com/4841/comus/
 2. These lyrics are totally my guess, I don't speak a word of Congolese and lyrics can't be found online... It's from Shadow by Papa Wemba, in Peter Gabriel's "Big Blue Ball", my favorite album of his since one of my two all-time favorite soundtracks, "The Last Temptation of Christ", in 1988. Which I, oddly, forgot to mention back in rev 1988. My other favorite soundtrack, even more oddly, is Shinku no Shônen Densetsu, a Saint Seiya movie, which was... my choice for rev 1988. That was a pretty good year for instrumental music...!
 3. Christophe[1], 'It must be a sign', in his beautiful "Aimer ce que nous sommes" album. I must also mention that it was his last album until yesterday, when he released a new one. I must get it!
 1. Whom you may know from a song in Kill Bill... I guess not! It was only an instrumental.
 4. Well, have nothing better to offer for The Dark Knight!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2009, on March 19th, 2013, 03:02 PM »Last edited on March 19th, 2013, 03:58 PM by Nao
(2 modified, 2 added, 15KB)

Revision: 2009[1]
Author: arantor
Date: 19 March 2013 14:01:46
Message:
+ English UK has landed. I will go through all the other files in time, to see what there is to be changed, but right now this is the only thing. Oh, and I don't even think the Info Centre string is used now anyway. (Flag.english-uk.png, index.english-uk.php)

! loadLanguage now bypasses the old switch-language callback and just loads English first before the other language, then caches the combined result. (Load.php)

! I don't like your accent, sir! (EmailTemplates.french.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Added : /trunk/Themes/default/languages/Flag.english-uk.png
Added : /trunk/Themes/default/languages/index.english-uk.php
 1. I have no pop culture references for 2009 :sob:

:edit: by Nao: which means I totally get to hijack your rev then!! :niark: I want to take you away with my feelings, and look you up till the highs of the Sun...[1] / Cast a revelation for the time of day, eventual panic attacks me. But I come back with a new determination. Knock wood, street solid rock, clock tick a time.[2] / I wanna go, go go, go right back again. I wanna give, give, give, give you everything.[3]
 1. This is was I managed to decypher, no lyrics available anywhere, and it has a lot of bass in it... Highs of the Sun, in "Institute of Joy", by A Mountain of One. Best pop-rock band of recent years -- and they split up since. :(
 2. Thought Conditioning, a great hip hop song from Archive's 2009 opus.
 3. And my favorite pop-rock song of that year... I can listen to it in loops. For hours. The last part is genius. It's "True to Life", by Royksopp.
Plugin revs »