New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1890, on February 1st, 2013, 06:06 AM »
(1 file, 7KB)

Revision: 1890
Author: arantor
Date: 01 February 2013 05:05:04
Message:
+ Ability to actually delete bans. This also entails the start of replacing updateBanMembers with a new version that figures out who is banned, who should be banned etc. and making all the changes. This is not finished yet. (ManageBans.php)
----
Modified : /trunk/Sources/ManageBans.php


@ It really isn't finished yet and needs to be before any alpha should ship with the updated ban system, simply because of the mess that will be made otherwise.
Re: New revs
« Reply #1891, on February 2nd, 2013, 05:37 AM »
(1 file, 7KB)

Revision: 1891
Author: arantor
Date: 02 February 2013 04:36:51
Message:
! Ban fixes. It can actually save the correct ban type now, and it should (in theory!!) check the state of bans when you change a ban so people who were hard banned, but should not be (for example) should then become unbanned. Needs infinitely more testing than I've given it thus far. (ManageBans.php)
----
Modified : /trunk/Sources/ManageBans.php
Re: New revs
« Reply #1892, on February 3rd, 2013, 03:19 AM »
10 files, 2KB[1]

Revision: 1892
Author: arantor
Date: 03 February 2013 02:19:04
Message:
! Removal of the old ban code. There's still the profile stuff to fix, but this is the old ban panel gone, including cleaning up the language strings as far as I can for now. (I think.) (ManageBans.php, ManageBans.template.php, language files: Admin, Errors, Help, ManageBans)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageBans.english.php
Modified : /trunk/Themes/default/languages/ManageBans.french.php
 1. Massive block delete is very small in SVN terns.
Re: New revs
« Reply #1893, on February 3rd, 2013, 04:29 AM »
(13 modified, 2KB)

Revision: 1893
Author: arantor
Date: 03 February 2013 03:27:05
Message:
! Did I mention that I love the @language embedding into script files? Set a default string from index, set it once and never have to explicitly set it again in any of the multiple places it is called (unless you *really* want to). All this for the 'delete item' help text on the auto suggest... it's the same everywhere, so just embed it in to the suggester as a default! It bugged me, mkay? (all files)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/ManageMedia2.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/scripts/suggest.js


@ And since it's now embedded in the suggest file, it will not only be gzipped and cached, it no longer has to be inlined into all the pages it's in, or declared in those pages where used. I would imagine that's actually a tidy little saving everywhere that uses the auto suggester, all in all. Every little helps.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1894, on February 3rd, 2013, 06:49 PM »
rev 1894 - jQuery... Can't live with you, can't live without you!
(23 files +2 -1, 182kb -- including 171kb of jQuery code.)

+ Updated jQuery from v1.5.2 to a dual v1.9/2.0, where 1.9 is used for IE 6/7/8 while 2.0 is used for other browsers. Also added support for beta and RC versions of jQuery by redirecting Google and Microsoft CDNs to the jQuery CDN if a beta version is requested (like for the current 2.0 release.) In case you're wondering, we're mainly upgrading jQuery because v2.0 is actually (for the first time!) smaller and tighter than v1.5.2. Yay. (Load.php, jquery-1.5.2.min.js, jquery-1.9.0.min.js, jquery-2.0.0b1.min.js)

* Changed .bind(), .unbind() and .andSelf() respectively to .on(), .off() and .addBack(), recommended methods in jQuery. Saves a couple of bytes off each file. (attic/Unused-SelectBox.js, attic/Unused-events.js, attic/Unused-tie.js, Admin.template.php, ManageModeration.template.php, Profile.template.php, mediadmin.js, player.js, sbox.js, script.js, suggest.js, topic.js, zoomedia.js)

* Changed .live() and .die() to custom .on() and .off() versions which should be faster. One occurrence was instead replaced with a .one() sent at editor creation time (remember that seldom used function..?), which is way more efficient than a live() call anyway. (Display.php, editor.js, editor-func.js)

* Turning some leftover <whatever /> tags to <whatever> in help files. (Admin.english.php, Admin.french.php, Help.english.php, Help.french.php)

* French translation. (ManageBans)

@ Just realized I posted this at 18:49 French time... That's an anagram of rev 1894 :p
Re: New revs
« Reply #1895, on February 3rd, 2013, 10:56 PM »
rev 1895 -- invented a new word! A day not wasted.
(9 files, 5kb)

+ Added a couple of menu separators in crowded submenus. (Admin.php)

* Updated jQuery UI to version 1.10, the latest available. (Subs-Cache.php)

* Rewrote sortable handler in Membergroup Badge and Order Pinned Topics pages to be more visible. Harmonized both sortable to use similar CSS. (Post.template.php, mana.css)

* Naoism: saving a microcycle. (Load.php)

* Naoism: comment typos. Also, Pete, you must have a 4K screen if you're able to read that MessageIndex comment without scrolling... ;) (MessageIndex.php, Pin.php)

* Naoism: slight changes to arrow color/size in menus and linktrees. Still not perfect, but it looks better than originally in Chrome. And since I'm no longer using Opera as my default browser these days (oh, how I miss you, good ol' Opera 9.2x days...), it's important to make them look perfect in the widest used browser. (What? IE? Never heard about that.) (common.css, index.css)

* Naoism: slightly less aggressive menu background color for IE9. I was about to use the same for Chrome, but I chickened out at the last minute. There's a barely noticeable delay in loading them... I'm wary of seeing older computers in pain. (index.css)

@ For those wondering, Naoism is the opposite of Taoism. It means that bickering about every little stupid detail is what life is really about.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1896, on February 4th, 2013, 04:07 AM »
(14 files, 6KB)

Revision: 1896
Author: arantor
Date: 04 February 2013 03:05:37
Message:
! Legacy code, missing check being called properly, stupid function not working as intended. (Security.php)

! One less variable injected inline. Potentially more could be done here but it's not pleasant. (Post.template.php, post.js)

! Profile now displays banned status properly, and some language cleanup as a result. (Profile-View.php, Profile.template.php, language files: index, Profile)

! Deleting accounts should clean up matching bans that would no longer apply. (Subs-Members.php)

! Newsletters shouldn't be touching the existing table, as such. If they're banned through username or their email, their account should be full banned anyway, no need to requery for that stuff, at least not there. (ManageNews.php)

! The old ban tables are now gone. Good bye. Good riddance. (install.sql, Class-DBPackages.php, ManageMaintenance.php)
----
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/post.js
Modified : /trunk/root/install.sql


@ Yes, this is almost entirely ban related. But since each of the different bits is a small part of the whole I delineated it, more for my reference later. (Thumbs down for Caesarness: the tables were not to survive. They have been tossed to the lions, who found them a bit chewy.)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1897, on February 4th, 2013, 04:44 PM »
rev 1897
(22 files, 6kb)

! Thank you very much jQuery, for being so obscure when it comes to the .attr()/.prop() change in v1.9. I'm not so stupid, but it was made very unclear that you reverted back to v1.6.0's behavior, and moreover it's totally erratical, e.g. doing .attr('disabled', true) still works. Nevertheless, I've taken the time to replace access to all of our boolean properties with a .prop() call or direct DOM access. This fixes a bug in the admin registration page, and most importantly a big one in the Select Box which was due to .attr('selected') not being taken into account. Here's hoping I didn't screw up anything else with my rewrites. (upgrade.php, install.php, ManageBoards.php, ManageMemberOptions.php, ManageNews.php, ManagePaid.php, ManageRegistration.php, ManageSearchEngines.php, ManageSettings.php, sbox.js, spellcheck.js, TEMPLATES: Admin, ManageBoards, ManageMaintenance, ManageMembergroups, ManagePaid, ManagePermissions, ManageSmileys, Packages, PersonalMessage, Profile, Register)

* Forgot to commit a portion of the sortable rewrite for membergroup badges. (ManageMembergroups.template.php)
Re: New revs
« Reply #1898, on February 4th, 2013, 04:45 PM »
rev 1898
(3 files, 71kb)

! The jQuery CDN (code.jquery.com) doesn't support HTTPS, so don't bother using it when that particular CDN is selected. (Load.php, Subs-Cache.php)

* Committed by mistake a custom minified version of jQuery 2.0... While it was about 600 bytes smaller than the official one, it didn't compress as well. Beats me. (jquery-2.0.0b1.min.js)
Re: New revs
« Reply #1899, on February 4th, 2013, 11:25 PM »
rev 1899
(3 files, 1kb)

! Fixed a jQuery 1.9-induced bug where editing a thought that had a smiley or a BBC tag would return an empty text string instead of the existing thought. Funny thing is, this fix actually removes 12 gzipped bytes from the script file... I'm the Wesley Crusher of gzipping. I pwn gzip, and people hate me for that. (script.js, Ajax.php)

* Just renamed a deprecated .error() to .fail()... Whatever. Looks like the jQuery team has a lot of time on their hands... ;) (topic.js)
Re: New revs
« Reply #1900, on February 4th, 2013, 11:39 PM »
rev 1900
(4 files +2, 7kb)

+ Preliminary implementation of the skeleton rewrite. This involves separating skin.xml skeletons into their own files, and removing the template_skeleton function from the index template, to be replaced by a (simpler?) skeleton.xml file in the skins folder. Currently, the only drawback is that you can no longer override a skeleton just with the magic of custom.xml, but OTOH I don't really see a reason for doing that, you're better off use <move> commands in that file. Perhaps I should also add custom.xml commands to <add> or <remove> elements from a skeleton..? (Load.php, Subs-Cache.php, index.template.php, skins/skeleton.xml, Warm/skeleton.xml, Warm/skin.xml)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1901, on February 5th, 2013, 12:11 AM »
(4 files, 9KB)

Revision: 1901
Author: arantor
Date: 04 February 2013 23:10:51
Message:
+ You can now like thoughts. It may require some more testing and likely some visual tweaks (e.g. making the link smaller maybe) but aside from slight ugliness of the code, it seems to work as expected. (Display.php, Home.php, Like.php, Home.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Home.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Home.template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1902, on February 5th, 2013, 05:12 PM »
Oh my, we need to do something about the like styling in thoughts... I guess it's going to force me to do my thought mini-menu earlier than hoped... :^^;:

rev 1902
(3 files +1, 35kb)

* Split Subs-Template's wetem object into its own file, Class-Skeleton. This was long overdue, especially considering it represented about a third of the more generic template code. (Class-Skeleton.php, Subs.php, Subs-Template.php)

* Moved <move> XML commands upstream, to avoid storing them in a variable for no reason other than legacy code. (Subs-Cache.php)

! oldIE has a very odd bug (who's surprised?), where it loads a CSS file twice if we linked to it without a protocol (i.e. //domain). Although it's unlikely you'd want to point to an external stylesheet in your code, it's still a possibility, so until further notice I'll be adding this extra regex to protect external stylesheets. (Subs-Template.php)
Re: New revs
« Reply #1903, on February 7th, 2013, 10:37 PM »
rev 1903 -- introducing weSkeleton, and fixing plenty of little bugs.
(7 files, 17kb)

+ Rewrote static 'wetem' class into dynamic class 'weSkeleton', allowing for multiple skeletons to be dealt with. wetem is now a separate (but still static) class dealing exclusively with the main skeleton, of course. So you can keep using wetem::load('block') or whatever. (Class-Skeleton.php, Load.php)

! Fixed IP address button (in profile mini-menus) not working at all, and actually even breaking JS entirely on the page. Took time to fix because the codepath wasn't triggered for admins... (Display.php)

! Fixed smileys regenerating their cache on... every... single... page... load. Thank... you... typos. (Subs-BBC.php)

! Fixed HTML validation for user status icons. Thanks... to... the HTML5 standard chickening out -- once again. (Display.template.php, sections.css)

! Fixed JavaScript not loading in Firefox 3.6 and below. This was due to jQuery 2.0 no longer being compatible with it... So we're now falling back to v1.9 for these, too. (Load.php)
Re: New revs
« Reply #1904, on February 7th, 2013, 10:44 PM »
rev 1904 -- doing this update separately so it doesn't increase the KB count artificially.
(+1-1 file, 238kb)

* Updated jQuery UI local version to 1.10, just like the remote versions. I don't know, though, if it's really a good thing to provide a 222KB minified file for local use... (scripts/jquery-ui-*.min.js)
Plugin revs »