New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #60, on September 7th, 2010, 09:00 AM »
It's no less straightforward than the prompt immediately before it, IMO, but I *am* a geek which means what sounds normal to me probably isn't, heh. I'll get my better half to look at it tonight.

It isn't actually mandatory, by design, so if people hit cancel on that prompt it gives them a url bbcode with the URL itself as the linktext.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #61, on September 7th, 2010, 11:40 AM »
It's just a matter of phrasing stuff correctly. I don't mean yours isn't correct -- just that it can be confusing.
I'm confused myself. With my post, not your phrasing. Or am I. Or is it.

I should go back to bed.
Re: New revs
« Reply #62, on September 7th, 2010, 12:14 PM »
rev 60
* Renamed files with mysql in the filename to make it more generic. (install.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php, detailed-version.js, Load.php, renamed: Db*-mysql.php to Db*.php, Subs-Db-mysql.php to Subs-Database.php)

--> I think "DbExtra.php" doesn't look good, but it's better than "DbExtra-mysql.php" which is redundant (MySQL *is* a Db.) Maybe "Data-Extra.php" or "Database-Extra.php"...? Dunno. It's not very important ;)

Okay, I should get back to my templating stuff now...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #63, on September 7th, 2010, 06:35 PM »
Revision: 61
Author: arantor
Date: 17:33:04, 07 September 2010
Message:
! Remove unnecessary board and threadid from quote bbc handler. (Subs.php)
----
Modified : /trunk/Sources/Subs.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #64, on September 7th, 2010, 10:56 PM »
rev 62
* URL prompt in editor should use [url] type instead of [url=] when no description is provided. (editor.js)
! Fixing on-the-fly rounded corners for IE when splitting topics. (SplitTopics.template.php)
* Minor stuff. (Recent.template.php, index.css, Subs.php)

--> when it comes to Subs.php, your modified regex had a "(?:topic)" in it... Just replaced it with "topic" ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #65, on September 7th, 2010, 11:04 PM »
Oh, yeah, nice optimisation there on the URL prompt, I missed that in passing.


As for Subs.php... I figured there had to be a reason it was there as a positive assertion so left it until I had a reason to remove it, really.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #66, on September 7th, 2010, 11:35 PM »
- editor: I was surprised to have noticed that myself ;D
- Subs: (?:topic) really does nothing. The regex engine will disregard it. The only reason to use (?:) is if you provide a quantifier after the parenthesis. (?:topic)? is logical. It's either topic, or nothing. (?:topic) means it's even topic, or topic. :lol:

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #67, on September 7th, 2010, 11:41 PM »
Subs: Not entirely... if it's part of a paranthesised expression, it won't be matched.

But yeah, it's irrelevant here :P

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #68, on September 7th, 2010, 11:43 PM »
I assure you that it means "topic or topic". :whistle:

Okay, bed time for me...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #69, on September 8th, 2010, 12:02 AM »
Sorry, I meant *captured* in the match. ((?:topic=)\d+) would only match the number in a backref.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #70, on September 8th, 2010, 12:32 AM »
No... "((?:topic=)\d+)" would return "topic=1", I'm pretty sure of it. (I wouldn't bet my life on it, but I'm still quite certain.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #71, on September 8th, 2010, 03:17 AM »
My bad, I was thinking of ?= rather than ?:, ?= is non matching assertion, ?: is a subpattern, so yes it would match that.
Posted: September 8th, 2010, 12:34 AM

Revision: 63
Author: arantor
Date: 02:16:59, 08 September 2010
Message:
! Add 'banned' to possible moderation statuses in display area (in addition to 'watched', 'moderated', 'muted'
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/warning_ban.gif
Modified : /trunk/Themes/default/languages/index.english.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #72, on September 8th, 2010, 02:36 PM »
rev 64
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
 ! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #73, on September 9th, 2010, 12:57 AM »
Revision: 65
Author: arantor
Date: 18:56:14, 08 September 2010
Message:
+ Add conversion from quick to inline full editor in Quick Reply (Display.php, index.css, Display.template.php, index.english.php, topic.js)
! Fix change of state in buttons if bbcode disabled (editor.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/topic.js


The edit to editor.js was to fix some errors coming up in FF when bbcode was disabled entirely. I couldn't reproduce in RC3 public, so I'm not 100% sure it isn't a regression caused by the editor changes, but it all functions as it's supposed to now, so not sure what to make of that.
Posted: September 8th, 2010, 07:57 PM

Revision: 66
Author: arantor
Date: 19:51:49, 08 September 2010
Message:
! Fixed font size selector to actually work as intended (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Posted: September 8th, 2010, 08:55 PM

Revision: 67
Author: arantor
Date: 23:57:05, 08 September 2010
Message:
+ Add post time on wireless views (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #74, on September 9th, 2010, 02:45 PM »
Sometimes... I really feel like a small-time hacker with my minor revs :P

rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Posted: September 9th, 2010, 11:25 AM

Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)

rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
Posted: September 9th, 2010, 11:37 AM

rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
Posted: September 9th, 2010, 12:13 PM

rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)

rev 72
! Fixed incorrect regex in browser detection. (script.js)

(Sorry, forgot to commit the second one at the same time...)
Posted: September 9th, 2010, 01:29 PM

rev 73
! Clean fix for the font size dropdown in Opera (see here), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)