New revs

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: New revs
« Reply #2925, on May 11th, 2019, 01:45 PM »
[Commit revision 9fd7470]
Author: Nao
Date: Sat, 11 May 2019 13:45:27 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Fixing harmless issue when when trying to request a negative number of topics on the homepage. (Home.template.php)
Re: New revs
« Reply #2926, on May 11th, 2019, 07:00 PM »
[Commit revision 294d044]
Author: Nao
Date: Sat, 11 May 2019 19:00:02 +0200
Stats: 2 files changed; +5 (insertions), -5 (deletions)

  • Implemented proper calc() support in Wess. Well, that was easier than expected... I thought I'd have forgotten how to write proper recursive regexes by now. (Class-CSS.php, Subs-Cache.php)
Re: New revs
« Reply #2927, on May 13th, 2019, 08:50 PM »
[Commit revision a51158f]
Author: Nao
Date: Mon, 13 May 2019 20:50:43 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed calc() recursive pattern: it was trying to match against the whole pattern, instead of the second group of brackets. Also simplified the rest of the pattern. (Class-CSS.php)
Re: New revs
« Reply #2928, on May 14th, 2019, 01:39 PM »
Quote from Nao on May 13th, 2019, 08:50 PM
  • Fixed calc() recursive pattern: it was trying to match against the whole pattern, instead of the second group of brackets. Also simplified the rest of the pattern. (Class-CSS.php)
Not that it matters, but the reason I didn't notice the bug earlier was that usually, calc() calls don't include nested brackets, so I didn't test against a stronger string like 'calc(100% + (7px / 1em))', and even then, it probably would have worked in your browser even if not matched.
Re: New revs
« Reply #2929, on June 26th, 2019, 11:27 AM »
[Commit revision a0fe1de]
Author: Nao
Date: Wed, 26 Jun 2019 11:27:04 +0200
Stats: 1 file changed; +20 (insertions), -15 (deletions)

  • Updated thought (comment) editor to use asynchronous loading of comments with BBCode in them. Previously, it would wait for them to be retrieved, which now triggers a warning in the browser console. (script.js)
  • Fixed potential error when prefetching the next page of messages in a topic. I haven't seen it happen at wedge.org, but it happened at lestrades.com, so I'm guessing this is more of a fix for heavily modded forums that play around with a lot of events. (script.js)
Re: New revs
« Reply #2930, on June 26th, 2019, 02:43 PM »
[Commit revision 8b92ee8]
Author: Nao
Date: Wed, 26 Jun 2019 14:42:54 +0200
Stats: 1 file changed; +8 (insertions), -26 (deletions)

  • Fixed #80. This is why I never use switch() in my code: it's confusing (PHP 7.3 seems to report a bug here), and it's longer than if() tests. Rewrote this one to something understandable, and not buggy. (Subs.php)
Re: New revs
« Reply #2931, on July 2nd, 2019, 11:10 PM »
[Commit revision 4b83267]
Author: Nao
Date: Tue, 02 Jul 2019 23:10:14 +0200
Stats: 1 file changed; +8 (insertions), -8 (deletions)

  • Updated Wess to remove prefixes from more modern browsers. (Class-CSS.php)
  • Details: Android 4+ browser supports box-shadow unprefixed; Firefox 29+ supports box-sizing unprefixed; Firefox 43+ supports hyphens unprefixed; Firefox 65+ supports column breaks unprefixed; Safari 9+ (also on iOS) supports flex unprefixed. Data courtesy of caniuse.com, as usual. Well, if I had a way to check these things automatically, that'd be nice...
Re: New revs
« Reply #2932,  »
[Commit revision f6c20a4]
Author: Nao
Date: Mon, 07 Oct 2019 20:03:54 +0200
Stats: 1 file changed; +5 (insertions), -2 (deletions)

  • Admins couldn't search for members in the admin area without specifying an IP, because the code was incorrectly trying to expand empty IP addresses and would thus force searching for an invalid IP. (ManageMembers.php)
Re: New revs
« Reply #2933,  »
[Commit revision eb0d124]
Author: Nao
Date: Tue, 23 Mar 2021 14:34:35 +0100
Stats: 1 file changed; +1 (insertion), -3 (deletions)

  • Just testing to see if GitHub's webhooks are back to normal.
Re: New revs
« Reply #2934,  »
So, apparently there were some changes internally at github and they deleted the webhook for Wedge. I reinstalled it, and it didn't work. I had to rewrite some parts of the code to allow it to go through. I don't know if anyone's interested in getting the updated code? If no one is, there isn't much of a reason for me to commit the changes (for some reason, my local plugin repo was deleted.)

So, I'm adding manually the two commits that were not posted here, they're both mine and dated from earlier today:

https://github.com/Wedge/wedge/commit/d802a61d455ca56e27fc839e7f92f23c57c988ae (minor AeMe bug I never bothered to fix on the repo before),
https://github.com/Wedge/wedge/commit/b37452eaaa4233ba361b71fc936c4fca28515ce7 (fix for Firefox breaking some CSS due to how :matches is implemented over there, thankfully they have :where now, which works fine everywhere.)

Sadly, I never committed anything in 2020.
Damn year!
Re: New revs
« Reply #2935,  »
Well, regarding the :where, it threw problems at me. Specifically, notifications stopped working on my other website because I have an extra class that uses the .notifs base, and it just shows that the standard isn't really ready for automation.

Code: [Select]
.notifs .mimenu { opacity: 0 }
.otherclass .open, .notifs .open { opacity: 1 } // This will work
:is(.otherclass, .notifs) .open { opacity: 1 } // This will work
:where(.otherclass, .notifs) .open { opacity: 1 } // This will NOT work!

I could modify my .mimenu declaration to not be 'final', so that .otherclass also reuses it, and then it'd probably work. Or I could specifically prevent that class that being converted into a :where() or whatver. But this just proves to me that there is currently no sure way to make it work at execution time. So I'm disabling it temporarily. Feel free to tell me if you can figure out a way! I loved :where(), but as it is, I'd rather have it work and waste a few bytes in my gzipped file. (Really, it's just that-- a few bytes. Doesn't matter as much in 2021 as it did in the early 2010's when I worked on this feature...)
Re: New revs
« Reply #2936,  »
[Commit revision 750c3a6]
Author: Nao
Date: Sat, 27 Mar 2021 18:40:17 +0100
Stats: 1 file changed; +4 (insertions), -1 (deletion)