New revs


  • Dadman with a boy
  • Posts: 16,062
Re: New revs
« Reply #2895, on April 21st, 2017, 07:37 PM »
[Commit revision 26be97f]
Author: Nao
Date: Tue, 18 Apr 2017 17:57:01 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Updated Gravatar URLs to cooperate with https mode. (Subs.php)

[Commit revision 132545d]
Author: Nao
Date: Fri, 21 Apr 2017 19:36:30 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Some stuff I don't know about. Don't ask me, I never touched that place. It's full of cobwebs. (ManageMail.template.php)

[Commit revision 7c269a1]
Author: Nao
Date: Fri, 21 Apr 2017 19:37:43 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Dropdowns would fail to open in case they had the 'multiple' attribute and no pre-selected entry. (sbox.js)
Re: New revs
« Reply #2896, on April 22nd, 2017, 02:31 PM »
[Commit revision ef31bf6]
Author: Nao
Date: Sat, 22 Apr 2017 14:31:26 +0200
Stats: 2 files changed; +3 (insertions), -1 (deletion)

  • Search members by IP was broken (presumably due to Pete upgrading the IP system to support IPv6.) (ManageMembers.php)
  • Removing an error suppressor that I suspect should be unneeded now. (Subs-Cache.php)
Re: New revs
« Reply #2897, on April 30th, 2017, 02:47 PM »
[Commit revision d45056f]
Author: Nao
Date: Sun, 30 Apr 2017 14:33:38 +0200
Stats: 2 files changed; +6 (insertions), -8 (deletions)

  • Cleaner privacy code. (Security.php)
  • Spacinazi. (Profile-Actions.php)

[Commit revision f52ad02]
Author: Nao
Date: Sun, 30 Apr 2017 14:37:26 +0200
Stats: 2 files changed; +5 (insertions), -4 (deletions)

  • The imperative scheduled task related to checking infraction expire dates doesn't have access to the system object, and thus should be careful with MID and timeformat(). I never noticed this error before because it was probably triggered before the error handler was rerouted, but it showed up (everytime the task was called) in my error.log file, so here we are, a fix. (ManageInfractions.php, Subs.php)
  • PHP 5.4 adds some nice JSON conversion constants, so I'm making use of them now, to remove an ugly str_replace and make integer output less verbose. (Subs.php)

[Commit revision 10494ab]
Author: Nao
Date: Sun, 30 Apr 2017 14:46:53 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Similarly, old notification pruning was using an undefined function, and that wasn't logged normally. (Notifications.php)
Re: New revs
« Reply #2898, on July 19th, 2017, 04:33 PM »
[Commit revision fb42680]
Author: Nao
Date: Wed, 19 Jul 2017 16:33:32 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed YouTube no longer allowing for fullscreen mode... I think? (Subs-Aeva-Sites.php)
Re: New revs
« Reply #2899, on July 22nd, 2017, 11:41 AM »
[Commit revision 389ed36]
Author: Nao
Date: Sat, 22 Jul 2017 10:28:59 +0200
Stats: 4 files changed; +0 (insertion), -0 (deletion)

  • Smaller size, dark-friendly rank icons. (assets/rank*.gif)

[Commit revision d060d06]
Author: Nao
Date: Sat, 22 Jul 2017 11:08:01 +0200
Stats: 3 files changed; +96 (insertions), -99 (deletions)

  • array() to [] conversions in the one file that screams "I'm there to optimize sizes, so optimize me!!" (Subs-Cache.php)
  • Same for Ajax.php because I can, also fixed a thought conversion call that was taking more space than needed in the database. (Ajax.php)
  • Also shaved a few bytes off serialized strings with integers in them. (Subs.php)

[Commit revision 0c3cd07]
Author: Nao
Date: Sat, 22 Jul 2017 11:10:20 +0200
Stats: 1 file changed; +14 (insertions), -7 (deletions)

  • Added proper hyphens support to Wess, now that, years later, support has grown a bit. (Class-CSS.php)
  • Dynamic functions shouldn't be cached across all CSS files... That can lead to some unexpected results. Not that it matters, really. (Class-CSS.php)

[Commit revision bcb61a6]
Author: Nao
Date: Sat, 22 Jul 2017 11:12:20 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • Simplified a query. (Memberlist.php)
  • PHP caching code was probably a bit too greedy. Wait time after uploading a file was reduced to 2 seconds max, with perfect results on my sometimes busy server. (Subs-CachePHP.php)

[Commit revision 8d4d155]
Author: Nao
Date: Sat, 22 Jul 2017 11:14:36 +0200
Stats: 2 files changed; +5 (insertions), -2 (deletions)

  • No need to log an error when someone logs off and has another tab around which still attempts to fetch notifications... It's okay, calm down. (Notifications.php)
  • Account for potential inputs inside select boxes. (sbox.js)

[Commit revision cee6d78]
Author: Nao
Date: Sat, 22 Jul 2017 11:17:20 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • While I no longer use a proxy, I've established that the most useful IP data to be recorded is the one discovered through the proxy's special headers. If nothing was found (e.g. no proxy), that data will be the same as usual anyway... Way, way more useful for most tasks. (Class-System.php)

[Commit revision ec916e4]
Author: Nao
Date: Sat, 22 Jul 2017 11:18:25 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • Why should guests want to collapse a category? Excuse me for a minute-- why would members want to, either? Anyway, guests, one less useless button for you... (Subs-Boards.php, Subs-BoardIndex.php)

[Commit revision 1937057]
Author: Nao
Date: Sat, 22 Jul 2017 11:20:23 +0200
Stats: 3 files changed; +6 (insertions), -13 (deletions)

  • Moved some of the app_error_count logic around. I haven't seen significant improvements, but it makes more sense to me. (index.php, Subs-Template.php)
  • Spacinazi. (index.template.php)

[Commit revision 3349b81]
Author: Nao
Date: Sat, 22 Jul 2017 11:25:34 +0200
Stats: 1 file changed; +1 (insertion), -96 (deletions)

  • Removed my very own sticky positioning polyfill. Why? Chrome recently added proper support for 'position: fixed', and I figured it would mean 90% of users would no longer need a polyfill. Older browsers will simply do without it, it's not a deal breaker anyway. Rest in peace polyfill, I was proud of you. (topic.js)

[Commit revision fa1b720]
Author: Nao
Date: Sat, 22 Jul 2017 11:28:22 +0200
Stats: 1 file changed; +30 (insertions), -30 (deletions)

  • Make sure search engines can't see context menus, even if some items remain for guests. This makes for uncomfortable pseudo-URLs that get parsed for no reason... Also, more array() to [] conversions. (Display.php)

[Commit revision 878793c]
Author: Nao
Date: Sat, 22 Jul 2017 11:28:43 +0200
Stats: 2 files changed; +5 (insertions), -5 (deletions)

  • Updated a few files with the https version of the Wedge URL. (ScheduledTasks.php, Credits.php)
  • I didn't need some hack in PM code... (pm.js)

[Commit revision c43f32d]
Author: Nao
Date: Sat, 22 Jul 2017 11:30:27 +0200
Stats: 4 files changed; +12 (insertions), -12 (deletions)

  • More protocol conversions. (install.php, Help.english.php, index.english.php, Admin.english.php)

[Commit revision aabdd5f]
Author: Nao
Date: Sat, 22 Jul 2017 11:33:32 +0200
Stats: 1 file changed; +8 (insertions), -8 (deletions)

  • Fixed error handling to use proper PHP logic for error constants, rather than the weird situation it was in in SMF... It was very old code, I reckon. Not finished with it though, I've got a better version live at but I need to test it further. (Errors.php)

[Commit revision 7f9ec53]
Author: Nao
Date: Sat, 22 Jul 2017 11:36:23 +0200
Stats: 1 file changed; +18 (insertions), -16 (deletions)

  • Added support for MySQL strict mode -- more specifically, the ability to disable it through a global variable. I wrote that for a previous server, and never bothered to commit it because I didn't need it anymore by the time I was committing everything. But still, can be useful to some... I know I wasted a few hours on that one..! (Class-DB.php)
  • Fixed {literal:...} code not allowing for flexible strings. (Class-DB.php)

[Commit revision 14d6a15]
Author: Nao
Date: Sat, 22 Jul 2017 11:41:01 +0200
Stats: 1 file changed; +32 (insertions), -20 (deletions)

  • Wrote a better, more self-explained version of invertAll() (kept the silly name though, for compatibility reasons), where it's made more explicit what the function does, *and* it now also ensures that events linked to those checkboxes are called as needed. (script.js)
  • Tweaked notification popup code to accomodate for any custom changes to the notification button HTML. I know it helped me. Also various additions and fixes that I won't bother listing. (script.js)
  • Reduced length of some select box strings. The idea is, you only need to escape the "<" sign... Everything else is fair game. As a result, the new stuff is more readable, and shorter of course. I always go for shorter. (script.js)
Re: New revs
« Reply #2900, on July 25th, 2017, 05:32 PM »
[Commit revision 6ec1c96]
Author: Nao
Date: Tue, 25 Jul 2017 17:32:01 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Getting "The database value you're trying to insert does not exist: id_file" on embedded files in the gallery. (Subs-Media.php)
Re: New revs
« Reply #2901, on July 25th, 2017, 05:40 PM »
[Commit revision 0992946]
Author: Nao
Date: Tue, 25 Jul 2017 17:39:50 +0200
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • More future-proof fix. (Subs-Media.php)
Re: New revs
« Reply #2902, on July 25th, 2017, 06:35 PM »
[Commit revision 195825e]
Author: Nao
Date: Tue, 25 Jul 2017 18:33:45 +0200
Stats: 1 file changed; +3 (insertions), -1 (deletion)

  • Found another occurrence of a Yahoo bot being rejected for not being of the allowed IP ranges, even though it was obviously a Yahoo IP range (probably set up after Bad Behavior last updated its ranges). Because of that, and BB's last version being from a year ago, I've decided to disable all tests against bots (Yahoo!, MSN, Google, even Baidu for some reason). Wedge's security is good enough to reject all bot attempts, it doesn't need an extra layer that may actually reject legit bots and thus hurt your rankings. (Security.php)

[Commit revision ccc21c6]
Author: Nao
Date: Tue, 25 Jul 2017 18:35:22 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)

  • And a quick extra layer of future-proof fixing. (Subs-Media.php)
Re: New revs
« Reply #2903, on August 11th, 2017, 02:02 PM »
[Commit revision a446f57]
Author: Nao
Date: Fri, 11 Aug 2017 14:02:18 +0200
Stats: 2 files changed; +6 (insertions), -3 (deletions)

  • $context['current_privacy'] needs to be an array, not a number. This caused topics to show a 'regular' privacy when editing them, even if their privacy is restricted. (Post.php, Security.php)
Re: New revs
« Reply #2904, on September 8th, 2017, 11:56 AM »
[Commit revision 932fdf8]
Author: Nao
Date: Fri, 08 Sep 2017 11:56:41 +0200
Stats: 1 file changed; +6 (insertions), -6 (deletions)

  • Media embeds in gallery didn't generate thumbnails for https links which, in 2017, are thankfully the vast majority. (Aeva-Embed.php)
  • Note: untested, but should work™.
Re: New revs
« Reply #2905, on September 8th, 2017, 03:16 PM »
[Commit revision 6d382ae]
Author: Nao
Date: Fri, 08 Sep 2017 15:16:34 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • The pattern for thumbnail creation was broken. (Aeva-Embed.php)
Re: New revs
« Reply #2906,  »
[Commit revision e80743d]
Author: Nao
Date: Sat, 30 Sep 2017 14:15:59 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Select box didn't properly remove small tags when finished selecting an entry. It was either broken for a while, or browser behavior changed in the meantime. (sbox.js)
Re: New revs
« Reply #2907,  »
[Commit revision 1b84312]
Author: Nao
Date: Mon, 16 Oct 2017 11:41:26 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Allow for uppercase color definitions in CSS. (Class-CSS.php)
Re: New revs
« Reply #2908,  »
[Commit revision 3d56349]
Author: Nao
Date: Mon, 16 Oct 2017 11:44:07 +0200
Stats: 2 files changed; +27 (insertions), -19 (deletions)

  • Fix mangled margin below icons in board list. (sections.css)

[Commit revision 91655f3]
Author: Nao
Date: Mon, 16 Oct 2017 11:45:22 +0200
Stats: 0 file changed; +0 (insertion), -0 (deletion)

Re: New revs
« Reply #2909,  »
(Sorry about the mess in the history log; I committed as planned, but pushed by mistake and then tried to cancel it partway through uploading, got an error message, panicked and made it worse. Git can sometimes be convoluted.)

(Not that ANYONE will care, of course...)