New revs

Nao

  • Dadman with a boy
  • Posts: 16,080
Re: New revs
« Reply #2805, on August 17th, 2016, 03:44 PM »Last edited on August 19th, 2016, 11:08 AM
[Commit revision 16e1651]
Author: C3realGuy
Date: Wed, 17 Aug 2016 15:44:48 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • body type on create_post didn't regard if $settings['max_messageLength']
  • [createPost] body type not regarding $settings['max_messageLength'] if zero (#37)
  • is 0 and therefore unlimited.
Re: New revs
« Reply #2806, on August 17th, 2016, 03:55 PM »
[Commit revision 38f7604]
Author: Nao
Date: Tue, 02 Aug 2016 22:26:42 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Fixed an ambiguous variable name for use in PHP 7. (Class-SFTP.php)

[Commit revision b23f38e]
Author: Nao
Date: Tue, 02 Aug 2016 22:54:45 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Another missed ambiguity. (ManageServer.php)

[Commit revision afbe3fe]
Author: Nao
Date: Wed, 17 Aug 2016 15:45:19 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)


[Commit revision 276273c]
Author: Nao (Signed-off)
Date: Wed, 17 Aug 2016 15:50:28 +0200
Stats: 7 files changed; +15 (insertions), -19 (deletions)

  • Spacinazi. (Load.php, QueryString.php, ScheduledTasks.php)
  • Upgraded jQuery to recent versions. They work fine for me. (Load.php, *.min.js)

[Commit revision de9c189]
Author: Nao (Signed-off)
Date: Wed, 17 Aug 2016 15:50:40 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • CSS tweak on reply box. Probably going to break something in another skin, ahah... (sections.css)

[Commit revision 4ac6905]
Author: Nao
Date: Wed, 17 Aug 2016 15:54:57 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Just avoiding an ambiguity... (Subs-Post.php)
Re: New revs
« Reply #2807, on August 19th, 2016, 10:44 AM »
[Commit revision bdfb3ea]
Author: Nao
Date: Fri, 19 Aug 2016 10:44:26 +0200
Stats: 3 files changed; +1 (insertion), -5 (deletions)

  • Spacinazi. (Subs-Post.php)
  • No Ucfirst Everywhere Thank You. (languages/index.english.php)
  • Fixed PM section using the Wine skin. I'm now waiting for a flood of messages indicating this broke something else... (index.member.css)
Re: New revs
« Reply #2808, on August 27th, 2016, 12:57 AM »
[Commit revision 241b8c5]
Author: Nao
Date: Sat, 27 Aug 2016 00:09:11 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Unused var. (script.js)
Re: New revs
« Reply #2809, on September 16th, 2016, 11:14 AM »
[Commit revision 14c4ea6]
Author: Nao (Signed-off)
Date: Fri, 16 Sep 2016 11:09:58 +0200
Stats: 6 files changed; +72 (insertions), -59 (deletions)

  • A small overhaul of the database class.
  •  Renamed wesql::query_* to wesql::get_*, to make it clearer these functions do all the work for you.
  •  wesql::get() will now return a single variable (instead of an array) if it only returns a single column & row. $my_var = wesql::get('SELECT my_var FROM table LIMIT 1'), welcome to a world where MySQL isn't so tedious anymore.
  •  $db_string renamed to $query internally (no impact expected).
  •  Added placeholder for a future utf8mb4 conversion function (I'm on the edge regarding this, as I'd rather add support in the installer itself).
  • Updated uses of wesql::query_* (Load.php, ManagePlugins.php, Subs-BoardIndex.php)
  • Fixed sessionRead() to return an empty string on failure, instead of 'false', since these callbacks functions are now properly documented at php.net. (Load.php)
  • Rare bug in the error viewer. (ManageErrors.php)

[Commit revision 71594a8]
Author: Nao (Signed-off)
Date: Fri, 16 Sep 2016 11:14:30 +0200
Stats: 3 files changed; +6 (insertions), -2 (deletions)

  • Rare bug where the SID constant isn't defined even if session_id() is valid. In my particular case, it was when enabling an official HHVM package. (Subs-Template.php)
  • $(document).on('ready') was removed from jQuery 3.0. I'm not sure how this will behave on IE8 and earlier, but I'm sure jQuery deals with them, and the market shares for those are ridiculous by now anyway. (topic.js)
  • These notifications are too narrow for me. (index.css)
Re: New revs
« Reply #2810, on September 16th, 2016, 11:30 AM »
[Commit revision 2e507da]
Author: Nao (Signed-off)
Date: Fri, 16 Sep 2016 11:30:00 +0200
Stats: 1 file changed; +2 (insertions), -3 (deletions)

  • #index_common_stats was broken in most (all?) skins. (sections.css)
  • Left arrow was broken in blog post comments if commented didn't have an avatar. (sections.css)
Re: New revs
« Reply #2811, on September 16th, 2016, 12:55 PM »
[Commit revision 1e5c171]
Author: Nao
Date: Fri, 16 Sep 2016 12:36:08 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • W3C validator was broken over HTTPS installs. (Subs-Template.php)
Re: New revs
« Reply #2812, on September 25th, 2016, 03:38 PM »
[Commit revision 18dee46]
Author: Nao
Date: Sun, 25 Sep 2016 15:29:13 +0200
Stats: 3 files changed; +15 (insertions), -1 (deletion)

  • Added a small task to the 'Find and fix errors' maintenance task, where boards with pretty URLs will make sure they have correctly cached their URL length. This is mainly to help you get up to speed faster if you ever move forums and need to update your URLs. (RepairBoards.php, ManageMaintenance.english.php)
  • Outdated comment. (ManageMaintenance.php)

[Commit revision ad3a277]
Author: Nao
Date: Sun, 25 Sep 2016 15:30:57 +0200
Stats: 1 file changed; +18 (insertions), -28 (deletions)

  • A single wesql::get('SELECT RAND()') now replaces 7 lines of code. I told you that helper function was nice. (Subs-Members.php)

[Commit revision a6ab3dd]
Author: Nao
Date: Sun, 25 Sep 2016 15:32:54 +0200
Stats: 1 file changed; +9 (insertions), -0 (deletion)

  • Added support for a pseudo-block, <ob:ignore>, within which the output buffer won't be manipulated. For instance, if you need to show a lot of data where you know there's no need to change anything (e.g. plenty of external links), adding this block around your data could shave several seconds off the total processing time. Tried by yours truly. (Subs-Template.php)

[Commit revision e22ec54]
Author: Nao
Date: Sun, 25 Sep 2016 15:36:26 +0200
Stats: 1 file changed; +4 (insertions), -2 (deletions)

  • Fixed wrong HTML nesting for guests. (index.template.php)
  • New HTML validator no longer supports protocol-relative URLs for item properties. Don't get a word of what I said? Well, I just mean I have to add 5 extra bytes per page, and it sucks. (index.template.php)

[Commit revision d41f147]
Author: Nao
Date: Sun, 25 Sep 2016 15:38:07 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • Some PHP installs prefer, by default, to give you blank pages or Apache errors instead of showing you an unfinished page when errors are met. I never realized that. Putting things back to normal. At least it'll make debugging easier now... (index.php)
Re: New revs
« Reply #2813, on September 27th, 2016, 02:32 PM »
[Commit revision 9f59d42]
Author: Nao
Date: Tue, 27 Sep 2016 14:30:05 +0200
Stats: 1 file changed; +7 (insertions), -7 (deletions)

  • Fixed untested utf8mb4 placeholder code. Note, this still doesn't support 4-byte UTF8... I still don't know exactly what I should do with those. (Class-DB.php)

[Commit revision 4633689]
Author: Nao
Date: Tue, 27 Sep 2016 14:31:50 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Forgot to remove <ob:ignore> pseudo-tags from final HTML if used. (Subs-Template.php)
Re: New revs
« Reply #2814, on October 1st, 2016, 07:39 PM »
[Commit revision 3758508]
Author: C3realGuy
Date: Sat, 01 Oct 2016 19:39:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Fixed escape_string_replacement(). There was some trouble with the (#39)
  • connection var.
Re: New revs
« Reply #2815, on October 2nd, 2016, 02:57 PM »
[Commit revision f3d603f]
Author: Nao
Date: Sun, 02 Oct 2016 14:56:52 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Main menu couldn't be opened anymore if one of its links was opened with a middle click (i.e. in a new tab). (script.js)
Re: New revs
« Reply #2816, on October 2nd, 2016, 11:26 PM »
[Commit revision 904a392]
Author: Nao
Date: Sun, 02 Oct 2016 15:41:32 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Avoiding a minor error when browsing the error log and for some reason the URL wasn't recorded. Need to find out why they wouldn't, too... (ManageErrors.php)

[Commit revision 23cb8a3]
Author: Nao
Date: Sun, 02 Oct 2016 23:25:51 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Is this a new jQuery 3 bug..? Lazy loading of pages would now show the JavaScript code in plain view (I guess that fadeIn() now applies to all tag types, including script tags, making them get a block display style, which apparently in the latest Chromium is enough to show the code). I added a safety check for that. It works, so I won't bother with the rest. (topic.js)
Re: New revs
« Reply #2817, on October 8th, 2016, 01:56 PM »
[Commit revision 810186f]
Author: Nao
Date: Sat, 08 Oct 2016 13:56:14 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)

  • Added auto-focus on quick reply box when unfolding it. Because usually the next step is typing into that box, isn't it..? (topic.js)
  • Some weird placement in the user box CSS. I dunno if this'll break something else. (index.css)
Re: New revs
« Reply #2818, on October 9th, 2016, 11:54 PM »
[Commit revision 660aa41]
Author: Nao
Date: Sun, 09 Oct 2016 23:53:23 +0200
Stats: 3 files changed; +8 (insertions), -1 (deletion)

  • It's hack day for me. When logging an error, I'm now adding a small indicator if the error was possibly triggered by a search engine (for instance visiting a page that's not always accessed by humans.) (Errors.php, ManageErrors.php, Errors.template.php)

[Commit revision e8cb752]
Author: Nao
Date: Sun, 09 Oct 2016 23:53:42 +0200
Stats: 3 files changed; +12 (insertions), -9 (deletions)

  • If a scheduled task function can't be found, try to find it without the 'scheduled_' prefix before giving up. This is mostly to keep in line with the fact that if the function is inside an object (like weobject::random_task), that prefix isn't expected/added at all. (ManageScheduledTasks.php, ScheduledTasks.php)
  • Also, if a scheduled task isn't found and Wedge gives up, then at least let the admin know through the error log... (ScheduledTasks.php)
  • Minor user box tweaks. (index.css)
Re: New revs
« Reply #2819, on October 16th, 2016, 12:41 PM »
[Commit revision c8b6c4a]
Author:
Date: Sun, 16 Oct 2016 12:23:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Fix low spam/flood limits
  • spamProtection() did not handle search limits correct.
  • It was not possible to disable flood control for search,
  • lowest possible value was 1. The new check also allows
  • a value of 0.
  • If user has moderator permissions, the limit was
  • always overridden with 2. We now check if the limit is
  • greater than 2 and if not, we override it with 2.

[Commit revision 41fb853]
Author: Nao
Date: Sun, 16 Oct 2016 12:41:32 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Merge pull request #40 from C3realGuy/fix_lowfloodlimits
  • Fix low spam/flood limits