New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2685, on September 12th, 2014, 12:42 AM »
[Commit revision 7b016f4]
Author: Nao
Date: Sat, 30 Aug 2014 23:57:07 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • The main script file was broken when compressing it with JSMin, because of the "+ ++unique" thingy. (sbox.js)
  • Interestingly, adding these 4 brackets actually reduced the file size by 2 bytes...
[Commit revision c04b446]
Author: Nao
Date: Mon, 08 Sep 2014 21:14:54 +0200
Stats: 1 file changed; +2 (insertions), -1 (deletion)
  • PHP has a set_charset function, let's use it... Seems to be a bit faster and safer. (Load.php)
[Commit revision b867b56]
Author: Nao
Date: Tue, 09 Sep 2014 13:55:23 +0200
Stats: 2 files changed; +2 (insertions), -35 (deletions)
  • I can't think of any other software that puts so much care into rebuilding the current URL, and then proceed to not using it in some areas. (Subs-Auth.php, Login.template.php)
[Commit revision 0caffa4]
Author: Nao
Date: Tue, 09 Sep 2014 14:01:49 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • We have the PROTOCOL constant, too, so let's use that... (Class-System.php)
[Commit revision caec3b3]
Author: Nao
Date: Fri, 12 Sep 2014 00:42:05 +0200
Stats: 2 files changed; +7 (insertions), -6 (deletions)
  • Message edited time was applying the user timezone twice, resulting in odd things like "edited 10 hours ago" instead on a message posted 5 or 6 hours ago... (Display.php)
  • Added a parameter to time_tag to disable timezone transformations. This isn't used in Wedge, and probably won't be used in the main codebase (doing timezone transforms isn't too expensive, but I'd rather do them only as needed), but here it is, it should be more flexible now. (Subs.php)
Re: New revs
« Reply #2686, on September 12th, 2014, 01:41 AM »
[Commit revision c7c0b6f]
Author: Nao
Date: Fri, 12 Sep 2014 01:41:16 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Board age tests (in board lists) were done incorrectly (difference between current unadjusted time, and last post's adjusted time). I told you, these timestamp adjustments just don't make sense... Well, okay, in that case it was my board icon rewrite that was a bit messed up. Had a lot to rewrite, at the time... (Subs-BoardIndex.php)
Re: New revs
« Reply #2687, on September 12th, 2014, 01:08 PM »
[Commit revision c763368]
Author: Nao
Date: Fri, 12 Sep 2014 13:07:27 +0200
Stats: 13 files changed; +26 (insertions), -26 (deletions)
  • Harmonized all 'timestamp' fields to use unadjusted times. The reasoning behind this is that (1) apart from a couple of occurrences not dealt with in this commit, NONE of these timestamps are actually used by Wedge, (2) wasting time on adjusting unused data is pointless, (3) it's easier to adjust times with timeformat() and time_tag() than un-adjusting them manually if needed. (Merge.php, MessageIndex.php, Modlog.php, PersonalMessage.php, Post.php, PrintPage.php, Profile-View.php, Recent.php, Search2.php, Split.php, Unread.php, UnreadReplies.php, Who.php) (Also a few plugins!)
Re: New revs
« Reply #2688, on September 14th, 2014, 08:43 PM »
[Commit revision eef8bbe]
Author: Nao
Date: Sun, 14 Sep 2014 10:33:25 +0200
Stats: 3 files changed; +18 (insertions), -23 (deletions)
  • Cleaner implementation of the burger (show sidebar) icon. It should look the same across all devices now, and not use non-semantic tags, although it didn't matter much because they were generated by JS anyway... (index.css, sections.css, script.js)
Re: New revs
« Reply #2689, on September 16th, 2014, 01:10 PM »
[Commit revision c3c77a3]
Author: Nao
Date: Tue, 16 Sep 2014 13:10:07 +0200
Stats: 4 files changed; +9 (insertions), -9 (deletions)
  • IE 11 (and presumably later) fails to support gz extensions. GO FUDGE YOURSELF, IE!! (Class-Editor.php, QueryString.php, Subs-BBC.php, Subs-Cache.php)
  • Broken link redirect code didn't work for non-gzipped css/js. (QueryString.php)
Re: New revs
« Reply #2690, on September 18th, 2014, 09:33 AM »
[Commit revision 6375a3f]
Author: Nao
Date: Wed, 17 Sep 2014 16:19:22 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Fixed some issues with the burger icon on mobile. (sections.css)
[Commit revision 98d6783]
Author: Nao
Date: Wed, 17 Sep 2014 16:21:09 +0200
Stats: 1 file changed; +3 (insertions), -2 (deletions)
  • Fixed animation on search form, as well as a sizing issue in... "Internet Explorer. What else?" (index.css)
[Commit revision a638f93]
Author: Nao
Date: Wed, 17 Sep 2014 16:25:55 +0200
Stats: 1 file changed; +2 (insertions), -0 (deletion)
  • Create a new stacking context for the search input, ensuring it shows on top of the 'Notifications' button when enlarging it on mobile devices. Trust me. (index.css)
[Commit revision 6bb1f10]
Author: Nao
Date: Wed, 17 Sep 2014 16:48:09 +0200
Stats: 1 file changed; +1 (insertion), -2 (deletions)
  • A less 'original' background for Warm. I'll leave original stuff to external skins... Right? (Warm/extra.css)
[Commit revision 9e31847]
Author: Nao
Date: Wed, 17 Sep 2014 16:49:14 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Semibold looks good on Windows, so I'll use that (for now) in Wilde headers... (Wilde/extra.css)
[Commit revision 40b9961]
Author: Nao
Date: Wed, 17 Sep 2014 17:43:14 +0200
Stats: 1 file changed; +7 (insertions), -5 (deletions)
  • Subtler alternate backgrounds for Weaving. Dunno if it'll stick. Feel free to suggest better defaults! (common.css)
[Commit revision e7143f3]
Author: Nao
Date: Wed, 17 Sep 2014 17:49:43 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Search input should have a more subtle border. (index.css)
  • Make use of your own macros, man..! (index.css)
Re: New revs
« Reply #2691, on September 20th, 2014, 05:55 PM »
[Commit revision 437382a]
Author: Nao
Date: Sat, 20 Sep 2014 00:02:16 +0200
Stats: 1 file changed; +25 (insertions), -14 (deletions)
  • Various minor improvements: more responsive topic titles (using flexbox if available), blog comment bubble tail position, and thought list fixes. Please note that the @if test was useful in Weaving until I decided not to proceed with identical $window_bg and $window_bg2 values, although it's still easy to do on your own skins. (sections.css)
[Commit revision eae8bcf]
Author: Nao
Date: Sat, 20 Sep 2014 00:02:58 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Commenazi. (Wireless/extra.css)
[Commit revision d49e096]
Author: Nao
Date: Sat, 20 Sep 2014 16:11:31 +0200
Stats: 1 file changed; +7 (insertions), -4 (deletions)
  • Fixes to Warm; also, trying to make it more... watchable. That'd be a good name for a skin. (Warm/extra.css)
[Commit revision c6bcd2a]
Author: Nao
Date: Sat, 20 Sep 2014 16:12:32 +0200
Stats: 2 files changed; +2 (insertions), -6 (deletions)
  • Firefox (no longer?) needs one of these many flex workarounds... (sections.css)
  • Select box border color benefits from being brighter, I think... (index.css)
[Commit revision 10a7860]
Author: Nao
Date: Sat, 20 Sep 2014 16:16:05 +0200
Stats: 1 file changed; +14 (insertions), -3 (deletions)
  • And some tweaks for Wilderless, for good measure. (Wilderless/extra.css)
[Commit revision 0d03088]
Author: Nao
Date: Sat, 20 Sep 2014 17:44:22 +0200
Stats: 2 files changed; +4 (insertions), -3 (deletions)
  • Chrome removed 'position: sticky' from their web platform experiments back in June. Hopefully it makes it back soon into the codebase, just like the vertical tabs feature. Eh? What did you say? They never restored vertical tabs?! Oh, yeah, now these are TWO things missing in stock Chrome that I hated to see go. Anyway. (common.css)
  • Firefox Mobile v32 doesn't seem to support sticky either (yet), so I'm removing support for it. (common.css)
  • A silly syntax error broke stickies in Wilderless. I never noticed it because it's a mobile-centric skin, my iPod is long gone, and none of the Android browsers support sticky for now. Also improved sticky rendering. Works fine in Firefox v32 for Windows. (Wilderless/extra.css)
Re: New revs
« Reply #2692, on September 22nd, 2014, 05:23 PM »
[Commit revision 52ad1bb]
Author: Nao
Date: Mon, 22 Sep 2014 17:23:09 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)
  • In Chrome browsers, admins could no longer manage (delete, etc.) anyone's profiles but theirs. Hmm, this was due to my recent trick for forcing Chrome to retrieve your saved password in admin login boxes. (QueryString.php)
Re: New revs
« Reply #2693, on September 24th, 2014, 04:37 PM »
[Commit revision 18d1ad6]
Author: Nao
Date: Wed, 24 Sep 2014 16:33:37 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • ! Forgot to add the $con variable to the mysqli_set_charset call. Mais qu'il est con ! (Look it up in a dictionary.) (Load.php)
[Commit revision 86c2add]
Author: Nao
Date: Wed, 24 Sep 2014 16:36:47 +0200
Stats: 3 files changed; +37 (insertions), -1 (deletion)
  • New feature: profile pages give you a link to the user's latest post, if any, and specifies the date. (Load.php, Profile.template.php, index.english.php)
  • Note to self: should member_name be a key in the members table..? It's only used in profile loading, though, AFAIK...

Jurien

  • All i want is a couple days off
  • Posts: 132
Re: New revs
« Reply #2694, on September 24th, 2014, 05:21 PM »
View someone user's profile gives a database error,when not been logged in !!

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2695, on September 24th, 2014, 05:21 PM »
[Commit revision 0cd3a7b]
Author: Nao
Date: Wed, 24 Sep 2014 17:21:20 +0200
Stats: 1 file changed; +5 (insertions), -4 (deletions)
  • Oops, missing join for the profile feature. (Load.php)
Re: New revs
« Reply #2696, on September 24th, 2014, 06:05 PM »
[Commit revision a1b0699]
Author: Nao
Date: Wed, 24 Sep 2014 18:05:24 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
  • Fixed incorrect positioning of the 'new' anchor in blog pages. One of these bug fixes that are probably going to bring more bugs, because I'm cursed with these in that particular code block... (Display.php)
Re: New revs
« Reply #2697, on September 26th, 2014, 01:08 AM »
[Commit revision 5558dd8]
Author: Nao
Date: Fri, 26 Sep 2014 01:08:18 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Fixed Open Sans not loading in Warm when enabling HTTPS mode. (Warm/skin.xml)
Re: New revs
« Reply #2698, on September 27th, 2014, 12:22 AM »
[Commit revision 4f6e1da]
Author: Nao
Date: Fri, 26 Sep 2014 16:24:30 +0200
Stats: 2 files changed; +5 (insertions), -1 (deletion)
  • $(dom).width/height() is problematic in browsers that do subpixel rendering (such as Firefox and the most recent Chrome builds), as it returns rounded values instead of floating point values, which CAN be a problem later on. I found a problem related to this in the language selector dropdown, so it had to be fixed with a $.realWidth alias. I also added a $.realHeight alias, even though it's not currently used, because it would be illogical not to offer it to developers, and it's also only a few more bytes in the gzipped JS... (script.js)
  • And so... As I said, I'm fixing the select box dropdowns. Without this, Chrome would now force a width less than a pixel narrower than the natural width for the div, causing text within it to be suddenly wrapped. (sbox.js)
[Commit revision a8644ca]
Author: Nao
Date: Sat, 27 Sep 2014 00:21:10 +0200
Stats: 2 files changed; +4 (insertions), -3 (deletions)
  • In select boxes, inline hints (such as "Mobile default" in the skin selector) are no longer shown on the display after clicking an entry. (sbox.js)
  • The language selector no longer shows the language name (see above), it's only shown if you open the dropdown. This saves precious space in that area, really. (index.template.php)
Re: New revs
« Reply #2699, on September 27th, 2014, 12:52 AM »
[Commit revision 98e6d91]
Author: Nao
Date: Sat, 27 Sep 2014 00:49:03 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Forgot to update the CSS for flag icons. Hmm, here's hoping I'm not breaking anything else... This was only tested on the main select box. (Subs-Cache.php)
[Commit revision 41f3076]
Author: Nao
Date: Sat, 27 Sep 2014 00:52:24 +0200
Stats: 3 files changed; +5 (insertions), -5 (deletions)
  • Fixed the last few timestamp entries that were being adjusted for timezones. As a reminder, it's easy to adjust (forum_time(true, $my_timestamp)), and harder to un-adjust, so you might as well want to work from the unadjusted version, AND you get to save processing time if not used. (SSI.php, Load.php, Memberlist.php)
Plugin revs »