New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2460, on February 18th, 2014, 11:10 AM »
[Commit revision cee9259]
Author: Nao
Date: Tue, 18 Feb 2014 10:37:20 +0100
Stats: 1 file changed; +8 (insertions), -4 (deletions)
  • Forgot to commit the JavaScript associated with the hey_not feature. (script.js)
[Commit revision 2ec9842]
Author: Nao
Date: Tue, 18 Feb 2014 11:10:19 +0100
Stats: 2 files changed; +28 (insertions), -31 (deletions)
  • Moved the unread notifications count calculator into its own method. (Notifications.php)
  • hey_not and hey_pm should be declared as integers. (Subs.php)
Re: New revs
« Reply #2461, on February 19th, 2014, 07:48 PM »
[Commit revision baaa4e8]
Author: Nao
Date: Wed, 19 Feb 2014 19:26:09 +0100
Stats: 3 files changed; +13 (insertions), -14 (deletions)
  • Added SVG support to Wess. It's not that interesting for now, as it's inefficient at being compressed. I tried storing files without encoding them, but it didn't work for me, unlike some online samples I found. I'll give it a try another day. (Class-CSS.php)
  • Changed credits page to my current gravatar and helped balance columns a bit. (Credits.php, Who.template.php)
[Commit revision bb405ce]
Author: Nao
Date: Wed, 19 Feb 2014 19:47:35 +0100
Stats: 16 files changed; +200 (insertions), -142 (deletions)
  • As we::$user['data'] may not always hold a variable in it, devs will always have to use !empty() on its variables, so let's just delete empty variables, to save some database space. (Subs.php)
  • Moved members.secret_question/secret_answer to members.data, renamed them to a single 'secret' string, separated by a | bar. This needs testing, as the rewrite unfortunately required a lot of changes, but I was adamant on doing it. (Load.php, Profile-Modify.php, Register.php, Reminder.php, Subs-Members.php)
  • Moved members.mod_prefs to members.data, renamed it to 'modset'. (ModerationCenter.php, Profile-Modify.php, Report.php, ScheduledTasks.php)
  • Moved members.message_labels to members.data, renamed it to 'pmlabs'. (PersonalMessage.php, Subs-Members.php)
  • Removed members.new_pm, as hey_pm was pretty much doing the same thing. Moved label updating code block around, to allow for this change. Hopefully, won't break anything. I've never used that feature in my life. (PersonalMessage.php, Subs-Members.php, Subs-Post.php, Subs.php)
  • Updated the install and upgrade scripts to account for all of these, and show how background incremental upgrading works. (Upgrade.php, index.php, install.php, install.sql)
  • Commenazi. (Profile-Modify.php, script.js)
Re: New revs
« Reply #2462, on February 19th, 2014, 08:50 PM »
[Commit revision 50c6fca]
Author: Nao
Date: Wed, 19 Feb 2014 20:50:32 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Syntax error broke PMs. (PersonalMessage.php)
Re: New revs
« Reply #2463, on February 19th, 2014, 09:30 PM »
[Commit revision 54a67a9]
Author: Nao
Date: Wed, 19 Feb 2014 21:30:35 +0100
Stats: 3 files changed; +4 (insertions), -1 (deletion)
  • Assigning we::$id to the first found $id_member (while waiting for a more accurate result), allowing data unserialize() errors to be attributed to the (hopefully) correct user. (Class-System.php)
  • Another error in PMs. (PersonalMessage.php)
  • Error when saving profile. (Profile-Modify.php)
Re: New revs
« Reply #2464, on February 19th, 2014, 11:04 PM »
[Commit revision 78930ff]
Author: Nao
Date: Wed, 19 Feb 2014 23:04:24 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Inverted values in the cache_get_data helper. Oops! (Subs-Cache.php)
Re: New revs
« Reply #2465, on February 20th, 2014, 01:31 PM »
[Commit revision 6fed32d]
Author: Nao
Date: Thu, 20 Feb 2014 11:13:50 +0100
Stats: 1 file changed; +40 (insertions), -39 (deletions)
  • Reverted wess_rgba changes from Dec 2013, because PHP 5.3+ doesn't accept calls to protected methods within closures that are declared inside a child class. This doesn't make sense at all, it's definitely a PHP bug, and I'm going to file a complaint at office 2A, but they're claiming I need to get hold of form 637-5c before I can proceed, and I don't know where I can get it. Perhaps from GitHub's customer support, but they're telling me that using a fake address in my commits is no longer supported and I'll now have to rewrite the entire history of all my repos and break everything for everyone because they can't make exceptions for not-so-fake addresses. Also, rewriting history forces me to get form 67E from the TheseThingsPissMeOffice, and I just checked, their address was fake.
[Commit revision 6207a43]
Author: Nao
Date: Thu, 20 Feb 2014 11:31:34 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Syntax error breaking registration. Another 'oops', but honestly, I expected more errors at this point. (Register.php)
[Commit revision 427c1a2]
Author: Nao
Date: Thu, 20 Feb 2014 11:32:14 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Better pixel placement of my avatar. I'm a bit vain, I'll admit it. (Credits.php)
Re: New revs
« Reply #2466, on February 20th, 2014, 11:17 PM »
[Commit revision cf99d97]
Author: Nao
Date: Thu, 20 Feb 2014 22:49:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Fixed duplicate headers breaking HTML validation. Hopefully, won't break AJAX mode. Shouldn't. (Thoughts.template.php)
[Commit revision 7c35f7d]
Author: Nao
Date: Thu, 20 Feb 2014 22:50:41 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Fixed duplicate classes in board template. (Boards.template.php)
Re: New revs
« Reply #2467, on February 21st, 2014, 04:04 PM »
[Commit revision 21457af]
Author: Nao
Date: Fri, 21 Feb 2014 12:26:25 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Another validation problem... It's sad to add an allowedTo() test just for that, but it'll never be called again once a thought is posted on your forum. (Thoughts.template.php)
[Commit revision 2904574]
Author: Nao
Date: Fri, 21 Feb 2014 16:03:39 +0100
Stats: 5 files changed; +13 (insertions), -10 (deletions)
  • Added $context['protocol'] variable, which saves some typing when trying to determine the current HTTP protocol. (Class-System.php, Credits.php, ManageServer.php, QueryString.php)
  • Fixed support for HTTPS protocol in pretty URLs. (PrettyUrls-Filters.php)
Re: New revs
« Reply #2468, on February 22nd, 2014, 08:58 AM »
[Commit revision dae4508]
Author: Nao
Date: Sat, 22 Feb 2014 08:58:13 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • I somehow managed to screw up the upgrade process. I'll rework this one to add an extra step to fix everything, but in the meantime, a quick fix to make stuff usable. (Upgrade.php)
Re: New revs
« Reply #2469, on February 22nd, 2014, 06:58 PM »
[Commit revision 8fe7997]
Author: Nao
Date: Sat, 22 Feb 2014 18:37:44 +0100
Stats: 6 files changed; +418 (insertions), -110 (deletions)
  • Rewrote the json_encode fallback: added encoding support, restarted from a fresh (and more recent) copy of Services_JSON, fixed a few bugs, removed we_json_encode and instead used the original function names, which are only declared if not already present. Also... For the first time in days, I've actually tested my code! Lol. (Class-JSON.php, Profile-Actions.php, Subs-Cache.php, Subs.php, Admin.template.php, Stats.template.php)
  • Prevent admin setting labels from enclosing descriptions. Previously, this would have prevented selecting the description text, which in a few situations might not have been desirable. (Admin.template.php)

Posted: February 22nd, 2014, 06:38 PM

[Commit revision 0b47a00]
Author: Nao
Date: Sat, 22 Feb 2014 18:58:04 +0100
Stats: 4 files changed; +6 (insertions), -1 (deletion)
  • Replacing footer logos with the new logo! (assets/wefoot*.png)
  • Ensured the correct logos are used against the correct backgrounds. (index.css, Wine/extra.css)
  • Ensured user can select the contents of notification popups. (index.css)
Re: New revs
« Reply #2470, on February 23rd, 2014, 07:13 PM »
[Commit revision 730d88b]
Author: Nao
Date: Sun, 23 Feb 2014 19:13:47 +0100
Stats: 1 file changed; +34 (insertions), -0 (deletion)
  • Fixed error when deleting media albums (thanks ema for pointing it out). Restored deltree function, a simpler version of it at least, in the media code. This was due to my grepWin setup recently adding 'media' in the list of ignored folders, when I only wanted to ignore 'root/media', not 'root/core/app/media'. Oops. Hopefully, this will be the only hiccup caused by this. (media/Aeva-Gallery2.php)
Re: New revs
« Reply #2471, on February 24th, 2014, 12:59 AM »
[Commit revision 13ab30b]
Author: Nao
Date: Mon, 24 Feb 2014 00:59:32 +0100
Stats: 1 file changed; +3 (insertions), -4 (deletions)
  • Fixed a quick 'jump' effect on page loading if the language selector was enabled. This was due to select boxes being hidden with the visibility setting, causing the browser to count them towards their dimension calculations. Whatever. The man is saying it's fixed. Don't bother with the ingredients. (index.css)
Re: New revs
« Reply #2472, on February 25th, 2014, 11:14 AM »
[Commit revision c690ad4]
Author: Nao
Date: Tue, 25 Feb 2014 11:13:54 +0100
Stats: 2 files changed; +20 (insertions), -0 (deletion)
  • The skin selector wasn't working for guests since I removed theme support. Used the opportunity to improve it by putting the skin setting into a cookie for guests, and removing the cookie when logging in. (Class-System.php, Themes.php)
Re: New revs
« Reply #2473, on February 25th, 2014, 07:27 PM »
[Commit revision 9859c51]
Author: Nao
Date: Tue, 25 Feb 2014 18:41:46 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Undefined index on 404 errors. (QueryString.php)
[Commit revision 523347b]
Author: Nao
Date: Tue, 25 Feb 2014 18:43:01 +0100
Stats: 1 file changed; +9 (insertions), -8 (deletions)
  • There's a strong chance MID isn't defined at the time it's tested against in is_not_banned. Never generated an error for me, but better safe than sorry... (Security.php)
[Commit revision 3b958f2]
Author: Nao
Date: Tue, 25 Feb 2014 18:46:12 +0100
Stats: 1 file changed; +3 (insertions), -2 (deletions)
  • Made title classes a bit less horrible in Wine. I really need to rework this skin... (Wine/extra.css)
[Commit revision 323f8b0]
Author: Nao
Date: Tue, 25 Feb 2014 19:19:34 +0100
Stats: 2 files changed; +11 (insertions), -3 (deletions)
  • Ah, the serialize bug... I've worked hard on this. I reproduced the original conditions. I was completely unable to trigger it again. It looks like I'm the only one who got affected by it, so... I'll be praying that it doesn't happen again, and in the meantime, I'm adding a solution that seems to work if the bug happens again. I don't want to waste any more time on this when I have so much work left to do. (Class-System.php)
  • Commenazi. (Upgrade.php)
Re: New revs
« Reply #2474, on February 25th, 2014, 07:47 PM »
[Commit revision 7e84d56]
Author: Nao
Date: Tue, 25 Feb 2014 19:47:36 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
  • Guest error. (Class-System.php)
Plugin revs »