New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2130, on May 23rd, 2013, 04:11 AM »
(4 modified, 6KB)

Revision: 2130
Author: arantor
Date: 23 May 2013 03:11:25
Message:
! Database error during newsletter sending. (ManageNews.php)

! Improved UI for sending newsletters, including removing ridiculous SMF logic of hiding post count groups if post count permissions are disabled. (ManageNews.php, ManageNews.template.php, mana.css, Admin language file)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/skins/mana.css
Re: New revs
« Reply #2131, on May 23rd, 2013, 04:13 PM »
(11 modified, 13KB)

Revision: 2131
Author: arantor
Date: 23 May 2013 15:11:28
Message:
! Indefinitely long infractions lasted very long indeed... right up until the next page load. (ManageInfractions.php)

! The user shouldn't be told they are post/PM banned if only one of those things is true. (Security.php, Subs-Template.php, index.english.php)

! Admins can now get people to re-agree to the reg agreement. There's also a few related changes that are needed to make this stuff work, since we don't want to quietly remove certain types of warning status when we shouldn't. At least, it seems to work for me... (CoppaForm.php, ManageRegistration.php, Profile-Actions.php, Reminder.php, Subs-Login.php, Register.template.php, Admin language file)
----
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/index.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2132, on May 23rd, 2013, 10:57 PM »
rev 2132
(6 files, 5kb)

* Had some room for improvement in wedge_get_css_filename... Rewrote to use array keys instead of values, so it's about twice faster now (we're talking about fractions of a milliseconds, so whatever... I like saving time, all right?), and also removes the 'member' keyword if a 'mID' keyword is already present (ID being your member ID). (Subs-Cache.php)

* Tweaked 'time remaining' box in the admin area to give breathing space to the menu below, hey, it's just three extra bytes... (Admin.template.php)

+ French translation. (Admin, Help, ManageSettings)
Re: New revs
« Reply #2133, on May 24th, 2013, 11:10 PM »
rev 2133 -- I really, really wanted to commit all of this now... Even though I'm quite ashamed of how I implemented the first feature in the list... :(
(22 files, 7kb)

+ Added more flexibility to auto-suggest popups, by determining the minimum applicable characters depending upon the number of members of your forum. It may seem like nothing, but on smaller forums, when you're typing 'Nao' and it only suggests me after you type those three letters, it just seems silly... The number of members I determined is arbitrary, feel like to change it. Even the function name, and the way it's used in auto-suggests, can be changed to whatever one feels works best... Really, I'm not fussed. Feel free. Have a drink and tell me what you want. (ManageBans.php, Aeva-Gallery2.php, ManageMedia2.php, Subs.php, ManageBoards/Maintenance/Membergroups/News/Paid.template.php, Media.template.php, PersonalMessage.template.php, Profile.template.php, pm.js, suggest.js)

* Renamed wePersonalMessageSend() to weSendPM()... Seriously, I don't know how it managed to survive with that name for so long... And the object creation also had a left-over unused param. (PersonalMessage.template.php, pm.js)

* Renamed url-no-base64() to raw-url(). While no-base64 is easy to understand for developers, it might not be for themers, so I thought it best to just use plain regular English. Behavior is the same. (Class-CSS.php, Subs-Cache.php, common.css, index.css, index.member.css, mana.css, sections.css)

* Tweaked error box padding. Again. This time it's for the main post page... (sections.css)

* Translation. (index.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2134, on May 26th, 2013, 11:39 PM »
(9 files, 12KB)

Revision: 2134
Author: arantor
Date: 26 May 2013 22:38:23
Message:
! Improved maintenance: allow moving old topics based on number of days, picking source boards, that kind of thing. I even tried to get the translation right. (Oh, yes, I did also clean up the strings slightly to fix compounding issues.) (ManageMaintenance.php, ManageMaintenance.template.php, ManageMaintenance language file)

! Remove bulk topics: there are two kinds of locked topics, not accounted for in SMF either, also in our case it's possible that the remove topics function could be called, legitimately, for a topic that no longer exists. This should be able to be handled safely without an error (intentionally) (RemoveTopic.php)

! When approving posts, the last message id needs to be recalculated otherwise weird things can happen, like messages you can't actually mark as read. (Subs-Post.php)

! Post moderation status needs to be maintained more than before now there are other ways to get posts moderated that aren't related to the moderation filters. (Load.php, ManageModeration.php, Post2.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2135, on May 27th, 2013, 10:53 AM »
rev 2135
(7 files, 8kb)

+ Added a hover preview of posts that triggered a notification. A good start! Still needs work, but it works for now. Also added a get_single_post() helper function which might need some love from Pete (security-wise maybe?) if we use it elsewhere... (Class-Notification.php, Notifications.php, notifiers/Likes.php, Subs.php, script.js, index.css)

* Renamed Class-NotifierLikes.php to just Likes.php (Notifications.php, notifiers/*)

* French tweaks. (ManagePermissions.french.php)
Re: New revs
« Reply #2136, on May 28th, 2013, 10:56 PM »
rev 2136 -- first batch...
(5 files, 3kb)

! Fixed not being able to Like a thought when its privacy was set to 'Contacts'. And another similar bug in the Welcome area, but whatever. (Like.php, Welcome.php)

! Fixed JavaScript error in mobile devices when visiting forum in guest mode. I actually had to reinstall the Android SDK and do remote debugging to figure it out... Why doesn't Chrome have a friggin' error console..?! (Thoughts.template.php)

! Missing global. Probably broke thought threads in some situations; never experienced, though... (Thoughts.template.php)

! Fixed post options alignment on mobile... Blah blah. (editor.css)

! Fixed select boxes triggering the change() event even when on a disabled or hidden item, if by any chance you hit the Tab key -- for instance, click the quick access select box, then hit Tab... And there you go, a bug. (sbox.js)
Re: New revs
« Reply #2137, on May 28th, 2013, 11:09 PM »
rev 2137 -- last batch.
(4 files, 3kb)

* Rewrote notification popup's way of showing previews. Instead of showing a side panel for the currently hovered notification, Wedge now expects you to click the notification item and it will show the preview below the item, making it possible to view previews in smaller screens. Relatively easy to revert, in case it's needed. (Notifications.template.php, script.js, index.css)

! Fixed smileys on mobile. It seems that Chrome for Android made some recent change to the way they handle a line-height of zero, thus hiding smileys entirely. This new technique is also faster to render, says Jeffrey Zeldman. Also applied the same fix to BBC links. (index.css, sections.css)

* Also updated select boxes to be shown, while still off-screen, now a bit less further away, ahem, a thousand times closer in fact... It should still be enough, and I have no other solution right now that still preserves change/focus events set directly on the select box. So, a thousand times closer it will be. (index.css)
Re: New revs
« Reply #2138, on May 29th, 2013, 11:02 AM »
rev 2138
(6 files, 3kb)

! Fixed subjects and messages sometimes not allowing a single content of '0' (thanks John). Although it's unlikely you'll want to use that, it still should be allowed... Otherwise, why allow for '1'? Also of note, I removed a safety from the draft code in PersonalMessage.php, I don't think it was needed at all. Pete might wanna have a look though... Just to be sure, since it's his code. (Display.php, PersonalMessage.php, Post.php, Post2.php, Profile-View.php, Search2.php)
Re: New revs
« Reply #2139, on May 29th, 2013, 11:15 PM »
rev 2139 -- yay, micro-optimizations..?
(6 files, 4kb)

+ Added support for rect() retro-compatibility to Wess. Specifically, IE 6/7 expect commas not to be used, so you're now free to use the standard commas, and IE 6/7 will remove them. Just, hmm, don't use silly unrelated comma-separated values inside your rect() function, but... There's no reason to, is there..? (Class-CSS.php)

* Increased execution speed for retro-compatibility code. Initially, I was doing a smart implode on all test strings, to run a single preg_replace_callback. After a couple of tests, I realized that doing them individually, whatever the number of tests, was 5 to 10 times faster. Okay, then... I guess sometimes, benchmarking isn't a waste of time. (Class-CSS.php)

* Theoretically, increased execution speed for CSS layout, as I definitely gave up on text-indent hacks to focus on clipping. Costs a few extra bytes, but it's safer, and seems to work just fine in all browsers I tested in. (index.css, sections.css)

- Profile statistics added some redundant HTML that was subsequently hidden by CSS. Yeah, sure. Removed said HTML and its related CSS hack. (Profile.template.php, sections.css)

- Moved profile statistics pie to external. Seriously, there never was a need to embed this one, as it's only seen on one obscure profile page, and it saves a whooping 1.5KB from the final CSS file. Hopefully, I didn't miss anything else... I guess..? (sections.css, extra.rtl.css)

! A quick and easy fix to hide the related notification preview, if opened, if you attempt to mark the notification as read. (script.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2140, on May 30th, 2013, 03:56 AM »
(9 modified, 16KB)

Revision: 2140
Author: arantor
Date: 30 May 2013 02:55:43
Message:
! Too many places need SimpleXML for it not to be a dependency at install-time, I'd say. (install.php, Install.english.php)
! number_context could get screwed up if the number being formatted would have had a comma in it but the array entry not. Which could be a problem... so better to not go there. (Subs.php)
! If in the moderation centre, highlight the right menu button, the moderate menu is under the admin menu... (Subs.php)
! Display the posts of a user that generated reports inside their profile. (Profile.php, Profile-View.php, Profile, Profile language file)

:edit: Forgot this on the changelog: ! Move the action hook earlier for those rare cases it does need to be done dynamically. (index.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Profile.english-uk.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/index.php
Modified : /trunk/root/install.php
Re: New revs
« Reply #2141, on May 30th, 2013, 05:56 AM »
(7 files, 8KB)

Revision: 2141
Author: arantor
Date: 30 May 2013 04:54:45
Message:
! Buffer hook couldn't load files properly, poor hook. (Thanks live!) (Subs-Template.php)

! Ability to merge current members. Seems to work for me. Does not handle drafts or PMs and probably some other stuff too. The destination account keeps its own profile settings etc., none of those are imported from the source account. Also includes a bonus hook for notifying plugins about reattribution in case plugins want to update their stuff too. (ManageMaintenance.php, ManagePlugins.php, Subs-Members.php, ManageMaintenance.template.php, ManageMaintenance and Modlog language files)

! Reattribution does actually bother to fix reported posts now. (ManageMaintenance.php)
----
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2142, on May 30th, 2013, 06:11 PM »
rev 2142 -- What is twenty-one times two?
(6 questions, 4 answers)

! Create cache.lock file at install time, so we don't have to deal with it later. Also removed a few unused globals. (install.php)

! dynamic_group_colors function was using MySQL, which killed the install process when showing the HTML header. (Subs-Cache.php)

* Simplified cache_put_data/cache_get_data functions by moving their (similar) init code to a stand-alone function. Harmonized another function to use the same naming scheme. (Subs-Cache.php)

* French translation. (Install, ManageMaintenance, Modlog, Profile)
Re: New revs
« Reply #2143, on May 30th, 2013, 06:38 PM »
rev 2143
(1 sin, 498 bytes) (I think it's the first time I'm getting a commit size in *bytes*, really...)

! Apparently, not fourty-two. Because I love doing meself some last-minute refactoring with an extra layer of bugs. (Subs-Cache.php)
Re: New revs
« Reply #2144, on June 1st, 2013, 12:26 AM »
rev 2144 -- just to get this one out of the way, I guess...
(1 file +2-2, 178kb)

* Updated jQuery to versions 1.10 and 2.0.1, as Google is now hosting them. They're one week late! (Load.php, jquery-1.10.0.min.js, jquery-2.0.1.min.js)
Plugin revs »