New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2055, on April 14th, 2013, 12:50 AM »
rev 2055
(1 file +1-1, 84kb)

* Updated jQuery 2.0b1 to beta 3. Odd that they're changing their naming scheme, but whatever... As far as I could see, this beta has no issues, contrary to beta 2, so I hope I won't have to revert it later. It saves an additional 200 gzipped bytes compared to the first beta. Which is particularly nice. (Load.php, jquery-2.0.0-beta3.min.js)
Re: New revs
« Reply #2056, on April 14th, 2013, 04:25 PM »
rev 2056 - I just killed XML! Yay!
(7 files -1, 7kb)

! Fixed Split Topics no longer working due to a template change. This has probably been around for a long, long time... (Split.php)

- Removed the last remaining XML templates. Everything is now done through return_xml() calls, and I recommend that you do the same. Again, XML data is not template material. (Ajax.php, Load.php, Post.php, Suggest.php, Xml.template.php)

* More uses of return_raw and return_xml throughout the rest of Wedge. More left to do, but first I need to determine whether I should add more helper functions for return values that don't require being passed through ob_sessrewrite... Minor headache. (Like.php, ManageMedia.php, Split.php)
Re: New revs
« Reply #2057, on April 15th, 2013, 11:40 AM »
rev 2057 -- SSI and XML fixes. Or breaking more things, maybe ;)
(4 files, 2kb)

! ssi_examples was horribly broken... Well, maybe not horribly, but it needed fixin'. (root/ssi_examples.php)

- Forgot to remove a Xml template call. Seems harmless, but broke all thoughts and board selector... Oops. (Ajax.php)

* Search2 no longer replies to AJAX calls, AFAIK, so it was needlessly calling a template block for it. (Search2.php)

! ssi_quickSearch was broken due to a very, very old change. I'm using the opportunity to add our output buffer handler to SSI, which is probably going to be controversial, so I'm repeating in case it's unclear or we need to revert: from now on, any calls to SSI will call pretty URLs, <URL> and other things on your page. Understood..? (SSI.php)
Re: New revs
« Reply #2058, on April 15th, 2013, 11:48 AM »
rev 2058
(3 files -1, 5kb)

* Simplified CSS button extends, removing per-button :hover declarations (replaced them with a similar but shorter and cooler solution), opting for a mixin instead of a base, and saving a hundred bytes in the process. Never underestimate the power of refactoring. (common.css, index.css)

* Moved all of extra.webkit.css's hacks to the main files. Yet another proof that while maintaining separate files is cleaner, sometimes it creates bugs due to oversights when removing features. (Plus, grouping items thematically compresses better, as always.) (extra.webkit.css, index.css, sections.css)
Re: New revs
« Reply #2059, on April 15th, 2013, 06:15 PM »
rev 2059
(6 files, 10kb)

* Renamed 'custom_fields_above_signature' class to just 'custom_fields'. Unless I missed something, there's no reason to have such a long class name, and even worse, a name that gives away a position -- what happens if you want to move it around, eh...? Also harmonized border colors, and removed an odd repetition in border declarations. (Msg.template.php, PersonalMessage.template.php, Profile.template.php, sections.css, extra.rtl.css)

- Removed a couple of styles that were unneeded (one was my fault, the other was obviously a very old one). With the addition of the custom fields tweak, today I saved about 20 bytes in the gzipped CSS. And more is coming... (sections.css)

! Fixed two minor bugs in Recent template: the main page ID was repeated twice (id="recent"), and if you happened to view the Latest Posts page in guest mode and one of the posts had been liked, your HTML would be broken. Not in a way that breaks the page, but it did make the validator complain. Also indenazi, related to removing the unneeded id="recent" divs... (Recent.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2060, on April 15th, 2013, 08:07 PM »
(12 files, 4KB)

@ This is really just the stuff I can commit right now, just so I can brain-dump a little bit. There's so much more stuff outstanding and waiting to be committed, but this at least lets me focus on what's left without it seeming like quite so much of a Wall. (I still have 36 files + 4 additions to commit.)

Revision: 2060
Author: arantor
Date: 15 April 2013 19:04:03
Message:
! Use the nice notice feature for a menu in the gallery area. Only noticed it accidentally on wedge.org (Aeva-Gallery.php)

! A minor change that doesn't affect anything else: whether the 'warning status' is shown in the profile fields area as a 'disabled' field or not. It won't be controlled from there, so it's safe to remove it. (ManageMemberOptions.php)

! Style changes that the infractions system will use. Won't affect anything currently in play to my knowledge. (index.css, index.member.css)

! Don't cache the menu. (Subs.php)

! Don't need to decrement the warning count - we don't do it that way any more. No effect on wedge.org, there are no users with warnings at present. (ScheduledTasks.php)

! We don't need these old permissions any more. Again, since we're not using this on wedge.org, bye bye. The bits where these permissions are checked is pending because there's a bunch of related stuff in those files that needs fixing up. (ManagePermissions.php, ManagePermissions and Reports language files)

! (Forgot this in the actual changelog) Preset some variables for later. (Class-System.php)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2061, on April 18th, 2013, 06:20 PM »
rev 2061 -- plenty of little bug fixes... As in r2060, I'm just cleaning up my stuff to make way for my upcoming CSS rewrites.
(7 files, 5kb)

! Missing global... Not that it really matters, as I'm not going to keep this image file around in the thought XML forever, eh... (Ajax.php)

! A recent Wess update slightly, but completely, broke support for multiple attribute selectors and the likes... Oops. (Class-CSS.php)

! The media admin page would give PHP strict warnings about a misused object. Used the opportunity to give more freedom to the admin page to resize its option descriptions. (ManageMedia.php, Media.template.php)

! Plugins that modified $txt strings would sometimes end up being ignored. Meh, it looks like I never actually committed the related fix I discussed in late January, and I even lost it at some point... (Subs.php)

! Validation error. Name attributes in anchors are deprecated... (MessageIndex.template.php)

* As discussed before, any class used in conjunction with .windowbg/.windowbg2 in the HTML itself, should use the 'final' keyword when its CSS uses these, as in '.windowbg.class-name'. This is because otherwise, all other classes that extends .windowbg will be added to the list... This saves over 50 gzipped bytes. Just with the extra keyword. (index.member.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2062, on April 19th, 2013, 04:01 AM »
(4 files, 15KB, though I really have no idea why it's so huge. Note I still have 36 modified, 4 new to commit.[1])

Revision: 2062
Author: arantor
Date: 19 April 2013 02:59:14
Message:
! Ooops, this one didn't get the $context['action'] treatment. (Groups.php)
! Should have fixed this in the menu code before. The rest of caching goes bye bye. The diff looks so much worse than it actually is. (Subs.php)
! New hook. (ManagePlugins.php)
! Another bit of style goodness. And before we go around the merry-go-around yet again, this is for the list of warnings on an account which could theoretically be seen by any registered member. (index.member.css)
----
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/skins/index.member.css
 1. Assuming I retain enough of my sanity with it to do so.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2063, on April 19th, 2013, 06:31 PM »
rev 2063 -- thought system rewrite! Again!
(8 files, 8kb) -- BTW Pete, since you were wondering: re-indenting an entire block is seen as a full rewrite by SVN, hence your huge commit ;))

* Rewrote large parts of the thought system to improve its flexibility. Basically, every Ajax action will now refresh the entire thought list, which has a few advantages: no need to provide a hidden new_thought template, new thoughts from other users will also be shown in the refresh, and it should allow for thought menus in threaded view; which isn't implemented yet, but it'll come soon... The only drawback, of course, is the extra bandwidth use, but it's not like posting/editing thoughts is going to kill your server anyway... Or is it? Also of note, I moved the URL-breaking JavaScript code to its own function (breakLinks), so now you can call it from within your plugins if you ever do the same kind of manipulation. This adds 12 gzipped bytes, but since the thought rewrite shaved off exactly 58 bytes of JavaScript, this means we still save 46 bytes. Oh, and if you like breaking rules, check out the new code in Ajax.php, it's pretty... interesting. (Ajax.php, Thoughts.php, Thoughts.template.php, Welcome.template.php (it's only for the principle -- it needs a complete rewrite), index.member.css, and sections.css)

! Clicking the BCC link in PM pages would send you to the top of the page... (pm.js)

! Fixed a JS error that would show up when loading any SSI page, due to the notification check not finding the we_notifs variable declared anywhere. I'm a bit upset that it adds a couple of bytes to the filesize, but... I know, I know, I should find some help. (script.js)

! Fixed status icons being too tall in IE6. (sections.css)

! Fixed thought mini-menus overlapping one another in IE 6/7. This is due to an IE bug that I couldn't find any information about. I've documented everything over at wedge.org, but in the end I decided to 'simply' show these menus to the right of the button, rather than below, because we don't have menu arrows in oldIE anyway... Note that this is only a partial commit, and it might not work until I'm finished with the rest. (sections.css)
Re: New revs
« Reply #2064, on April 19th, 2013, 07:03 PM »
rev 2064 -- the 'I can already smell someone reverting this...' commit :P
(3 files +1-1, 86kb)

* Updated jQuery to version 2.0 final. They managed to remove hundreds more bytes compared to the very recent beta 3... They're my heroes, definitely. (Load.php, jquery-2.0.0.min.js)

+ Added an optional $txt['lang_hreflang'] string, that can be set to 'force' a language's hreflang for SEO purposes. Not that it's very important, but I wanted to implement it in a clean way that didn't cause any harm to 'main' language files, so this is it... The string falls back to $txt['lang_dictionary'], i.e. the previous default. As of now, the 'code' array entry is no longer used anywhere, so  (Load.php, index.template.php, index.english-uk.php)
Re: New revs
« Reply #2065, on April 20th, 2013, 08:03 PM »
rev 2065 -- I like nested stuff!
(7 files, 4kb)

+ Finally added support for mini-menus in thought threads ("In context" pages). Tough job... Also added privacy icons to them; I'm not sure why I forgot to show them in the first place... (Ajax.php, Thoughts.php, Thoughts.template.php, index.member.css, sections.css)

* Don't show a hard link to user's posts in their profile page if they never posted. Link remains available in the profile menu, but feel free to remove it as well. I don't mind either way... (Profile.template.php)

! Mini-menu would fail to position correctly when un-ignoring a post from an ignored user, and then attempting to open the 'More' link. (Display.template.php)

* Moved some inline styles to CSS. (Thoughts.template.php, sections.css)

* Multiple extends (extends ".class1, .class2") are cool, but not so much when .class2 doesn't do anything special... (sections.css)
Re: New revs
« Reply #2066, on April 21st, 2013, 11:32 AM »
rev 2066 -- making Wedge less buggy, one file at a time.
(1 file, 3kb)

! Fixed member recount. Since Pete doesn't seem to be available to tell me what's best, I've done a tentative fix that seems to work. (ManageMaintenance.php)
  - Takes recycle board into account (and yes, I still want to remove that crap from Wedge...), since these boards still advertise themselves as wanting post counts, and we have to exclude them manually;
  - adds a GROUP BY clause to ensure we get all members in the final recount query. I'm surprised Pete's original commit from nearly 2000 revs ago already didn't have it...
  - updates post count as well for members that aren't found in the messages table anymore. At least, in the case of test boards, it can be useful.
Re: New revs
« Reply #2067, on April 23rd, 2013, 11:45 AM »
rev 2067 -- everything I could find from sections.css, and some satellite files...
(13 files +4 -1, 24kb)

- Removed ability to ask for a topic notification from within places that do NOT show the entirety of the topic... It only makes sense to require someone to at least have a glance at a topic, before they can determine whether it's worth their attention at all... (Profile-View.php, Recent.php, Search2.php, Profile.template.php, Recent.template.php, Search.template.php)

* Push my button. Saved over 500 bytes from the final CSS filesize... Not bad, I guess..? (blank-button.png, warn.png, quickbuttons-32bit.png, approve.gif, restore.gif, actions.png, warn.gif, extra.rtl.css, sections.css)
  - Reworked the 'in context' button from a new blank-button I quickly cooked up, as well as warn.gif to make it more readable.
  - Removed notify.gif button, as it was only used in those places I removed.
  - Removed notify_sm.gif, I couldn't for the life of me find a place that uses it. Anyone else, maybe..?
  - Split approve and restore buttons out of the button sprite, as they're very, very unlikely to be ever seen, even by an admin...

! Better alignment for plugin icons in admin menu. (mana.css)

! Fixed top left margin in thought threads. (sections.css)

- Removed flex use from topic posts. You can still use @if can_flex in your CSS to provide a fallback for non-flex supporting browsers, but I'd advise against using nested flexboxes, as they're VERY, VERY buggy, and even browser authors recognize it... So, basically, doing rowspans and colspans in flex..? Not a very good idea of mine. The only ways to do that, are table tags, or the grid layout from IE10, which I'll try and implement, once it's available in Chrome, and perhaps in Firefox... But I wouldn't hold my breath. Sob. Also, upped the minimum versions of Chrome and Firefox to support flex, as earlier versions are even buggier... See the pattern, eh..? And finally, restored support for Opera 12.1+, as in the end, it's not buggier than other browsers, it just is... differently buggy, I guess... (Class-CSS.php, sections.css)
Re: New revs
« Reply #2068, on April 25th, 2013, 01:29 PM »
rev 2068 -- better thoughts, again!
(11 files, 7kb)

* Rewrote though system to get rid of the sidebar area, and instead move the 'new thought' box to the thoughts area, wherever it is. (Homepage, Profile or All thoughts. Thought threads don't support it because it doesn't make sense, as the new thought won't, technically, be part of that thread, eh...) This saves a whopping 39 gzipped JS bytes, err... Well, I was hoping for more, but whatever... This also saves us from storing your latest thought in the database; while I thought it was nice to do, you can still see your latest thoughts from your profile, so why bother..? It was, probably, a minor waste of bytes. (Ajax.php, Like.php, Subs.php, Thoughts.php, Welcome.php, index.template.php, Thoughts.template.php, index.language.php, script.js, index.member.css)

+ Added a return_raw() helper function, very close to return_text() but it also bypasses gzipping and output buffering altogether. Which, I'd say, is quite welcome when you're returning only a couple of bytes... (Ajax.php, Subs.php)
Re: New revs
« Reply #2069, on April 25th, 2013, 04:41 PM »
rev 2069 -- mostly maintenance.
(22 files, 23kb -- over half of it due to re-indenting in zoomedia.js)

+ Added a we::$is_member variable, which is simply the opposite of we::$is_guest... Not that it's going to be very useful, but I don't see the reason to force people to use !we::$is_guest when they could use the other. Also, Wess did an extra test for guests and members, when it should already be dealt with by we::is(), so I removed these... There are still dozens to fix, but we're in no hurry. It's just my usual pedantry... (index.php, Class-CSS.php, Class-System.php, Display.php, Feed.php, Load.php, Login2.php, Aeva-Gallery.php, Aeva-Gallery2.php, Subs-Media.php, MessageIndex.php, Security.php, Thoughts.php, Welcome.php, Subs.php, Subs-Post.php, index.template.php, Boards.template.php, Display.template.php, MessageIndex.template.php)

! Fixed Wedge insisting on calling you a 'guest' if you're not logged in, even if you're not in English mode. (Class-System.php, Load.php)

! Fixed broken image in sidebar when no avatar is set for oneself. (Class-System.php, Subs.php, index.template.php)

* Moved Zoomedia's language strings to the JS file. Commented most of them out, since they're not really used for now... Saves space, eh? (Aeva-Subs-Vital.php, zoomedia.js)

* draftXmlReturn wasn't using the return_xml() shortcut, sadly... (Subs-Post.php)
Plugin revs »