New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2010, on March 19th, 2013, 06:29 PM »
rev 2010 - I kept dreaming of a world I thought I'd never see. And then, one day... I got in.[1] / Jeo haneur wi nunmullo geurin baramui soksagim gubigubi ttaraga geu soge jamdeunda...[2] / (...)[3] / À la belle étoile... Quelques étoiles fuyantes, et toi la bonne étoile.[4]
(7 files, 6kb)

! Finally fixing that undefined index error in QuickMod... Never really knew why it occurred, but there are more important things in life. (QuickMod.php)

! Ah, the joys of automatic replacements eh, Pete...? ;) Fixed $settings['language'] (the entire variable) being globaled several times... (Subs-Post.php)

! Fixed indenazi function for lines starting with text. My original intent was to prevent <pre> code from being indented, but then I realized that Wedge adds spans to them instead of just showing tab characters, so... (Subs-Template.php)

! Fixed reqWin('url string') not working since the jQuery update. I wouldn't recommend doing that, though... Also removed a couple of workarounds that were no longer necessary. Saved 7 bytes all in all. (script.js)

* Translation. Partial for notifications, I stopped in the middle to fix the English version and, one thing led to another... I'll finish it next time. (ManageSettings.french.php, Notifications.language.php)

* Commenazi. (ManageLanguages.php)
 1. Daft Punk, 'Tron Legacy'.
 2. Jang NaRa, a beautiful song from 'Dong Yi', a Korean period drama. Same composer wrote 'Dae Jang Geum' back in 2003, my first (and favorite) Korean show. I wanted to quote him back then, but Pete took the spot :lol:
 3. Insert Sugizo song quote here. Damn, can't find lyrics... He released some damn good singles that year. He's the guitarist for Luna Sea and X Japan, my favorite J-Rock bands, their best composer as well, a very gifted arranger, he works with Origa (who sang the Russian songs in Princess Arete in 2000), and is also a member of Juno Reactor... What's not to like?
 4. La belle étoile, in 'Les saisons de passage' (Mathieu Chédid). Best live/rock album of the year for me... You should listen to some French music guys -- it rocques!! :D

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2011, on March 19th, 2013, 09:12 PM »
(4 added, 2 modified, 4KB)

Revision: 2011[1]
Author: arantor
Date: 19 March 2013 20:07:45
Message:
! Spacinazi. (Agreement.english.php)
! Proper conjugation is *so* important, don't you think? (Errors.english.php)
! More English UK translations but that's enough for now. (Admin, Agreement, EmailTemplates, Errors language files)
----
Added : /trunk/Themes/default/languages/Admin.english-uk.php
Added : /trunk/Themes/default/languages/Agreement.english-uk.php
Modified : /trunk/Themes/default/languages/Agreement.english.php
Added : /trunk/Themes/default/languages/EmailTemplates.english-uk.php
Added : /trunk/Themes/default/languages/Errors.english-uk.php
Modified : /trunk/Themes/default/languages/Errors.english.php
 1. It's a long road down the river deep and wild,
Every twist and turn a wonder-dale,
It's a scary ride we'd give anything to take,
Let yourself bleed,
Leave a footprint on every island you see...

Ghost River - Nightwish's "Imaginaerum". Fantastic album.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2012, on March 20th, 2013, 07:05 PM »
rev 2012 - D'you like this music?[1] / I'm breakin' a sweat, it's all right. I'm breakin' a sweat! Come on baby light my fire.[2] / Who are you Mr. Blue, Mr. Blue Mr. Blue? How do you do Mr. Blue, Mr. Blue Mr. Blue?[3]
(5 files, 1kb -- oh, come on..??!!)

! Notification hook was sending the wrong variable. (Class-Notification.php)

! afterNotify method expected Notification object, was sent an array of Notification objects. Changed the declaration to expect an array. (Class-Notifier.php)

* Renamed ;area= to ;sa= in notification action (these are really sub-actions, not areas...), and ;id= to ;in=, to avoid the infamous (but probably quite rare) security protection against these. (Notifications.php)

* Finished notification translation. FWIW. (Notifications.french.php)

* Another remaining location.href needed to be reduced. (install.php)
 1. That's pretty much the only lyric in that song, ah ah... It's from SQ Party #3's Live set by the Stealth Boys. A remix of Chrono Trigger and other Square soundtracks. If you like these, go check it out! http://www.youtube.com/watch?v=Qa7wYR3mUjg
 2. I didn't know of this guy till a few weeks ago... So, apparently everyone hates him and he's a boys band or something like that. Still, I love that lesser-known song which I heard by chance, "Breakn' a sweat", from Skrillex. Probably because it reminds me of SQ Party..?! From what I've read, the SQ Party albums have plenty of dubstep in them. So, for the first time in like 20 years, am I actually liking a *current musical trend*..? I'm finished!
 3. And that would be my favorite rap/funk album of 2012... Hopefully a nice new trend in France -- 70's-inspired funk albums with English vocals, anoother example being the excellent G'S WAY released in 2011. Also, Roberto Fonseco's "Yo" album has great funk songs.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2013, on March 21st, 2013, 02:53 AM »
(14 modified, 1 added, 30KB)

Revision: 2013[1]
Author: arantor
Date: 21 March 2013 01:50:45
Message:
! Minor accuracy fixes and a couple of legacy strings, including English UK translation. (Help language file)

! We don't want no raw >, thanks. (Help, Notifications language files)

! Profile / Show Posts (and Topics) now shows like count for displayed posts. (Profile-View.php, Profile.template.php)

! Profile areas will disregard board-access permissions when a user is viewing their own posts. There is no reason for a user not to be able to see their own posts - they wrote them, after all. But if possible, the posts will not be linked to, and the user shouldn't have permissions for those boards anyway. (Profile-View.php, Profile.template.php)

! Users can now select to ignore another user directly from thread view. Not AJAXively, sorry, but not bad. (Display.php, Profile-Modify.php, index language file)

! There is no good reason to embed the main site into a frame or iframe on another domain. SSI should not be included, of course, because cross-origin requests could conceivably be made there legitimately. (QueryString.php)

! phpinfo() displayed in admin panel. I'm inclined to think some of the superglobal values should be pruned because they are meaningless in that specific context (e.g. URL used to get to the page) (Admin.php, ManageServer.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Added : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Modified : /trunk/Themes/default/languages/index.english.php
 1. I got no lyrics for this year, haven't heard a 'new' song I like yet.
Re: New revs
« Reply #2014, on March 21st, 2013, 08:05 PM »
(12 added, 18 modified, 24KB)

Revision: 2014
Author: arantor
Date: 21 March 2013 19:04:12
Message:
! Missing static variable. (Display.php)
! Fallback measures weren't quite correct in language loading in the event of certain combinations of default language. (Load.php)

! Required custom fields on the registration page should include required field indication. (Profile.php)

! While we're on the subject, CAPTCHA and question fields should also be indicated as required to the browser. Yes: competent browsers won't even send the page off the first place until these are filled in, which might save some page requests. (GenericControls.template.php)

! No point indicating the rel="search" if the user can't see it. (index.template.php)

! Legacy strings go bye-bye. (Error, Login language files)

! Accuracy tweaks (Install, ManageMaintenance language files)

! Oops, missed some other things that should have been entitised. (Notifications language file)

! 'New posts while you were...' warnings should have been number-context strings. (Post.php, Post language file)

! More UK translation. Some of these are ugly placeholders, bah. (*.english-uk.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Added : /trunk/Themes/default/languages/Install.english-uk.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/Install.french.php
Added : /trunk/Themes/default/languages/Login.english-uk.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Added : /trunk/Themes/default/languages/ManageBans.english-uk.php
Added : /trunk/Themes/default/languages/ManageBoards.english-uk.php
Added : /trunk/Themes/default/languages/ManageMail.english-uk.php
Added : /trunk/Themes/default/languages/ManageMaintenance.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Added : /trunk/Themes/default/languages/Modlog.english-uk.php
Added : /trunk/Themes/default/languages/Notifications.english-uk.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Added : /trunk/Themes/default/languages/Post.english-uk.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Added : /trunk/Themes/default/languages/Settings.english-uk.php
Added : /trunk/Themes/default/languages/Stats.english-uk.php
Added : /trunk/Themes/default/languages/Who.english-uk.php
Re: New revs
« Reply #2015, on March 21st, 2013, 11:48 PM »
(6 modified, 18 added, 41KB)

Revision: 2015[1]
Author: arantor
Date: 21 March 2013 22:42:32
Message:
! I forgot that the installer doesn't normally load English as a fallback - but now it does, especially in case of other languages that don't have a complete language pack. On top of that, (crudely) display the flags to users when selecting their language, updating the mapping of Accept-Language to language packs, and fix the fact that the installer wanted jQuery 1.5.2 but that the selectbox needs a higher version, and just for fun, actually display the language's *name* rather than its internal code to users. (install.php)

! I have no idea why the expiry date is 1997 except for it's the date used on the PHP example page. Set it to something a little more... appropriate. (current-version.php, install.php, Errors.php, Subs-Template.php)

! Accuracy update. (ManagePlugins language file)

! Hopefully the rest of English UK (*.english-uk.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Subs-Template.php
Added : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Added : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Added : /trunk/Themes/default/languages/ManagePaid.english-uk.php
Added : /trunk/Themes/default/languages/ManagePermissions.english-uk.php
Added : /trunk/Themes/default/languages/ManagePlugins.english-uk.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
Modified : /trunk/Themes/default/languages/ManagePlugins.french.php
Added : /trunk/Themes/default/languages/ManageScheduledTasks.english-uk.php
Added : /trunk/Themes/default/languages/ManageSettings.english-uk.php
Added : /trunk/Themes/default/languages/ManageSmileys.english-uk.php
Added : /trunk/Themes/default/languages/ManageTopics.english-uk.php
Added : /trunk/Themes/default/languages/Media.english-uk.php
Added : /trunk/Themes/default/languages/ModerationCenter.english-uk.php
Added : /trunk/Themes/default/languages/Packages.english-uk.php
Added : /trunk/Themes/default/languages/PersonalMessage.english-uk.php
Added : /trunk/Themes/default/languages/Profile.english-uk.php
Added : /trunk/Themes/default/languages/Reports.english-uk.php
Added : /trunk/Themes/default/languages/Search.english-uk.php
Added : /trunk/Themes/default/languages/Security.english-uk.php
Added : /trunk/Themes/default/languages/Themes.english-uk.php
Modified : /trunk/other/xml/current-version.php
Modified : /trunk/root/install.php
 1. The time-traveling is just too dangerous. Better that I devote myself to study the other great mystery of the universe: women! (I couldn't let 2015 go by without a BTTF reference!
Re: New revs
« Reply #2016, on March 22nd, 2013, 04:41 AM »
(4 files, 4KB)

Revision: 2016
Author: arantor
Date: 22 March 2013 03:40:59
Message:
! Ancient crusty bits in the styling. (ManagePlugins.template.php)

! Display likes in the recent-posts page too. (Recent.php, Recent.template.php)

! On the standard home page, link the board names to their boards for the 'recent posts' bit, it's bugged me for ages. (Home.template.php)

! Notifications should declare a page title where it needs one. (Notifications.php)
----
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Themes/default/Home.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/Recent.template.php
Re: New revs
« Reply #2017, on March 23rd, 2013, 05:22 AM »
(36 files, 17KB)

Revision: 2017
Author: arantor
Date: 23 March 2013 04:20:22
Message:
! Syntax error I added back in October 2011, complete with commit note of 'not tested'. And guess what, it still isn't tested, but I found a syntax error anyway that needed fixing! Yeah, shows you how often we test the COPPA form. (CoppaForm.php)
! PayPal language should be deferred back to the language files. (Subscriptions-PayPal.php, index language files)
! add_linktree use pretty much everywhere. (everything else)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Themes/default/languages/index.english-uk.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2018, on March 24th, 2013, 04:02 PM »
rev 2018 -- woohoo, no more references! :P Back to quick descriptions of my changes...
(12 files, 44kb, mostly spaces-to-tabs in install.sql)

* Updated notification code to use the data field in the members table. Thanks Dragooon! (install.sql, Class-System.php, Notifications.php,

! Notifications markAsRead wasn't using the proper $id_member variable. Thanks myself! (Class-Notification.php)

* Harmonized notifications to use returnAjax(), for consistency. And because that's shorter. ;) (Notifications.php)

* All sorts of Naoisms -- spacinazi, indenazi, commenazi, bytenazi, you name it. Also fixed $context['skeleton'] to be initialized as an array, as pointed out by John. (Class-UnitTest_tidyhtml.php, install.sql, Class-FTP.php, Load.php, Display.template.php, ManageLanguages.template.php, Who.template.php, respond.js, suggest.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2019, on March 24th, 2013, 06:51 PM »
(5 files, 12KB)

Revision: 2019
Author: arantor
Date: 24 March 2013 17:51:13
Message:
! Die, Simple Permissions, DIE. Yes, that's right, we have 'Classic Permissions'. Only it's just 'Permissions' now. There's more stuff to do but this is where it begins. (ManagePermissions.php, ManagePermissions.template.php, plugin-info.rng, ManagePermissions language files)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/other/plugin-info.rng

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2020, on March 25th, 2013, 08:12 PM »
rev 2020 -- and I'd like to point out that if I'd committed rev 2019, I'd have made a reference to both Akira and Blade Runner, but alas it was not to be... :P
(8 files, 4kb)

! Fixed Wess parsing of calc() to actually add prefixes if needed... Also made the search process looser, as we don't really need to force a particular string end. (Class-CSS.php)

! Fixed a remaining reference to a removed field. (Class-Notification.php)

* Spacinazi. (ManageBans.php, ManageLanguages.php, Notifications.php, ScheduledTasks.php, Security.php, ManageLanguages.template.php)
Re: New revs
« Reply #2021, on March 26th, 2013, 12:19 AM »
rev 2021
(3 files, 4kb)

! Last rev's fix was overwriting the $data parameter in the issue() method. (Class-Notification.php)

! Fixed another use of ;id= which, as I said, may sometimes be forbidden by mod_security. Or is that a thing of the past..? (Notifications.template.php)

! Fixed $member[$row['id_member']], should have been $members[$row['id_member']] instead... Notice the extra 's'. This probably prevented scheduled tasks from working... (Notifications.php)

! Notification e-mail template was calling weNotif::getNotifie instead of weNotif::getNotifiers... (Notifications.template.php)

* Small clean-up... No need to call loadSource() twice in a row, just provide an array of source filenames. Removed some extra $scripturl's. Avoid self-referencing a static object by using its full name, use 'self' instead. Renamed some variables to avoid further confusion (and potential reference overrun... If you know what I mean. Never re-use a variable that was set as a reference earlier. I learned it the hard way long ago.) (Notifications.php)

@ Also, err... Should this notification e-mail template REALLY spit out HTML code...?! (Notifications.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2022, on March 27th, 2013, 03:10 AM »
(14 modified, 1 added, 10KB)

Revision: 2022
Author: arantor
Date: 27 March 2013 02:09:16
Message:
! Break styling for contacts/hidden out of the old way and use icons by the name instead for online lists. You will likely want to shorten the naming, which is fine, heh. (Subs-MembersOnline.php, Display.template.php, InfoCenter.template.php, MessageIndex.template.php, sections.css) :edit: And hidden.png.

! Weekly maintenance should check for missing .htaccess and index.php files, and regenerate them if appropriate, related to SMF bug 4965. (ScheduledTasks.php)

! Globanazi: we're not using $sourcedir any more for cache flagging. (Subs-Cache.php)

! Sort order for spiders online is often wrong, related to SMF bug 4930. (Subs-MembersOnline.php)

! Stats couldn't still be accessed even if disabled, SMF bug 4742. (Stats.php)

! Pruning attachments without leaving a deleted message could have an SQL error, SMF bug 4818. (ManageAttachments.php)

! SMF bug 4902: subscriptions handler can provide output without proper content encoding. SSI should not be influencing headers however. (subscriptions.php)

! SMF bug 4857: unlocking a post from the additional options would not log it properly in the moderation log. (Post2.php)

! SMF bug 4555: censored word description didn't fit the behaviour on the page. Also fixed bare > in the template, which is even in 2.0.4 and AFAIK isn't legal XHTML *whistle* (Admin.template.php)

! SMF bug 4669: plugin enabling/disabling was not logged. (ManagePlugins.php, Modlog.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/hidden.png
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/subscriptions.php
Re: New revs
« Reply #2023, on March 27th, 2013, 04:42 AM »
(6 files, 4KB)

Revision: 2023
Author: arantor
Date: 27 March 2013 03:40:40
Message:
! Only update the notifications count if there are people to notify. (Class-Notification.php)
! Harmonise area vs sa in the URLs. (Notifications.template.php, notifications.js)
+ Support for notifying people about their posts being liked. I don't know how rugged it is, it feels a touch hacky to me, but I don't see how else to do it as a core feature at this time, without bootstrapping it as a plugin. (Like.php, Notifications.php, Notifications language file)
----
Modified : /trunk/Sources/Class-Notification.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Themes/default/Notifications.template.php
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/scripts/notifications.js

:heck: And I forgot to upload a file with this. Dumbass that I am.
Re: New revs
« Reply #2024, on March 27th, 2013, 04:43 AM »
(1 file, 4KB)

Revision: 2024
Author: arantor
Date: 27 March 2013 03:42:50
Message:
! Missing file from r2023. I clearly need more tea. (Class-NotifierLikes.php)
----
Added : /trunk/Sources/Class-NotifierLikes.php
Plugin revs »