New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1950, on February 24th, 2013, 05:46 AM »
rev 1950 -- I'm hungry... Can't sleep... Browsing on my S3... Fixing stuff for it.
(2 files, 2kb)

! Fixed scrollbar no longer being reactive in Android. This was mostly due to the fact that I forgot the window object has a scrollTo method already. Costs an additional 2 bytes to fix. (sbox.js)

+ Implemented my own super-short Android compatibility hack into menus. It only does the basics, but you don't need more because AFAIK, all parent menus have an equivalent link in their children. And it's only 21 more bytes, eh eh. Likely in reaction to Ant's comment at Elk about how Superfish got bloated to add mobile support... ;) (script.js)
Re: New revs
« Reply #1951, on February 24th, 2013, 07:12 AM »
rev 1951
(17 files, 9kb)

! Fixed -prefix replacements in Wess. Seriously, I'm ashamed of this one... Probably a last-minute change. (Class-CSS.php)

! Fixed @if not supporting member/guest flags in Wess. I really thought they were already accounted for... (Class-CSS.php)

* More literal love... Literally. Okay, that one's done... Okay, should we also use literal for constant numbers..? (upgrade.php, Subs-Media.php, Merge.php, ModerationCenter.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, Reports.php, Stats.php, Subs-Admin.php, Subs-Charset.php, Subs-Members.php, Subs-Post.php, Themes.php)

* Minor layout fix. Yes, with a language string change... Don't bother. (ManageBans.french.php)

* Another scripturl bites the dust. (Subs-Media.php)

! setlocale fix and harmonizing. (Subs-Media.php, Subs.php)

@ Not that I'm teaching anyone anything, but my regex to find potential literals is '([^']+)' => '\1' -- although it's (ahem) unlikely to find things like {string:icon} associated with 'icon' => 'xx', for instance...
Re: New revs
« Reply #1952, on February 25th, 2013, 12:29 PM »
rev 1952 -- wanted to have a cooler update, but.. had to pull it at the last minute. Still -- enough content for a commit.
(14 files, 5kb)

! Fixed menu tabs in Android. (GenericMenu.template.php)

* More strings to literals. (Class-Editor.php, ManageBoards.php, ManageMembergroups.php, ManagePermissions.php, ManageSearch.php, Aeva-Gallery2.php, ManageMedia2.php)

* Commenazi. (ManageBans.php, ManageMail.php, ManageMemberOptions.php, ManagePaid.php, ManageSearch.php, ManageSettings.php)

* More partial French translation... Honestly, I think I'm lost in this ocean of translation work. I'll give it another try, and then... We'll see. (Help.french.php)
Re: New revs
« Reply #1953, on February 25th, 2013, 05:12 PM »
rev 1953 -- fixing a mail bug. I think. I never touched that code before... Pure chance.
(5 files, 15kb) (argh, translations..?!)

! SMF bug (also in Elk and everything...): fixed a variable inversion bug that caused, I would venture to say, failed mails to be stored for further retries but said retries never undertaken. I'd say that's a big one... Which needs fixing everywhere else. I'll post the details somewhere if someone asks. (ScheduledTasks.php)

* Finished string to literal transitions. I think they're all done now, but I've probably missed hundreds of strings that aren't named the same as their literal value. (ManageLanguages.php, ScheduledTasks.php, Subs-BBC.php)

* Translation. The nightmare continues in... Translation II: Spell-checker. (ManageMail.french.php)

* Typoos. (ManageMail.english.php)
Re: New revs
« Reply #1954, on February 25th, 2013, 05:53 PM »
rev 1954
(15 files, 6kb)

* Reviewed all {string:}'s in the source code (by this point, you already know I'm a bit crazy), and turned all relevant ones to literals. Also more naoisms not worthy of any mention. (ManageBoards.php, ManageErrors.php, ManageMaintenance.php, ManagePaid.php, Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php, Subs-Media.php, Memberlist.php, Reminder.php, Subs-Members.php, Subs-Post.php, Subs-PrettyUrls.php, Themes.php, UnreadReplies.php)
Re: New revs
« Reply #1955, on February 26th, 2013, 10:44 AM »
rev 1955 -- we::is grouping, final flexbox prefixing support. :)
(3 files, 8kb)

+ Added grouping support for we::is browser tests. I'm going to elaborate because it needs some attention. This allows you to do for instance "chrome && (ios, android)" instead of "chrome && ios, chrome && android", and more interestingly, "chrome && !(ios, android)". Well, I think it's more interesting because, let's say you have a $browser_list variable... You can do @if $browser_list to test for it, but doing @if !$browser_list wouldn't work as expect (it would only do a negative test for the first browser in the list), so running @if !($browser_list) will do what you want. You're the boss now. Also, I *think* nested grouping should work, but I haven't tested it, and I'm not sure there are many use cases for that anyway. (Class-System.php)

+ Added partial support for flexbox model: automatic prefixing (as needed) of flex properties, and a common CSS variable to offer an @if block for browsers that support it. Yes, it's directly related to the above... As for where I'm going to use the flexbox... I'll commit it as soon as I fix some obscure edge case. (Class-CSS.php, common.css)

! Fixed Samsung tablets and HTC Flyer to return a negative on is_mobile. I haven't actually tested them, but I looked through my code and it seemed like they'd misbehave. Also removed detection of WAP (Wedge is not going to work on this, don't bother testing!), up.link (a 90's browser, come on!) and Bolt (which was discontinued 2 years ago and doesn't work anymore). (Class-System.php)
Re: New revs
« Reply #1956, on February 27th, 2013, 07:13 PM »
rev 1956 -- woohoo, CSS love!
(3 files, 5kb)

+ Messages are now shown in a flexbox that, err... Well, you'll see by yourself. You probably won't notice if you don't read the actual CSS. I'm so happy with that. Took me the entire week to get it right. Non-supporting browsers will still get the CSS table version, or the HTML table one for IE 6-7. (sections.css)

! Fixed broken rounded corners on context menus. What..?! And the fix barely makes sense either... (index.css)

* Simplified CSS for mini-menu arrows. Arrows' horizontal positions should now be the same in either direction. Hey, it's my first use of the calc() keyword... Funny! There's a fallback, too. (index.css)

! A relatively recent update had .bbc_pre set to inline-block, and I forgot to document that in the changelog. Well, it turns out that it broke flex boxes, so I'm reverting this... And perhaps I'll find the reason why I changed it. ;) (index.css)

* Replaced brackets around page number with CSS-generated ones. Just as a prologue to whatever Pete wants to replace it with later... ;) (index.css)

* Moved two action icons to where their brothers were. This is the reason I implemented '@if member' in Wess, not that you would care, but it saves quite a few bytes. (index.member.css, sections.css)

- Removed right margin in .inner class... This dated back to the original Weaving commit (two years ago!), and I have no idea whether it was supposed to be 'cool' or just fixed something that no longer happens. (sections.css)

- Removed mini-menu overflow rules. I remember I had to keep them at some point, but was unable to reproduce an error when removing them this time. (sections.css)
Re: New revs
« Reply #1957, on February 27th, 2013, 07:15 PM »
rev 1957 -- best of the rest.
(7 files, 3kb)

! Fixed weSkeleton->find not returning false (and instead triggering an error) when a block/layer couldn't be found. This bug was introduced in rev 1175, which was a major rewrite, so I think I'm allowed room for forgiveness here. ;) (Class-Skeleton.php)

+ Added support for @viewport for browsers that support them (Opera 11+ and IE 10+). Although it doesn't look like much, it allows me to remove the meta viewport tag from all HTML pages in Opera Mobile and Windows 8. Best of all, skins can thus determine their favorite zoom levels. Okay, now we just need to wait for WebKit to add support for this... All right? It's underway... And it's taking time. Boo. (Class-CSS.php, index.template.php, Wireless/extra.css)

* Got rid of the .live (well, '.on' since the jQuery version change) calls to mini-menu items. The recent mini-menu rewrite was partly done to allow for event-driven JS to be put back into the 'click' array entry, and I forgot to do that for the two entries that called for the rewrite... Amusing. Also, note the double JSE call. It's needed because the string will be inserted between single quotes later. (Display.php)

* More bytes saved... About 10. And select box generation should be a tad faster, too. Well, I haven't benchmarked myself but... (script.js, sbox.js)

* Ah, yes, still needed to commit the index template's @viewport modification... (index.template.php)
Re: New revs
« Reply #1958, on February 27th, 2013, 09:09 PM »
rev 1958 -- just fixes.
(4 files, forgot to check size -- I'd say 2 or 3kb.)

! Fixed Aeva Media misbehaving on servers that misbehave themselves by disabling the exec function. Thanks Farjo! (Class-Media.php)

! Oops, $$$$ should be called on a .replace() function, but on a .join() it should be $$ instead... (Yeah, I know, nobody will get that one.) (script.js)

! Fixed Profile link in user mini-menus. At the cost of 3 bytes... But I saved one with the fix above, so that's just two. (script.js)

! Fixed Wireless in Chrome Beta for Android. This is a specific version because only this one supports the final flex model. (Wireless/extra.css)

* I think these language strings are closer to what's really happening, but I might be wrong. (EmailTemplates.english.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1959, on February 28th, 2013, 12:26 AM »
(3 modified, 7 deleted, 1KB)

Revision: 1959
Author: arantor
Date: 27 February 2013 23:25:04
Message:
! Some more house cleaning. (Packages language file)
! Use the correct string, it's not_applicable rather than na. (ManagePlugins.php)
! We don't use these fonts and even if we did, I'm not sure what the licensing terms are for them anyway - not even SMF knows whether they can redistribute the fonts under BSD licence. What's left is all we use and it may well be replaced pretty shortly anyway, I'm already experimenting with new fonts. (*.gdf, *.ttf)
----
Modified : /trunk/Sources/ManagePlugins.php
Deleted : /trunk/Themes/default/fonts/Candice.gdf
Deleted : /trunk/Themes/default/fonts/Forgottb.ttf
Deleted : /trunk/Themes/default/fonts/Hootie.gdf
Deleted : /trunk/Themes/default/fonts/Kimbalt.ttf
Deleted : /trunk/Themes/default/fonts/President.gdf
Deleted : /trunk/Themes/default/fonts/Venusris.ttf
Deleted : /trunk/Themes/default/fonts/Walshes.ttf
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php



Yikes, 3 days since my last commit!
Re: New revs
« Reply #1960, on February 28th, 2013, 01:11 AM »
(1 removed, 1 added, 5 modified, 5KB)

Revision: 1960
Author: arantor
Date: 28 February 2013 00:08:21
Message:
! Adding new CAPTCHA font. It only has the basic alphabet in it so it's *very* small for the base package. I might add more fonts yet, hence the name. (wecaptcha1.ttf, captcha-*.php)
! The old Larabie font is no longer used, and so it can disappear too. (Screenge.ttf)
----
Modified : /trunk/Sources/captcha/captcha-grid.php
Modified : /trunk/Sources/captcha/captcha-recomposeanim.php
Modified : /trunk/Sources/captcha/captcha-silhouette.php
Modified : /trunk/Sources/captcha/captcha-simpleanim.php
Modified : /trunk/Sources/captcha/captcha-stripes.php
Deleted : /trunk/Themes/default/fonts/Screenge.ttf
Added : /trunk/Themes/default/fonts/wecaptcha1.ttf
Re: New revs
« Reply #1961, on February 28th, 2013, 05:16 AM »
(1 added, 4 modified, 17KB)

Revision: 1961
Author: arantor
Date: 28 February 2013 04:14:48
Message:
! This isn't finished but I'm fed up of having it on my local copy uncommitted. This is, then, the first part of the new language editor, except doesn't have the editory saving bit. There's also no way to delete languages at present but I'm not sure exactly what I want to do with that yet, I may just have it as being 'selectable' and 'nonselectable' and admins that really are bothered by such can delete the files themselves. Also note the search function doesn't work yet either. (ManageLanguages.php, ManageLanguages.template.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/ManageLanguages.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1962, on February 28th, 2013, 09:12 PM »
rev 1962 -- can_flex, E_STRICT, Firefox OS basic support.
(7 files, 9kb)

! Wess can't actually hold a list of browser UAs in a variable and allow you to do a test on it. It's a technical limitation. I could overcome it, but I don't see many situations where it would be helpful other than testing for a particular feature repeatedly, so I decided to implement constants to do just that. 'can_flex' is the one you want for the latest flex box model support, it replaces '$supports_flex' and that's all I have to say... Also, this has the advantage of allowing you to just do '!can_flex', without bothering about brackets. I also added support for the older flex models, which I'm not using. Currently, these constants are case-sensitive, in order to save time. I don't know what's best. It's something I'm saying a lot, these days... (Class-CSS.php, common.css, sections.css)

* Since E_STRICT is a PHP 5 constant, it no longer needs to be tested against... There's another one in Errors.php but I'm not committing this one for now because I'm working on the cleanest solution for it. Basically, SMF/Wedge skips all strict errors unless a hidden setting is enabled. Also, the end of the function is quite folkloric, dare I say hilarious, at least it made me laugh, so it shall be deleted entirely. (Elk, if you're listening....) (index.php, SSI.php)

! Fixed strict error: wetem static method calls. I don't know why I insisted on extending wetem from weSkeleton, it really wasn't needed. (Class-Skeleton.php)

! Fixed strict error: weSkeleton->render_recursive() doesn't accept non-variables as parameters. I benchmarked against the alternative (removing the pass-by-ref), and performance was similar, but often a tad faster in pass-by-ref mode, so I left it that way and just assigned variables. Anyone interested in doing more benchmarks in a different environment..? I can't wait to find a reason to get rid of all my unused references. Finally, weSkeleton is back to being a final class... If you have any reason for it to be extendable, just discuss it with me! (Class-Skeleton.php)

+ Added support for Firefox OS. Tested with both the G2B Desktop Client and the simulator bundled as a Firefox add-on. The former won't work because currently it provides the host OS in its user agent, instead of their own. The latter will work fine, though, it uses the official UA. (Class-System.php)
Re: New revs
« Reply #1963, on February 28th, 2013, 10:28 PM »
rev 1963
(10 files, 4kb)

! Fixed togglebar link in profiles redirecting to your profile, even if visiting another's. (Subs-Menu.php)

* I've decided to make skin options clearer in scope. Until now there have only been two skin options, namely sidebar and mobile, so now we're storing them as SKIN_SIDEBAR and SKIN_MOBILE constants. Hopefully this won't affect performance in template_msg_wrap_before. The advantages are multiple: much easier to type, the constants are always defined, and of course no globaling to do. Any other custom settings will be defined as well, e.g. <my_setting> should be defined as SKIN_MY_SETTING. (Aeva-Gallery.php, Subs-Cache.php, Boards.template.php, Display.template.php, Home.template.php, index.template.php, MessageIndex.template.php, Msg.template.php, PersonalMessage.template.php)
Re: New revs
« Reply #1964, on February 28th, 2013, 11:29 PM »
rev 1964
(3 files, 5kb)

* French translations. Hopefully, only EmailTemplates remains to be completed... Phew. (Admin, Errors, ManageSettings)
Plugin revs »