If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.
Adding try/catch is not something I'm overly looking at yet, since SMF's code is written to pretty much avoid failing anyway.
Posted: September 5th, 2010, 02:41 PM
Revision: 40
Author: arantor
Date: 14:02:17, 05 September 2010
Message:
! Removed unnecessary eval from dropping PHP 4 support (convert.php)
----
Modified : /trunk/other/converters/convert.php
EDIT to add
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
Posted: September 5th, 2010, 03:02 PM
Revision: 41
Author: arantor
Date: 14:26:17, 05 September 2010
Message:
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql
Posted: September 5th, 2010, 03:26 PM
Revision: 42
Author: arantor
Date: 14:44:43, 05 September 2010
Message:
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php