Wedge

That's... interesting. Weird, but interesting.

Can you view the source for that page and post it here please? I can't reproduce it myself - but I'm suspecting that's because I have permissions for other things.Nope.

What's happening is, the code that generates the mini menu over the profile (which includes a given user's website) is being output in a manner in which it should not be. Please provide a copy of the view-source when you see it so I can try and nail down why this code is being output when it shouldn't be.

Here you go!

Ah, thanks :)


OK, so I know what the problem is.

Display.template.php pushes the user menu (umme) to $context['footer_js'], while the other footer JS is pushed via add_js(). Trouble is for guests, and possibly some others, there's nothing being pushed via add_js already - so the script tag to contain it never gets output.

I don't see why Display.template.php can't push the umme and acme code to the footer through add_js, they're all going to be in the same place anyway... either that or footer_js needs to test whether it begins with a <script> and makes sure to add one otherwise.

I need to hit the sack in a minute or so, so I can't test it however... I can see one reason why it isn't added to add_js directly - and that's performance, stuff's being added in a loop. In which case it should go to a temporary variable and then pass that to add_js, would be better than directly injecting into $context['footer_js'] in the cases where there isn't already footer code.

I actually reproduced the bug locally last night while testing my Register rewrite (I had to log out to test it obviously, and this umme stuff would show up at the end of a Display page.)
I fixed it without committing because I really had plenty of stuff to commit. And still do. And I'm putting the priority on OUAT and TWD this morning. :P

At least I'm relieved to learn that this was introduced only in the latest updates, last night I thought it might have been a long-lived bug, considering I rarely ever log out of my websites...!

I take it this one is solved?

Yup!

Hmm why am I not redirected to this page after logging in with the form box in it...