« Remove \
XenForo wins
This describes me somewhat »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: XenForo wins
« Reply #15, on February 28th, 2013, 10:50 PM »
Quote from Arantor on February 28th, 2013, 10:45 PM
:) Credit where credit is due.
Oh, don't talk to me about credits today... :lol:
Quote
I saw that, and honestly I wouldn't be that worried. There's two choices - I can either work on a proper language tool for here (though given my lack of enthusiasm for the inline one in Wedge...) or I can just shove stuff through Google Translate as a working one and it get fixed later. Up to you. I don't mind doing stuff like that if it would be useful.
I don't know, I'm looking at the rev 1942-1949 diff patch, and there aren't as many strings as I remembered... It also seems that I'm done with the 1935-1938 diff. All that should remain from earlier, is EmailTemplates. I think I was done with the rest (such as the new ManageLanguages strings... Although I'm not sure...)

Also, when you removed the package files, did you thoroughly check for unused text strings...?
I only tested for one, and couldn't find it. It is $txt['package_file_contents']. I suppose there may be many more..?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: XenForo wins
« Reply #16, on February 28th, 2013, 10:53 PM »
Quote
Also, when you removed the package files, did you thoroughly check for unused text strings...?
I did actually remove a little more after that in r1959, but once I get the plugin server architecture sorted out, there's little reason to keep the rest of that language file at all.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: XenForo wins
« Reply #17, on February 28th, 2013, 11:17 PM »
Yeah, that particular string was gone already anyway, I'd only checked the diff patch but forgotten to update my files themselves.

ManageSettings wasn't up to date. I fixed that.
Errors wasn't, either. And Admin.

ManageMail is up to date. I think everything's good now, except for EmailTemplates...

I'd be great to have some tool, in the language cache stuff, to actually spot missing language entries and notify the admin... Ohhhhhh yes, thaaat would be goooood.... :)
Heck, even better: storing a MD5 of all English files, thus spotting any modifications, and determining whether the equivalent translation has a modified MD5 as well. In which case --> all good. Otherwise --> may need an update.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: XenForo wins
« Reply #18, on February 28th, 2013, 11:28 PM »
I didn't mean in the language cache stuff. I mean here for all translations (because we will need to cope with other languages as well!) so we'll need to check there, and it could field French too. Don't know yet. Needs way more thought to handle it, but I'm less inclined to put that in Wedge core because it's not that useful for general admins.
« Remove \
This describes me somewhat »