Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Remove \
« on March 6th, 2013, 07:13 AM »
Honestly this option should be removed and enabled by default, I've seen no service which doesn't save messages automatically. Plus it's not like it's a real space saver, and it's a pain when you want to switch to conversation view but don't have any sent messages. Also remove the entire "Save a copy in my outbox" while sending PMs, same reasoning.
Posted: March 6th, 2013, 07:12 AM

For the love of god, the title was Remove "Save a copy of each personal message in my sent items by default.". I call bug.
The way it's meant to be

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: Remove \
« Reply #1, on March 6th, 2013, 07:41 AM »
hmmm..
This is something I'd only be willing to do if we had a 'backup all of my PMs in a HTML file' option like the one I remember from IPB 1.x.
Not saying what you're saying isn't sane... It's just that I tend to miss that one!

Also, known bug... I'll just say: I'm very wary of touching htmlspecialchars & co. code. I think maybe we should make several versions (just like we have westr::safe), and sort them by 'role', rather than something else. For instance: a function to sanitize stuff that's being used with MySQL or whatever... Another one to sanitize JavaScript stuff, another to sanitize HTML entries that need to have double quotes removed (i.e. used inside a tag param), etc...

Aaron

  • Posts: 356
Re: Remove \
« Reply #2, on March 6th, 2013, 11:57 AM »
While we're at it ... make viewing PMs by conversation the default, too — or even the only mode. It's how (new) users would expect it to work, I think.
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: Remove \
« Reply #3, on March 6th, 2013, 12:07 PM »
I don't know. I was very happy with default mode until I discovered convo mode.
Oh, and one thing to take care of... If you click 'Mark unread' on your latest PM (convo or whatever), you're sent back to the PM page, meaning it's never marked unread...
We could either have a convo homepage without any PMs below it, or redirect to the forum homepage after marking the latest PM as unread.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Remove \
« Reply #4, on March 6th, 2013, 02:05 PM »
OK, there's several things here.

Saving by default, sure. It's not like it's a hard job.

Convo mode by default, no big deal either.

Mark unread... it works but only if it's not the most recent conversation. To fix this, I'd like to propose that we separate the PM list from viewing PMs, that is to say: when you first hit the PM page, there's just a list of conversations - not going straight to any one conversation. If you pick one, then it displays the list plus the conversation in question. This means mark unread would actually work properly and stuff doesn't automatically get read just by visiting the PM area.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,668
Re: Remove \
« Reply #5, on March 8th, 2013, 05:12 AM »
Quote
, I'd like to propose that we separate the PM list from viewing PMs
oh  yes, do it :D
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Remove \
« Reply #6, on March 8th, 2013, 05:39 AM »
I have an enormous commit already in progress, but I'll see if I can squeeze that in. Oh, and the commit also fixes the bug regarding titles so they'll all be properly escaped again.
Posted: March 8th, 2013, 05:36 AM

(But considering that r1983 is next and that's the year I was born, I don't want to mess with a half assed commit :lol:)

godboko71

  • Fence accomplished!
  • Hello
  • Posts: 361
Re: Remove \
« Reply #7, on March 8th, 2013, 06:07 AM »
1983 was a very good vintage ;)
Thank you,
Boko

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: Remove \
« Reply #8, on March 8th, 2013, 01:42 PM »
Re: convo without PMs, I suggested it above ('have a convo homepage without any PMs below it'), so obviously I'm all for it. As for saved PMs, I'm still unsure, but it is true that PMs never represent more than 10% of the overall post count in any given forum (usually...?), so it's never going to be the 'bottleneck'.

Please try and commit today Pete, I've been holding up for your revs, and I'd like to commit some stuff before I'm leaving tonight -- a rewrite of the device-pixel-ratio fallback in Class-CSS, as well as the (finally!) completed EmailTemplates translation, and a few other minor fixes.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Remove \
« Reply #9, on March 8th, 2013, 03:23 PM »
Quote
As for saved PMs, I'm still unsure, but it is true that PMs never represent more than 10% of the overall post count in any given forum (usually...?), so it's never going to be the 'bottleneck'.
There is precisely zero overhead of retaining saved PMs vs not doing so. It's almost entirely a UI consideration.
Quote
Please try and commit today Pete, I've been holding up for your revs, and I'd like to commit some stuff before I'm leaving tonight -- a rewrite of the device-pixel-ratio fallback in Class-CSS, as well as the (finally!) completed EmailTemplates translation, and a few other minor fixes.
I wanted to do something useful and worthwhile, and I have 50+ files to commit...

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: Remove \
« Reply #10, on March 8th, 2013, 03:35 PM »
Quote from Arantor on March 8th, 2013, 03:23 PM
Quote
As for saved PMs, I'm still unsure, but it is true that PMs never represent more than 10% of the overall post count in any given forum (usually...?), so it's never going to be the 'bottleneck'.
There is precisely zero overhead of retaining saved PMs vs not doing so. It's almost entirely a UI consideration.
There's overhead if the recipient deletes their PMs, of course... (?)
But yes -- this and that: very unlikely to have an impact at all... Removable.
Quote from Arantor on March 8th, 2013, 03:23 PM
I wanted to do something useful and worthwhile, and I have 50+ files to commit...
Anything you do is worthwhile! All right?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Remove \
« Reply #11, on March 8th, 2013, 04:01 PM »
Quote
There's overhead if the recipient deletes their PMs, of course...
I'm not sure about that. I'm not sure how much the PM housecleaning actually works.
Quote
But yes -- this and that: very unlikely to have an impact at all... Removable.
I already did it :P
Quote
Anything you do is worthwhile! All right?
I did want to have something more meaningful than a couple of bug fixes and a shit-ton of $scripturl removal, but there it is.