Wedge

Let's try these... One for the dark backgrounds, one for bright backgrounds.

Since there are fans of the skewed version and fans of the square version, I tried to do something halfway between the two. (The light version isn't very readable but I'm on an odd-numbered post so I've got a light background for it.)

:edit: Updated white version.
:edit: And again...

your logo is ok ~DS~ ??
What do you want to change?

Not that I am volunteering mind you  :lol:

I actually find myself really liking the header one even though the font is thinner than something I'd have chosen myself.

And since I posted, it looks like the header image changed slightly, to use the one that had the triangles more offset. Either that or I'm imagining it :/

My logo is ok but not that it excites me.

*minic Yoda*

Make logo me, you must.

:p

Nao, I am having second thought about the skew. :P
:lol:

That's the magic of Helvetica.
Although I'm still debating whether I shouldn't be using Myriad... If I could find a version between Regular and Bold... Hmm. Or just another slick font.As I said above, I chose to please everyone by ditching both the squared and skewed versions, and instead making a slightly skewed version that also looks square. Eh, TBOBW.

Also, since no one seems to be reading the Skeleton topic, I'll post here... :whistle: I fixed the problems with Wireless (it was my fault basically), but I found the origin of the problem for my server crash on ?action=do;sa=send2;xml... In fact, that URL is only used by the PM draft code, and from what I can see, the generic PM code isn't optimized for handling a XML version, at all. Thus, it tends to rewrite the XML template with the PM and GenericMenu templates, and it also initializes the menu entirely... At this point it'd probably make more sense to re-route the XML codepath to end much shorter in the process, what do you think?

Also, it would seem that PMs sent to drafts via Ajax will go through the same codepath as with non-Ajax stuff...
Hence, if the PM has no recipient (i.e. I started typing my PM without specifying one), the XML codepath will return, instead of XML code, a HTML block saying that no recipient was indicated, etc, etc. All of the possible errors really...

It's actually surprising that the code used to work :P But I admit it's particularly annoying to debug Ajax code. I had to change all of the $_POST to $_REQUEST in saveDraft() just so that I could pass a dummy URL requesting to save a draft, and see the resulting code in plain view.

Oh, and saveDraft defines a fatal_error('empty_draft'), when no language files have $txt['empty_draft'] in them. I've checked the original mod, it *is* in its language file. Just not in ours... Should we remove the error or add the error message back in?
There may be other strings missing but it's the only one I checked.

Hmm, I really can't remember :/

But I suspect we should really put that string (back) in, otherwise find an alternative solution for if the user presses save-draft when the thing is empty.

Even though I thought the old logo looked fine, I really like this new logo. Well done. :)

Pete, just so you know -- there were other bugs, like area=drafts used at one point in the PM area when it's sa in that area. Also, I noticed that if you don't have a recipient, it actually saves a different draft every 30 seconds... I left a PM send tab open for a copule of days and had a couple hundred pages of drafts... (Thankfully there's a delete all button now :)) After fixing the various bugs I tried again and it didn't do it, phew...

All in all I still have a few things to commit, notably in PersonalMessage.php, I'll do it tomorrow morning because it's very late here... (Plus, I'm trying to do thematic commits. The PM commits are only loosely related to the layer fixes.)

Oh and I hope it doesn't bother anyone that I decided to rebuild the skeleton array more often. I don't think it's a big deal to call, on most layer/block modifications, a recursive function with a simple isset() for each layer/block in the skeleton. I could probably get away with a few millions before I'd have to optimize actually... :P

@Aaron> Thanks :) I'm 95% happy with it, which is very high for me and as far as I'll be able to go I suppose. I was only 75% happy with the good ol' green logo ;)

Yeah, PM drafts wasn't thoroughly tested though I never had any such problems in my testing :/

Blame the beta testers :niark:

Even on the light background the lighter one still looks better to me

Yeah it looks great but it's less readable ;)