Wedge

Neither am I and that wasn't the plan. The current editor is... broken. So either we fix it or we kill it and replace it a new one. A better one.Notepad++Yeah, implemented that one in a bit of a hurry (I think I said it was ugly). Should be $_GET really, and I don't think I did it as a form submit because of the rest of the form on the page. Though perhaps something properly AJAXish would be better? (And more prone to breaking on custom themes). In any case I'm so used to SMF interchanging $_REQUEST, $_GET and $_POST for the wrong reasons :(

Haven't looked at the changes yet, but all sounds good to me.

Yes, in an editor object, because the only time I ever actually saw it used outside of coming from the editor was for shoutboxes.Yes, now the underlying reason. Code that comes from one of those will need some kind of treatment before it can be saved - I don't know about you, but I'm hesitant to trust anything from the user. Don't care what it is, I don't want to trust it without some kind of processing.

I need to sit down and look at exactly what is sent, to figure out what changes are going to be necessary to the preparse routine, but some changes *are* going to be required, and having all the code in one place means it's possible to keep all the related behaviour together.

I'm not sure yet exactly we'll handle the editors, whether we just have one only, or multiple (since that was something YSF wanted), or fix up the WYSIWYG editor in some fashion, so I haven't yet made it trivial to switch behaviours, but having the class structure will make it easier in the long run.

Revision: 89
Author: arantor
Date: 01:17:59, 12 September 2010
Message:
! Change 'stars' to 'rank images' (including renaming the star*.gif files though left the table column alone) (yabbse_to_smf.sql, install_2-0.sql, upgrade_1-0.sql, ManageMembers.english.php)
----
Added : /trunk/Themes/default/images/rank.gif (Copy from path: /trunk/Themes/default/images/star.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankadmin.gif (Copy from path: /trunk/Themes/default/images/staradmin.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankgmod.gif (Copy from path: /trunk/Themes/default/images/stargmod.gif, Revision, 87)
Added : /trunk/Themes/default/images/rankmod.gif (Copy from path: /trunk/Themes/default/images/starmod.gif, Revision, 87)
Deleted : /trunk/Themes/default/images/star.gif
Deleted : /trunk/Themes/default/images/staradmin.gif
Deleted : /trunk/Themes/default/images/stargmod.gif
Deleted : /trunk/Themes/default/images/starmod.gif
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/other/converters/yabbse_to_smf.sql
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/upgrade_1-0.sql

(ticket 36)

Revision: 90
Author: arantor
Date: 04:16:31, 12 September 2010
Message:
+ Dropdown user menu added (Display.php, Display.template.php, index.english.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js

It's not overly pretty, but I think it's better handled than my original mod; firstly, it doesn't show in wireless when it isn't meant to, and it is now JS controlled, but the JS isn't particularly elegant - and for some reason it's not dropping smf_scripturl into the URL when it begins with ? - I didn't see a need to spell out $scripturl every time in the array. Note that since PHP 5 rather than 5.1 or 5.2 has been stated, I'm using a homebrew limited version of json_encode to pump the array of data.

I also didn't have the catbg header bar I had before, didn't see a need to throw that into the mix as well. Works in FF and Chrome, too late tonight to test any more (or debug that last oddity)

Revision: 91
Author: arantor
Date: 12:41:48, 12 September 2010
Message:
! Actual fix for who's online glitch (removing previous fix too) (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php

-sigh-

I just realised my fix works for those folks who use JS but not for those who don't. Argh, why did they do it the stupid way they did it? (One form, two dropdowns, and never checking between the two sets of values)

Revision: 92
Author: arantor
Date: 13:13:44, 12 September 2010
Message:
! Additional fix to who's online for non JS users (Who.php, Who.template.php)
----
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Who.template.php

There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.

I liked how you did the AeMe changelog though I'll admit I never read it in detail.

I hadn't committed the PM stuff, I wanted to get opinions on it before I did since it wasn't very cleanly done. I'll commit in a minute and we can pick the bones out of it later.

Revision: 88
Author: arantor
Date: 19:50:12, 11 September 2010
Message:
+ Dropdown selector for PM viewing mode (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php


Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.

SlammedDime has had commit access for years, just he never uses it.

The slow way; I look through the log, rev by rev, and then file by file. Though depending on the level and nature of changes I have been known to run two revs together, such as when we were fixing CRLFs, when I'd run two revs together to see the total changes between them.

Basically whatever looks like it'll give me the best clue as to what's changed in the code.

Revision: 74
Author: arantor
Date: 14:05:08, 09 September 2010
Message:
! Removal of easter eggs:
 the clock (Calendar.php, Calendar.template.php, index.php)
 the Books of Unknown (Karma.php, index.php)
 i am the administrator. (Post.php)
 iamanoompaloompa (Subs-Menu.php)
 chocolate cake (Subs-Members.php)
 fake integrate_egg_nog (ViewQuery.php)
 OH NOES (ManageMaintenance.php)
----
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/index.php


As per http://wedge.org/up/6160/easter-eggs/

Revision: 65
Author: arantor
Date: 18:56:14, 08 September 2010
Message:
+ Add conversion from quick to inline full editor in Quick Reply (Display.php, index.css, Display.template.php, index.english.php, topic.js)
! Fix change of state in buttons if bbcode disabled (editor.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/topic.js


The edit to editor.js was to fix some errors coming up in FF when bbcode was disabled entirely. I couldn't reproduce in RC3 public, so I'm not 100% sure it isn't a regression caused by the editor changes, but it all functions as it's supposed to now, so not sure what to make of that.

Revision: 66
Author: arantor
Date: 19:51:49, 08 September 2010
Message:
! Fixed font size selector to actually work as intended (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Revision: 67
Author: arantor
Date: 23:57:05, 08 September 2010
Message:
+ Add post time on wireless views (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php