Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8416
Features / Re: New revs
« on September 5th, 2010, 11:22 PM »
Does Tortoise use GNU patch? I thought it used its own to be honest.

But if that's the case, repair_settings.php should be affected out of the last patch - and it wasn't. Which means it still is with them. It wouldn't hurt to have our stuff above reproach, but really it should be fixed at source, and how many times have you told them about this?
8417
Features / Re: New revs
« on September 5th, 2010, 10:46 PM »
Can you believe the SMF team are still this sloppy?

It wouldn't hurt to fix it on our side, but they should be fixing it on theirs, and really how can you do a commit review if you can't check it is what it is supposed to be?
8418
Features / Re: New revs
« on September 5th, 2010, 09:43 PM »
Quote
PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array)
And again... -.- If it weren't actually kind of important this would be almost funny.


Revision: 45
Author: arantor
Date: 20:42:54, 05 September 2010
Message:
! Again with the CRLF line endings having to disappear. (index.php, upgrade_2-0_mysql.sql, DbPackages-mysql.php, ManageMaintenance.php, Subs-OpenID.php, script.js)
----
Modified : /trunk/Sources/DbPackages-mysql.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/index.php
Modified : /trunk/other/upgrade_2-0_mysql.sql
8419
Features / Re: New revs
« on September 5th, 2010, 08:19 PM »
Revision: 43
Author: arantor
Date: 19:18:15, 05 September 2010
Message:
! db_show_debug can now be shown to different user groups (admin, admin+mod, all logged in users, everyone), optionally with query log being separated. (ManageServer.php, Subs.php, ViewQuery.php, Help.english.php, ManageSettings.english.php) (ticket 12)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
8420
Features / Re: New revs
« on September 5th, 2010, 04:55 PM »
Just for reference, yes, try/catch (I keep typing cache instead, haha) would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
8421
Features / Re: New revs
« on September 5th, 2010, 04:49 PM »
Quote from MultiformeIngegno on September 5th, 2010, 04:47 PM
@Nao: I can't keep it secret!!!! Everybody needs to know this incredible scoop!! :P
I'd love to tell people, but 1) it would risk being overhyped, and 2) we've kept it quiet as a courtesy to SMF. It is, as Nao has said, a PR move. Can you imagine what would happen if it were public what we were doing?
8422
Features / Re: New revs
« on September 5th, 2010, 04:43 PM »
Quote
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
Quote
That's nice... But I'm sure it can be rewritten, still
Sure it can. Just remember that each block is given specific parameters in order to specify what will be in each block. It shouldn't be too hard to deal with that though.
Quote
Yeah, I have yet to look into the mysql install files
It only occurred to me as I was adding the return_to_post entry which lives in the same place.
Quote
Ahhhh!! You, filthy thief!!
Hahaha
Quote
Can't look into the svn right now (see above), so... Are you doing stuff in my stead?
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.

Sure, can assign stuff, it's been a while since I worked in a team!
8423
Features / Re: New revs
« on September 5th, 2010, 03:45 PM »
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.

Adding try/catch is not something I'm overly looking at yet, since SMF's code is written to pretty much avoid failing anyway.
Posted: September 5th, 2010, 02:41 PM

Revision: 40
Author: arantor
Date: 14:02:17, 05 September 2010
Message:
! Removed unnecessary eval from dropping PHP 4 support (convert.php)
----
Modified : /trunk/other/converters/convert.php



EDIT to add
Quote
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
Posted: September 5th, 2010, 03:02 PM

Revision: 41
Author: arantor
Date: 14:26:17, 05 September 2010
Message:
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
----
Modified : /trunk/other/install_2-0_mysql.sql

Posted: September 5th, 2010, 03:26 PM

Revision: 42
Author: arantor
Date: 14:44:43, 05 September 2010
Message:
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
----
Modified : /trunk/Sources/Subs-Auth.php
8424
Features / Re: New revs
« on September 5th, 2010, 03:07 AM »
Revision: 38
Author: arantor
Date: 02:06:18, 05 September 2010
Message:
! Ensure the auto added topic is updated to actually be the new admin's by ownership. (other/install.php) (ticket 21)
----
Modified : /trunk/other/install.php
8425
Features / Re: New revs
« on September 5th, 2010, 02:12 AM »
No, I'm really not a social person.

The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
8426
Features / Re: New revs
« on September 4th, 2010, 07:10 PM »
Revision: 37
Author: arantor
Date: 18:09:04, 04 September 2010
Message:
+ Added unified editor class (Class-Editor.php) (for ticket 3)
! Updated editor handlers to do WYSIWYG->BBC parsing in the class rather than having the logic totally in the calling script (Post.php, PersonalMessage.php)
! Removed old functions that are no longer relevant as now part of the class (Subs-Editor.php, Subs-Post.php, GenericControls.template.php)
! Modified all the other places that used preparsecode and friends to use the class (I *think* I got everything right) (ManageNews.php, ModerationCenter.php, MoveTopic.php, PersonalMessage.php, Post.php, Profile-Modify.php)
! Updated sources and templates to use class instantiation/referencing (Post.php, Post.template.php, PersonalMessage.php, PersonalMessage.template.php)
----
Added : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php


I forgot to add to the note I also updated index.php to call the class instead of Subs-Editor for the code that is used when switching between the WYSIWYG and normal editors.

What I need to do next - and I've got to out to a wedding reception, ack - is document the changes, because this is HUGE in what it changes.
8427
Features / Re: New revs
« on September 4th, 2010, 02:13 PM »
I forget about convert.php, mostly because I figure with all the changes that are going to be made, we'll end up rewriting the converter core (at least) anyway.
8428
Features / Re: New revs
« on September 4th, 2010, 11:45 AM »
Rev 33 didn't show in the SVN log for some reason.
8429
Features / Re: New revs
« on September 4th, 2010, 12:27 AM »
Revision: 35
Author: arantor
Date: 23:42:23, 03 September 2010
Message:
! Fix ARIN WHOIS lookup URL (Profile-View.php)
----
Modified : /trunk/Sources/Profile-View.php



Revision: 34
Author: arantor
Date: 23:25:25, 03 September 2010
Message:
! Encoding safe version of the legacy attachment filename function (Subs.php)
----
Modified : /trunk/Sources/Subs.php

NB this is the function I complained so bitterly about Norv breaking. This fixes it once and for all in a way that never gets broken by encoding, it's all 7-bit safe.



Not sure where rev 33 went?



Revision: 32
Author: nao
Date: 17:36:05, 03 September 2010
Message:
! CRLFs go home! (changelog.txt, repair_settings.php, Subs-Calendar.php)
----
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/changelog.txt
Modified : /trunk/Sources/Subs-Calendar.php
8430
Features / Re: New revs
« on September 3rd, 2010, 02:14 AM »
Revision: 26
Author: arantor
Date: 01:12:53, 03 September 2010
Message:
+ Attempt to detect user time offset on registration (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php


NB This closes Ticket 10: Time zone auto detection on registration