Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
1531
Bug reports / Re: Profile field values lost when edited
« on February 20th, 2013, 07:52 PM »
It's an old bug - it's fundamental to SMF's implementation.
It's actually something I tackled in SimpleDesk so I do know how it can be tackled, but it's horribly messy.
Essentially yes, the actual value is stored in the themes table, rather than a pointer to the relevant item, if that makes sense (so instead of storing 'New Value', you could store the number of the item)
That does have some other interesting consequences so I have been wary of suggesting it or acting on it, though, especially as I've debated adding in 'multi select' (i.e. picking 1+ items from the list rather than just 1) as I did in SimpleDesk, but that has the same issues. It also then gets into the situation where you potentially need to be able to reorganise the list of items.
It's actually something I tackled in SimpleDesk so I do know how it can be tackled, but it's horribly messy.
Essentially yes, the actual value is stored in the themes table, rather than a pointer to the relevant item, if that makes sense (so instead of storing 'New Value', you could store the number of the item)
That does have some other interesting consequences so I have been wary of suggesting it or acting on it, though, especially as I've debated adding in 'multi select' (i.e. picking 1+ items from the list rather than just 1) as I did in SimpleDesk, but that has the same issues. It also then gets into the situation where you potentially need to be able to reorganise the list of items.
1532
Archived fixes / Re: Minor Quick Edit Bug
« on February 20th, 2013, 05:59 AM »
And this is actually still broken :/ Quick edit never got fixed, it seems.
The cause of this is in the way the content is converted by:
Code: [Select]
If the subject is entity escaped, there's no problem, it absolutely works as expected.
I won't do it tomorrow, I'm out most of tomorrow but on Thursday I'm advising now that I'm going to do it and frankly I don't care about the extra bytes (most of which will be gzipped out anyway, or if we hide the subject it will be even less of a problem anyway). I am fed up with having to dance around security matters for the saving of a few bytes.
The cause of this is in the way the content is converted by:
oCurSubjectDiv = $('#msg' + sCurMessageId + ' h5');
sSubjectBuffer = oCurSubjectDiv.html();If the subject is entity escaped, there's no problem, it absolutely works as expected.
* Arantor is sorely tempted to just forcibly encode everything back with ENT_QUOTES how it used to be because nothing broke when that happened, there were no strange necessities of workarounds or anything like we have now, fixing every edge case when it appears.
I won't do it tomorrow, I'm out most of tomorrow but on Thursday I'm advising now that I'm going to do it and frankly I don't care about the extra bytes (most of which will be gzipped out anyway, or if we hide the subject it will be even less of a problem anyway). I am fed up with having to dance around security matters for the saving of a few bytes.
1533
Archived fixes / Re: SMF bug 4859 (Text limit not necessarily enforced properly)
« on February 20th, 2013, 05:52 AM »
Bump to remind myself. I'm going to convert the table to mediumint, strip the edge logic around bumping the size around and then it will work as it should.
1534
Features / Re: New revs
« on February 20th, 2013, 05:47 AM »
(1 file, 1KB)
Revision: 1935
Author: arantor
Date: 20 February 2013 04:46:47
Message:
! A quick one before bed, consistent fixed handling of not-found language files. (Load.php)
----
Modified : /trunk/Sources/Load.php
Revision: 1935
Author: arantor
Date: 20 February 2013 04:46:47
Message:
! A quick one before bed, consistent fixed handling of not-found language files. (Load.php)
----
Modified : /trunk/Sources/Load.php
1535
Bug reports / Re: WebGet and open_basedir
« on February 20th, 2013, 02:51 AM »
Bumping to remind myself to fix this. I do now know and understand why it is in place, I just haven't implemented it yet.
1536
The Pub / Re: Looking for volunteers to test the Wedge private alpha!
« on February 20th, 2013, 02:23 AM »
So why didn't you say something in the meantime?
1537
The Pub / Re: Looking for volunteers to test the Wedge private alpha!
« on February 20th, 2013, 02:18 AM »
Except that it was fixed later that day, or no later than the next day which means it was back in November when betas were available to people to try.
1538
Features / Re: Guess the Feature
« on February 20th, 2013, 02:15 AM »
Yeah, it's pretty horrendous actually. I know I've added one template to Wedge since we started and I've removed one today. It is possible others were removed in the meantime but I can't put my finger on if/when that happened.
The file is much tidier now.
The file is much tidier now.
1539
Bug reports / Re: SMF bug 4873 (agreement not shown, no error, if agreement.txt is not available)
« on February 20th, 2013, 02:01 AM »
I'm not sure how valid this is as a bug any more. Certainly it's no longer in agreement.txt and is now in Agreement.english.php and so on so there should never be a case where it is not available as such.
Thinking about it, it is possible to empty it out in the admin panel at the current time, not sure what really to do about that yet.
Thinking about it, it is possible to empty it out in the admin panel at the current time, not sure what really to do about that yet.
1540
Archived fixes / Re: Membergroup settings
« on February 20th, 2013, 01:57 AM »
I'm going to bump this to remind myself that while I fixed the original bug (undef indexes), I didn't implement the underlying logic to go with it in the aftermath of badge support.
1541
Archived fixes / Re: No 'reply' button in 'thoughts' (all) page
« on February 20th, 2013, 01:56 AM »Fact is, the JS for thoughts is a bit complicated and I fear it would add to the JS filesize, which I don't really want.
Plus, I don't want to encourage digging out old thoughts for reply
Although I reckon that we post way more thoughts per day than what the homepage can hold...
That reminds me, need permissions control for thoughts.
1542
Archived fixes / Re: Serious error - current theme
« on February 20th, 2013, 01:28 AM »
Yay for my language caching changes!
$txt is emptied out and when the language file isn't found, it wasn't being put back. Now that sounds fine and all until we get to Current Theme which implicitly asks for ThemeStrings - which doesn't exist.
Fixed, will commit next commit.
$txt is emptied out and when the language file isn't found, it wasn't being put back. Now that sounds fine and all until we get to Current Theme which implicitly asks for ThemeStrings - which doesn't exist.
Fixed, will commit next commit.
1543
Features / Re: New revs
« on February 20th, 2013, 01:00 AM »
(17 files, 49KB!)
Revision: 1934
Author: arantor
Date: 19 February 2013 23:59:12
Message:
! Scary commit. Emails can now be edited from the admin panel easily. (ManageMail.php, ManageMail.template.php, Admin.php, language files: Admin, ManageMail, EmailTemplates)
! Admin notifications should be sent for users who require admin approval after email validation. (Activate.php)
! Bug fix relating to $helptxt and indeterminate initialisation state. (Load.php)
! Harmonisation of email variables. In theory everything should be working and not broken in any fashion since I should have maintained all the email templates properly in sync. (Groups.php, Mailer.php, ManageMembers.php, Reminder.php, ScheduledTasks.php, Subs-Admin.php, Subs-Auth.php, subscriptions.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/subscriptions.php
Revision: 1934
Author: arantor
Date: 19 February 2013 23:59:12
Message:
! Scary commit. Emails can now be edited from the admin panel easily. (ManageMail.php, ManageMail.template.php, Admin.php, language files: Admin, ManageMail, EmailTemplates)
! Admin notifications should be sent for users who require admin approval after email validation. (Activate.php)
! Bug fix relating to $helptxt and indeterminate initialisation state. (Load.php)
! Harmonisation of email variables. In theory everything should be working and not broken in any fashion since I should have maintained all the email templates properly in sync. (Groups.php, Mailer.php, ManageMembers.php, Reminder.php, ScheduledTasks.php, Subs-Admin.php, Subs-Auth.php, subscriptions.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/ManageMail.english.php
Modified : /trunk/subscriptions.php
1544
Archived fixes / Serious error - current theme
« on February 20th, 2013, 12:13 AM »
For some reason when Current Theme is triggered, and only Current Theme (not the entire Themes and Layout section, it's only the theme settings for an actual theme), something is broken whereby it proceeds to dump the entirety of all language strings, vomiting 95 errors into the log.
I'll look into this one tonight as part of my language changes in general.
I'll look into this one tonight as part of my language changes in general.
1545
Archived fixes / Re: Current Theme points to manage and install
« on February 20th, 2013, 12:12 AM »
This was fixed in r1913 last week.