Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
1351
Features / Re: Mini-skeletons
« on March 7th, 2013, 02:00 AM »
OK, so I was ruminating on this today. One of the things I wanted in the mini-skeleton is the ability essentially to be able to juggle poster info around and inject new areas, and having it as one huge <msg_author> block kind of bugged me.
So I juggled it around and I came up with this:
Code: [Select]
I split it all out, and while it's ugly, it does work as expected. I haven't bothered prettying it up because I'm not sure about committing it yet, mostly because I haven't been able to meaningfully benchmark the performance aspects.
More importantly, it does mean a lot of extra tests are being done unnecessarily at this point because of course, $msg['member']['is_guest'] and $context['is_mobile'] need to be tested a lot more. Still there's ways around that - I see no reason why Display couldn't do the test then alter the relevant skeleton instance to just cut those functions from being called, entirely.
There's also stuff like $gts being redeclared every function call and stuff (rather than checked and force-set properly earlier on) but that's all fixable stuff.
What it does mean, though, is people can move things around easily - and plugins can easily add things wherever they want, rather than just tagging it on to the end of msg_author.
So, what do you reckon? Clean up and commit or rethink?
So I juggled it around and I came up with this:
<msg_author>
<msg_author_title />
<msg_author_avatar />
<msg_author_group />
<msg_author_badge />
<msg_author_blurb />
<msg_author_postcount />
<msg_author_icons />
<msg_author_cf />
<msg_author_warning />
</msg_author>I split it all out, and while it's ugly, it does work as expected. I haven't bothered prettying it up because I'm not sure about committing it yet, mostly because I haven't been able to meaningfully benchmark the performance aspects.
More importantly, it does mean a lot of extra tests are being done unnecessarily at this point because of course, $msg['member']['is_guest'] and $context['is_mobile'] need to be tested a lot more. Still there's ways around that - I see no reason why Display couldn't do the test then alter the relevant skeleton instance to just cut those functions from being called, entirely.
There's also stuff like $gts being redeclared every function call and stuff (rather than checked and force-set properly earlier on) but that's all fixable stuff.
What it does mean, though, is people can move things around easily - and plugins can easily add things wherever they want, rather than just tagging it on to the end of msg_author.
So, what do you reckon? Clean up and commit or rethink?
1352
Features / Re: New revs
« on March 6th, 2013, 10:30 PM »
(36 modified, 2 deleted, 4KB)
Revision: 1979[1]
Author: arantor
Date: 06 March 2013 21:26:35
Message:
! No more of this 'save in outbox' nonsense. It's saved automatically, even forcing the default for sendpm to save (because plugins doing it should default unless they *know* they don't want to), except for the places it shouldn't, like warning notifications and announcements. (install.sql, ManageMemberOptions.php, ManageNews.php, PersonalMessage.php, Subs-Post.php, PersonalMessage.template.php, Profile.template.php, PersonalMessage and Profile language files)
- Spell checking support removed from the bulk of code. Support does remain but only in the search area and even that might go. (index.php, detailed-version.php, Class-Editor.php, Display.php, Load.php, ManagePosts.php, Profile-Modify.php, Search2.php, Spellcheck.php, Subs-Media.php, Display.template.php, index.css, editor.js[2], language files: Admin, Help, index, ManageSettings, Post, Who)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/editor.js
Deleted : /trunk/Themes/default/scripts/spellcheck.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql
Revision: 1979[1]
Author: arantor
Date: 06 March 2013 21:26:35
Message:
! No more of this 'save in outbox' nonsense. It's saved automatically, even forcing the default for sendpm to save (because plugins doing it should default unless they *know* they don't want to), except for the places it shouldn't, like warning notifications and announcements. (install.sql, ManageMemberOptions.php, ManageNews.php, PersonalMessage.php, Subs-Post.php, PersonalMessage.template.php, Profile.template.php, PersonalMessage and Profile language files)
- Spell checking support removed from the bulk of code. Support does remain but only in the search area and even that might go. (index.php, detailed-version.php, Class-Editor.php, Display.php, Load.php, ManagePosts.php, Profile-Modify.php, Search2.php, Spellcheck.php, Subs-Media.php, Display.template.php, index.css, editor.js[2], language files: Admin, Help, index, ManageSettings, Post, Who)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/PersonalMessage.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/scripts/editor.js
Deleted : /trunk/Themes/default/scripts/spellcheck.js
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/index.php
Modified : /trunk/other/xml/detailed-version.php
Modified : /trunk/root/install.sql
| 1. | You got me runnin', goin out of my mind, You got me thinkin' that I'm wastin' my time. Don't bring me down, no, no, no, no, no! I'll tell you once more before I get off the floor: Don't bring me down! |
| 2. | I forgot these in the actual SVN log |
1353
The Pub / Re: Spell checker
« on March 6th, 2013, 09:31 PM »
So far I've removed the main guts of the spell checker, it's only the integration into the search system left. I guess I could commit what I have and not worry about that bit for now - we can always remove it later easily enough.
Though, looking back, I'd prefer to strip it entirely, so that I could get rid of the dictionary info from inside the language files.
Posted: March 6th, 2013, 09:11 PM
Though, looking back, I'd prefer to strip it entirely, so that I could get rid of the dictionary info from inside the language files.
1354
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 6th, 2013, 06:30 PM »So, what do you think..?Quote from Arantor on March 6th, 2013, 02:11 PM Been busy, sorry, I'll look at it shortly.
Also, I think you missed my bit about thematic groupings of htmlspecialchar & derivates. Although I'm pretty sure you'll disagre... (If only because it requires refactoring everything...)
Wait... thematic groupings?
Depends on the user... I usually press Enter myself, but with the big popup, it's tempting to change the settings in there, and the quickest is then to click the Search button...Quote Users actually press the button? I thought they just pressed enter for simple searching?
Anyway, if there's no button, and no JS thus no popup, you still have to rely on JS (AFAIK) to automatically submit the input box when pressing Enter...
Then, would it make more sense to move that one to 'Advanced options' as well, in the dedicated search page..?Quote Sounds like a plan.Quote - Add 'containing all these words..' etc select box to the popup
Oh, we could always have a fallback somewhere for it... Although currently, fallbacks are only for elements added through code, i.e. wetem::load/add, while elements in a skeleton are supposed to be shown all the time so there's no potential fallback...Quote Dislike this idea for the same reason as I said about the notifications - if the sidebar is collapsed, it's not accessible easily.
Oh, yes, searching thoughts and gallery comments... That's a good idea. I guess we should deal with that in Search2.php, too... But it'd require quite a bit of refactoring, once again. Not something I'll do with pleasure, and especially not these days... ;)Quote Also, as a heads-up, there is going to be a selector growing on there for what should be searched (whole forum, current board, current topic, thoughts, calendar, other items yet to be determined), haven't decided exactly how to handle that yet.
I'd already busy trying to get my thoughts rewrite to a commitable state.
Interface, though, I'm thinking I'll break the dropdown select into multiple optgroups, e.g. optgroup label="Forum" with the 'everything'/'this board'/'this topic' options in it.
| 1. | And before anyone gets into 'why did SMF not offer it as core', it's simple: prior to Sphinx 0.9.9rc2, the only bridge to Sphinx was their API which was a GPL file, which of course didn't play nicely. But after 0.9.9rc2, there is SphinxQL which reuses MySQL functions rather than a custom API. No licence issues to fight with. |
1355
Features / Re: Saving Bytes Every Page - Or, How I Learned To Stop Worrying And Enhance Search
« on March 6th, 2013, 02:11 PM »
Been busy, sorry, I'll look at it shortly.Quote Users actually press the button? I thought they just pressed enter for simple searching?Quote Sounds like a plan.Quote Might be nice to have that.Quote Dislike this idea for the same reason as I said about the notifications - if the sidebar is collapsed, it's not accessible easily.
Also, as a heads-up, there is going to be a selector growing on there for what should be searched (whole forum, current board, current topic, thoughts, calendar, other items yet to be determined), haven't decided exactly how to handle that yet.
- Get rid of the Search button in HTML. Pro: there's already a search button in the popup. Con: if JS is disabled, it won't work.
- Add 'containing all these words..' etc select box to the popup
- Use a magnifier icon on the Search button in the popup..???
- Move search box by default to the sidebar, since it will be narrow enough to accommodate any sidebar width.
Also, as a heads-up, there is going to be a selector growing on there for what should be searched (whole forum, current board, current topic, thoughts, calendar, other items yet to be determined), haven't decided exactly how to handle that yet.
1356
The Pub / Re: Spell checker
« on March 6th, 2013, 02:07 PM »
It has a very high failure rate because it has no awareness of what's in the database, and I'm not inclined to keep it because of that high failure rate.
Now, there is one way we can fix that, at major DB space cost: by logging what words are actually in the database. It's a similar sort of idea to the search index but instead of storing hashes (which you can't look up against) you also store the actual words in use, and can do comparisons against that reasonably well.
The problem is, it's a major space killer and performance is going to be fairly poor. I personally would rather just ditch the whole thing entirely.
Now, there is one way we can fix that, at major DB space cost: by logging what words are actually in the database. It's a similar sort of idea to the search index but instead of storing hashes (which you can't look up against) you also store the actual words in use, and can do comparisons against that reasonably well.
The problem is, it's a major space killer and performance is going to be fairly poor. I personally would rather just ditch the whole thing entirely.
1357
The Pub / Re: Remove \
« on March 6th, 2013, 02:05 PM »
OK, there's several things here.
Saving by default, sure. It's not like it's a hard job.
Convo mode by default, no big deal either.
Mark unread... it works but only if it's not the most recent conversation. To fix this, I'd like to propose that we separate the PM list from viewing PMs, that is to say: when you first hit the PM page, there's just a list of conversations - not going straight to any one conversation. If you pick one, then it displays the list plus the conversation in question. This means mark unread would actually work properly and stuff doesn't automatically get read just by visiting the PM area.
Saving by default, sure. It's not like it's a hard job.
Convo mode by default, no big deal either.
Mark unread... it works but only if it's not the most recent conversation. To fix this, I'd like to propose that we separate the PM list from viewing PMs, that is to say: when you first hit the PM page, there's just a list of conversations - not going straight to any one conversation. If you pick one, then it displays the list plus the conversation in question. This means mark unread would actually work properly and stuff doesn't automatically get read just by visiting the PM area.
1358
The Pub / Re: Spell checker
« on March 6th, 2013, 01:40 AM »
The spell checker wouldn't tell you that anyway... ;) Neither pspell nor enchant can do that.
Mind you, there is one side use of the spell check that I do want to bring up, and that is the 'Did you mean...' feature. If you haven't noticed it, do a search but misspell one of the words. You'll get a 'You may have meant <alternative>' message.
Doing away with the spell checker can mean doing away with that too.
Just a thought.
Mind you, there is one side use of the spell check that I do want to bring up, and that is the 'Did you mean...' feature. If you haven't noticed it, do a search but misspell one of the words. You'll get a 'You may have meant <alternative>' message.
Doing away with the spell checker can mean doing away with that too.
Just a thought.
1359
The Pub / Re: Spell checker
« on March 5th, 2013, 01:38 AM »
Haha, you got me, it is pretty slim. Slim enough that we could safely drop it :)
1360
The Pub / Re: Spell checker
« on March 5th, 2013, 01:32 AM »
There's still a lot of XP users who can't get IE 9 let alone 10 ;)
1361
The Pub / Re: Spell checker
« on March 5th, 2013, 01:24 AM »It needs to be removed IMO. Every OS/browser natively supports spell checking, so it's not needed and adds extra space :)
1362
Off-topic / Re: Spirate
« on March 4th, 2013, 10:19 PM »And I remember He and Arantor getting in deep in conversation over things, but like I mentioned, I feel he felt he was being Missile'd into others ideas and or directions.
For a personal exploration, that's fine. But for a system that is intended for general use, it simply isn't practical. Whether you like that fact or not is pretty much irrelevant, that's the reality of it.
1363
Off-topic / Re: Spirate
« on March 4th, 2013, 10:11 PM »
And we listened and we made changes to accommodate it as best we could, but essentially it turned into 'you're not listening to me, bye'.
1364
Features / Re: New revs
« on March 4th, 2013, 10:01 PM »
(30 modified, 6KB)
Revision: 1972
Author: arantor
Date: 04 March 2013 20:59:16
Message:
! More $scripturl removal. I was bored and not wanting to tackle much that was particularly brain troubling. (all files)
----
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Stats.template.php
Revision: 1972
Author: arantor
Date: 04 March 2013 20:59:16
Message:
! More $scripturl removal. I was bored and not wanting to tackle much that was particularly brain troubling. (all files)
----
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Notify.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Stats.template.php
1365
Off-topic / Re: Spirate
« on March 4th, 2013, 09:49 PM »
Part of the problem is that Bloc and I never saw eye to eye about some things, and in particular the fact that what he wants to do isn't really feasible in a wider-scale project, as wonderful as it would be, it just is not practical for us to adopt it.