« [Plugin Screenshots] Invitation Only Topics
Something I started working on
Wand »

Dr. Deejay

  • Happy new year all!
  • Posts: 118
Re: Something I started working on
« Reply #15, on September 18th, 2012, 07:01 PM »
It looks amazing, nice work! :) I like that it just takes a few lines to create a decent settings page, which is really cool. ;D

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Something I started working on
« Reply #16, on September 22nd, 2012, 03:55 PM »
Quote from Arantor on September 18th, 2012, 05:04 PM
I haven't found one in jQuery that I like the look of though, and don't know exactly how I'd like it to look either...
Always looking for plugins eh? Be a man, write everything yourself! :niark:

Okay, may have found a bug somewhere, *or* I incorrectly set something up, but it shouldn't be doing this...

Warning: getimagesize(/my_root/wedge/Themes/default/images/admin/http://wedge.org/.../topic_solved/img/tick.png) [function.getimagesize]: failed to open stream: No such file or directory in /my_root/wedge/Sources/Class-CSS.php on line 619

This is caused by the admin menu's call to the @dynamic CSS icon generator, which in turn expects the 'icon' entry of admin menus to be a relative URL, rather than absolute...
And it seems that your plugin system provides an absolute URL to the tick.png file. It should either calculate the relative position for it, or we should update the admin code to deal with absolute URLs... What do you prefer..?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Something I started working on
« Reply #17, on September 22nd, 2012, 04:06 PM »
Quote
Always looking for plugins eh? Be a man, write everything yourself!
I don't actually like JavaScript that much if I'm honest, but as I said, if I knew how I'd like it to look, I could probably make my own.
Quote
Okay, may have found a bug somewhere, *or* I incorrectly set something up, but it shouldn't be doing this...
Bug.
Quote
And it seems that your plugin system provides an absolute URL to the tick.png file. It should either calculate the relative position for it, or we should update the admin code to deal with absolute URLs... What do you prefer..?
The plugin provides absolute URLs for everything, and the code was designed with that in mind and has been that way since I wrote the guts of the plugin manager a year ago. The problem with relative URLs is that it assumes the structure doesn't change, just as some mods assumed that Sources would always be at $boardurl/Sources, which it isn't. I know at least a dozen sites that do that, and I can well imagine they would want to do the same with plugins.

There's also the other matter: making it easy to use. The current structure is easy enough to follow for modders. If you want @dynamic to mess around with it and do something else, that's absolutely fine, but please please please do not force modders to have to do something more byzantine and awkward to put an icon in to the admin menu. (I'm still not happy with how plugins have to jump through hoops like adding a whole line of CSS including positioning to add a simple main menu icon.)


The rest of the code is straightforward on this point: if the icon looks like a URL, treat it as a URL, if it doesn't look like a URL, fetch it from the admin folder of the theme's images.

Also, remember that a plugin CANNOT know for certain what folder it will be installed in, relative to Plugins/, which is the whole point of having the context variables. If you want to make it relative, do it OUTSIDE of the plugin, e.g. in the @dynamic code.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Something I started working on
« Reply #18, on September 23rd, 2012, 12:59 PM »
Quote from Arantor on September 22nd, 2012, 04:06 PM
I don't actually like JavaScript that much if I'm honest, but as I said, if I knew how I'd like it to look, I could probably make my own.
I'd personally like a three slider solution where you can set HSL individually... But that's just me and my damn Wess, of course ;)
Quote
The plugin provides absolute URLs for everything, and the code was designed with that in mind and has been that way since I wrote the guts of the plugin manager a year ago. The problem with relative URLs is that it assumes the structure doesn't change, just as some mods assumed that Sources would always be at $boardurl/Sources, which it isn't. I know at least a dozen sites that do that, and I can well imagine they would want to do the same with plugins.
But, I'm just wondering... Couldn't we simply supply a path relative to $boardurl or something when it comes to the icon...?
It's no biggie, but absolute URLs can be a pain when doing getimagesize() on them, so doing, in Wess, a "width(absolute_url)px" call might fail if the server doesn't allow for these... :-/

Other than that, yeah, it makes more sense to test for absolute URLs inside the dynamic function, but the above is the reason why I wanted to explore something else before, ah ah...

Aaron

  • Posts: 356
Re: Something I started working on
« Reply #19, on September 23rd, 2012, 01:29 PM »
Just a quick note ...



Shouldn't those two be labeled row colours instead of column colours?
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Something I started working on
« Reply #20, on September 23rd, 2012, 04:02 PM »
No, the message index has differently coloured columns, not differently coloured rows - just like Curve...

« [Plugin Screenshots] Invitation Only Topics
Wand »